<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>220445</bug_id>
          
          <creation_ts>2021-01-07 16:40:42 -0800</creation_ts>
          <short_desc>Make it safe to re-enter HashMap::clear()</short_desc>
          <delta_ts>2021-01-08 07:46:16 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Template Framework</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>benjamin</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>darin</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>ggaren</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>wenson_hsieh</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1718141</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2021-01-07 16:40:42 -0800</bug_when>
    <thetext>Make it safe to re-enter HashMap::clear(). This will fix the following crashes on the GPUProcess bot:
Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
Exception Codes:       KERN_INVALID_ADDRESS at 0x00000000bbadbeef
Exception Note:        EXC_CORPSE_NOTIFY

Termination Signal:    Segmentation fault: 11
Termination Reason:    Namespace SIGNAL, Code 0xb
Terminating Process:   exc handler [27650]

VM Regions Near 0xbbadbeef:
--&gt; 
    __TEXT                 0000000106dc3000-0000000106dc4000 [    4K] r-x/r-x SM=COW  /Volumes/VOLUME/*/*.Development

Application Specific Information:
CRASHING TEST: fast/canvas/canvas-overloads-strokeText.html

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.JavaScriptCore      	0x0000000622535c2e WTFCrash + 14 (Assertions.cpp:295)
1   com.apple.WebCore             	0x00000005ff704dfb WTFCrashWithInfo(int, char const*, char const*, int) + 27
2   com.apple.WebCore             	0x00000005ff719db8 WTF::RefCountedBase::hasOneRef() const + 104 (RefCounted.h:55)
3   com.apple.WebCore             	0x00000005ff719c9c WTF::RefCountedBase::applyRefDerefThreadingCheck() const + 28 (RefCounted.h:106)
4   com.apple.WebCore             	0x00000005ff719b0c WTF::RefCountedBase::derefBase() const + 28 (RefCounted.h:130)
5   com.apple.WebCore             	0x00000006006072af WTF::RefCounted&lt;WebCore::ImageBuffer, std::__1::default_delete&lt;WebCore::ImageBuffer&gt; &gt;::deref() const + 31 (RefCounted.h:189)
6   com.apple.WebCore             	0x0000000603b1daf5 WTF::Ref&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt; &gt;::~Ref() + 53 (Ref.h:62)
7   com.apple.WebCore             	0x0000000603b1dab5 WTF::Ref&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt; &gt;::~Ref() + 21 (Ref.h:62)
8   com.apple.WebCore             	0x0000000603b1da8e WTF::KeyValuePair&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt;, WTF::Ref&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt; &gt; &gt;::~KeyValuePair() + 30 (KeyValuePair.h:33)
9   com.apple.WebCore             	0x0000000603b1d9c5 WTF::KeyValuePair&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt;, WTF::Ref&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt; &gt; &gt;::~KeyValuePair() + 21 (KeyValuePair.h:33)
10  com.apple.WebCore             	0x0000000603b1d951 WTF::HashTable&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt;, WTF::KeyValuePair&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt;, WTF::Ref&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt; &gt; &gt;, WTF::KeyValuePairKeyExtractor&lt;WTF::KeyValuePair&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt;, WTF::Ref&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt; &gt; &gt; &gt;, WTF::DefaultHash&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt; &gt;, WTF::HashMap&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt;, WTF::Ref&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt; &gt;, WTF::DefaultHash&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt; &gt;, WTF::HashTraits&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt; &gt;, WTF::HashTraits&lt;WTF::Ref&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt; &gt; &gt; &gt;::KeyValuePairTraits, WTF::HashTraits&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt; &gt; &gt;::deallocateTable(WTF::KeyValuePair&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt;, WTF::Ref&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt; &gt; &gt;*) + 97 (HashTable.h:1237)
11  com.apple.WebCore             	0x0000000603b23cdb WTF::HashTable&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt;, WTF::KeyValuePair&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt;, WTF::Ref&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt; &gt; &gt;, WTF::KeyValuePairKeyExtractor&lt;WTF::KeyValuePair&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt;, WTF::Ref&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt; &gt; &gt; &gt;, WTF::DefaultHash&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt; &gt;, WTF::HashMap&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt;, WTF::Ref&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt; &gt;, WTF::DefaultHash&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt; &gt;, WTF::HashTraits&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt; &gt;, WTF::HashTraits&lt;WTF::Ref&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt; &gt; &gt; &gt;::KeyValuePairTraits, WTF::HashTraits&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt; &gt; &gt;::clear() + 59 (HashTable.h:1383)
12  com.apple.WebCore             	0x0000000603b13ce5 WTF::HashMap&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt;, WTF::Ref&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt; &gt;, WTF::DefaultHash&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt; &gt;, WTF::HashTraits&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt; &gt;, WTF::HashTraits&lt;WTF::Ref&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt; &gt; &gt; &gt;::clear() + 21 (HashMap.h:475)
13  com.apple.WebCore             	0x0000000603b13c48 WebCore::DisplayList::DisplayList::clear() + 104 (DisplayList.cpp:83)
14  com.apple.WebKit              	0x00000005f19bdbb6 WebKit::RemoteImageBufferProxy&lt;WebKit::ImageBufferShareableMappedIOSurfaceBackend&gt;::clearDisplayList() + 38 (RemoteImageBufferProxy.h:247)
15  com.apple.WebKit              	0x00000005f19bc139 WebKit::RemoteImageBufferProxy&lt;WebKit::ImageBufferShareableMappedIOSurfaceBackend&gt;::changeDestinationImageBuffer(WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt;) + 105 (RemoteImageBufferProxy.h:237)
16  com.apple.WebKit              	0x00000005f19578a6 WebKit::RemoteRenderingBackendProxy::willAppendItem(WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt;) + 198 (RemoteRenderingBackendProxy.cpp:238)
17  com.apple.WebKit              	0x00000005f19bc783 WebKit::RemoteImageBufferProxy&lt;WebKit::ImageBufferShareableMappedIOSurfaceBackend&gt;::willAppendItemOfType(WebCore::DisplayList::ItemType) + 99 (RemoteImageBufferProxy.h:253)
18  com.apple.WebCore             	0x0000000603b36185 WebCore::DisplayList::Recorder::willAppendItemOfType(WebCore::DisplayList::ItemType) + 85 (DisplayListRecorder.cpp:112)
19  com.apple.WebKit              	0x00000005f19bdbe5 void WebCore::DisplayList::Recorder::append&lt;WebCore::DisplayList::FlushContext, WTF::ObjectIdentifier&lt;WebCore::DisplayList::FlushIdentifierType&gt;&amp;&gt;(WTF::ObjectIdentifier&lt;WebCore::DisplayList::FlushIdentifierType&gt;&amp;) + 37 (DisplayListRecorder.h:155)
20  com.apple.WebKit              	0x00000005f19bdb7d WebCore::DisplayList::Recorder::flushContext(WTF::ObjectIdentifier&lt;WebCore::DisplayList::FlushIdentifierType&gt;) + 29 (DisplayListRecorder.h:73)
21  com.apple.WebKit              	0x00000005f19bc040 WebKit::RemoteImageBufferProxy&lt;WebKit::ImageBufferShareableMappedIOSurfaceBackend&gt;::flushDrawingContextAsync() + 160
22  com.apple.WebKit              	0x00000005f19bbf7d WebKit::RemoteImageBufferProxy&lt;WebKit::ImageBufferShareableMappedIOSurfaceBackend&gt;::flushDrawingContext() + 125 (RemoteImageBufferProxy.h:198)
23  com.apple.WebKit              	0x00000005f19bd79d WebKit::RemoteImageBufferProxy&lt;WebKit::ImageBufferShareableMappedIOSurfaceBackend&gt;::~RemoteImageBufferProxy() + 125 (RemoteImageBufferProxy.h:69)
24  com.apple.WebKit              	0x00000005f19bbd25 WebKit::RemoteImageBufferProxy&lt;WebKit::ImageBufferShareableMappedIOSurfaceBackend&gt;::~RemoteImageBufferProxy() + 21 (RemoteImageBufferProxy.h:72)
25  com.apple.WebKit              	0x00000005f19bbd4c WebKit::RemoteImageBufferProxy&lt;WebKit::ImageBufferShareableMappedIOSurfaceBackend&gt;::~RemoteImageBufferProxy() + 28 (RemoteImageBufferProxy.h:66)
26  com.apple.WebCore             	0x000000060060730f std::__1::default_delete&lt;WebCore::ImageBuffer&gt;::operator()(WebCore::ImageBuffer*) const + 47 (memory:2339)
27  com.apple.WebCore             	0x00000006006072d2 WTF::RefCounted&lt;WebCore::ImageBuffer, std::__1::default_delete&lt;WebCore::ImageBuffer&gt; &gt;::deref() const + 66 (RefCounted.h:191)
28  com.apple.WebCore             	0x0000000603b1daf5 WTF::Ref&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt; &gt;::~Ref() + 53 (Ref.h:62)
29  com.apple.WebCore             	0x0000000603b1dab5 WTF::Ref&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt; &gt;::~Ref() + 21 (Ref.h:62)
30  com.apple.WebCore             	0x0000000603b1da8e WTF::KeyValuePair&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt;, WTF::Ref&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt; &gt; &gt;::~KeyValuePair() + 30 (KeyValuePair.h:33)
31  com.apple.WebCore             	0x0000000603b1d9c5 WTF::KeyValuePair&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt;, WTF::Ref&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt; &gt; &gt;::~KeyValuePair() + 21 (KeyValuePair.h:33)
32  com.apple.WebCore             	0x0000000603b1d951 WTF::HashTable&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt;, WTF::KeyValuePair&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt;, WTF::Ref&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt; &gt; &gt;, WTF::KeyValuePairKeyExtractor&lt;WTF::KeyValuePair&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt;, WTF::Ref&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt; &gt; &gt; &gt;, WTF::DefaultHash&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt; &gt;, WTF::HashMap&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt;, WTF::Ref&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt; &gt;, WTF::DefaultHash&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt; &gt;, WTF::HashTraits&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt; &gt;, WTF::HashTraits&lt;WTF::Ref&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt; &gt; &gt; &gt;::KeyValuePairTraits, WTF::HashTraits&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt; &gt; &gt;::deallocateTable(WTF::KeyValuePair&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt;, WTF::Ref&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt; &gt; &gt;*) + 97 (HashTable.h:1237)
33  com.apple.WebCore             	0x0000000603b23cdb WTF::HashTable&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt;, WTF::KeyValuePair&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt;, WTF::Ref&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt; &gt; &gt;, WTF::KeyValuePairKeyExtractor&lt;WTF::KeyValuePair&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt;, WTF::Ref&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt; &gt; &gt; &gt;, WTF::DefaultHash&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt; &gt;, WTF::HashMap&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt;, WTF::Ref&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt; &gt;, WTF::DefaultHash&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt; &gt;, WTF::HashTraits&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt; &gt;, WTF::HashTraits&lt;WTF::Ref&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt; &gt; &gt; &gt;::KeyValuePairTraits, WTF::HashTraits&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt; &gt; &gt;::clear() + 59 (HashTable.h:1383)
34  com.apple.WebCore             	0x0000000603b13ce5 WTF::HashMap&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt;, WTF::Ref&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt; &gt;, WTF::DefaultHash&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt; &gt;, WTF::HashTraits&lt;WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt; &gt;, WTF::HashTraits&lt;WTF::Ref&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt; &gt; &gt; &gt;::clear() + 21 (HashMap.h:475)
35  com.apple.WebCore             	0x0000000603b13c48 WebCore::DisplayList::DisplayList::clear() + 104 (DisplayList.cpp:83)
36  com.apple.WebKit              	0x00000005f19bdbb6 WebKit::RemoteImageBufferProxy&lt;WebKit::ImageBufferShareableMappedIOSurfaceBackend&gt;::clearDisplayList() + 38 (RemoteImageBufferProxy.h:247)
37  com.apple.WebKit              	0x00000005f19bc063 WebKit::RemoteImageBufferProxy&lt;WebKit::ImageBufferShareableMappedIOSurfaceBackend&gt;::flushDrawingContextAsync() + 195 (RemoteImageBufferProxy.h:214)
38  com.apple.WebKit              	0x00000005f19bbf7d WebKit::RemoteImageBufferProxy&lt;WebKit::ImageBufferShareableMappedIOSurfaceBackend&gt;::flushDrawingContext() + 125 (RemoteImageBufferProxy.h:198)
39  com.apple.WebKit              	0x00000005f19bd79d WebKit::RemoteImageBufferProxy&lt;WebKit::ImageBufferShareableMappedIOSurfaceBackend&gt;::~RemoteImageBufferProxy() + 125 (RemoteImageBufferProxy.h:69)
40  com.apple.WebKit              	0x00000005f19bbd25 WebKit::RemoteImageBufferProxy&lt;WebKit::ImageBufferShareableMappedIOSurfaceBackend&gt;::~RemoteImageBufferProxy() + 21 (RemoteImageBufferProxy.h:72)
41  com.apple.WebKit              	0x00000005f19bbd4c WebKit::RemoteImageBufferProxy&lt;WebKit::ImageBufferShareableMappedIOSurfaceBackend&gt;::~RemoteImageBufferProxy() + 28 (RemoteImageBufferProxy.h:66)
42  com.apple.WebCore             	0x000000060060730f std::__1::default_delete&lt;WebCore::ImageBuffer&gt;::operator()(WebCore::ImageBuffer*) const + 47 (memory:2339)
43  com.apple.WebCore             	0x00000006006072d2 WTF::RefCounted&lt;WebCore::ImageBuffer, std::__1::default_delete&lt;WebCore::ImageBuffer&gt; &gt;::deref() const + 66 (RefCounted.h:191)
44  com.apple.WebCore             	0x0000000600607257 WTF::DefaultRefDerefTraits&lt;WebCore::ImageBuffer&gt;::derefIfNotNull(WebCore::ImageBuffer*) + 55 (RefPtr.h:43)
45  com.apple.WebCore             	0x0000000600607219 WTF::RefPtr&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt;, WTF::DefaultRefDerefTraits&lt;WebCore::ImageBuffer&gt; &gt;::~RefPtr() + 41 (RefPtr.h:73)
46  com.apple.WebCore             	0x00000006006071e5 WTF::RefPtr&lt;WebCore::ImageBuffer, WTF::RawPtrTraits&lt;WebCore::ImageBuffer&gt;, WTF::DefaultRefDerefTraits&lt;WebCore::ImageBuffer&gt; &gt;::~RefPtr() + 21 (RefPtr.h:73)
47  com.apple.WebCore             	0x0000000602b39c33 WebCore::HTMLCanvasElement::~HTMLCanvasElement() + 195 (HTMLCanvasElement.cpp:157)
48  com.apple.WebCore             	0x0000000602b39d15 WebCore::HTMLCanvasElement::~HTMLCanvasElement() + 21 (HTMLCanvasElement.cpp:158)
49  com.apple.WebCore             	0x0000000602b39d7c WebCore::HTMLCanvasElement::~HTMLCanvasElement() + 28 (HTMLCanvasElement.cpp:149)
50  com.apple.WebCore             	0x00000006027e45ef WebCore::Node::removedLastRef() + 223 (Node.cpp:2564)
51  com.apple.WebCore             	0x00000005ff9a215f WebCore::Node::deref() const + 527 (Node.h:801)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1718148</commentid>
    <comment_count>1</comment_count>
      <attachid>417223</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2021-01-07 16:48:04 -0800</bug_when>
    <thetext>Created attachment 417223
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1718204</commentid>
    <comment_count>2</comment_count>
      <attachid>417223</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2021-01-07 20:46:25 -0800</bug_when>
    <thetext>Comment on attachment 417223
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1718296</commentid>
    <comment_count>3</comment_count>
      <attachid>417223</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2021-01-08 07:45:26 -0800</bug_when>
    <thetext>Comment on attachment 417223
Patch

Clearing flags on attachment: 417223

Committed r271296: &lt;https://trac.webkit.org/changeset/271296&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1718297</commentid>
    <comment_count>4</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2021-01-08 07:45:29 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1718298</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-01-08 07:46:16 -0800</bug_when>
    <thetext>&lt;rdar://problem/72930238&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>417223</attachid>
            <date>2021-01-07 16:48:04 -0800</date>
            <delta_ts>2021-01-08 07:45:26 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-220445-20210107164804.patch</filename>
            <type>text/plain</type>
            <size>3284</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxMjQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDZhOWRiN2IzZmNhYzczYWM2N2QzYTJl
ODEyZjZiNzYwZWJlMzA5YmQuLmEzMWE5MWNmM2FkMWJiOTg4ZDllZDQzYTJlYWExOGZiOGU3ZWI3
MDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMDEtMDcgIENocmlzIER1bWV6ICA8Y2R1bWV6
QGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIGl0IHNhZmUgdG8gcmUtZW50ZXIgSGFzaE1hcDo6
Y2xlYXIoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
MjIwNDQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
TWFrZSBpdCBzYWZlIHRvIHJlLWVudGVyIEhhc2hNYXA6OmNsZWFyKCkuIFRoaXMgd2lsbCBmaXgg
c29tZSBjcmFzaGVzIG9uIHRoZSBHUFVQcm9jZXNzIGJvdHMKKyAgICAgICAgZHVlIHRvIERpc3Bs
YXlMaXN0OjpjbGVhcigpIHJlLWVudGVyaW5nIHZpYSBIYXNoTWFwOjpjbGVhcigpLgorCisgICAg
ICAgICogd3RmL0hhc2hUYWJsZS5oOgorICAgICAgICAoV1RGOjpLZXlUcmFpdHM+OjpjbGVhcik6
CisKIDIwMjEtMDEtMDcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t
PgogCiAgICAgICAgIFtHVEtdIEJ1aWxkIGZhaWx1cmVzIHdpdGggR1RLNCAzLjk5LjUuMQpkaWZm
IC0tZ2l0IGEvU291cmNlL1dURi93dGYvSGFzaFRhYmxlLmggYi9Tb3VyY2UvV1RGL3d0Zi9IYXNo
VGFibGUuaAppbmRleCA2YTk1NTBlYjlhNzliMGRkZWM1MDJlNTJhODE0NmVlZDUwNWYxODBlLi5i
YTc0MGJkYzY5ZmMzMGI3N2MyNmNkMzBhNDkzNTMwOGU1YjZjYmMxIDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvV1RGL3d0Zi9IYXNoVGFibGUuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9IYXNoVGFibGUuaApA
QCAtMTM4MCw4ICsxMzgwLDcgQEAgREVDTEFSRV9BTExPQ0FUT1JfV0lUSF9IRUFQX0lERU5USUZJ
RVIoSGFzaFRhYmxlKTsKICAgICAgICAgaWYgKCFtX3RhYmxlKQogICAgICAgICAgICAgcmV0dXJu
OwogCi0gICAgICAgIGRlYWxsb2NhdGVUYWJsZShtX3RhYmxlKTsKLSAgICAgICAgbV90YWJsZSA9
IG51bGxwdHI7CisgICAgICAgIGRlYWxsb2NhdGVUYWJsZShzdGQ6OmV4Y2hhbmdlKG1fdGFibGUs
IG51bGxwdHIpKTsKICAgICB9CiAKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBLZXksIHR5cGVuYW1l
IFZhbHVlLCB0eXBlbmFtZSBFeHRyYWN0b3IsIHR5cGVuYW1lIEhhc2hGdW5jdGlvbnMsIHR5cGVu
YW1lIFRyYWl0cywgdHlwZW5hbWUgS2V5VHJhaXRzPgpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdl
TG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDhmZTdhY2FkYTU2NTExMzMzOTMyNTA2Zjg5ZjU4
ZDk2MzJjOWFlODQuLjQxY2VmMzZhMDQ5Y2VmNWM2ZTZiZjFkZjVhNDIyNjUxZjc4MjM3NTkgMTAw
NjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyAr
MSwxNSBAQAorMjAyMS0wMS0wNyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCisg
ICAgICAgIE1ha2UgaXQgc2FmZSB0byByZS1lbnRlciBIYXNoTWFwOjpjbGVhcigpCisgICAgICAg
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjA0NDUKKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgQVBJIHRlc3QgY292
ZXJhZ2UuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9IYXNoTWFwLmNwcDoK
KyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgorCiAyMDIxLTAxLTA3ICBTYW0gU25lZGRv
biAgPGdzbmVkZGVyc0BhcHBsZS5jb20+CiAKICAgICAgICAgTGF5b3V0VGVzdEZpbmRlciBzaG91
bGQgYmUgaW4gY2hhcmdlIG9mIGZpbmRpbmcgbGF5b3V0IHRlc3RzCmRpZmYgLS1naXQgYS9Ub29s
cy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9IYXNoTWFwLmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRB
UEkvVGVzdHMvV1RGL0hhc2hNYXAuY3BwCmluZGV4IDJjY2E3MzkxODgzNDhhMmVlYzM3OGY4YTZj
YzFkMzI1NzAzYmI2NjIuLmNkZTVhMjgzNjllY2M1NGVjZjU2ZTc2NDhiN2IwOWE3YTE2NTlhNTkg
MTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0hhc2hNYXAuY3BwCisr
KyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0hhc2hNYXAuY3BwCkBAIC0xMTYzLDQg
KzExNjMsMzYgQEAgVEVTVChXVEZfSGFzaE1hcCwgUmFuZG9tX0lzRXZlbmx5RGlzdHJpYnV0ZWRB
ZnRlclJlbW92ZSkKICAgICB9CiB9CiAKK2NsYXNzIFRlc3RPYmplY3RXaXRoQ3VzdG9tRGVzdHJ1
Y3RvciB7CisgICAgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQ7CitwdWJsaWM6CisgICAgVGVzdE9i
amVjdFdpdGhDdXN0b21EZXN0cnVjdG9yKEZ1bmN0aW9uPHZvaWQoKT4mJiBydW5JbkRlc3RydWN0
b3IpCisgICAgICAgIDogbV9ydW5JbkRlc3RydWN0b3IoV1RGTW92ZShydW5JbkRlc3RydWN0b3Ip
KQorICAgIHsgfQorCisgICAgflRlc3RPYmplY3RXaXRoQ3VzdG9tRGVzdHJ1Y3RvcigpCisgICAg
eworICAgICAgICBtX3J1bkluRGVzdHJ1Y3RvcigpOworICAgIH0KKworcHJpdmF0ZToKKyAgICBG
dW5jdGlvbjx2b2lkKCk+IG1fcnVuSW5EZXN0cnVjdG9yOworfTsKKworVEVTVChXVEZfSGFzaE1h
cCwgQ2xlYXJfUmVlbnRlcikKK3sKKyAgICBIYXNoTWFwPHVpbnQ2NF90LCBzdGQ6OnVuaXF1ZV9w
dHI8VGVzdE9iamVjdFdpdGhDdXN0b21EZXN0cnVjdG9yPj4gbWFwOworICAgIGZvciAodW5zaWdu
ZWQgaSA9IDE7IGkgPD0gMTA7ICsraSkgeworICAgICAgICBtYXAuYWRkKGksIG1ha2VVbmlxdWU8
VGVzdE9iamVjdFdpdGhDdXN0b21EZXN0cnVjdG9yPihbJm1hcF0geworICAgICAgICAgICAgbWFw
LmNsZWFyKCk7CisgICAgICAgICAgICBFWFBFQ1RfRVEoMFUsIG1hcC5zaXplKCkpOworICAgICAg
ICAgICAgRVhQRUNUX1RSVUUobWFwLmlzRW1wdHkoKSk7CisgICAgICAgIH0pKTsKKyAgICB9Cisg
ICAgRVhQRUNUX0VRKDEwVSwgbWFwLnNpemUoKSk7CisgICAgbWFwLmNsZWFyKCk7CisgICAgRVhQ
RUNUX0VRKDBVLCBtYXAuc2l6ZSgpKTsKKyAgICBFWFBFQ1RfVFJVRShtYXAuaXNFbXB0eSgpKTsK
K30KKwogfSAvLyBuYW1lc3BhY2UgVGVzdFdlYktpdEFQSQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>