22042 2008-11-02 13:02:11 -0800 REGRESSION(r38066): ASSERTION FAILED: source in CodeBlock 2008-11-03 10:26:47 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P1 Normal --- 1 dev+webkit webkit-unassigned zwarich oldest_to_newest 97432 0 dev+webkit 2008-11-02 13:02:11 -0800 <http://trac.webkit.org/changeset/38066> caused an assertion failure on any page that has JavaScript. ASSERTION FAILED: source (/Users/matt/Code/WebKit/JavaScriptCore/VM/CodeBlock.h:264 JSC::CodeBlock::CodeBlock(JSC::ScopeNode*, JSC::CodeType, WTF::PassRefPtr<JSC::SourceProvider>, unsigned int)) 97433 1 24854 dev+webkit 2008-11-02 13:04:20 -0800 Created attachment 24854 Fix My C++-foo isn't strong enough to know exactly why this was wrong, but this stops the ASSERT. 97434 2 24854 zwarich 2008-11-02 13:11:32 -0800 Comment on attachment 24854 Fix r=me if you change the parameters on the other two constructors in that file to match. This is a pretty bizarre thing. I wish I knew why it happened. 97435 3 dev+webkit 2008-11-02 13:15:48 -0800 Committed revision 38068. 97473 4 ggaren 2008-11-03 10:23:56 -0800 Doesn't this mean that all the name changes in http://trac.webkit.org/changeset/38066 are invalid? 97475 5 zwarich 2008-11-03 10:26:47 -0800 The name changes are valid. The issue was that after the initializer , source(source) the PassRefPtr source was getting zeroed out, causing the assertion that source is nonzero to fail, where source is scoped to the parameter rather than the member variable. The assertion could also have been changed to ASSERT(this->source), and I might go back and do that. 24854 2008-11-02 13:04:20 -0800 2008-11-02 13:11:32 -0800 Fix FOO text/plain 1447 dev+webkit SW5kZXg6IFZNL0NvZGVCbG9jay5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFZNL0NvZGVCbG9jay5oCShyZXZp c2lvbiAzODA2NikKKysrIFZNL0NvZGVCbG9jay5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNDUsNyAr MjQ1LDcgQEAKICAgICB9OwogCiAgICAgc3RydWN0IENvZGVCbG9jayB7Ci0gICAgICAgIENvZGVC bG9jayhTY29wZU5vZGUqIG93bmVyTm9kZSwgQ29kZVR5cGUgY29kZVR5cGUsIFBhc3NSZWZQdHI8 U291cmNlUHJvdmlkZXI+IHNvdXJjZSwgdW5zaWduZWQgc291cmNlT2Zmc2V0KQorICAgICAgICBD b2RlQmxvY2soU2NvcGVOb2RlKiBvd25lck5vZGUsIENvZGVUeXBlIGNvZGVUeXBlLCBQYXNzUmVm UHRyPFNvdXJjZVByb3ZpZGVyPiBzb3VyY2VQcm92aWRlciwgdW5zaWduZWQgc291cmNlT2Zmc2V0 KQogICAgICAgICAgICAgOiBvd25lck5vZGUob3duZXJOb2RlKQogICAgICAgICAgICAgLCBnbG9i YWxEYXRhKDApCiAjaWYgRU5BQkxFKENUSSkKQEAgLTI1OCw3ICsyNTgsNyBAQAogICAgICAgICAg ICAgLCBuZWVkc0Z1bGxTY29wZUNoYWluKG93bmVyTm9kZS0+bmVlZHNBY3RpdmF0aW9uKCkpCiAg ICAgICAgICAgICAsIHVzZXNFdmFsKG93bmVyTm9kZS0+dXNlc0V2YWwoKSkKICAgICAgICAgICAg ICwgY29kZVR5cGUoY29kZVR5cGUpCi0gICAgICAgICAgICAsIHNvdXJjZShzb3VyY2UpCisgICAg ICAgICAgICAsIHNvdXJjZShzb3VyY2VQcm92aWRlcikKICAgICAgICAgICAgICwgc291cmNlT2Zm c2V0KHNvdXJjZU9mZnNldCkKICAgICAgICAgewogICAgICAgICAgICAgQVNTRVJUKHNvdXJjZSk7 CkluZGV4OiBDaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gQ2hhbmdlTG9nCShyZXZpc2lvbiAzODA2 NykKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDA4LTEx LTAyICBNYXR0IExpbGVrICA8d2Via2l0QG1hdHRsaWxlay5jb20+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDIyMDQyOiBSRUdSRVNTSU9OKHIz ODA2Nik6IEFTU0VSVElPTiBGQUlMRUQ6IHNvdXJjZSBpbiBDb2RlQmxvY2sKKyAgICAgICAgPGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjA0Mj4KKworICAgICAgICBS ZW5hbWUgcGFyYW1ldGVyIG5hbWUgdG8gYXZvaWQgQVNTRVJULgorCisgICAgICAgICogVk0vQ29k ZUJsb2NrLmg6CisgICAgICAgIChKU0M6OkNvZGVCbG9jazo6Q29kZUJsb2NrKToKKwogMjAwOC0x MS0wMiAgQ2FtZXJvbiBad2FyaWNoICA8endhcmljaEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgT2xpdmVyIEh1bnQuCg==