22041 2008-11-02 11:36:46 -0800 Fix CURL crashes on the test suite 2008-11-03 13:21:52 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Gtk P2 Normal --- 1 zecke webkit-unassigned oldest_to_newest 97422 0 zecke 2008-11-02 11:36:46 -0800 There are some crashes in the curl backend on the layout test suite. To make my life more easy I try to collect the fixes here. 97423 1 24850 zecke 2008-11-02 11:37:57 -0800 Created attachment 24850 Do not run into an assert Do not call didReceiveData if we have nothing to offer. 97424 2 24851 zecke 2008-11-02 11:39:47 -0800 Created attachment 24851 Fix segfault with setDefersLoading Do not call into curl when we don't have a CURL handle. 97460 3 24850 alp 2008-11-03 08:50:45 -0800 Comment on attachment 24850 Do not run into an assert r=me Added the same check to the other didReceiveData() in the same func too. 97461 4 24851 alp 2008-11-03 09:10:39 -0800 Comment on attachment 24851 Fix segfault with setDefersLoading r=me Good catch. I didn't spot this when testing recently because I neither had debugging enabled nor a recent enough version of curl to get the defer code compiled. Oops! Extra braces should not be there in the first if case to suit WebKit coding style. Will fix and land to get this out of the way. 97489 5 zecke 2008-11-03 13:21:52 -0800 Okay the patch was put into svn, SOUP got updated too => close this bug for now. 24850 2008-11-02 11:37:57 -0800 2008-11-03 08:50:45 -0800 Do not run into an assert 0006-assert-on-fast-tokenizer-image-empty-crash.html-do-n.patch text/plain 1329 zecke RnJvbSA3Mzk2OGVjZWY3MGE1ODlhZDkzZDZiZWU2NDc2MWEzYmE2NzExYjE4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlciA8emVja2VAc2Vs ZmlzaC5vcmc+CkRhdGU6IFN1biwgMiBOb3YgMjAwOCAxOToyNzowMCArMDEwMApTdWJqZWN0OiBb UEFUQ0hdIGFzc2VydCBvbiBmYXN0L3Rva2VuaXplci9pbWFnZS1lbXB0eS1jcmFzaC5odG1sIGRv IG5vdCBzZW5kICJubyBkYXRhIiB0byBXZWJDb3JlCgogICAgZmFzdC9wYXJzZXIveGh0bWwtZG9j dW1lbnQtd2l0aC1odG1sLW9iamVjdC54aHRtbCBpcyBhbHNvIGZpeGVkIGJ5CiAgICBpdC4KLS0t CiAuLi4vbmV0d29yay9jdXJsL1Jlc291cmNlSGFuZGxlTWFuYWdlci5jcHAgICAgICAgICB8ICAg IDMgKystCiAxIGZpbGVzIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRs ZU1hbmFnZXIuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5k bGVNYW5hZ2VyLmNwcAppbmRleCBiMzIyMzk4Li41MmQ3OGM3IDEwMDY0NAotLS0gYS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZU1hbmFnZXIuY3BwCisrKyBiL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNlSGFuZGxlTWFuYWdlci5jcHAKQEAg LTUzMCw3ICs1MzAsOCBAQCBzdGF0aWMgdm9pZCBwYXJzZURhdGFVcmwoUmVzb3VyY2VIYW5kbGUq IGhhbmRsZSkKICAgICAgICAgZGF0YSA9IGRlY29kZVVSTEVzY2FwZVNlcXVlbmNlcyhkYXRhLCBU ZXh0RW5jb2RpbmcoY2hhcnNldCkpOwogICAgICAgICByZXNwb25zZS5zZXRUZXh0RW5jb2RpbmdO YW1lKCJVVEYtMTYiKTsKICAgICAgICAgY2xpZW50LT5kaWRSZWNlaXZlUmVzcG9uc2UoaGFuZGxl LCByZXNwb25zZSk7Ci0gICAgICAgIGNsaWVudC0+ZGlkUmVjZWl2ZURhdGEoaGFuZGxlLCByZWlu dGVycHJldF9jYXN0PGNvbnN0IGNoYXIqPihkYXRhLmNoYXJhY3RlcnMoKSksIGRhdGEubGVuZ3Ro KCkgKiBzaXplb2YoVUNoYXIpLCAwKTsKKyAgICAgICAgaWYgKGRhdGEubGVuZ3RoKCkgPiAwKQor ICAgICAgICAgICAgY2xpZW50LT5kaWRSZWNlaXZlRGF0YShoYW5kbGUsIHJlaW50ZXJwcmV0X2Nh c3Q8Y29uc3QgY2hhcio+KGRhdGEuY2hhcmFjdGVycygpKSwgZGF0YS5sZW5ndGgoKSAqIHNpemVv ZihVQ2hhciksIDApOwogICAgIH0KIAogICAgIGNsaWVudC0+ZGlkRmluaXNoTG9hZGluZyhoYW5k bGUpOwotLSAKMS41LjYuMwoK 24851 2008-11-02 11:39:47 -0800 2008-11-03 09:10:39 -0800 Fix segfault with setDefersLoading 0007-Fix-segfault-on-fast-loader-simultaneous-reloads-ass.patch text/plain 2791 zecke RnJvbSBhNWRkOTE5NTk1NDg3OWQyNTY0ZWVjZmVlMTNmMzNhMzg5ZjZjZGVjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlciA8emVja2VAc2Vs ZmlzaC5vcmc+CkRhdGU6IFN1biwgMiBOb3YgMjAwOCAyMDoxODo1NSArMDEwMApTdWJqZWN0OiBb UEFUQ0hdIEZpeCBzZWdmYXVsdCBvbiBmYXN0L2xvYWRlci9zaW11bHRhbmVvdXMtcmVsb2Fkcy1h c3NlcnQuaHRtbAoKIEl0IGlzIGF0dGVtcHRlZCB0byBkZWZlciB0aGUgbG9hZGluZyBiZWZvcmUg dGhlIGxvYWQgaGFzIGJlZW4KIHN0YXJ0ZWQgKG5vIGN1cmwgaGFuZGxlIHdhcyBhbGxvY2F0ZWQg eWV0KS4gSWYgdGhhdCBoYXBwZW5zIHRoZW4KIGp1c3QgcmVtZW1iZXIgdGhhdC4gUmVzb3VyY2VI YW5kbGVNYW5hZ2VyOjpzdGFydEpvYiBpcyBhbHJlYWR5IHRha2luZwogY2FyZSBvZiB0aGlzIGFu ZCBpbiBpbml0UmVzb3VyY2VIYW5kbGUgdGhlIHRoZSBkb3dubG9hZGluZyB3aWxsCiBiZSBwYXVz ZWQgaWYgbmVlZGVkLgoKIFByb2dyYW0gcmVjZWl2ZWQgc2lnbmFsIFNJR1NFR1YsIFNlZ21lbnRh dGlvbiBmYXVsdC4KIFtTd2l0Y2hpbmcgdG8gVGhyZWFkIDB4YjQ0MjU3MjAgKExXUCAyOTYyNild CiAweGI2MzMwOWFhIGluIGN1cmxfZWFzeV9wYXVzZSAoKSBmcm9tIC91c3IvbGliL2xpYmN1cmwt Z251dGxzLnNvLjQKIChnZGIpIGJ0CiAjMCAgMHhiNjMzMDlhYSBpbiBjdXJsX2Vhc3lfcGF1c2Ug KCkgZnJvbSAvdXNyL2xpYi9saWJjdXJsLWdudXRscy5zby40CiAjMSAgMHhiNmYxOTU4MSBpbiBX ZWJDb3JlOjpSZXNvdXJjZUhhbmRsZTo6c2V0RGVmZXJzTG9hZGluZwogKHRoaXM9MHhhMDEyMTgw LCBkZWZlcnM9dHJ1ZSkgYXQKIC4uLy4uL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jl c291cmNlSGFuZGxlQ3VybC5jcHA6MTU2CiAjMiAgMHhiNmQwYmQwNSBpbiBXZWJDb3JlOjpSZXNv dXJjZUxvYWRlcjo6c2V0RGVmZXJzTG9hZGluZwogKHRoaXM9MHhhMDU5ODIwLCBkZWZlcnM9dHJ1 ZSkgYXQKIC4uLy4uL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZGVyLmNwcDoxNDUKICMzICAw eGI2Y2NmM2FlIGluIHNldEFsbERlZmVyc0xvYWRpbmcgKGxvYWRlcnM9QDB4YTAzYjUxNCwgZGVm ZXJzPXRydWUpCiBhdCAuLi8uLi9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHA6MTM0 CiAjNCAgMHhiNmNkMDY3NCBpbiBXZWJDb3JlOjpEb2N1bWVudExvYWRlcjo6c2V0RGVmZXJzTG9h ZGluZwogKHRoaXM9MHhhMDNiNTAwLCBkZWZlcnM9dHJ1ZSkgYXQKIC4uLy4uL1dlYkNvcmUvbG9h ZGVyL0RvY3VtZW50TG9hZGVyLmNwcDo3MjgKICM1ICAweGI2Y2YyYWIxIGluIFdlYkNvcmU6OkZy YW1lTG9hZGVyOjpzZXREZWZlcnNMb2FkaW5nCiAodGhpcz0weGEwMzVlZGMsIGRlZmVycz10cnVl KSBhdAogLi4vLi4vV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwOjMwNQogIzYgIDB4YjZk ODI2NDYgaW4gV2ViQ29yZTo6UGFnZTo6c2V0RGVmZXJzTG9hZGluZyAodGhpcz0weDlmM2Q1ZDgs CiBkZWZlcnM9dHJ1ZSkgYXQgLi4vLi4vV2ViQ29yZS9wYWdlL1BhZ2UuY3BwOjM2NwogIzcgIDB4 YjZkM2Q4NWUgaW4gUGFnZUdyb3VwTG9hZERlZmVycmVyICh0aGlzPTB4YmZlMzJiNjAsCiBwYWdl PTB4OWYzZDVkOCwgZGVmZXJTZWxmPXRydWUpIGF0IC4uLy4uL1dlYkNvcmUvcGFnZS9DaHJvbWUu Y3BwOjQ4MQogIzggIDB4YjZkM2U4OTUgaW4gV2ViQ29yZTo6Q2hyb21lOjpydW5KYXZhU2NyaXB0 QWxlcnQgKHRoaXM9MHg5ZjNkNjU4LAogZnJhbWU9MHg5ZjdkZGMwLCBtZXNzYWdlPUAweGJmZTMy Y2I4KSBhdAogLi4vLi4vV2ViQ29yZS9wYWdlL0Nocm9tZS5jcHA6MjUzCiAjOSAgMHhiNmQ0ODZk NCBpbiBXZWJDb3JlOjpET01XaW5kb3c6OmFsZXJ0ICh0aGlzPTB4OWY5ZTY1OCwKIG1lc3NhZ2U9 QDB4YmZlMzJjYjgpIGF0IC4uLy4uL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwOjQ4NAotLS0K IC4uLi9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVDdXJsLmNwcCAgIHwgICAg NCArKystCiAxIGZpbGVzIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRs ZUN1cmwuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVD dXJsLmNwcAppbmRleCA0NTM5NzBiLi4xNWUzZmM3IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZUN1cmwuY3BwCisrKyBiL1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNlSGFuZGxlQ3VybC5jcHAKQEAgLTE1Miw3ICsxNTIs OSBAQCB2b2lkIFJlc291cmNlSGFuZGxlOjpzZXREZWZlcnNMb2FkaW5nKGJvb2wgZGVmZXJzKQog ICAgICAgICByZXR1cm47CiAKICNpZiBMSUJDVVJMX1ZFUlNJT05fTlVNID4gMHgwNzEyMDAKLSAg ICBpZiAoZGVmZXJzKSB7CisgICAgaWYgKCFkLT5tX2hhbmRsZSkgeworICAgICAgICBkLT5tX2Rl ZmVyc0xvYWRpbmcgPSBkZWZlcnM7CisgICAgfSBlbHNlIGlmIChkZWZlcnMpIHsKICAgICAgICAg Q1VSTGNvZGUgZXJyb3IgPSBjdXJsX2Vhc3lfcGF1c2UoZC0+bV9oYW5kbGUsIENVUkxQQVVTRV9B TEwpOwogICAgICAgICAvLyBJZiB3ZSBjb3VsZCBub3QgZGVmZXIgdGhlIGhhbmRsZSwgc28gZG9u J3QgZG8gaXQuCiAgICAgICAgIGlmIChlcnJvciAhPSBDVVJMRV9PSykKLS0gCjEuNS42LjMKCg==