<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>220400</bug_id>
          
          <creation_ts>2021-01-06 23:20:59 -0800</creation_ts>
          <short_desc>[CoreIPC] null-ptr in IPC::createArchiveList</short_desc>
          <delta_ts>2021-01-19 23:30:35 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ryosuke Niwa">rniwa</reporter>
          <assigned_to name="Rob Buis">rbuis</assigned_to>
          <cc>achristensen</cc>
    
    <cc>bfulgham</cc>
    
    <cc>cgarcia</cc>
    
    <cc>ews-feeder</cc>
    
    <cc>fred.wang</cc>
    
    <cc>gpoo</cc>
    
    <cc>product-security</cc>
    
    <cc>rbuis</cc>
    
    <cc>svillar</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1717873</commentid>
    <comment_count>0</comment_count>
      <attachid>417158</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2021-01-06 23:20:59 -0800</bug_when>
    <thetext>Created attachment 417158
Test (requires WTR in macOS)

Using the new IPC testing code I added in https://trac.webkit.org/r268239,
we can reproduce the following crash in macOS ASAN builds:

ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc 0x7fff203e9144 bp 0x7ffee7d4c6f0 sp 0x7ffee7d4c6c0 T0)

    #0 0x7fff203e9144 in CFDictionaryGetValue+0x21 (CoreFoundation:x86_64h+0x8144)
    #1 0x1133c5b8e in IPC::createArchiveList(__CFDictionary const*, void const*, long*, void const***, long*, __CFDictionary const**, __CFNumber const**, __CFString const**) WebCoreArgumentCodersMac.mm:108
    #2 0x1133c57f3 in IPC::createCFURLRequestFromSerializableRepresentation(__CFDictionary const*, void const*) WebCoreArgumentCodersMac.mm:170
    #3 0x1133b71b7 in IPC::createNSURLRequestFromSerializableRepresentation(__CFDictionary const*, void const*) WebCoreArgumentCodersMac.mm:185
    #4 0x1133b69dd in IPC::ArgumentCoder&lt;WebCore::ResourceRequest&gt;::decodePlatformData(IPC::Decoder&amp;, WebCore::ResourceRequest&amp;) WebCoreArgumentCodersMac.mm:234
    #5 0x1146ee151 in IPC::ArgumentCoder&lt;WebCore::ResourceRequest&gt;::decode(IPC::Decoder&amp;, WebCore::ResourceRequest&amp;) WebCoreArgumentCoders.cpp:1270
    #6 0x112359f8b in IPC::Decoder&amp; IPC::Decoder::operator&gt;&gt;&lt;WebCore::ResourceRequest, (void*)0&gt;(WTF::Optional&lt;WebCore::ResourceRequest&gt;&amp;) Decoder.h:161
    #7 0x113497604 in WebKit::FrameInfoData::decode(IPC::Decoder&amp;) FrameInfoData.cpp:50
    #8 0x1125d4bbd in WTF::Optional&lt;WebKit::FrameInfoData&gt; IPC::ArgumentCoder&lt;WebKit::FrameInfoData&gt;::decode&lt;WebKit::FrameInfoData, (void*)0&gt;(IPC::Decoder&amp;) ArgumentCoder.h:111
    #9 0x1125d4779 in IPC::Decoder&amp; IPC::Decoder::operator&gt;&gt;&lt;WebKit::FrameInfoData, (void*)0&gt;(WTF::Optional&lt;WebKit::FrameInfoData&gt;&amp;) Decoder.h:153
    #10 0x11460e156 in IPC::TupleDecoderImpl&lt;WebKit::FrameInfoData, WTF::Vector&lt;unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc&gt;, WebCore::PublicKeyCredentialRequestOptions, bool&gt;::decode(IPC::Decoder&amp;) ArgumentCoders.h:296
    #11 0x11460de2e in IPC::TupleDecoderImpl&lt;WTF::ObjectIdentifier&lt;WebCore::FrameIdentifierType&gt;, WebKit::FrameInfoData, WTF::Vector&lt;unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc&gt;, WebCore::PublicKeyCredentialRequestOptions, bool&gt;::decode(IPC::Decoder&amp;) ArgumentCoders.h:300
    #12 0x11460dc7d in IPC::TupleDecoder&lt;5ul, WTF::ObjectIdentifier&lt;WebCore::FrameIdentifierType&gt;, WebKit::FrameInfoData, WTF::Vector&lt;unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc&gt;, WebCore::PublicKeyCredentialRequestOptions, bool&gt;::decode(IPC::Decoder&amp;) ArgumentCoders.h:324
    #13 0x11460db9d in IPC::ArgumentCoder&lt;std::__1::tuple&lt;WTF::ObjectIdentifier&lt;WebCore::FrameIdentifierType&gt;, WebKit::FrameInfoData, WTF::Vector&lt;unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc&gt;, WebCore::PublicKeyCredentialRequestOptions, bool&gt; &gt;::decode(IPC::Decoder&amp;) ArgumentCoders.h:344
    #14 0x11460d952 in IPC::Decoder&amp; IPC::Decoder::operator&gt;&gt;&lt;std::__1::tuple&lt;WTF::ObjectIdentifier&lt;WebCore::FrameIdentifierType&gt;, WebKit::FrameInfoData, WTF::Vector&lt;unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc&gt;, WebCore::PublicKeyCredentialRequestOptions, bool&gt;, (void*)0&gt;(WTF::Optional&lt;std::__1::tuple&lt;WTF::ObjectIdentifier&lt;WebCore::FrameIdentifierType&gt;, WebKit::FrameInfoData, WTF::Vector&lt;unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc&gt;, WebCore::PublicKeyCredentialRequestOptions, bool&gt; &gt;&amp;) Decoder.h:153
    #15 0x114608ef7 in void IPC::handleMessageAsync&lt;Messages::WebAuthenticatorCoordinatorProxy::GetAssertion, WebKit::WebAuthenticatorCoordinatorProxy, void (WebKit::WebAuthenticatorCoordinatorProxy::*)(WTF::ObjectIdentifier&lt;WebCore::FrameIdentifierType&gt;, WebKit::FrameInfoData&amp;&amp;, WTF::Vector&lt;unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc&gt;&amp;&amp;, WebCore::PublicKeyCredentialRequestOptions&amp;&amp;, bool, WTF::CompletionHandler&lt;void (WebCore::AuthenticatorResponseData const&amp;, WebCore::ExceptionData const&amp;)&gt;&amp;&amp;)&gt;(IPC::Connection&amp;, IPC::Decoder&amp;, WebKit::WebAuthenticatorCoordinatorProxy*, void (WebKit::WebAuthenticatorCoordinatorProxy::*)(WTF::ObjectIdentifier&lt;WebCore::FrameIdentifierType&gt;, WebKit::FrameInfoData&amp;&amp;, WTF::Vector&lt;unsigned char, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc&gt;&amp;&amp;, WebCore::PublicKeyCredentialRequestOptions&amp;&amp;, bool, WTF::CompletionHandler&lt;void (WebCore::AuthenticatorResponseData const&amp;, WebCore::ExceptionData const&amp;)&gt;&amp;&amp;)) HandleMessage.h:178
    #16 0x114608a0d in WebKit::WebAuthenticatorCoordinatorProxy::didReceiveMessage(IPC::Connection&amp;, IPC::Decoder&amp;) WebAuthenticatorCoordinatorProxyMessageReceiver.cpp:146
    #17 0x11284c285 in IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&amp;, IPC::Decoder&amp;) MessageReceiverMap.cpp:123
    #18 0x1137757fc in WebKit::AuxiliaryProcessProxy::dispatchMessage(IPC::Connection&amp;, IPC::Decoder&amp;) AuxiliaryProcessProxy.cpp:216
    #19 0x113b57367 in WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&amp;, IPC::Decoder&amp;) WebProcessProxy.cpp:808
    #20 0x112374b93 in IPC::Connection::dispatchMessage(IPC::Decoder&amp;) Connection.cpp:1039
    #21 0x112376507 in IPC::Connection::dispatchMessage(std::__1::unique_ptr&lt;IPC::Decoder, std::__1::default_delete&lt;IPC::Decoder&gt; &gt;) Connection.cpp:1139
    #22 0x112373319 in IPC::Connection::dispatchIncomingMessages() Connection.cpp:1243
    #23 0x1123955ee in IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr&lt;IPC::Decoder, std::__1::default_delete&lt;IPC::Decoder&gt; &gt;)::$_8::operator()() Connection.cpp:1000
    #24 0x11239555c in WTF::Detail::CallableWrapper&lt;IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr&lt;IPC::Decoder, std::__1::default_delete&lt;IPC::Decoder&gt; &gt;)::$_8, void&gt;::call() Function.h:52
    #25 0x109c695ce in WTF::Function&lt;void ()&gt;::operator()() const Function.h:83
    #26 0x109d02a28 in WTF::RunLoop::performWork() RunLoop.cpp:128
    #27 0x109d05d45 in WTF::RunLoop::performWork(void*) RunLoopCF.cpp:46
    #28 0x7fff20462a0b in __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__+0x10 (CoreFoundation:x86_64h+0x81a0b)
    #29 0x7fff20462973 in __CFRunLoopDoSource0+0xb3 (CoreFoundation:x86_64h+0x81973)
    #30 0x7fff204626ee in __CFRunLoopDoSources0+0xf7 (CoreFoundation:x86_64h+0x816ee)
    #31 0x7fff20461120 in __CFRunLoopRun+0x379 (CoreFoundation:x86_64h+0x80120)
    #32 0x7fff204606cd in CFRunLoopRunSpecific+0x232 (CoreFoundation:x86_64h+0x7f6cd)
    #33 0x7fff211edfa0 in -[NSRunLoop(NSRunLoop) runMode:beforeDate:]+0xd3 (Foundation:x86_64+0x5ffa0)
    #34 0x107f77006 in WTR::TestController::platformRunUntil(bool&amp;, WTF::Seconds) TestControllerCocoa.mm:225
    #35 0x107f2183a in WTR::TestController::runUntil(bool&amp;, WTF::Seconds) TestController.cpp:1546
    #36 0x107f996cd in WTR::TestInvocation::invoke() TestInvocation.cpp:168
    #37 0x107f2e541 in WTR::TestController::runTest(char const*) TestController.cpp:1476
    #38 0x107f2269d in WTR::TestController::run() TestController.cpp:1533
    #39 0x107f21c01 in WTR::TestController::TestController(int, char const**) TestController.cpp:193
    #40 0x107f22708 in WTR::TestController::TestController(int, char const**) TestController.cpp:190
    #41 0x107ebd0aa in main main.mm:70

&lt;rdar://problem/70476922&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1720316</commentid>
    <comment_count>1</comment_count>
      <attachid>417824</attachid>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2021-01-18 03:05:29 -0800</bug_when>
    <thetext>Created attachment 417824
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1720363</commentid>
    <comment_count>2</comment_count>
      <attachid>417824</attachid>
    <who name="youenn fablet">youennf</who>
    <bug_when>2021-01-18 09:34:06 -0800</bug_when>
    <thetext>Comment on attachment 417824
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417824&amp;action=review

&gt; Source/WebKit/Shared/mac/WebCoreArgumentCodersMac.mm:235
&gt; +        return false;

Seems fine like this.
Looking at a few place, we sometimes do check for dictionary being null before encoding it and we are not doing it everywhere (FontInfo::decode or SecItemRequestData::decode).
In that particular case, we would not need to encode this boolean at all so there might be a small gain to have explicit checks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1720477</commentid>
    <comment_count>3</comment_count>
      <attachid>417861</attachid>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2021-01-19 00:23:16 -0800</bug_when>
    <thetext>Created attachment 417861
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1720485</commentid>
    <comment_count>4</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-01-19 01:07:56 -0800</bug_when>
    <thetext>Committed r271597: &lt;https://trac.webkit.org/changeset/271597&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417861.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>417158</attachid>
            <date>2021-01-06 23:20:59 -0800</date>
            <delta_ts>2021-01-06 23:20:59 -0800</delta_ts>
            <desc>Test (requires WTR in macOS)</desc>
            <filename>ipc-createArchiveList.html</filename>
            <type>text/html</type>
            <size>674</size>
            <attacher name="Ryosuke Niwa">rniwa</attacher>
            
              <data encoding="base64">PCFET0NUWVBFIGh0bWw+PCEtLSB3ZWJraXQtdGVzdC1ydW5uZXIgWyBJUENUZXN0aW5nQVBJRW5h
YmxlZD10cnVlIF0gLS0+CjxodG1sPgo8Ym9keT4KPHNjcmlwdD4KSVBDLnNlbmRNZXNzYWdlKCdV
SScsSVBDLndlYlBhZ2VQcm94eUlELElQQy5tZXNzYWdlcy5XZWJBdXRoZW50aWNhdG9yQ29vcmRp
bmF0b3JQcm94eV9HZXRBc3NlcnRpb24ubmFtZSxbe3R5cGU6ICd1aW50NjRfdCcsdmFsdWU6IElQ
Qy5mcmFtZUlEfSx7dHlwZTogJ3VpbnQ2NF90Jyx2YWx1ZTogSVBDLmZyYW1lSUR9LHt0eXBlOiAn
ZG91YmxlJyx2YWx1ZTogNDUzLjc1NDgwMDE3MTU2NzA3fSxuZXcgVWludDhBcnJheShbMjQyLDMy
LDI1MSwxNTUsMjMyLDc4LDEwOSwzMSw5NSw2OSwyMzAsMjA0LDE4MCwyMjMsMTQzLDExNywzNyw2
MCw1OCwyMzQsMTY2LDIwNiwxNjYsMjA2LDIwMyw4NSwyMDgsMTAzLDEyMywxNCwyMzgsMTIzLDI0
OSwxNzcsMTkxLDE1NywxOSwyNDEsNzQsNTIsMjQwLDEyNyw2Miw3OCwxMzEsMjMyLDI1NCwyNDgs
MjUyLDE0LDE1MSwyMzMsMTk0LDIyMSwxMTYsMTE5LDExNiwyNDIsODYsMTM3LDE3MiwxOTYsMjIy
LDE0LDE0MSwxNTMsNzEsMjQxLDE1NiwxNDcsMjUyLDAsMjQ0LDIwMiwyNTAsMjI0XSkse3R5cGU6
ICdib29sJyx2YWx1ZTogMX1dKTsKPC9zY3JpcHQ+CjwvYm9keT4KPC9odG1sPgo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>417824</attachid>
            <date>2021-01-18 03:05:29 -0800</date>
            <delta_ts>2021-01-19 00:23:10 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-220400-20210118120526.patch</filename>
            <type>text/plain</type>
            <size>3620</size>
            <attacher name="Rob Buis">rbuis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNTc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGNjNzcxYTU2MTZkYTRmNDBh
OWNjZjE2MDZiNzc0NTBiNGNkY2ZiNGYuLmRmZmZmNGMwODRjNjcyYjU2ZTY0MmE2ZWQ0MzI5ZjQ4
MWY2NTU2ZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMDEtMTggIFJvYiBCdWlz
ICA8cmJ1aXNAaWdhbGlhLmNvbT4KKworICAgICAgICBOdWxsIGNoZWNrIFJlc291cmNlUmVxdWVz
dCBJUEMgZGVjb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD0yMjA0MDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg
ICAgICBUZXN0OiBpcGMvd2ViLWF1dGhlbnRpY2F0b3ItZ2V0LWFzc2VydGlvbi5odG1sCisKKyAg
ICAgICAgKiBTaGFyZWQvbWFjL1dlYkNvcmVBcmd1bWVudENvZGVyc01hYy5tbToKKyAgICAgICAg
KElQQzo6QXJndW1lbnRDb2RlcjxXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3Q+OjpkZWNvZGVQbGF0
Zm9ybURhdGEpOgorCiAyMDIxLTAxLTE3ICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5j
b20+CiAKICAgICAgICAgSklUT3BlcmF0aW9uIGRvZXMgbm90IGV4aXN0IGluIFdlYktpdApkaWZm
IC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvbWFjL1dlYkNvcmVBcmd1bWVudENvZGVyc01h
Yy5tbSBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL21hYy9XZWJDb3JlQXJndW1lbnRDb2RlcnNNYWMu
bW0KaW5kZXggZWU5MWQwOGUwMTQ5NDM2MTQwOGM5MWM0MjAwYzZhY2UzN2I5YzcxYy4uYjUyOGI5
YTc5ZDM1YWMzY2ZlNTFlZWMzOWJhN2UwYzY3NWVlYzlkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YktpdC9TaGFyZWQvbWFjL1dlYkNvcmVBcmd1bWVudENvZGVyc01hYy5tbQorKysgYi9Tb3VyY2Uv
V2ViS2l0L1NoYXJlZC9tYWMvV2ViQ29yZUFyZ3VtZW50Q29kZXJzTWFjLm1tCkBAIC0yMzEsNiAr
MjMxLDkgQEAgYm9vbCBBcmd1bWVudENvZGVyPFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdD46OmRl
Y29kZVBsYXRmb3JtRGF0YShEZWNvZGVyJiBkZWNvZGUKICAgICBpZiAoIUlQQzo6ZGVjb2RlKGRl
Y29kZXIsIGRpY3Rpb25hcnkpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKKyAgICBpZiAoIWRp
Y3Rpb25hcnkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAgIGF1dG8gbnNVUkxSZXF1ZXN0
ID0gY3JlYXRlTlNVUkxSZXF1ZXN0RnJvbVNlcmlhbGl6YWJsZVJlcHJlc2VudGF0aW9uKGRpY3Rp
b25hcnkuZ2V0KCksIElQQzo6dG9rZW5OdWxscHRyVHlwZVJlZigpKTsKICAgICBpZiAoIW5zVVJM
UmVxdWVzdCkKICAgICAgICAgcmV0dXJuIGZhbHNlOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv
Q2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDIzMDZiZmY4ZWQ5MjU1YmJj
YmZjZGYxNGUyOGJiZjc2NGFjMTQ5YzAuLmI0NmY3MDczZTgyYTMwMTExZmYzNWI0ZmFiODliMDRj
OTI4OTI5NTYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRU
ZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAyMS0wMS0xOCAgUm9iIEJ1aXMgIDxy
YnVpc0BpZ2FsaWEuY29tPgorCisgICAgICAgIE51bGwgY2hlY2sgUmVzb3VyY2VSZXF1ZXN0IElQ
QyBkZWNvZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTIyMDQwMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IEFkZCB0ZXN0IGZvciB0aGlzLgorCisgICAgICAgICogaXBjL3dlYi1hdXRoZW50aWNhdG9yLWdl
dC1hc3NlcnRpb24tZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBpcGMvd2ViLWF1dGhl
bnRpY2F0b3ItZ2V0LWFzc2VydGlvbi5odG1sOiBBZGRlZC4KKwogMjAyMS0wMS0xOCAgWW91ZW5u
IEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViUlRDIGxpdmUgT3B1cyBh
dWRpbyBzdHJlYW0gc3R1dHRlcnMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2lwYy93ZWItYXV0
aGVudGljYXRvci1nZXQtYXNzZXJ0aW9uLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2lwYy93
ZWItYXV0aGVudGljYXRvci1nZXQtYXNzZXJ0aW9uLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2Rl
IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4w
MzgzMTYyMGY2NDgwNDUzOGUyMGU5NmExMTMzYmFlOTFkNmI0Y2VkCi0tLSAvZGV2L251bGwKKysr
IGIvTGF5b3V0VGVzdHMvaXBjL3dlYi1hdXRoZW50aWNhdG9yLWdldC1hc3NlcnRpb24tZXhwZWN0
ZWQudHh0CkBAIC0wLDAgKzEgQEAKK1Rlc3QgcGFzc2VzIGlmIGl0IGRvZXMgbm90IGNyYXNoLgpk
aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaXBjL3dlYi1hdXRoZW50aWNhdG9yLWdldC1hc3NlcnRp
b24uaHRtbCBiL0xheW91dFRlc3RzL2lwYy93ZWItYXV0aGVudGljYXRvci1nZXQtYXNzZXJ0aW9u
Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMC4uMmI4MjUyYzg1MGQzZTRiYmJlNzAwNzVkNDk5ZGU3M2ZlMjExMDZh
OQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2lwYy93ZWItYXV0aGVudGljYXRvci1n
ZXQtYXNzZXJ0aW9uLmh0bWwKQEAgLTAsMCArMSwxMiBAQAorPCFET0NUWVBFIGh0bWw+PCEtLSB3
ZWJraXQtdGVzdC1ydW5uZXIgWyBJUENUZXN0aW5nQVBJRW5hYmxlZD10cnVlIF0gLS0+Cis8aHRt
bD4KKzxib2R5PgorVGVzdCBwYXNzZXMgaWYgaXQgZG9lcyBub3QgY3Jhc2guCis8c2NyaXB0Pgor
aWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworaWYg
KHdpbmRvdy5JUEMpCisgICAgSVBDLnNlbmRNZXNzYWdlKCdVSScsSVBDLndlYlBhZ2VQcm94eUlE
LElQQy5tZXNzYWdlcy5XZWJBdXRoZW50aWNhdG9yQ29vcmRpbmF0b3JQcm94eV9HZXRBc3NlcnRp
b24ubmFtZSxbe3R5cGU6ICd1aW50NjRfdCcsdmFsdWU6IElQQy5mcmFtZUlEfSx7dHlwZTogJ3Vp
bnQ2NF90Jyx2YWx1ZTogSVBDLmZyYW1lSUR9LHt0eXBlOiAnZG91YmxlJyx2YWx1ZTogNDUzLjc1
NDgwMDE3MTU2NzA3fSxuZXcgVWludDhBcnJheShbMjQyLDMyLDI1MSwxNTUsMjMyLDc4LDEwOSwz
MSw5NSw2OSwyMzAsMjA0LDE4MCwyMjMsMTQzLDExNywzNyw2MCw1OCwyMzQsMTY2LDIwNiwxNjYs
MjA2LDIwMyw4NSwyMDgsMTAzLDEyMywxNCwyMzgsMTIzLDI0OSwxNzcsMTkxLDE1NywxOSwyNDEs
NzQsNTIsMjQwLDEyNyw2Miw3OCwxMzEsMjMyLDI1NCwyNDgsMjUyLDE0LDE1MSwyMzMsMTk0LDIy
MSwxMTYsMTE5LDExNiwyNDIsODYsMTM3LDE3MiwxOTYsMjIyLDE0LDE0MSwxNTMsNzEsMjQxLDE1
NiwxNDcsMjUyLDAsMjQ0LDIwMiwyNTAsMjI0XSkse3R5cGU6ICdib29sJyx2YWx1ZTogMX1dKTsK
Kzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>417861</attachid>
            <date>2021-01-19 00:23:16 -0800</date>
            <delta_ts>2021-01-19 01:07:57 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-220400-20210119092314.patch</filename>
            <type>text/plain</type>
            <size>3856</size>
            <attacher name="Rob Buis">rbuis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNTk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU0NmM5ZWNhNzk5ZGI3ZTFi
MjM1OWQ5ZTBmY2FjNTYyNWY5MGRkNjIuLjhkOWQ2Y2RlY2E0ZDc3OWM1MDZkMDBkYTI2YzQyYzY1
ZTEwNmVjOTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjEtMDEtMTkgIFJvYiBCdWlz
ICA8cmJ1aXNAaWdhbGlhLmNvbT4KKworICAgICAgICBOdWxsIGNoZWNrIFJlc291cmNlUmVxdWVz
dCBJUEMgZGVjb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD0yMjA0MDAKKworICAgICAgICBSZXZpZXdlZCBieSBZb3Vlbm4gRmFibGV0LgorCisgICAg
ICAgIE51bGwgY2hlY2sgUmVzb3VyY2VSZXF1ZXN0IElQQyBkZWNvZGUgc2luY2UKKyAgICAgICAg
dGhlIElQQzo6ZGVjb2RlIGNhbGwgY2FuIHN1Y2NlZWQgeWV0IGJ1dCBzZXQKKyAgICAgICAgdGhl
IGRpY3Rpb25hcnkgdG8gbnVsbC4KKworICAgICAgICBUZXN0OiBpcGMvd2ViLWF1dGhlbnRpY2F0
b3ItZ2V0LWFzc2VydGlvbi5odG1sCisKKyAgICAgICAgKiBTaGFyZWQvbWFjL1dlYkNvcmVBcmd1
bWVudENvZGVyc01hYy5tbToKKyAgICAgICAgKElQQzo6QXJndW1lbnRDb2RlcjxXZWJDb3JlOjpS
ZXNvdXJjZVJlcXVlc3Q+OjpkZWNvZGVQbGF0Zm9ybURhdGEpOgorCiAyMDIxLTAxLTE4ICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgogCiAgICAgICAgIFtHVEtdIE11
bHRpbGliIGNvbmZsaWN0cyBpbiBnaXIgZmlsZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv
U2hhcmVkL21hYy9XZWJDb3JlQXJndW1lbnRDb2RlcnNNYWMubW0gYi9Tb3VyY2UvV2ViS2l0L1No
YXJlZC9tYWMvV2ViQ29yZUFyZ3VtZW50Q29kZXJzTWFjLm1tCmluZGV4IGVlOTFkMDhlMDE0OTQz
NjE0MDhjOTFjNDIwMGM2YWNlMzdiOWM3MWMuLmI1MjhiOWE3OWQzNWFjM2NmZTUxZWVjMzliYTdl
MGM2NzVlZWM5ZDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL21hYy9XZWJDb3Jl
QXJndW1lbnRDb2RlcnNNYWMubW0KKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQvbWFjL1dlYkNv
cmVBcmd1bWVudENvZGVyc01hYy5tbQpAQCAtMjMxLDYgKzIzMSw5IEBAIGJvb2wgQXJndW1lbnRD
b2RlcjxXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3Q+OjpkZWNvZGVQbGF0Zm9ybURhdGEoRGVjb2Rl
ciYgZGVjb2RlCiAgICAgaWYgKCFJUEM6OmRlY29kZShkZWNvZGVyLCBkaWN0aW9uYXJ5KSkKICAg
ICAgICAgcmV0dXJuIGZhbHNlOwogCisgICAgaWYgKCFkaWN0aW9uYXJ5KQorICAgICAgICByZXR1
cm4gZmFsc2U7CisKICAgICBhdXRvIG5zVVJMUmVxdWVzdCA9IGNyZWF0ZU5TVVJMUmVxdWVzdEZy
b21TZXJpYWxpemFibGVSZXByZXNlbnRhdGlvbihkaWN0aW9uYXJ5LmdldCgpLCBJUEM6OnRva2Vu
TnVsbHB0clR5cGVSZWYoKSk7CiAgICAgaWYgKCFuc1VSTFJlcXVlc3QpCiAgICAgICAgIHJldHVy
biBmYWxzZTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3Rz
L0NoYW5nZUxvZwppbmRleCA5NmE1ZTIzNTQwNzYwNGY4ZDVmODkyMjNiZDc2NWVhNmQ4MWFhNjli
Li4zMjgzYmZjNTg2MmQwNjc3NWFlODczMGNlN2FkN2Y4MmU3ODZmODI1IDEwMDY0NAotLS0gYS9M
YXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMg
KzEsMTUgQEAKKzIwMjEtMDEtMTkgIFJvYiBCdWlzICA8cmJ1aXNAaWdhbGlhLmNvbT4KKworICAg
ICAgICBOdWxsIGNoZWNrIFJlc291cmNlUmVxdWVzdCBJUEMgZGVjb2RlCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjA0MDAKKworICAgICAgICBSZXZp
ZXdlZCBieSBZb3Vlbm4gRmFibGV0LgorCisgICAgICAgIEFkZCB0ZXN0IGZvciB0aGlzLgorCisg
ICAgICAgICogaXBjL3dlYi1hdXRoZW50aWNhdG9yLWdldC1hc3NlcnRpb24tZXhwZWN0ZWQudHh0
OiBBZGRlZC4KKyAgICAgICAgKiBpcGMvd2ViLWF1dGhlbnRpY2F0b3ItZ2V0LWFzc2VydGlvbi5o
dG1sOiBBZGRlZC4KKwogMjAyMS0wMS0xOCAgTGF1cm8gTW91cmEgIDxsbW91cmFAaWdhbGlhLmNv
bT4KIAogICAgICAgICBbR0xJQl0gR2FyZGVuaW5nIHNvbWUgZmFpbHVyZXMgYW5kIGNyYXNoZXMK
ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2lwYy93ZWItYXV0aGVudGljYXRvci1nZXQtYXNzZXJ0
aW9uLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2lwYy93ZWItYXV0aGVudGljYXRvci1nZXQt
YXNzZXJ0aW9uLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4wMzgzMTYyMGY2NDgwNDUzOGUyMGU5
NmExMTMzYmFlOTFkNmI0Y2VkCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaXBjL3dl
Yi1hdXRoZW50aWNhdG9yLWdldC1hc3NlcnRpb24tZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEgQEAK
K1Rlc3QgcGFzc2VzIGlmIGl0IGRvZXMgbm90IGNyYXNoLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz
dHMvaXBjL3dlYi1hdXRoZW50aWNhdG9yLWdldC1hc3NlcnRpb24uaHRtbCBiL0xheW91dFRlc3Rz
L2lwYy93ZWItYXV0aGVudGljYXRvci1nZXQtYXNzZXJ0aW9uLmh0bWwKbmV3IGZpbGUgbW9kZSAx
MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNTJi
OTRhNmU0YTM5YzcyMGI0ZDZlZDViN2ViNmZlODIxZjdiN2Q1OQotLS0gL2Rldi9udWxsCisrKyBi
L0xheW91dFRlc3RzL2lwYy93ZWItYXV0aGVudGljYXRvci1nZXQtYXNzZXJ0aW9uLmh0bWwKQEAg
LTAsMCArMSwxMiBAQAorPCFET0NUWVBFIGh0bWw+PCEtLSB3ZWJraXQtdGVzdC1ydW5uZXIgWyBJ
UENUZXN0aW5nQVBJRW5hYmxlZD10cnVlIF0gLS0+Cis8aHRtbD4KKzxib2R5PgorVGVzdCBwYXNz
ZXMgaWYgaXQgZG9lcyBub3QgY3Jhc2guCis8c2NyaXB0PgoraWYgKHdpbmRvdy50ZXN0UnVubmVy
KQorICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworaWYgKHdpbmRvdy5JUEMpCisgICAgSVBD
LnNlbmRNZXNzYWdlKCdVSScsIElQQy53ZWJQYWdlUHJveHlJRCwgSVBDLm1lc3NhZ2VzLldlYkF1
dGhlbnRpY2F0b3JDb29yZGluYXRvclByb3h5X0dldEFzc2VydGlvbi5uYW1lLCBbe3R5cGU6ICd1
aW50NjRfdCcsIHZhbHVlOiBJUEMuZnJhbWVJRH0sIHt0eXBlOiAndWludDY0X3QnLCB2YWx1ZTog
SVBDLmZyYW1lSUR9LCB7dHlwZTogJ2RvdWJsZScsIHZhbHVlOiA0NTMuNzU0ODAwMTcxNTY3MDd9
LCBuZXcgVWludDhBcnJheShbMjQyLCAzMiwgMjUxLCAxNTUsIDIzMiwgNzgsIDEwOSwgMzEsIDk1
LCA2OSwgMjMwLCAyMDQsIDE4MCwgMjIzLCAxNDMsIDExNywgMzcsIDYwLCA1OCwgMjM0LCAxNjYs
IDIwNiwgMTY2LCAyMDYsIDIwMywgODUsIDIwOCwgMTAzLCAxMjMsIDE0LCAyMzgsIDEyMywgMjQ5
LCAxNzcsIDE5MSwgMTU3LCAxOSwgMjQxLCA3NCwgNTIsIDI0MCwgMTI3LCA2MiwgNzgsIDEzMSwg
MjMyLCAyNTQsIDI0OCwgMjUyLCAxNCwgMTUxLCAyMzMsIDE5NCwgMjIxLCAxMTYsIDExOSwgMTE2
LCAyNDIsIDg2LCAxMzcsIDE3MiwgMTk2LCAyMjIsIDE0LCAxNDEsIDE1MywgNzEsIDI0MSwgMTU2
LCAxNDcsIDI1MiwgMCwgMjQ0LCAyMDIsIDI1MCwgMjI0XSksIHt0eXBlOiAnYm9vbCcsIHZhbHVl
OiAxfV0pOworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>