220380 2021-01-06 12:29:07 -0800 [WinCairo] WebGL isn't shown in non-AC mode 2021-01-07 13:36:41 -0800 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 220428 1 fujii fujii dino ews-watchlist graouts jdarpinian kbr kkinnunen kondapallykalyan webkit-bug-importer oldest_to_newest 1717741 0 fujii 2021-01-06 12:29:07 -0800 [WinCairo] WebGL isn't shown in non-AC mode 1. Start WinCairo MiniBrowser 2. Go to a WebGL page, for example, https://get.webgl.org/ A cube is shown 3. Disable Accelerated Compositing. Menu → Debug → Use Accelerated Compositing 4. The cube disappears 1717742 1 417114 fujii 2021-01-06 12:29:24 -0800 Created attachment 417114 WIP patch 1717748 2 417116 fujii 2021-01-06 12:50:25 -0800 Created attachment 417116 Patch 1717753 3 jdarpinian 2021-01-06 13:04:14 -0800 In this case, context creation should fail when the failIfMajorPerformanceCaveat context creation flag is set. Can you verify that is working? 1717777 4 417116 kbr 2021-01-06 14:45:03 -0800 Comment on attachment 417116 Patch r+ assuming jdarpinian's question is answered in the affirmative. 1717830 5 fujii 2021-01-06 18:51:37 -0800 (In reply to James Darpinian from comment #3) > In this case, context creation should fail when the > failIfMajorPerformanceCaveat context creation flag is set. Can you verify > that is working? No, it doesn't fail. I don't think it should fail in the case. Disabling accelerated compositing doesn't necessarily mean no GPU available. I disables WinCairo's accelerated compositing for some purposes: 1. non-AC mode is still faster than AC mode in WinCairo. (WinCairo's compositor should be improved) 2. Comparing AC mode and non-AC mode rendering results for debugging compositor's issues WebGL works nicely in non-AC mode with this patch. I think there is no MajorPerformanceCaveat. 1717851 6 jdarpinian 2021-01-06 21:15:55 -0800 This exact situation, using glReadPixels in the compositing path, is exactly why failIfMajorPerformanceCaveat was originally added to the spec. It is a big performance problem for fullscreen WebGL apps on high resolution monitors. 1717864 7 fujii 2021-01-06 22:29:38 -0800 (In reply to James Darpinian from comment #6) > This exact situation, using glReadPixels in the compositing path, is exactly > why failIfMajorPerformanceCaveat was originally added to the spec. It is a > big performance problem for fullscreen WebGL apps on high resolution > monitors. Yeah, it's pretty likely happening. Reading back from GPU to CPU is so expensive. OK. I'm going to land the patch without solving the failIfMajorPerformanceCaveat problem and leave the task into my lengthy to-do list. 1718007 8 kbr 2021-01-07 11:18:53 -0800 (In reply to Fujii Hironori from comment #7) > (In reply to James Darpinian from comment #6) > > This exact situation, using glReadPixels in the compositing path, is exactly > > why failIfMajorPerformanceCaveat was originally added to the spec. It is a > > big performance problem for fullscreen WebGL apps on high resolution > > monitors. > > Yeah, it's pretty likely happening. Reading back from GPU to CPU is so > expensive. > > OK. I'm going to land the patch without solving the > failIfMajorPerformanceCaveat problem and leave the task into my > lengthy to-do list. Would you mind filing a bug here under the WebGL component and blocking it on this one? That way at least it's tracked in a way that others might potentially contribute to the solution. Thanks! 1718039 9 fujii 2021-01-07 12:22:04 -0800 Sure. Filed: Bug 220428 – [WinCairo] WebGL context creation should fail if accelerated compositing is disabled and the failIfMajorPerformanceCaveat context creation flag is set 1718043 10 417116 fujii 2021-01-07 12:26:41 -0800 Comment on attachment 417116 Patch Clearing flags on attachment: 417116 Committed r271254: <https://trac.webkit.org/changeset/271254> 1718044 11 fujii 2021-01-07 12:26:45 -0800 All reviewed patches have been landed. Closing bug. 1718045 12 webkit-bug-importer 2021-01-07 12:27:16 -0800 <rdar://problem/72900500> 417114 2021-01-06 12:29:24 -0800 2021-01-06 12:50:18 -0800 WIP patch webgl-non-ac.diff text/plain 600 fujii ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFw aGljc0NvbnRleHRHTE9wZW5HTC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0R0xPcGVuR0wuY3BwCmluZGV4IDJmZWI3NGMyZmFkMS4u ODg2NzAxNTIyODQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0R0xPcGVuR0wuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHRHTE9wZW5HTC5jcHAKQEAg LTIzNiw3ICsyMzYsNyBAQCBSZWZQdHI8SW1hZ2VEYXRhPiBHcmFwaGljc0NvbnRleHRHTE9wZW5H TDo6cGFpbnRSZW5kZXJpbmdSZXN1bHRzVG9JbWFnZURhdGEoKQogI2lmICFQTEFURk9STShDT0NP QSkKIFJlZlB0cjxJbWFnZURhdGE+IEdyYXBoaWNzQ29udGV4dEdMT3BlbkdMOjpyZWFkQ29tcG9z aXRlZFJlc3VsdHMoKQogewotICAgIHJldHVybiBudWxscHRyOworICAgIHJldHVybiByZWFkUmVu ZGVyaW5nUmVzdWx0cygpOwogfQogI2VuZGlmCiAK 417116 2021-01-06 12:50:25 -0800 2021-01-07 12:26:41 -0800 Patch bug-220380-20210107055024.patch text/plain 1617 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxMTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjIxYTE0NTU2YzA4OWVi ZTZjM2ZjMmZlYzU1ODJmNGRjODAyMTliYi4uMzFkYTExYjBmOTA3NjVkZGE4ZGYyMzIyMjgxYzA3 MDI1Y2YwMDU2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAxLTA2ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5DYWly b10gV2ViR0wgaXNuJ3Qgc2hvd24gaW4gbm9uLUFDIG1vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMDM4MAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElmIFdpbkNhaXJvIGRpc2FibGVkIGFjY2VsZXJh dGVkIGNvbXBvc2l0aW5nLCBubyBXZWJHTCB3ZXJlIHNob3duLgorICAgICAgICBHcmFwaGljc0Nv bnRleHRHTE9wZW5HTDo6cmVhZENvbXBvc2l0ZWRSZXN1bHRzIHdhc24ndCBpbXBsZW1lbnRlZAor ICAgICAgICBmb3IgIVBMQVRGT1JNKENPQ09BKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHRHTE9wZW5HTC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpHcmFwaGljc0NvbnRleHRHTE9wZW5HTDo6cmVhZENvbXBvc2l0ZWRSZXN1bHRzKToKKwogMjAy MS0wMS0wNSAgUGVuZyBMaXUgIDxwZW5nLmxpdTZAYXBwbGUuY29tPgogCiAgICAgICAgIFtNZWRp YSBpbiBHUFUgUHJvY2Vzc11bTVNFXSBTb3VyY2VCdWZmZXIgZmlyZXMgdXBkYXRlIGFuZCB1cGRh dGVlbmQgZXZlbnRzIGJlZm9yZSB0aGUgY29kZWQgZnJhbWVzIGFyZSByZW1vdmVkCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250 ZXh0R0xPcGVuR0wuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3Blbmds L0dyYXBoaWNzQ29udGV4dEdMT3BlbkdMLmNwcAppbmRleCAyZmViNzRjMmZhZDFiMmE2MmZmNjBj NjEyNWQxYjhmY2NmNWRiNTZhLi44ODY3MDE1MjI4NDYzMGM3NGJkN2I0MzdlNWFjODcwNjgzNjNi MTFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wv R3JhcGhpY3NDb250ZXh0R0xPcGVuR0wuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHRHTE9wZW5HTC5jcHAKQEAgLTIzNiw3ICsy MzYsNyBAQCBSZWZQdHI8SW1hZ2VEYXRhPiBHcmFwaGljc0NvbnRleHRHTE9wZW5HTDo6cGFpbnRS ZW5kZXJpbmdSZXN1bHRzVG9JbWFnZURhdGEoKQogI2lmICFQTEFURk9STShDT0NPQSkKIFJlZlB0 cjxJbWFnZURhdGE+IEdyYXBoaWNzQ29udGV4dEdMT3BlbkdMOjpyZWFkQ29tcG9zaXRlZFJlc3Vs dHMoKQogewotICAgIHJldHVybiBudWxscHRyOworICAgIHJldHVybiByZWFkUmVuZGVyaW5nUmVz dWx0cygpOwogfQogI2VuZGlmCiAK