22037 QtLauncherRobot 2008-11-02 08:42:30 -0800 QtLauncher robotization for testing purposes 2008-12-09 04:02:32 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED DUPLICATE 20932 Qt P2 Normal --- 0 kbalazs webkit-unassigned hausmann oldest_to_newest 97406 0 kbalazs 2008-11-02 08:42:30 -0800 I made a feature for QtLauncher: to load URL-s from a list file one by one. The original goal was leak hunting, but I think it is usable for other testing purposes or performance measuring as well. I used the QtWebKit API. The loadFinished signal is the key of the automatization. The feature can activated by the -r switch. The second parameter should be the file with one URL at each line. I hope you can find it useful. 97407 1 24844 kbalazs 2008-11-02 08:46:56 -0800 Created attachment 24844 proposed patch 97687 2 24844 hausmann 2008-11-05 08:25:35 -0800 Comment on attachment 24844 proposed patch Is this patch obsolete through bug 20932 ? 97705 3 kbalazs 2008-11-05 10:30:37 -0800 I thought it would be better if I create a separeted bugreport for the robotization feature. Where shall I send the new version that follows your comments in bug 20932? Here or there? 98134 4 kbalazs 2008-11-10 02:17:31 -0800 *** This bug has been marked as a duplicate of 20932 *** 101957 5 24844 hausmann 2008-12-09 02:31:16 -0800 Comment on attachment 24844 proposed patch > Index: WebKit/qt/ChangeLog > =================================================================== > --- WebKit/qt/ChangeLog (revision 37444) > +++ WebKit/qt/ChangeLog (working copy) > @@ -1,3 +1,24 @@ > +2008-10-09 System User <set EMAIL_ADDRESS environment variable> Please add your real name and email address. > --- WebKit/qt/QtLauncher/QtLauncher.pro (revision 37432) > +++ WebKit/qt/QtLauncher/QtLauncher.pro (working copy) > @@ -3,6 +3,9 @@ SOURCES += main.cpp > CONFIG -= app_bundle > CONFIG += uitools > DESTDIR = ../../../bin > +INCPATH += $$PWD/../../../JavaScriptCore/wtf > +LIBS += -L../../../JavaScriptCore/ > +LIBS += -lJavaScriptCore I don't think we should use the WTF types outside of WebCore, so this should not be necessary. > +public slots: > + void loadNext() > + { > + QString qstr; > + if (getUrl(qstr)) { > + QUrl url(qstr, QUrl::StrictMode); > + if (url.isValid()) { > + m_stdOut<<"Loading "<<qstr<<" ......"<<endl; Coding style, please put spaces between the arguments. > +private: > + WTF::Vector<QString> m_urls; I suggest the use of QStringList instead. This way we do not have to have to pull in WTF or the static JavaScriptCore library. The rest of the patch looks good, heads up :) 101960 6 kbalazs 2008-12-09 04:02:32 -0800 I finished the patch in bug 20932. Now it uses QVector for the strings. I'm sorry if I confused yo. I would not create this bugriport. So, I leave this as a duplicate, and let's continue the discuss at bug 20932! 24844 2008-11-02 08:46:56 -0800 2008-12-09 02:31:16 -0800 proposed patch QtLauncherRobot.patch text/plain 5002 kbalazs SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gMzc0NDQpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMjQgQEAKKzIwMDgtMTAtMDkgIFN5c3RlbSBVc2VyICA8c2V0IEVNQUlM X0FERFJFU1MgZW52aXJvbm1lbnQgdmFyaWFibGU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRXh0ZW5kZWQgUXRMYXVuY2hlciBzbyBub3cgaXQgY2Fu IGxvYWQgcGFnZXMgZnJvbSBhbiB1cmwgbGlzdAorICAgICAgICBvbmUgYnkgb25lLiBUaGlzIGNh biBiZSB1c2VmdWwgZm9yIHRlc3RpbmcgcHVycG9zZXMgKGVxLiBsZWFrIGh1bnRpbmcpLgorICAg ICAgICBUaGUgLXIgb3B0aW9uIGFjdGl2YXRlcyB0aGlzIGZlYXR1cmUuCisKKyAgICAgICAgKiBR dExhdW5jaGVyL1F0TGF1bmNoZXIucHJvOgorICAgICAgICBCZWNhdXNlIHVzaW5nIG9mIFdURjo6 VmVjdG9yIGxpYkphdmFTY3JpcHRDb3JlIGhhZCB0byBiZWVuIGFkZGVkIHRvIExJQlMuCisgICAg ICAgICogUXRMYXVuY2hlci9tYWluLmNwcDoKKyAgICAgICAgKE1haW5XaW5kb3c6OndlYlBhZ2Up OgorICAgICAgICBKdXN0IGEgY29kaW5nIHN0eWxlIHJlcGFpcmluZyAoKiB3cml0dGVuIHdpdGgg bm8gc3BhY2UgYmV0d2VlbiB0aGUgcmV0dXJuIHR5cGUgbmFtZSkKKyAgICAgICAgKE1haW5XaW5k b3c6OndlYlZpZXcpOgorICAgICAgICBJIG11c3QgZ2V0IHRoZSB3ZWJWaWV3IHRvIGNvbm5lY3Qg aXQgd2l0aCB0aGUgVVJMTG9hZGVyIG9iamVjdC4KKyAgICAgICAgKFVSTExvYWRlcjo6VVJMTG9h ZGVyKToKKyAgICAgICAgKFVSTExvYWRlcjo6bG9hZE5leHQpOgorICAgICAgICAoVVJMTG9hZGVy Ojppbml0KToKKyAgICAgICAgKFVSTExvYWRlcjo6Z2V0VXJsKToKKyAgICAgICAgKG1haW4pOgor CiAyMDA4LTEwLTA4ICBNYXR0aGlhcyBFdHRyaWNoIDxldHRyaWNoQG5va2lhLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBTaW1vbi4KSW5kZXg6IFdlYktpdC9xdC9RdExhdW5jaGVyL1F0TGF1 bmNoZXIucHJvCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9RdExhdW5jaGVyL1F0TGF1bmNoZXIu cHJvCShyZXZpc2lvbiAzNzQzMikKKysrIFdlYktpdC9xdC9RdExhdW5jaGVyL1F0TGF1bmNoZXIu cHJvCSh3b3JraW5nIGNvcHkpCkBAIC0zLDYgKzMsOSBAQCBTT1VSQ0VTICs9IG1haW4uY3BwCiBD T05GSUcgLT0gYXBwX2J1bmRsZQogQ09ORklHICs9IHVpdG9vbHMKIERFU1RESVIgPSAuLi8uLi8u Li9iaW4KK0lOQ1BBVEggKz0gJCRQV0QvLi4vLi4vLi4vSmF2YVNjcmlwdENvcmUvd3RmCitMSUJT ICs9IC1MLi4vLi4vLi4vSmF2YVNjcmlwdENvcmUvIAorTElCUyArPSAtbEphdmFTY3JpcHRDb3Jl CiAKIGluY2x1ZGUoLi4vLi4vLi4vV2ViS2l0LnByaSkKIApJbmRleDogV2ViS2l0L3F0L1F0TGF1 bmNoZXIvbWFpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L1F0TGF1bmNoZXIvbWFpbi5j cHAJKHJldmlzaW9uIDM3NDMyKQorKysgV2ViS2l0L3F0L1F0TGF1bmNoZXIvbWFpbi5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTQyLDYgKzQyLDExIEBACiAKICNpbmNsdWRlIDxRdFVpVG9vbHMvUVVp TG9hZGVyPgogCisjaW5jbHVkZSA8VmVjdG9yLmg+CisjaW5jbHVkZSA8UVRleHRTdHJlYW0+Cisj aW5jbHVkZSA8UUZpbGU+CisjaW5jbHVkZSA8Y3N0ZGlvPgorCiBjbGFzcyBXZWJQYWdlIDogcHVi bGljIFFXZWJQYWdlCiB7CiBwdWJsaWM6CkBAIC04MywxMCArODgsMTQgQEAgcHVibGljOgogICAg ICAgICB9CiAgICAgfQogCi0gICAgUVdlYlBhZ2UgKndlYlBhZ2UoKSBjb25zdCB7CisgICAgUVdl YlBhZ2UqIHdlYlBhZ2UoKSBjb25zdCB7CiAgICAgICAgIHJldHVybiB2aWV3LT5wYWdlKCk7CiAg ICAgfQogCisgICAgUVdlYlZpZXcqIHdlYlZpZXcoKSBjb25zdCB7CisgICAgICAgIHJldHVybiB2 aWV3OworICAgIH0KKwogcHJvdGVjdGVkIHNsb3RzOgogCiAgICAgdm9pZCBjaGFuZ2VMb2NhdGlv bigpIHsKQEAgLTMyMiw2ICszMzEsNzIgQEAgUU9iamVjdCAqV2ViUGFnZTo6Y3JlYXRlUGx1Z2lu KGNvbnN0IFFTdAogICAgIHJldHVybiBsb2FkZXIuY3JlYXRlV2lkZ2V0KGNsYXNzSWQsIHZpZXco KSk7CiB9CiAKK2NsYXNzIFVSTExvYWRlciA6IHB1YmxpYyBRT2JqZWN0Cit7CisgICAgUV9PQkpF Q1QKK3B1YmxpYzoKKyAgICBVUkxMb2FkZXIoUVdlYlZpZXcqIHZpZXcsIGNvbnN0IFFTdHJpbmcm IGlucHV0RmlsZU5hbWUpCisgICAgICAgIDogbV92aWV3KHZpZXcpLAorICAgICAgICAgbV9zdGRP dXQoc3Rkb3V0KQorICAgIHsKKyAgICAgICAgaW5pdChpbnB1dEZpbGVOYW1lKTsKKyAgICB9CisK K3B1YmxpYyBzbG90czoKKyAgICB2b2lkIGxvYWROZXh0KCkKKyAgICB7CisgICAgICAgIFFTdHJp bmcgcXN0cjsKKyAgICAgICAgaWYgKGdldFVybChxc3RyKSkgeworICAgICAgICAgICAgUVVybCB1 cmwocXN0ciwgUVVybDo6U3RyaWN0TW9kZSk7CisgICAgICAgICAgICBpZiAodXJsLmlzVmFsaWQo KSkgeworICAgICAgICAgICAgICAgIG1fc3RkT3V0PDwiTG9hZGluZyAiPDxxc3RyPDwiIC4uLi4u LiI8PGVuZGw7CisgICAgICAgICAgICAgICAgbV92aWV3LT5sb2FkKHVybCk7CisgICAgICAgICAg ICB9IGVsc2UgeworICAgICAgICAgICAgICAgIGxvYWROZXh0KCk7CisgICAgICAgICAgICB9Cisg ICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICBkaXNjb25uZWN0KG1fdmlldywgMCwgdGhpcywg MCk7CisgICAgICAgIH0KKyAgICB9CisKK3ByaXZhdGU6CisgICAgdm9pZCBpbml0KGNvbnN0IFFT dHJpbmcmIGlucHV0RmlsZU5hbWUpCisgICAgeworICAgICAgICBRRmlsZSBpbnB1dEZpbGUoaW5w dXRGaWxlTmFtZSk7CisgICAgICAgIGlmIChpbnB1dEZpbGUub3BlbihRSU9EZXZpY2U6OlJlYWRP bmx5IHwgUUlPRGV2aWNlOjpUZXh0KSkgeworICAgICAgICAgICAgUVRleHRTdHJlYW0gc3RyZWFt KCZpbnB1dEZpbGUpOworICAgICAgICAgICAgUVN0cmluZyBsaW5lOworICAgICAgICAgICAgaW50 IGkgPSAwOworICAgICAgICAgICAgd2hpbGUgKHRydWUpIHsKKyAgICAgICAgICAgICAgICBsaW5l ID0gc3RyZWFtLnJlYWRMaW5lKCk7CisgICAgICAgICAgICAgICAgaWYgKGxpbmUuaXNOdWxsKCkp CisgICAgICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgICAgIG1fdXJscy5pbnNl cnQoaSsrLCBsaW5lKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAg ICAgIHFEZWJ1ZygpIDw8ICJDYW50J3Qgb3BlbiBsaXN0IGZpbGUiOworICAgICAgICAgICAgZXhp dCgwKTsKKyAgICAgICAgfQorICAgICAgICBtX2luZGV4ID0gMDsKKyAgICAgICAgaW5wdXRGaWxl LmNsb3NlKCk7CisgICAgfQorCisgICAgYm9vbCBnZXRVcmwoUVN0cmluZyYgcXN0cikKKyAgICB7 CisgICAgICAgIGlmIChtX2luZGV4ID09IG1fdXJscy5zaXplKCkpIHsKKyAgICAgICAgICAgIHJl dHVybiBmYWxzZTsKKyAgICAgICAgfQorICAgICAgICBxc3RyID0gbV91cmxzW21faW5kZXgrK107 CisgICAgICAgIHJldHVybiB0cnVlOworICAgIH0KKworcHJpdmF0ZToKKyAgICBXVEY6OlZlY3Rv cjxRU3RyaW5nPiBtX3VybHM7CisgICAgaW50IG1faW5kZXg7CisgICAgUVdlYlZpZXcqIG1fdmll dzsKKyAgICBRVGV4dFN0cmVhbSBtX3N0ZE91dDsKK307CisKICNpbmNsdWRlICJtYWluLm1vYyIK IAogaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKiphcmd2KQpAQCAtMzQyLDEyICs0MTcsMjYgQEAg aW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKiphcmd2KQogICAgIFFXZWJTZXR0aW5nczo6Z2xvYmFs U2V0dGluZ3MoKS0+c2V0QXR0cmlidXRlKFFXZWJTZXR0aW5nczo6RGV2ZWxvcGVyRXh0cmFzRW5h YmxlZCwgdHJ1ZSk7CiAKICAgICBjb25zdCBRU3RyaW5nTGlzdCBhcmdzID0gYXBwLmFyZ3VtZW50 cygpOwotICAgIGlmIChhcmdzLmNvdW50KCkgPiAxKQotICAgICAgICB1cmwgPSBhcmdzLmF0KDEp OwotCi0gICAgTWFpbldpbmRvdyB3aW5kb3codXJsKTsKLSAgICB3aW5kb3cuc2hvdygpOwogCi0g ICAgcmV0dXJuIGFwcC5leGVjKCk7CisgICAgLy9yb2JvdGl6ZWQKKyAgICBpZiAoYXJncy5jb250 YWlucyhRTGF0aW4xU3RyaW5nKCItciIpKSkgeworICAgICAgICBRU3RyaW5nIGxpc3RGaWxlID0g YXJncy5hdCgyKTsKKyAgICAgICAgaWYgKCEoYXJncy5jb3VudCgpPT0zKSAmJiAoUUZpbGU6OmV4 aXN0cyhsaXN0RmlsZSkpKSB7CisgICAgICAgICAgICBxRGVidWcoKSA8PCAiVXNhZ2U6IFF0TGF1 bmNoZXIgLXIgbGlzdGZpbGUiOworICAgICAgICAgICAgZXhpdCgwKTsKKyAgICAgICAgfQorICAg ICAgICBNYWluV2luZG93IHdpbmRvdyh1cmwpOworICAgICAgICBRV2ViVmlldyAqdmlldyA9IHdp bmRvdy53ZWJWaWV3KCk7CisgICAgICAgIFVSTExvYWRlciBsb2FkZXIodmlldywgbGlzdEZpbGUp OworICAgICAgICBRT2JqZWN0Ojpjb25uZWN0KHZpZXcsIFNJR05BTChsb2FkRmluaXNoZWQoYm9v bCkpLCAmbG9hZGVyLCBTTE9UKGxvYWROZXh0KCkpKTsKKyAgICAgICAgd2luZG93LnNob3coKTsK KyAgICAgICAgcmV0dXJuIGFwcC5leGVjKCk7CisgICAgfSBlbHNlIHsKKyAgICAgICAgaWYgKGFy Z3MuY291bnQoKSA+IDEpIHsKKyAgICAgICAgICAgIHVybCA9IGFyZ3MuYXQoMSk7CisgICAgICAg IH0KKyAgICAgICAgTWFpbldpbmRvdyB3aW5kb3codXJsKTsKKyAgICAgICAgd2luZG93LnNob3co KTsKKyAgICAgICAgcmV0dXJuIGFwcC5leGVjKCk7CisgICAgfQogfQotCg==