220363 2021-01-06 07:30:21 -0800 [WPE][GTK] Ensure URI scheme handler is not registered multiple times 2021-01-20 07:59:49 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro berto bugs-noreply cgarcia ews-watchlist gustavo mcatanzaro mcrha oldest_to_newest 1717643 0 mcatanzaro 2021-01-06 07:30:21 -0800 Currently we have a debug ASSERT to ensure a URI scheme handler is not registered more than once, but nothing checks this in release builds. See: https://gitlab.gnome.org/GNOME/evolution/-/issues/1286 1717659 1 mcrha 2021-01-06 09:09:09 -0800 Be careful with the outcome, considering what it can do with older applications, where you update WebKitGTK at (without updating the affected applications), please. 1717669 2 417094 mcatanzaro 2021-01-06 09:26:42 -0800 Created attachment 417094 Patch 1717670 3 ews-watchlist 2021-01-06 09:27:32 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1717679 4 mcatanzaro 2021-01-06 09:33:50 -0800 (In reply to Milan Crha from comment #1) > Be careful with the outcome, considering what it can do with older > applications, where you update WebKitGTK at (without updating the affected > applications), please. Thing is, there's no question what the correct behavior is: emit a critical and return early. Duplicate registrations cannot possibly work as expected and should be ignored. I guess with Evolution, the behavior you were actually getting was for the second registration to take precedence over the previous registration? If so, we're just going to have to update Evolution in tandem with WebKit, or tell distros to patch Evolution downstream. That's OK as long as we don't forget to tell distros to handle this with care. 1718753 5 mcatanzaro 2021-01-11 11:34:09 -0800 Ping reviewers 1720356 6 mcatanzaro 2021-01-18 09:03:23 -0800 (In reply to Michael Catanzaro from comment #5) > Ping reviewers 1720476 7 417094 cgarcia 2021-01-19 00:22:57 -0800 Comment on attachment 417094 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417094&action=review > Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:1242 > + if (context->priv->uriSchemeHandlers.get(scheme)) { > + g_critical("Cannot register URI scheme %s more than once", scheme); > + return; > + } I guess a g_warning should be enough, since this is not fatal in the end. Instead of this early return, we could change the "set" below by an "add" and check if addResult.isNewEntry is false. 1720529 8 mcatanzaro 2021-01-19 08:11:36 -0800 (In reply to Carlos Garcia Campos from comment #7) > > Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:1242 > > + if (context->priv->uriSchemeHandlers.get(scheme)) { > > + g_critical("Cannot register URI scheme %s more than once", scheme); > > + return; > > + } > > I guess a g_warning should be enough, since this is not fatal in the end. g_critical() seems like a better choice because this is undefined behavior (programmer error). > Instead of this early return, we could change the "set" below by an "add" > and check if addResult.isNewEntry is false. Sure. 1720531 9 417878 mcatanzaro 2021-01-19 08:28:24 -0800 Created attachment 417878 Patch 1720825 10 ews-feeder 2021-01-20 00:43:03 -0800 commit-queue failed to commit attachment 417878 to WebKit repository. 1720877 11 mcatanzaro 2021-01-20 07:20:40 -0800 commit-queue error is: ERROR from SVN: Item is out of date: File '/trunk/Source/WebCore/ChangeLog' is out of date W: 4e3e4e0e2a88e15386956b2a49eafbeb5ac8e2cc and refs/remotes/origin/main differ, using rebase: :040000 040000 41d277ce2779148216363a2d1801423625051a8a 881cae33229fc437cba1cdd4a5f7318c45ca5f24 M Source Current branch main is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Not sure what's going on here. Let me rebase and try again.... 1720879 12 mcatanzaro 2021-01-20 07:21:48 -0800 P.S. Let's avoid backporting this commit. 1720880 13 417967 mcatanzaro 2021-01-20 07:22:00 -0800 Created attachment 417967 Patch for landing 1720888 14 ews-feeder 2021-01-20 07:59:47 -0800 Committed r271647: <https://trac.webkit.org/changeset/271647> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417967. 417094 2021-01-06 09:26:42 -0800 2021-01-19 08:28:21 -0800 Patch bug-220363-20210106112712.patch text/plain 1511 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxMTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDMxYTQwZjkxNDQ3N2Y2N2Q3 YTEzNjY3OTEwODc0Mzk0N2I2MTZjNTMuLmM0NjM2MjRjNmViMDhiODA0Y2ZkMWUyN2U3ODJiOTJm M2YwZDg0NjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjEtMDEtMDYgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0Bnbm9tZS5vcmc+CisKKyAgICAgICAgW1dQRV1bR1RLXSBF bnN1cmUgVVJJIHNjaGVtZSBoYW5kbGVyIGlzIG5vdCByZWdpc3RlcmVkIG11bHRpcGxlIHRpbWVz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjAzNjMK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJv Y2Vzcy9BUEkvZ2xpYi9XZWJLaXRXZWJDb250ZXh0LmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJf Y29udGV4dF9yZWdpc3Rlcl91cmlfc2NoZW1lKToKKwogMjAyMS0wMS0wMiAgUm9iIEJ1aXMgIDxy YnVpc0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFJlbW92ZSBzb21lIEZyYW1lTG9hZGVyOjpjaGFu Z2VMb2NhdGlvbiBwYXJhbWV0ZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9BUEkvZ2xpYi9XZWJLaXRXZWJDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0FQSS9nbGliL1dlYktpdFdlYkNvbnRleHQuY3BwCmluZGV4IGFjZjljY2RiNmQxMjlkN2RhZDc4 NmIxMmI0MzBiNDJmOGJmYWQ5ZWUuLjcyMDI3Mzc3NzRiYTJmNDUyNTYyZGM0NGJiMDM4MWYwNGJm ZTY4OGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktp dFdlYkNvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dl YktpdFdlYkNvbnRleHQuY3BwCkBAIC0xMjM2LDYgKzEyMzYsMTEgQEAgdm9pZCB3ZWJraXRfd2Vi X2NvbnRleHRfcmVnaXN0ZXJfdXJpX3NjaGVtZShXZWJLaXRXZWJDb250ZXh0KiBjb250ZXh0LCBj b25zdCBjaGEKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAorICAgIGlmIChjb250ZXh0LT5wcml2 LT51cmlTY2hlbWVIYW5kbGVycy5nZXQoc2NoZW1lKSkgeworICAgICAgICBnX2NyaXRpY2FsKCJD YW5ub3QgcmVnaXN0ZXIgVVJJIHNjaGVtZSAlcyBtb3JlIHRoYW4gb25jZSIsIHNjaGVtZSk7Cisg ICAgICAgIHJldHVybjsKKyAgICB9CisKICAgICBpZiAoV1RGOjpVUkxQYXJzZXI6OmlzU3BlY2lh bFNjaGVtZShjYW5vbmljYWxpemVkU2NoZW1lLnZhbHVlKCkpKSB7CiAgICAgICAgIGdfd2Fybmlu ZygiUmVnaXN0ZXJpbmcgc3BlY2lhbCBVUkkgc2NoZW1lICVzIGlzIG5vIGxvbmdlciBhbGxvd2Vk Iiwgc2NoZW1lKTsKICAgICAgICAgcmV0dXJuOwo= 417878 2021-01-19 08:28:24 -0800 2021-01-20 07:21:56 -0800 Patch bug-220363-20210119102823.patch text/plain 1968 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU0NmM5ZWNhNzk5ZGI3ZTFi MjM1OWQ5ZTBmY2FjNTYyNWY5MGRkNjIuLjM5MTAwNDYyNmM3YmE0OGFhMzA5MThlZDI3OGFiZDBj Zjc2MGI0Y2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjEtMDEtMTkgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0Bnbm9tZS5vcmc+CisKKyAgICAgICAgW1dQRV1bR1RLXSBF bnN1cmUgVVJJIHNjaGVtZSBoYW5kbGVyIGlzIG5vdCByZWdpc3RlcmVkIG11bHRpcGxlIHRpbWVz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjAzNjMK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJv Y2Vzcy9BUEkvZ2xpYi9XZWJLaXRXZWJDb250ZXh0LmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJf Y29udGV4dF9yZWdpc3Rlcl91cmlfc2NoZW1lKToKKwogMjAyMS0wMS0xOCAgTWljaGFlbCBDYXRh bnphcm8gIDxtY2F0YW56YXJvQGdub21lLm9yZz4KIAogICAgICAgICBbR1RLXSBNdWx0aWxpYiBj b25mbGljdHMgaW4gZ2lyIGZpbGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9BUEkvZ2xpYi9XZWJLaXRXZWJDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0FQSS9nbGliL1dlYktpdFdlYkNvbnRleHQuY3BwCmluZGV4IGFjZjljY2RiNmQxMjlkN2RhZDc4 NmIxMmI0MzBiNDJmOGJmYWQ5ZWUuLjJiYmUxYTcyNzI4Y2U3NzZmM2ExNDBmZWZkZGUyYTUzMjA3 ZWZmMjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktp dFdlYkNvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dl YktpdFdlYkNvbnRleHQuY3BwCkBAIC0xMjQyLDkgKzEyNDIsMTIgQEAgdm9pZCB3ZWJraXRfd2Vi X2NvbnRleHRfcmVnaXN0ZXJfdXJpX3NjaGVtZShXZWJLaXRXZWJDb250ZXh0KiBjb250ZXh0LCBj b25zdCBjaGEKICAgICB9CiAKICAgICBhdXRvIGhhbmRsZXIgPSBXZWJLaXRVUklTY2hlbWVIYW5k bGVyOjpjcmVhdGUoY29udGV4dCwgY2FsbGJhY2ssIHVzZXJEYXRhLCBkZXN0cm95Tm90aWZ5KTsK LSAgICBhdXRvIGFkZFJlc3VsdCA9IGNvbnRleHQtPnByaXYtPnVyaVNjaGVtZUhhbmRsZXJzLnNl dChTdHJpbmc6OmZyb21VVEY4KHNjaGVtZSksIFdURk1vdmUoaGFuZGxlcikpOwotICAgIGZvciAo YXV0byogd2ViVmlldyA6IGNvbnRleHQtPnByaXYtPndlYlZpZXdzLnZhbHVlcygpKQotICAgICAg ICB3ZWJraXRXZWJWaWV3R2V0UGFnZSh3ZWJWaWV3KS5zZXRVUkxTY2hlbWVIYW5kbGVyRm9yU2No ZW1lKCphZGRSZXN1bHQuaXRlcmF0b3ItPnZhbHVlLCBTdHJpbmc6OmZyb21VVEY4KHNjaGVtZSkp OworICAgIGF1dG8gYWRkUmVzdWx0ID0gY29udGV4dC0+cHJpdi0+dXJpU2NoZW1lSGFuZGxlcnMu YWRkKFN0cmluZzo6ZnJvbVVURjgoc2NoZW1lKSwgV1RGTW92ZShoYW5kbGVyKSk7CisgICAgaWYg KGFkZFJlc3VsdC5pc05ld0VudHJ5KSB7CisgICAgICAgIGZvciAoYXV0byogd2ViVmlldyA6IGNv bnRleHQtPnByaXYtPndlYlZpZXdzLnZhbHVlcygpKQorICAgICAgICAgICAgd2Via2l0V2ViVmll d0dldFBhZ2Uod2ViVmlldykuc2V0VVJMU2NoZW1lSGFuZGxlckZvclNjaGVtZSgqYWRkUmVzdWx0 Lml0ZXJhdG9yLT52YWx1ZSwgU3RyaW5nOjpmcm9tVVRGOChzY2hlbWUpKTsKKyAgICB9IGVsc2UK KyAgICAgICAgZ19jcml0aWNhbCgiQ2Fubm90IHJlZ2lzdGVyIFVSSSBzY2hlbWUgJXMgbW9yZSB0 aGFuIG9uY2UiLCBzY2hlbWUpOwogfQogCiAvKioK 417967 2021-01-20 07:22:00 -0800 2021-01-20 07:59:48 -0800 Patch for landing bug-220363-20210120092159.patch text/plain 1992 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNjQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDMzNzk2MGU0MWVkMjlmNGY2 NDgyMjMzMTNiOTM2ODlhY2U1ZGI3MGYuLjhmMTU3YjFlZTJkMGFkODg4MTA2YzA2OGVlMWJmODA3 ZDM4YWZmOWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjEtMDEtMjAgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0Bnbm9tZS5vcmc+CisKKyAgICAgICAgW1dQRV1bR1RLXSBF bnN1cmUgVVJJIHNjaGVtZSBoYW5kbGVyIGlzIG5vdCByZWdpc3RlcmVkIG11bHRpcGxlIHRpbWVz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjAzNjMK KworICAgICAgICBSZXZpZXdlZCBieSBDYXJsb3MgR2FyY2lhIENhbXBvcy4KKworICAgICAgICAq IFVJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRXZWJDb250ZXh0LmNwcDoKKyAgICAgICAgKHdlYmtp dF93ZWJfY29udGV4dF9yZWdpc3Rlcl91cmlfc2NoZW1lKToKKwogMjAyMS0wMS0yMCAgWW91ZW5u IEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgT24gcGFnZSBjbG9zZSwgbWFr ZSBzdXJlIHRvIG5vdGlmeSBvZiBjYXB0dXJlIHN0YXRlIGltbWVkaWF0ZWx5CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRXZWJDb250ZXh0LmNwcCBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFdlYkNvbnRleHQuY3BwCmlu ZGV4IGFjZjljY2RiNmQxMjlkN2RhZDc4NmIxMmI0MzBiNDJmOGJmYWQ5ZWUuLjJiYmUxYTcyNzI4 Y2U3NzZmM2ExNDBmZWZkZGUyYTUzMjA3ZWZmMjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFdlYkNvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFdlYkNvbnRleHQuY3BwCkBAIC0xMjQyLDkgKzEy NDIsMTIgQEAgdm9pZCB3ZWJraXRfd2ViX2NvbnRleHRfcmVnaXN0ZXJfdXJpX3NjaGVtZShXZWJL aXRXZWJDb250ZXh0KiBjb250ZXh0LCBjb25zdCBjaGEKICAgICB9CiAKICAgICBhdXRvIGhhbmRs ZXIgPSBXZWJLaXRVUklTY2hlbWVIYW5kbGVyOjpjcmVhdGUoY29udGV4dCwgY2FsbGJhY2ssIHVz ZXJEYXRhLCBkZXN0cm95Tm90aWZ5KTsKLSAgICBhdXRvIGFkZFJlc3VsdCA9IGNvbnRleHQtPnBy aXYtPnVyaVNjaGVtZUhhbmRsZXJzLnNldChTdHJpbmc6OmZyb21VVEY4KHNjaGVtZSksIFdURk1v dmUoaGFuZGxlcikpOwotICAgIGZvciAoYXV0byogd2ViVmlldyA6IGNvbnRleHQtPnByaXYtPndl YlZpZXdzLnZhbHVlcygpKQotICAgICAgICB3ZWJraXRXZWJWaWV3R2V0UGFnZSh3ZWJWaWV3KS5z ZXRVUkxTY2hlbWVIYW5kbGVyRm9yU2NoZW1lKCphZGRSZXN1bHQuaXRlcmF0b3ItPnZhbHVlLCBT dHJpbmc6OmZyb21VVEY4KHNjaGVtZSkpOworICAgIGF1dG8gYWRkUmVzdWx0ID0gY29udGV4dC0+ cHJpdi0+dXJpU2NoZW1lSGFuZGxlcnMuYWRkKFN0cmluZzo6ZnJvbVVURjgoc2NoZW1lKSwgV1RG TW92ZShoYW5kbGVyKSk7CisgICAgaWYgKGFkZFJlc3VsdC5pc05ld0VudHJ5KSB7CisgICAgICAg IGZvciAoYXV0byogd2ViVmlldyA6IGNvbnRleHQtPnByaXYtPndlYlZpZXdzLnZhbHVlcygpKQor ICAgICAgICAgICAgd2Via2l0V2ViVmlld0dldFBhZ2Uod2ViVmlldykuc2V0VVJMU2NoZW1lSGFu ZGxlckZvclNjaGVtZSgqYWRkUmVzdWx0Lml0ZXJhdG9yLT52YWx1ZSwgU3RyaW5nOjpmcm9tVVRG OChzY2hlbWUpKTsKKyAgICB9IGVsc2UKKyAgICAgICAgZ19jcml0aWNhbCgiQ2Fubm90IHJlZ2lz dGVyIFVSSSBzY2hlbWUgJXMgbW9yZSB0aGFuIG9uY2UiLCBzY2hlbWUpOwogfQogCiAvKioK