22035 2008-11-02 03:10:49 -0800 Remove the '_' suffix on constructor parameter names for structs 2008-11-02 03:30:26 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 zwarich zwarich oldest_to_newest 97398 0 zwarich 2008-11-02 03:10:49 -0800 In the past, we had a lot of structs whose constructors took parameters which were of the form "field_". Recently, Darin has been changing a number of these use the same name as the field, which is perfectly allowable by C++ scoping rules. I think it looks better (and doesn't cause confusion with the fairly common style of using '_' as a suffix for member variables). I have a patch to do the rest of the in JavaScriptCore. 97399 1 24841 zwarich 2008-11-02 03:12:37 -0800 Created attachment 24841 Proposed patch 97400 2 24841 oliver 2008-11-02 03:25:29 -0800 Comment on attachment 24841 Proposed patch r=me 97401 3 zwarich 2008-11-02 03:30:26 -0800 Landed in r38066. 24841 2008-11-02 03:12:37 -0800 2008-11-02 03:25:29 -0800 Proposed patch underscore.diff text/plain 4469 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM4MDY1 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMDgtMTEt MDIgIENhbWVyb24gWndhcmljaCAgPHp3YXJpY2hAYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAyMjAzNTogUmVtb3ZlIHRoZSAn Xycgc3VmZml4IG9uIGNvbnN0cnVjdG9yIHBhcmFtZXRlciBuYW1lcyBmb3Igc3RydWN0cworICAg ICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMDM1PgorCisg ICAgICAgICogQVBJL0pTQ2FsbGJhY2tPYmplY3QuaDoKKyAgICAgICAgKEpTQzo6SlNDYWxsYmFj a09iamVjdDo6SlNDYWxsYmFja09iamVjdERhdGE6OkpTQ2FsbGJhY2tPYmplY3REYXRhKToKKyAg ICAgICAgKiBWTS9Db2RlQmxvY2suaDoKKyAgICAgICAgKEpTQzo6Q29kZUJsb2NrOjpDb2RlQmxv Y2spOgorICAgICAgICAoSlNDOjpQcm9ncmFtQ29kZUJsb2NrOjpQcm9ncmFtQ29kZUJsb2NrKToK KyAgICAgICAgKEpTQzo6RXZhbENvZGVCbG9jazo6RXZhbENvZGVCbG9jayk6CisgICAgICAgICog d3JlYy9XUkVDLmg6CisgICAgICAgIChKU0M6OlF1YW50aWZpZXI6OlF1YW50aWZpZXIpOgorCiAy MDA4LTEwLTMxICBDYW1lcm9uIFp3YXJpY2ggIDx6d2FyaWNoQGFwcGxlLmNvbT4KIAogICAgICAg ICBSdWJiZXItc3RhbXBlZCBieSBHZW9mZiBHYXJlbi4KSW5kZXg6IEFQSS9KU0NhbGxiYWNrT2Jq ZWN0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gQVBJL0pTQ2FsbGJhY2tPYmplY3QuaAkocmV2aXNpb24gMzgw NjUpCisrKyBBUEkvSlNDYWxsYmFja09iamVjdC5oCSh3b3JraW5nIGNvcHkpCkBAIC04OCw5ICs4 OCw5IEBAIHByaXZhdGU6CiAgICAgc3RhdGljIEpTVmFsdWUqIGNhbGxiYWNrR2V0dGVyKEV4ZWNT dGF0ZSosIGNvbnN0IElkZW50aWZpZXImLCBjb25zdCBQcm9wZXJ0eVNsb3QmKTsKIAogICAgIHN0 cnVjdCBKU0NhbGxiYWNrT2JqZWN0RGF0YSB7Ci0gICAgICAgIEpTQ2FsbGJhY2tPYmplY3REYXRh KHZvaWQqIHByaXZhdGVEYXRhXywgSlNDbGFzc1JlZiBqc0NsYXNzXykKLSAgICAgICAgICAgIDog cHJpdmF0ZURhdGEocHJpdmF0ZURhdGFfKQotICAgICAgICAgICAgLCBqc0NsYXNzKGpzQ2xhc3Nf KQorICAgICAgICBKU0NhbGxiYWNrT2JqZWN0RGF0YSh2b2lkKiBwcml2YXRlRGF0YSwgSlNDbGFz c1JlZiBqc0NsYXNzKQorICAgICAgICAgICAgOiBwcml2YXRlRGF0YShwcml2YXRlRGF0YSkKKyAg ICAgICAgICAgICwganNDbGFzcyhqc0NsYXNzKQogICAgICAgICB7CiAgICAgICAgICAgICBKU0Ns YXNzUmV0YWluKGpzQ2xhc3MpOwogICAgICAgICB9CkluZGV4OiBWTS9Db2RlQmxvY2suaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBWTS9Db2RlQmxvY2suaAkocmV2aXNpb24gMzgwNjUpCisrKyBWTS9Db2RlQmxv Y2suaAkod29ya2luZyBjb3B5KQpAQCAtMjQ1LDggKzI0NSw4IEBAIG5hbWVzcGFjZSBKU0Mgewog ICAgIH07CiAKICAgICBzdHJ1Y3QgQ29kZUJsb2NrIHsKLSAgICAgICAgQ29kZUJsb2NrKFNjb3Bl Tm9kZSogb3duZXJOb2RlXywgQ29kZVR5cGUgY29kZVR5cGVfLCBQYXNzUmVmUHRyPFNvdXJjZVBy b3ZpZGVyPiBzb3VyY2VfLCB1bnNpZ25lZCBzb3VyY2VPZmZzZXRfKQotICAgICAgICAgICAgOiBv d25lck5vZGUob3duZXJOb2RlXykKKyAgICAgICAgQ29kZUJsb2NrKFNjb3BlTm9kZSogb3duZXJO b2RlLCBDb2RlVHlwZSBjb2RlVHlwZSwgUGFzc1JlZlB0cjxTb3VyY2VQcm92aWRlcj4gc291cmNl LCB1bnNpZ25lZCBzb3VyY2VPZmZzZXQpCisgICAgICAgICAgICA6IG93bmVyTm9kZShvd25lck5v ZGUpCiAgICAgICAgICAgICAsIGdsb2JhbERhdGEoMCkKICNpZiBFTkFCTEUoQ1RJKQogICAgICAg ICAgICAgLCBjdGlDb2RlKDApCkBAIC0yNTUsMTEgKzI1NSwxMSBAQCBuYW1lc3BhY2UgSlNDIHsK ICAgICAgICAgICAgICwgbnVtQ29uc3RhbnRzKDApCiAgICAgICAgICAgICAsIG51bVZhcnMoMCkK ICAgICAgICAgICAgICwgbnVtUGFyYW1ldGVycygwKQotICAgICAgICAgICAgLCBuZWVkc0Z1bGxT Y29wZUNoYWluKG93bmVyTm9kZV8tPm5lZWRzQWN0aXZhdGlvbigpKQotICAgICAgICAgICAgLCB1 c2VzRXZhbChvd25lck5vZGVfLT51c2VzRXZhbCgpKQotICAgICAgICAgICAgLCBjb2RlVHlwZShj b2RlVHlwZV8pCi0gICAgICAgICAgICAsIHNvdXJjZShzb3VyY2VfKQotICAgICAgICAgICAgLCBz b3VyY2VPZmZzZXQoc291cmNlT2Zmc2V0XykKKyAgICAgICAgICAgICwgbmVlZHNGdWxsU2NvcGVD aGFpbihvd25lck5vZGUtPm5lZWRzQWN0aXZhdGlvbigpKQorICAgICAgICAgICAgLCB1c2VzRXZh bChvd25lck5vZGUtPnVzZXNFdmFsKCkpCisgICAgICAgICAgICAsIGNvZGVUeXBlKGNvZGVUeXBl KQorICAgICAgICAgICAgLCBzb3VyY2Uoc291cmNlKQorICAgICAgICAgICAgLCBzb3VyY2VPZmZz ZXQoc291cmNlT2Zmc2V0KQogICAgICAgICB7CiAgICAgICAgICAgICBBU1NFUlQoc291cmNlKTsK ICAgICAgICAgfQpAQCAtMzcxLDkgKzM3MSw5IEBAIG5hbWVzcGFjZSBKU0MgewogICAgIC8vIHJl c3BvbnNpYmxlIGZvciBtYXJraW5nIGl0LgogCiAgICAgc3RydWN0IFByb2dyYW1Db2RlQmxvY2sg OiBwdWJsaWMgQ29kZUJsb2NrIHsKLSAgICAgICAgUHJvZ3JhbUNvZGVCbG9jayhTY29wZU5vZGUq IG93bmVyTm9kZV8sIENvZGVUeXBlIGNvZGVUeXBlXywgSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9i amVjdF8sIFBhc3NSZWZQdHI8U291cmNlUHJvdmlkZXI+IHNvdXJjZV8pCi0gICAgICAgICAgICA6 IENvZGVCbG9jayhvd25lck5vZGVfLCBjb2RlVHlwZV8sIHNvdXJjZV8sIDApCi0gICAgICAgICAg ICAsIGdsb2JhbE9iamVjdChnbG9iYWxPYmplY3RfKQorICAgICAgICBQcm9ncmFtQ29kZUJsb2Nr KFNjb3BlTm9kZSogb3duZXJOb2RlLCBDb2RlVHlwZSBjb2RlVHlwZSwgSlNHbG9iYWxPYmplY3Qq IGdsb2JhbE9iamVjdCwgUGFzc1JlZlB0cjxTb3VyY2VQcm92aWRlcj4gc291cmNlKQorICAgICAg ICAgICAgOiBDb2RlQmxvY2sob3duZXJOb2RlLCBjb2RlVHlwZSwgc291cmNlLCAwKQorICAgICAg ICAgICAgLCBnbG9iYWxPYmplY3QoZ2xvYmFsT2JqZWN0KQogICAgICAgICB7CiAgICAgICAgICAg ICBnbG9iYWxPYmplY3QtPmNvZGVCbG9ja3MoKS5hZGQodGhpcyk7CiAgICAgICAgIH0KQEAgLTM4 OCw4ICszODgsOCBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICB9OwogCiAgICAgc3RydWN0IEV2YWxD b2RlQmxvY2sgOiBwdWJsaWMgUHJvZ3JhbUNvZGVCbG9jayB7Ci0gICAgICAgIEV2YWxDb2RlQmxv Y2soU2NvcGVOb2RlKiBvd25lck5vZGVfLCBKU0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0Xywg UGFzc1JlZlB0cjxTb3VyY2VQcm92aWRlcj4gc291cmNlXykKLSAgICAgICAgICAgIDogUHJvZ3Jh bUNvZGVCbG9jayhvd25lck5vZGVfLCBFdmFsQ29kZSwgZ2xvYmFsT2JqZWN0Xywgc291cmNlXykK KyAgICAgICAgRXZhbENvZGVCbG9jayhTY29wZU5vZGUqIG93bmVyTm9kZSwgSlNHbG9iYWxPYmpl Y3QqIGdsb2JhbE9iamVjdCwgUGFzc1JlZlB0cjxTb3VyY2VQcm92aWRlcj4gc291cmNlKQorICAg ICAgICAgICAgOiBQcm9ncmFtQ29kZUJsb2NrKG93bmVyTm9kZSwgRXZhbENvZGUsIGdsb2JhbE9i amVjdCwgc291cmNlKQogICAgICAgICB7CiAgICAgICAgIH0KICAgICB9OwpJbmRleDogd3JlYy9X UkVDLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gd3JlYy9XUkVDLmgJKHJldmlzaW9uIDM4MDY1KQorKysgd3Jl Yy9XUkVDLmgJKHdvcmtpbmcgY29weSkKQEAgLTYwLDEwICs2MCwxMCBAQCBuYW1lc3BhY2UgSlND IHsKICAgICAgICAgewogICAgICAgICB9CiAKLSAgICAgICAgUXVhbnRpZmllcihUeXBlIHR5cGVf LCB1bnNpZ25lZCBtaW5fID0gMCwgdW5zaWduZWQgbWF4XyA9IG5vTWF4U3BlY2lmaWVkKQotICAg ICAgICAgICAgOiB0eXBlKHR5cGVfKQotICAgICAgICAgICAgLCBtaW4obWluXykKLSAgICAgICAg ICAgICwgbWF4KG1heF8pCisgICAgICAgIFF1YW50aWZpZXIoVHlwZSB0eXBlLCB1bnNpZ25lZCBt aW4gPSAwLCB1bnNpZ25lZCBtYXggPSBub01heFNwZWNpZmllZCkKKyAgICAgICAgICAgIDogdHlw ZSh0eXBlKQorICAgICAgICAgICAgLCBtaW4obWluKQorICAgICAgICAgICAgLCBtYXgobWF4KQog ICAgICAgICB7CiAgICAgICAgIH0KIAo=