220336 2021-01-05 13:49:28 -0800 PCM: Experimental debug mode stops working after initial use 2021-01-05 17:09:19 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wilander wilander bfulgham webkit-bug-importer oldest_to_newest 1717458 0 wilander 2021-01-05 13:49:28 -0800 We need to make sure the PCM debug mode flag sticks. 1717459 1 wilander 2021-01-05 13:49:40 -0800 <rdar://problem/72398086> 1717462 2 417035 wilander 2021-01-05 13:53:58 -0800 Created attachment 417035 Patch 1717481 3 417035 bfulgham 2021-01-05 14:30:13 -0800 Comment on attachment 417035 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417035&action=review r=me > Source/WebKit/NetworkProcess/NetworkProcess.cpp:1327 > +void NetworkProcess::setPrivateClickMeasurementDebugMode(bool enabled) Is this always called on NetworkProcess initialization? And I assume toggling the setting switch in UIProcess sends a message that hits this? 1717506 4 417035 wilander 2021-01-05 15:07:21 -0800 Comment on attachment 417035 Patch Thanks, Brent! 1717507 5 wilander 2021-01-05 15:08:25 -0800 (In reply to Brent Fulgham from comment #3) > Comment on attachment 417035 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=417035&action=review > > r=me > > > Source/WebKit/NetworkProcess/NetworkProcess.cpp:1327 > > +void NetworkProcess::setPrivateClickMeasurementDebugMode(bool enabled) > > Is this always called on NetworkProcess initialization? And I assume > toggling the setting switch in UIProcess sends a message that hits this? I don't know actually. I think this may be a feature switch that requires a browser restart. 1717551 6 ews-feeder 2021-01-05 17:09:18 -0800 Committed r271184: <https://trac.webkit.org/changeset/271184> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417035. 417035 2021-01-05 13:53:58 -0800 2021-01-05 17:09:18 -0800 Patch bug-220336-20210105135358.patch text/plain 5410 wilander U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxMTQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZjN2I2YWU0OGFkODQzM2Q1 YjBmYmNkNmY4OGM3MjRkZmY2NTRjNGUuLjNhMDEyMjRlZTRkOGE5MjVlOTBkMjI3ZGZhNzBlZTJj ZGI2ZGU1MmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMjEtMDEtMDUgIEpvaG4gV2ls YW5kZXIgIDx3aWxhbmRlckBhcHBsZS5jb20+CisKKyAgICAgICAgUENNOiBFeHBlcmltZW50YWwg ZGVidWcgbW9kZSBzdG9wcyB3b3JraW5nIGFmdGVyIGluaXRpYWwgdXNlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjAzMzYKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzcyMzk4MDg2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoZSBleGlzdGluZyBleHBlcmltZW50YWwgUENNIGRlYnVnIG1vZGUgdXNl cworICAgICAgICBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpzaGFyZWRGZWF0dXJlcygpLnByaXZh dGVDbGlja01lYXN1cmVtZW50RGVidWdNb2RlRW5hYmxlZCgpCisgICAgICAgIHdoaWNoIGlzIG5v dCBjb3JyZWN0IGluIHRoZSBuZXR3b3JrIHByb2Nlc3MuIFRoaXMgbWFrZXMgdGhlIGZsYWcgdG8g bG9zZSBpdHMKKyAgICAgICAgc3RhdGUgYWZ0ZXIgbmF2aWdhdGlvbnMgaW4gbmV3IHRhYnMuCisK KyAgICAgICAgVGhpcyBwYXRjaCBtb3ZlcyB0aGUgZmxhZyB0byBiZSBhbG9uZ3NpZGUgdGhlIFBD TSBmZWF0dXJlIGZsYWcgaW4KKyAgICAgICAgV2ViS2l0OjpOZXR3b3JrUHJvY2Vzcy4KKworICAg ICAgICAqIE5ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktp dDo6TmV0d29ya1Byb2Nlc3M6OnNldFByaXZhdGVDbGlja01lYXN1cmVtZW50RGVidWdNb2RlKToK KyAgICAgICAgKFdlYktpdDo6TmV0d29ya1Byb2Nlc3M6OnByaXZhdGVDbGlja01lYXN1cmVtZW50 RGVidWdNb2RlRW5hYmxlZCBjb25zdCk6CisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvTmV0d29y a1Byb2Nlc3MuaDoKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9Qcml2YXRlQ2xpY2tNZWFzdXJl bWVudE1hbmFnZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpQcml2YXRlQ2xpY2tNZWFzdXJlbWVu dE1hbmFnZXI6OmRlYnVnTW9kZUVuYWJsZWQgY29uc3QpOgorCiAyMDIxLTAxLTA0ICBKZWZmIE1p bGxlciAgPGplZmZtQGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGUgdXNlci12aXNpYmxlIGNv cHlyaWdodCBzdHJpbmdzIHRvIGluY2x1ZGUgMjAyMQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdv cmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmNwcAppbmRleCBkOGQwODQzOWNjOWUwNzRjOTQxYTFk YWRmYjBkZDljMWJjMjhlYTJiLi5lMDEyNWE2NzVlMmM0NzJlN2VlMGI3OGM3NmE1YjU3NTkyOGE0 NzA1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9j ZXNzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNz LmNwcApAQCAtMTMyNCwxNCArMTMyNCwxNCBAQCBib29sIE5ldHdvcmtQcm9jZXNzOjpwcml2YXRl Q2xpY2tNZWFzdXJlbWVudEVuYWJsZWQoKSBjb25zdAogICAgIHJldHVybiBtX3ByaXZhdGVDbGlj a01lYXN1cmVtZW50RW5hYmxlZDsKIH0KIAotdm9pZCBOZXR3b3JrUHJvY2Vzczo6c2V0UHJpdmF0 ZUNsaWNrTWVhc3VyZW1lbnREZWJ1Z01vZGUoYm9vbCBkZWJ1Z01vZGUpCit2b2lkIE5ldHdvcmtQ cm9jZXNzOjpzZXRQcml2YXRlQ2xpY2tNZWFzdXJlbWVudERlYnVnTW9kZShib29sIGVuYWJsZWQp CiB7Ci0gICAgaWYgKFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OnNoYXJlZEZlYXR1cmVzKCkucHJp dmF0ZUNsaWNrTWVhc3VyZW1lbnREZWJ1Z01vZGVFbmFibGVkKCkgPT0gZGVidWdNb2RlKQorICAg IGlmIChtX3ByaXZhdGVDbGlja01lYXN1cmVtZW50RGVidWdNb2RlRW5hYmxlZCA9PSBlbmFibGVk KQogICAgICAgICByZXR1cm47CiAKLSAgICBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpzaGFyZWRG ZWF0dXJlcygpLnNldFByaXZhdGVDbGlja01lYXN1cmVtZW50RGVidWdNb2RlRW5hYmxlZChkZWJ1 Z01vZGUpOworICAgIG1fcHJpdmF0ZUNsaWNrTWVhc3VyZW1lbnREZWJ1Z01vZGVFbmFibGVkID0g ZW5hYmxlZDsKIAotICAgIFN0cmluZyBtZXNzYWdlID0gZGVidWdNb2RlID8gIltQcml2YXRlIENs aWNrIE1lYXN1cmVtZW50XSBUdXJuZWQgRGVidWcgTW9kZSBvbi4iX3MgOiAiW1ByaXZhdGUgQ2xp Y2sgTWVhc3VyZW1lbnRdIFR1cm5lZCBEZWJ1ZyBNb2RlIG9mZi4iX3M7CisgICAgU3RyaW5nIG1l c3NhZ2UgPSBlbmFibGVkID8gIltQcml2YXRlIENsaWNrIE1lYXN1cmVtZW50XSBUdXJuZWQgRGVi dWcgTW9kZSBvbi4iX3MgOiAiW1ByaXZhdGUgQ2xpY2sgTWVhc3VyZW1lbnRdIFR1cm5lZCBEZWJ1 ZyBNb2RlIG9mZi4iX3M7CiAgICAgZm9yIChhdXRvJiBuZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJv Y2VzcyA6IG1fd2ViUHJvY2Vzc0Nvbm5lY3Rpb25zLnZhbHVlcygpKSB7CiAgICAgICAgIGlmIChu ZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzcy0+c2Vzc2lvbklEKCkuaXNFcGhlbWVyYWwoKSkK ICAgICAgICAgICAgIGNvbnRpbnVlOwpAQCAtMTMzOSw2ICsxMzM5LDExIEBAIHZvaWQgTmV0d29y a1Byb2Nlc3M6OnNldFByaXZhdGVDbGlja01lYXN1cmVtZW50RGVidWdNb2RlKGJvb2wgZGVidWdN b2RlKQogICAgIH0KIH0KIAorYm9vbCBOZXR3b3JrUHJvY2Vzczo6cHJpdmF0ZUNsaWNrTWVhc3Vy ZW1lbnREZWJ1Z01vZGVFbmFibGVkKCkgY29uc3QKK3sKKyAgICByZXR1cm4gbV9wcml2YXRlQ2xp Y2tNZWFzdXJlbWVudERlYnVnTW9kZUVuYWJsZWQ7Cit9CisKIHZvaWQgTmV0d29ya1Byb2Nlc3M6 OnByZWNvbm5lY3RUbyhQQUw6OlNlc3Npb25JRCBzZXNzaW9uSUQsIFdlYlBhZ2VQcm94eUlkZW50 aWZpZXIgd2ViUGFnZVByb3h5SUQsIFdlYkNvcmU6OlBhZ2VJZGVudGlmaWVyIHdlYlBhZ2VJRCwg Y29uc3QgVVJMJiB1cmwsIGNvbnN0IFN0cmluZyYgdXNlckFnZW50LCBXZWJDb3JlOjpTdG9yZWRD cmVkZW50aWFsc1BvbGljeSBzdG9yZWRDcmVkZW50aWFsc1BvbGljeSwgT3B0aW9uYWw8TmF2aWdh dGluZ1RvQXBwQm91bmREb21haW4+IGlzTmF2aWdhdGluZ1RvQXBwQm91bmREb21haW4pCiB7CiAg ICAgTE9HKE5ldHdvcmssICIoTmV0d29ya1Byb2Nlc3MpIFByZWNvbm5lY3RpbmcgdG8gVVJMICVz IChzdG9yZWRDcmVkZW50aWFsc1BvbGljeSAlaSkiLCB1cmwuc3RyaW5nKCkudXRmOCgpLmRhdGEo KSwgKGludClzdG9yZWRDcmVkZW50aWFsc1BvbGljeSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmggYi9Tb3VyY2UvV2ViS2l0L05ldHdv cmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmgKaW5kZXggODZlZDczYzFlMjMyZmJlY2FlMjMxYTYw OTUxY2NhODZiNWU2NTJlNi4uNDEyMzFiZmQ4NTk3ZTVhMWZiOWE3ZTEwMDkxMWU3NWI5MTFlYjZm NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vz cy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Byb2Nlc3MuaApA QCAtMjc5LDYgKzI3OSw3IEBAIHB1YmxpYzoKICAgICB2b2lkIHNldFByaXZhdGVDbGlja01lYXN1 cmVtZW50RW5hYmxlZChib29sKTsKICAgICBib29sIHByaXZhdGVDbGlja01lYXN1cmVtZW50RW5h YmxlZCgpIGNvbnN0OwogICAgIHZvaWQgc2V0UHJpdmF0ZUNsaWNrTWVhc3VyZW1lbnREZWJ1Z01v ZGUoYm9vbCk7CisgICAgYm9vbCBwcml2YXRlQ2xpY2tNZWFzdXJlbWVudERlYnVnTW9kZUVuYWJs ZWQoKSBjb25zdDsKIAogICAgIHVzaW5nIENhY2hlU3RvcmFnZVJvb3RQYXRoQ2FsbGJhY2sgPSBD b21wbGV0aW9uSGFuZGxlcjx2b2lkKFN0cmluZyYmKT47CiAgICAgdm9pZCBjYWNoZVN0b3JhZ2VS b290UGF0aChQQUw6OlNlc3Npb25JRCwgQ2FjaGVTdG9yYWdlUm9vdFBhdGhDYWxsYmFjayYmKTsK QEAgLTU5NCw2ICs1OTUsNyBAQCBwcml2YXRlOgogICAgIEhhc2hNYXA8V2ViQ29yZTo6UGFnZUlk ZW50aWZpZXIsIFZlY3RvcjxXZWJDb3JlOjpVc2VyQ29udGVudFVSTFBhdHRlcm4+PiBtX2V4dGVu c2lvbkNPUlNEaXNhYmxpbmdQYXR0ZXJuczsKIAogICAgIGJvb2wgbV9wcml2YXRlQ2xpY2tNZWFz dXJlbWVudEVuYWJsZWQgeyB0cnVlIH07CisgICAgYm9vbCBtX3ByaXZhdGVDbGlja01lYXN1cmVt ZW50RGVidWdNb2RlRW5hYmxlZCB7IGZhbHNlIH07CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJL aXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvUHJpdmF0ZUNsaWNr TWVhc3VyZW1lbnRNYW5hZ2VyLmNwcCBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvUHJp dmF0ZUNsaWNrTWVhc3VyZW1lbnRNYW5hZ2VyLmNwcAppbmRleCBmYmQ1NGI4NGIwYTc5NTEyYmJm NWRiMzc4ZmVhZDFmZjg3NTBlMmJmLi4wM2ZkODYyMDRkOTQyNDMzNGQ2MjY5ZmE1YTEwMmE4NTE1 MWQzNWY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL1ByaXZhdGVD bGlja01lYXN1cmVtZW50TWFuYWdlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJv Y2Vzcy9Qcml2YXRlQ2xpY2tNZWFzdXJlbWVudE1hbmFnZXIuY3BwCkBAIC0zMzQsNyArMzM0LDcg QEAgYm9vbCBQcml2YXRlQ2xpY2tNZWFzdXJlbWVudE1hbmFnZXI6OmZlYXR1cmVFbmFibGVkKCkg Y29uc3QKIAogYm9vbCBQcml2YXRlQ2xpY2tNZWFzdXJlbWVudE1hbmFnZXI6OmRlYnVnTW9kZUVu YWJsZWQoKSBjb25zdAogewotICAgIHJldHVybiBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpzaGFy ZWRGZWF0dXJlcygpLnByaXZhdGVDbGlja01lYXN1cmVtZW50RGVidWdNb2RlRW5hYmxlZCgpICYm ICFtX3Nlc3Npb25JRC5pc0VwaGVtZXJhbCgpOworICAgIHJldHVybiBtX25ldHdvcmtQcm9jZXNz LT5wcml2YXRlQ2xpY2tNZWFzdXJlbWVudERlYnVnTW9kZUVuYWJsZWQoKSAmJiAhbV9zZXNzaW9u SUQuaXNFcGhlbWVyYWwoKTsKIH0KIAogdm9pZCBQcml2YXRlQ2xpY2tNZWFzdXJlbWVudE1hbmFn ZXI6Om1hcmtBdHRyaWJ1dGVkUHJpdmF0ZUNsaWNrTWVhc3VyZW1lbnRzQXNFeHBpcmVkRm9yVGVz dGluZyhDb21wbGV0aW9uSGFuZGxlcjx2b2lkKCk+JiYgY29tcGxldGlvbkhhbmRsZXIpCg==