<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>220335</bug_id>
          
          <creation_ts>2021-01-05 13:14:57 -0800</creation_ts>
          <short_desc>[WPE][GTK] File descriptor leak</short_desc>
          <delta_ts>2021-02-23 13:13:55 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>MOVED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=220090</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Catanzaro">mcatanzaro</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>tpopela</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1717448</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-01-05 13:14:57 -0800</bug_when>
    <thetext>Open MiniBrowser (or Epiphany), launch five browser tabs, and use gnome-system-monitor to inspect the open files of the first and last WebKitWebProcess. Do not use flatpak, because when running Epiphany under flatpak, everything seems fine for some reason I don&apos;t understand. But when running outside flatpak, I see the number of local sockets usually -- but not always -- increases by 2 for each web process launched. We are leaking some file descriptors... somewhere.

Sadly, this is going to be hard to debug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1720359</commentid>
    <comment_count>1</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-01-18 09:07:28 -0800</bug_when>
    <thetext>From bug #220090, we can probably avoid this by removing G_SUBPROCESS_FLAGS_INHERIT_FDS, but to do that we need a way to exempt the WPE render host socket by passing it to ProcessLauncher and from there to g_subprocess_launcher_take_fd(). r241816 -- which seemed like a nice cleanup at the time -- made this harder.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1732668</commentid>
    <comment_count>2</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-02-23 13:13:55 -0800</bug_when>
    <thetext>I tracked this down to wpebackend-fdo, https://github.com/Igalia/WPEBackend-fdo/pull/136.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>