220324 2021-01-05 05:16:06 -0800 [GStreamer] Use Ref<> in AudioTrackPrivateGStreamer::create() 2021-01-05 11:18:19 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboya aboya bugs-noreply calvaris cgarcia eric.carlson ews-watchlist glenn gustavo jer.noble menard philipj pnormand sergio vjaquez oldest_to_newest 1717287 0 aboya 2021-01-05 05:16:06 -0800 create() should return Ref<> when the return value can't be null. 1717289 1 416995 aboya 2021-01-05 05:24:15 -0800 Created attachment 416995 Patch 1717402 2 ews-feeder 2021-01-05 11:18:15 -0800 Committed r271163: <https://trac.webkit.org/changeset/271163> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416995. 416995 2021-01-05 05:24:15 -0800 2021-01-05 11:18:17 -0800 Patch bug-220324-20210105142421.patch text/plain 3146 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxMTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2FhYTgwN2NmOGNmNjU2 NGFiMTg5MDhjNDZhNGMyZDI0NGVkZDE5MS4uYWIyMDA3Y2Q5M2U0YzJhYWYxMmRlMjIyZjA4YWIw ZmU4NzFjNTBiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTAxLTA1ICBBbGlj aWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBVc2UgUmVmPD4gaW4gQXVkaW9UcmFja1ByaXZhdGVHU3RyZWFtZXI6OmNyZWF0ZSgpCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjAzMjQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBjcmVhdGUoKSBzaG91 bGQgcmV0dXJuIFJlZjw+IHdoZW4gdGhlIHJldHVybiB2YWx1ZSBjYW4ndCBiZSBudWxsLgorCisg ICAgICAgIFRoaXMgaXMgYSBjbGVhbnVwIHdpdGggbm8gZnVuY3Rpb25hbCBjaGFuZ2VzLgorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0F1ZGlvVHJhY2tQcml2YXRlR1N0 cmVhbWVyLmg6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxh eWVyUHJpdmF0ZUdTdHJlYW1lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclBy aXZhdGVHU3RyZWFtZXI6Om5vdGlmeVBsYXllck9mQXVkaW8pOgorCiAyMDIwLTEyLTE0ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtjc3MtbXVs dGljb2xdIERvIG5vdCBhdHRhY2ggPGxlZ2VuZD4gdG8gPGZpZWxkc2V0PiBtdWx0aWNvbHVtbiBj b250YWluZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n c3RyZWFtZXIvQXVkaW9UcmFja1ByaXZhdGVHU3RyZWFtZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9BdWRpb1RyYWNrUHJpdmF0ZUdTdHJlYW1lci5oCmlu ZGV4IDEzNjgxODdiNGNlNDYwMjk4ZTEwNzM5MDZmYWYxYTM5ODhjNDg1MWQuLmZlOTc5ZjQzODA3 ZDk2ZTUyZDhjZDIzNmEzZTc2MjdjMWU2ZWFjODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9BdWRpb1RyYWNrUHJpdmF0ZUdTdHJlYW1lci5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9BdWRpb1Ry YWNrUHJpdmF0ZUdTdHJlYW1lci5oCkBAIC0zOCwxMiArMzgsMTIgQEAgY2xhc3MgTWVkaWFQbGF5 ZXJQcml2YXRlR1N0cmVhbWVyOwogCiBjbGFzcyBBdWRpb1RyYWNrUHJpdmF0ZUdTdHJlYW1lciBm aW5hbCA6IHB1YmxpYyBBdWRpb1RyYWNrUHJpdmF0ZSwgcHVibGljIFRyYWNrUHJpdmF0ZUJhc2VH U3RyZWFtZXIgewogcHVibGljOgotICAgIHN0YXRpYyBSZWZQdHI8QXVkaW9UcmFja1ByaXZhdGVH U3RyZWFtZXI+IGNyZWF0ZShXZWFrUHRyPE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcj4gcGxh eWVyLCBnaW50IGluZGV4LCBHUmVmUHRyPEdzdFBhZD4gcGFkKQorICAgIHN0YXRpYyBSZWY8QXVk aW9UcmFja1ByaXZhdGVHU3RyZWFtZXI+IGNyZWF0ZShXZWFrUHRyPE1lZGlhUGxheWVyUHJpdmF0 ZUdTdHJlYW1lcj4gcGxheWVyLCBnaW50IGluZGV4LCBHUmVmUHRyPEdzdFBhZD4gcGFkKQogICAg IHsKICAgICAgICAgcmV0dXJuIGFkb3B0UmVmKCpuZXcgQXVkaW9UcmFja1ByaXZhdGVHU3RyZWFt ZXIocGxheWVyLCBpbmRleCwgcGFkKSk7CiAgICAgfQogCi0gICAgc3RhdGljIFJlZlB0cjxBdWRp b1RyYWNrUHJpdmF0ZUdTdHJlYW1lcj4gY3JlYXRlKFdlYWtQdHI8TWVkaWFQbGF5ZXJQcml2YXRl R1N0cmVhbWVyPiBwbGF5ZXIsIGdpbnQgaW5kZXgsIEdSZWZQdHI8R3N0U3RyZWFtPiBzdHJlYW0p CisgICAgc3RhdGljIFJlZjxBdWRpb1RyYWNrUHJpdmF0ZUdTdHJlYW1lcj4gY3JlYXRlKFdlYWtQ dHI8TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyPiBwbGF5ZXIsIGdpbnQgaW5kZXgsIEdSZWZQ dHI8R3N0U3RyZWFtPiBzdHJlYW0pCiAgICAgewogICAgICAgICByZXR1cm4gYWRvcHRSZWYoKm5l dyBBdWRpb1RyYWNrUHJpdmF0ZUdTdHJlYW1lcihwbGF5ZXIsIGluZGV4LCBzdHJlYW0pKTsKICAg ICB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFt ZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCmlu ZGV4IDkzN2Q5NTU0MDdmNTU4NTI4NTM5ZjNhYTE1ZTMzMTcxMGQ2NjE3N2UuLjBmNmM2NmQyMDc1 ZDU3YzVjNzc0MzZjMWRkMDk0ZDQ0MWU3ZWU1ODcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCkBAIC0xMTcyLDggKzExNzIsOCBAQCB2b2lkIE1l ZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6bm90aWZ5UGxheWVyT2ZBdWRpbygpCiAgICAgICAg IGlmICghdHJhY2stPnRyYWNrSW5kZXgoKSkKICAgICAgICAgICAgIHRyYWNrLT5zZXRBY3RpdmUo dHJ1ZSk7CiAgICAgICAgIEFTU0VSVChzdHJlYW1JZCA9PSB0cmFjay0+aWQoKSk7Ci0gICAgICAg IG1fYXVkaW9UcmFja3MuYWRkKHN0cmVhbUlkLCB0cmFjayk7Ci0gICAgICAgIG1fcGxheWVyLT5h ZGRBdWRpb1RyYWNrKCp0cmFjayk7CisgICAgICAgIG1fYXVkaW9UcmFja3MuYWRkKHN0cmVhbUlk LCB0cmFjay5jb3B5UmVmKCkpOworICAgICAgICBtX3BsYXllci0+YWRkQXVkaW9UcmFjayh0cmFj ay5nZXQoKSk7CiAgICAgfQogCiAgICAgcHVyZ2VJbnZhbGlkQXVkaW9UcmFja3ModmFsaWRBdWRp b1N0cmVhbXMpOwo=