220210 2020-12-31 08:57:09 -0800 [LFC Display] Give display boxes a parent pointer 2021-01-04 10:16:36 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser bfulgham simon.fraser webkit-bug-importer zalan oldest_to_newest 1716917 0 simon.fraser 2020-12-31 08:57:09 -0800 [LFC Display] Give display boxes a parent pointer 1716918 1 416866 simon.fraser 2020-12-31 08:57:54 -0800 Created attachment 416866 Patch 1717028 2 416866 zalan 2021-01-02 20:09:38 -0800 Comment on attachment 416866 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416866&action=review > Source/WebCore/display/css/DisplayBox.h:73 > + ContainerBox* parent() const { return m_parent; } I usually do a const and a non-const version of getters like this (unless you really only need a const ContainerBox* parent()) 1717154 3 simon.fraser 2021-01-04 10:15:21 -0800 https://trac.webkit.org/r271134 1717157 4 webkit-bug-importer 2021-01-04 10:16:36 -0800 <rdar://problem/72794178> 416866 2020-12-31 08:57:54 -0800 2021-01-02 20:09:38 -0800 Patch bug-220210-20201231085753.patch text/plain 2648 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxMTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWM1ZDc3Zjk1ODVkMjA1 MzE4ODRjMjdkYWQxMzg2YTRmYTZiNTRmYi4uNmE0MjJiNzE4MWM3YjBlYzI5YzRkNDExNmIzNDk5 NTY3OTY3Nzk3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTEyLTMxICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFtMRkMgRGlzcGxh eV0gR2l2ZSBkaXNwbGF5IGJveGVzIGEgcGFyZW50IHBvaW50ZXIKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMDIxMAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZ1dHVyZSBjb2RlIHdpbGwgbmVlZCB0byBi ZSBhYmxlIHRvIGRvIGFuY2VzdG9yIHRyZWUgd2Fsa3MgKCJmaW5kIGVuY2xvc2luZyIpLAorICAg ICAgICBzbyBnaXZlIERpc3BsYXk6OkJveCBhIHBvaW50ZXIgdG8gaXRzIHBhcmVudCBDb250YWlu ZXJCb3guCisKKyAgICAgICAgKiBkaXNwbGF5L0Rpc3BsYXlUcmVlQnVpbGRlci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpEaXNwbGF5OjpUcmVlQnVpbGRlcjo6aW5zZXJ0IGNvbnN0KToKKyAgICAg ICAgKiBkaXNwbGF5L2Nzcy9EaXNwbGF5Qm94Lmg6CisgICAgICAgIChXZWJDb3JlOjpEaXNwbGF5 OjpCb3g6OnBhcmVudCBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpEaXNwbGF5OjpCb3g6OnNl dFBhcmVudCk6CisKIDIwMjAtMTItMzEgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBs ZS5jb20+CiAKICAgICAgICAgW0xGQyBEaXNwbGF5XSBPbmx5IHJlYnVpbGQgdGhlIGRpc3BsYXkg dHJlZSBpZiBsYXlvdXQgY2hhbmdlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZGlzcGxh eS9EaXNwbGF5VHJlZUJ1aWxkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvZGlzcGxheS9EaXNwbGF5 VHJlZUJ1aWxkZXIuY3BwCmluZGV4IGRiOTdhZjAyMjhhZjVlY2UwYjdiMzUxYjkwNzY3YmQwZmYy ZmJlNzkuLjc0ZDQ3MDZiZWIwMjdlN2E1ZDU4YmFjNGUxNWI2MDA5MTM3YzFlNzEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2Rpc3BsYXkvRGlzcGxheVRyZWVCdWlsZGVyLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9kaXNwbGF5L0Rpc3BsYXlUcmVlQnVpbGRlci5jcHAKQEAgLTI2NCw2ICsy NjQsNyBAQCBjb25zdCBQb3NpdGlvbmluZ0NvbnRleHQmIFRyZWVCdWlsZGVyOjpwb3NpdGlvbmlu Z0NvbnRleHQoKQogCiB2b2lkIFRyZWVCdWlsZGVyOjppbnNlcnQoc3RkOjp1bmlxdWVfcHRyPEJv eD4mJiBib3gsIEluc2VydGlvblBvc2l0aW9uJiBpbnNlcnRpb25Qb3NpdGlvbikgY29uc3QKIHsK KyAgICBib3gtPnNldFBhcmVudCgmaW5zZXJ0aW9uUG9zaXRpb24uY29udGFpbmVyKTsKICAgICBp ZiAoaW5zZXJ0aW9uUG9zaXRpb24uY3VycmVudENoaWxkKSB7CiAgICAgICAgIGF1dG8gYm94UHRy ID0gYm94LmdldCgpOwogICAgICAgICBpbnNlcnRpb25Qb3NpdGlvbi5jdXJyZW50Q2hpbGQtPnNl dE5leHRTaWJsaW5nKFdURk1vdmUoYm94KSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9k aXNwbGF5L2Nzcy9EaXNwbGF5Qm94LmggYi9Tb3VyY2UvV2ViQ29yZS9kaXNwbGF5L2Nzcy9EaXNw bGF5Qm94LmgKaW5kZXggZGY2MjdmZmZiMmM3Zjk3MmM2NGNkYzc1YzM4MWY3ZTdjN2U2ZWE3OC4u YWViMDIyMTRiYjU2MGY5Y2RhMjc0MzI5ZmNlYjYzZGQyZGIzODkxYyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvZGlzcGxheS9jc3MvRGlzcGxheUJveC5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2Rpc3BsYXkvY3NzL0Rpc3BsYXlCb3guaApAQCAtMzUsNiArMzUsNyBAQAogbmFtZXNwYWNlIFdl YkNvcmUgewogbmFtZXNwYWNlIERpc3BsYXkgewogCitjbGFzcyBDb250YWluZXJCb3g7CiBjbGFz cyBUcmVlOwogCiAvLyBGSVhNRTogTWFrZSB0aGlzIGEgc3Ryb25nIHR5cGUuCkBAIC02OSw2ICs3 MCw5IEBAIHB1YmxpYzoKIAogICAgIGJvb2wgcGFydGljaXBhdGVzSW5aT3JkZXJTb3J0aW5nKCkg Y29uc3Q7CiAKKyAgICBDb250YWluZXJCb3gqIHBhcmVudCgpIGNvbnN0IHsgcmV0dXJuIG1fcGFy ZW50OyB9CisgICAgdm9pZCBzZXRQYXJlbnQoQ29udGFpbmVyQm94KiBwYXJlbnQpIHsgbV9wYXJl bnQgPSBwYXJlbnQ7IH0KKwogICAgIGNvbnN0IEJveCogbmV4dFNpYmxpbmcoKSBjb25zdCB7IHJl dHVybiBtX25leHRTaWJsaW5nLmdldCgpOyB9CiAgICAgdm9pZCBzZXROZXh0U2libGluZyhzdGQ6 OnVuaXF1ZV9wdHI8Qm94PiYmKTsKIApAQCAtODAsNiArODQsNyBAQCBwcml2YXRlOgogICAgIGNv bnN0IFRyZWUmIG1fdHJlZTsKICAgICBBYnNvbHV0ZUZsb2F0UmVjdCBtX2Fic29sdXRlQm94UmVj dDsKICAgICBTdHlsZSBtX3N0eWxlOworICAgIENvbnRhaW5lckJveCogbV9wYXJlbnQgeyBudWxs cHRyIH07CiAgICAgc3RkOjp1bmlxdWVfcHRyPEJveD4gbV9uZXh0U2libGluZzsKICAgICBPcHRp b25TZXQ8RmxhZ3M+IG1fZmxhZ3M7CiB9Owo=