22019 2008-10-31 15:20:50 -0700 Move JSC::Interpreter::shouldPrintExceptions() to WebCore::Console 2008-11-01 18:10:16 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 zwarich zwarich sam oldest_to_newest 97323 0 zwarich 2008-10-31 15:20:50 -0700 The function Interpreter::shouldPrintExceptions() is only used in WebCore::Console and is exposed via the WebKit, so it should really be on Console instead of Interpreter. 97337 1 24823 zwarich 2008-10-31 17:07:33 -0700 Created attachment 24823 Proposed patch 97339 2 24823 darin 2008-10-31 17:12:38 -0700 Comment on attachment 24823 Proposed patch r=me 97379 3 sam 2008-11-01 18:10:16 -0700 Fixed in r38060. 24823 2008-10-31 17:07:33 -0700 2008-10-31 17:12:38 -0700 Proposed patch console.diff text/plain 7561 zwarich SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM4MDU1KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDgtMTAtMzEgIENhbWVyb24g WndhcmljaCAgPHp3YXJpY2hAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAyMjAxOTogTW92ZSBKU0M6OkludGVycHJldGVyOjpz aG91bGRQcmludEV4Y2VwdGlvbnMoKSB0byBXZWJDb3JlOjpDb25zb2xlCisgICAgICAgIDxodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIwMTk+CisKKyAgICAgICAgVGhl IEpTQzo6SW50ZXJwcmV0ZXI6OnNob3VsZFByaW50RXhjZXB0aW9ucygpIGZ1bmN0aW9uIGlzIG5v dCB1c2VkIGF0CisgICAgICAgIGFsbCBpbiBKYXZhU2NyaXB0Q29yZSwgc28gaXQgc2hvdWxkIGJl IG1vdmVkIHRvIFdlYkNvcmU6OkNvbnNvbGUsIGl0cworICAgICAgICBvbmx5IHVzZXIuCisKKyAg ICAgICAgKiBKYXZhU2NyaXB0Q29yZS5leHA6CisgICAgICAgICoga2pzL2ludGVycHJldGVyLmNw cDoKKyAgICAgICAgKiBranMvaW50ZXJwcmV0ZXIuaDoKKwogMjAwOC0xMC0zMSAgQ2FtZXJvbiBa d2FyaWNoICA8endhcmljaEBhcHBsZS5jb20+CiAKICAgICAgICAgTm90IHJldmlld2VkLgpJbmRl eDogSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUuZXhwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFT Y3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmV4cAkocmV2aXNpb24gMzgwNTMpCisrKyBKYXZhU2Ny aXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5leHAJKHdvcmtpbmcgY29weSkKQEAgLTEwMCw4ICsxMDAs NiBAQCBfX1pOM0pTQzEwdGhyb3dFcnJvckVQTlNfOUV4ZWNTdGF0ZUVOU185CiBfX1pOM0pTQzEw dGhyb3dFcnJvckVQTlNfOUV4ZWNTdGF0ZUVOU185RXJyb3JUeXBlRVBLYwogX19aTjNKU0MxMHRo cm93RXJyb3JFUE5TXzlFeGVjU3RhdGVFTlNfOUVycm9yVHlwZUVSS05TXzdVU3RyaW5nRQogX19a TjNKU0MxMUludGVycHJldGVyMTFjaGVja1N5bnRheEVQTlNfOUV4ZWNTdGF0ZUVSS05TXzEwU291 cmNlQ29kZUUKLV9fWk4zSlNDMTFJbnRlcnByZXRlcjIxc2hvdWxkUHJpbnRFeGNlcHRpb25zRXYK LV9fWk4zSlNDMTFJbnRlcnByZXRlcjI0c2V0U2hvdWxkUHJpbnRFeGNlcHRpb25zRWIKIF9fWk4z SlNDMTFJbnRlcnByZXRlcjhldmFsdWF0ZUVQTlNfOUV4ZWNTdGF0ZUVSTlNfMTBTY29wZUNoYWlu RVJLTlNfMTBTb3VyY2VDb2RlRVBOU183SlNWYWx1ZUUKIF9fWk4zSlNDMTFKU0ltbWVkaWF0ZTEy bm9uSW5saW5lTmFORXYKIF9fWk4zSlNDMTFKU0ltbWVkaWF0ZTh0b09iamVjdEVQTlNfN0pTVmFs dWVFUE5TXzlFeGVjU3RhdGVFCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9ranMvaW50ZXJwcmV0ZXIu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL2tqcy9pbnRlcnByZXRlci5jcHAJKHJl dmlzaW9uIDM4MDUzKQorKysgSmF2YVNjcmlwdENvcmUva2pzL2ludGVycHJldGVyLmNwcAkod29y a2luZyBjb3B5KQpAQCAtNzUsMTYgKzc1LDQgQEAgQ29tcGxldGlvbiBJbnRlcnByZXRlcjo6ZXZh bHVhdGUoRXhlY1N0YQogICAgIHJldHVybiBDb21wbGV0aW9uKE5vcm1hbCwgcmVzdWx0KTsKIH0K IAotc3RhdGljIGJvb2wgcHJpbnRFeGNlcHRpb25zID0gZmFsc2U7Ci0KLWJvb2wgSW50ZXJwcmV0 ZXI6OnNob3VsZFByaW50RXhjZXB0aW9ucygpCi17Ci0gICAgcmV0dXJuIHByaW50RXhjZXB0aW9u czsKLX0KLQotdm9pZCBJbnRlcnByZXRlcjo6c2V0U2hvdWxkUHJpbnRFeGNlcHRpb25zKGJvb2wg cHJpbnQpCi17Ci0gICAgcHJpbnRFeGNlcHRpb25zID0gcHJpbnQ7Ci19Ci0KIH0gLy8gbmFtZXNw YWNlIEpTQwpJbmRleDogSmF2YVNjcmlwdENvcmUva2pzL2ludGVycHJldGVyLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gSmF2YVNjcmlwdENvcmUva2pzL2ludGVycHJldGVyLmgJKHJldmlzaW9uIDM4MDUzKQor KysgSmF2YVNjcmlwdENvcmUva2pzL2ludGVycHJldGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTYx LDkgKzYxLDYgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICogQHJldHVybiBBIGNvbXBsZXRpb24g b2JqZWN0IHJlcHJlc2VudGluZyB0aGUgcmVzdWx0IG9mIHRoZSBleGVjdXRpb24uCiAgICAgICov CiAgICAgc3RhdGljIENvbXBsZXRpb24gZXZhbHVhdGUoRXhlY1N0YXRlKiwgU2NvcGVDaGFpbiYs IGNvbnN0IFNvdXJjZUNvZGUmLCBKU1ZhbHVlKiB0aGlzVmFsdWUgPSBub1ZhbHVlKCkpOwotICAg IAotICAgIHN0YXRpYyBib29sIHNob3VsZFByaW50RXhjZXB0aW9ucygpOwotICAgIHN0YXRpYyB2 b2lkIHNldFNob3VsZFByaW50RXhjZXB0aW9ucyhib29sKTsKICAgfTsKIAogfSAvLyBuYW1lc3Bh Y2UgSlNDCkluZGV4OiBXZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL0No YW5nZUxvZwkocmV2aXNpb24gMzgwNTYpCisrKyBXZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBj b3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDA4LTEwLTMxICBDYW1lcm9uIFp3YXJpY2ggIDx6d2Fy aWNoQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBCdWcgMjIwMTk6IE1vdmUgSlNDOjpJbnRlcnByZXRlcjo6c2hvdWxkUHJpbnRFeGNl cHRpb25zKCkgdG8gV2ViQ29yZTo6Q29uc29sZQorICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMDE5PgorCisgICAgICAgICogV2ViQ29yZS5iYXNlLmV4 cDoKKyAgICAgICAgKiBwYWdlL0NvbnNvbGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6cHJpbnRU b1N0YW5kYXJkT3V0KToKKyAgICAgICAgKFdlYkNvcmU6OkNvbnNvbGU6OnNob3VsZFByaW50RXhj ZXB0aW9ucyk6CisgICAgICAgIChXZWJDb3JlOjpDb25zb2xlOjpzZXRTaG91bGRQcmludEV4Y2Vw dGlvbnMpOgorICAgICAgICAqIHBhZ2UvQ29uc29sZS5oOgorCiAyMDA4LTEwLTMxICBUaW1vdGh5 IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgbWFudWFsIHRlc3Rz IHRoYXQgY2hlY2sgYnJlYWtwb2ludHMgb24gYSBibG9ja2xlc3MgYm9keSBvZiAiZm9yIiBsb29w cy4KSW5kZXg6IFdlYkNvcmUvV2ViQ29yZS5iYXNlLmV4cAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L1dlYkNvcmUuYmFzZS5leHAJKHJldmlzaW9uIDM4MDUzKQorKysgV2ViQ29yZS9XZWJDb3JlLmJh c2UuZXhwCSh3b3JraW5nIGNvcHkpCkBAIC0yNzQsNiArMjc0LDggQEAgX19aTjdXZWJDb3JlMTNU eXBpbmdDb21tYW5kMzlpbnNlcnRQYXJhZwogX19aTjdXZWJDb3JlMTN0b0RldmljZVNwYWNlRVJL TlNfOUZsb2F0UmVjdEVQOE5TV2luZG93CiBfX1pON1dlYkNvcmUxM3RvSlNET01XaW5kb3dFUE5T XzVGcmFtZUUKIF9fWk43V2ViQ29yZTE0Q2FjaGVkUmVzb3VyY2UxMnJlbW92ZUNsaWVudEVQTlNf MjBDYWNoZWRSZXNvdXJjZUNsaWVudEUKK19fWk43V2ViQ29yZTdDb25zb2xlMjFzaG91bGRQcmlu dEV4Y2VwdGlvbnNFdgorX19aTjdXZWJDb3JlN0NvbnNvbGUyNHNldFNob3VsZFByaW50RXhjZXB0 aW9uc0ViCiBfX1pON1dlYkNvcmUxNERvY3VtZW50TG9hZGVyMTNhdHRhY2hUb0ZyYW1lRXYKIF9f Wk43V2ViQ29yZTE0RG9jdW1lbnRMb2FkZXIxNWRldGFjaEZyb21GcmFtZUV2CiBfX1pON1dlYkNv cmUxNERvY3VtZW50TG9hZGVyMThhZGRBcmNoaXZlUmVzb3VyY2VFTjNXVEYxMFBhc3NSZWZQdHJJ TlNfMTVBcmNoaXZlUmVzb3VyY2VFRUUKSW5kZXg6IFdlYkNvcmUvcGFnZS9Db25zb2xlLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvQ29uc29sZS5jcHAJKHJldmlzaW9uIDM4MDUzKQor KysgV2ViQ29yZS9wYWdlL0NvbnNvbGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTgsNyArMTE4 LDcgQEAgc3RhdGljIHZvaWQgcHJpbnRNZXNzYWdlU291cmNlQW5kTGV2ZWxQcgogCiBzdGF0aWMg dm9pZCBwcmludFRvU3RhbmRhcmRPdXQoTWVzc2FnZVNvdXJjZSBzb3VyY2UsIE1lc3NhZ2VMZXZl bCBsZXZlbCwgY29uc3QgU3RyaW5nJiBtZXNzYWdlLCBjb25zdCBTdHJpbmcmIHNvdXJjZVVSTCwg dW5zaWduZWQgbGluZU51bWJlcikKIHsKLSAgICBpZiAoIUludGVycHJldGVyOjpzaG91bGRQcmlu dEV4Y2VwdGlvbnMoKSkKKyAgICBpZiAoIUNvbnNvbGU6OnNob3VsZFByaW50RXhjZXB0aW9ucygp KQogICAgICAgICByZXR1cm47CiAKICAgICBwcmludFNvdXJjZVVSTEFuZExpbmUoc291cmNlVVJM LCBsaW5lTnVtYmVyKTsKQEAgLTEyOSw3ICsxMjksNyBAQCBzdGF0aWMgdm9pZCBwcmludFRvU3Rh bmRhcmRPdXQoTWVzc2FnZVNvCiAKIHN0YXRpYyB2b2lkIHByaW50VG9TdGFuZGFyZE91dChNZXNz YWdlTGV2ZWwgbGV2ZWwsIEV4ZWNTdGF0ZSogZXhlYywgY29uc3QgQXJnTGlzdCYgYXJncywgY29u c3QgS1VSTCYgdXJsKQogewotICAgIGlmICghSW50ZXJwcmV0ZXI6OnNob3VsZFByaW50RXhjZXB0 aW9ucygpKQorICAgIGlmICghQ29uc29sZTo6c2hvdWxkUHJpbnRFeGNlcHRpb25zKCkpCiAgICAg ICAgIHJldHVybjsKIAogICAgIHByaW50U291cmNlVVJMQW5kTGluZSh1cmwucHJldHR5VVJMKCks IDApOwpAQCAtNDU5LDYgKzQ1OSwxOCBAQCB2b2lkIENvbnNvbGU6OnJlcG9ydEN1cnJlbnRFeGNl cHRpb24oRXhlCiAgICAgcmVwb3J0RXhjZXB0aW9uKGV4ZWMsIGV4Y2VwdGlvbik7CiB9CiAKK3N0 YXRpYyBib29sIHByaW50RXhjZXB0aW9ucyA9IGZhbHNlOworCitib29sIENvbnNvbGU6OnNob3Vs ZFByaW50RXhjZXB0aW9ucygpCit7CisgICAgcmV0dXJuIHByaW50RXhjZXB0aW9uczsKK30KKwor dm9pZCBDb25zb2xlOjpzZXRTaG91bGRQcmludEV4Y2VwdGlvbnMoYm9vbCBwcmludCkKK3sKKyAg ICBwcmludEV4Y2VwdGlvbnMgPSBwcmludDsKK30KKwogUGFnZSogQ29uc29sZTo6cGFnZSgpIGNv bnN0CiB7CiAgICAgaWYgKCFtX2ZyYW1lKQpJbmRleDogV2ViQ29yZS9wYWdlL0NvbnNvbGUuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvQ29uc29sZS5oCShyZXZpc2lvbiAzODA1MykKKysr IFdlYkNvcmUvcGFnZS9Db25zb2xlLmgJKHdvcmtpbmcgY29weSkKQEAgLTk2LDggKzk2LDEyIEBA IG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdm9pZCByZXBvcnRFeGNlcHRpb24oSlNDOjpF eGVjU3RhdGUqLCBKU0M6OkpTVmFsdWUqKTsKICAgICAgICAgdm9pZCByZXBvcnRDdXJyZW50RXhj ZXB0aW9uKEpTQzo6RXhlY1N0YXRlKik7CiAKKyAgICAgICAgc3RhdGljIGJvb2wgc2hvdWxkUHJp bnRFeGNlcHRpb25zKCk7CisgICAgICAgIHN0YXRpYyB2b2lkIHNldFNob3VsZFByaW50RXhjZXB0 aW9ucyhib29sKTsKKwogICAgICAgICBjb25zdCBQcm9maWxlc0FycmF5JiBwcm9maWxlcygpIGNv bnN0IHsgcmV0dXJuIG1fcHJvZmlsZXM7IH0KICNlbmRpZgorCiAgICAgcHJpdmF0ZToKICAgICAg ICAgaW5saW5lIFBhZ2UqIHBhZ2UoKSBjb25zdDsKIApJbmRleDogV2ViS2l0L21hYy9DaGFuZ2VM b2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDM4MDU2KQor KysgV2ViS2l0L21hYy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAor MjAwOC0xMC0zMSAgQ2FtZXJvbiBad2FyaWNoICA8endhcmljaEBhcHBsZS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVnIDIyMDE5OiBNb3Zl IEpTQzo6SW50ZXJwcmV0ZXI6OnNob3VsZFByaW50RXhjZXB0aW9ucygpIHRvIFdlYkNvcmU6OkNv bnNvbGUKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MjAxOT4KKworICAgICAgICAqIE1pc2MvV2ViQ29yZVN0YXRpc3RpY3MubW06CisgICAgICAgICgr W1dlYkNvcmVTdGF0aXN0aWNzIHNob3VsZFByaW50RXhjZXB0aW9uc10pOgorICAgICAgICAoK1tX ZWJDb3JlU3RhdGlzdGljcyBzZXRTaG91bGRQcmludEV4Y2VwdGlvbnM6XSk6CisKIDIwMDgtMTAt MzEgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IERhcmluIEFkbGVyCkluZGV4OiBXZWJLaXQvbWFjL01pc2MvV2ViQ29yZVN0YXRpc3RpY3Mu bW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViS2l0L21hYy9NaXNjL1dlYkNvcmVTdGF0aXN0aWNzLm1tCShy ZXZpc2lvbiAzODA1MykKKysrIFdlYktpdC9tYWMvTWlzYy9XZWJDb3JlU3RhdGlzdGljcy5tbQko d29ya2luZyBjb3B5KQpAQCAtMzAsOCArMzAsOCBAQAogCiAjaW1wb3J0ICJXZWJDYWNoZS5oIgog I2ltcG9ydCAiV2ViRnJhbWVJbnRlcm5hbC5oIgotI2ltcG9ydCA8a2pzL2ludGVycHJldGVyLmg+ CiAjaW1wb3J0IDxranMvSlNMb2NrLmg+CisjaW1wb3J0IDxXZWJDb3JlL0NvbnNvbGUuaD4KICNp bXBvcnQgPFdlYkNvcmUvRm9udENhY2hlLmg+CiAjaW1wb3J0IDxXZWJDb3JlL0ZyYW1lLmg+CiAj aW1wb3J0IDxXZWJDb3JlL0dDQ29udHJvbGxlci5oPgpAQCAtMTQzLDEzICsxNDMsMTMgQEAgdXNp bmcgbmFtZXNwYWNlIFdlYkNvcmU7CiArIChCT09MKXNob3VsZFByaW50RXhjZXB0aW9ucwogewog ICAgIEpTTG9jayBsb2NrKGZhbHNlKTsKLSAgICByZXR1cm4gSW50ZXJwcmV0ZXI6OnNob3VsZFBy aW50RXhjZXB0aW9ucygpOworICAgIHJldHVybiBDb25zb2xlOjpzaG91bGRQcmludEV4Y2VwdGlv bnMoKTsKIH0KIAogKyAodm9pZClzZXRTaG91bGRQcmludEV4Y2VwdGlvbnM6KEJPT0wpcHJpbnQK IHsKICAgICBKU0xvY2sgbG9jayhmYWxzZSk7Ci0gICAgSW50ZXJwcmV0ZXI6OnNldFNob3VsZFBy aW50RXhjZXB0aW9ucyhwcmludCk7CisgICAgQ29uc29sZTo6c2V0U2hvdWxkUHJpbnRFeGNlcHRp b25zKHByaW50KTsKIH0KIAogKyAodm9pZCllbXB0eUNhY2hlCg==