22018 2008-10-31 15:06:22 -0700 enable-developer-extras doesn't toggle WebInspector 2008-10-31 17:28:47 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) All All RESOLVED FIXED Gtk P2 Normal --- 1 christian christian oldest_to_newest 97318 0 christian 2008-10-31 15:06:22 -0700 While adding a preference for enable-developer-extras I noticed that it didn't affect existing web views. Basically there's a notify 'else if' missing. 97320 1 24819 christian 2008-10-31 15:07:38 -0700 Created attachment 24819 Add if branch for enable-developer-extras 97329 2 24819 mrowe 2008-10-31 15:41:55 -0700 Comment on attachment 24819 Add if branch for enable-developer-extras r=me 97343 3 24819 christian 2008-10-31 17:28:32 -0700 Comment on attachment 24819 Add if branch for enable-developer-extras 2008-10-31 Christian Dywan <christian@twotoasts.de> Reviewed by Mark Rowe. http://bugs.webkit.org/show_bug.cgi?id=22018 enable-developer-extras doesn't toggle WebInspector * webkit/webkitwebview.cpp: Add missing 'if' in notification for 'enable-developer-extras'. 24819 2008-10-31 15:07:38 -0700 2008-10-31 17:28:32 -0700 Add if branch for enable-developer-extras developerextrasnotify.diff text/plain 826 christian ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwIGIvV2ViS2l0 L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKaW5kZXggNjJhYTM3YS4uMmM5MGI0ZSAxMDA2 NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKKysrIGIvV2ViS2l0 L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKQEAgLTE0NjQsNiArMTQ2NCw4IEBAIHN0YXRp YyB2b2lkIHdlYmtpdF93ZWJfdmlld19zZXR0aW5nc19ub3RpZnkoV2ViS2l0V2ViU2V0dGluZ3Mq IHdlYlNldHRpbmdzLCBHUGFyCiAgICAgICAgIHNldHRpbmdzLT5zZXRUZXh0QXJlYXNBcmVSZXNp emFibGUoZ192YWx1ZV9nZXRfYm9vbGVhbigmdmFsdWUpKTsKICAgICBlbHNlIGlmIChuYW1lID09 IGdfaW50ZXJuX3N0cmluZygidXNlci1zdHlsZXNoZWV0LXVyaSIpKQogICAgICAgICBzZXR0aW5n cy0+c2V0VXNlclN0eWxlU2hlZXRMb2NhdGlvbihLVVJMKGdfdmFsdWVfZ2V0X3N0cmluZygmdmFs dWUpKSk7CisgICAgZWxzZSBpZiAobmFtZSA9PSBnX2ludGVybl9zdHJpbmcoImVuYWJsZS1kZXZl bG9wZXItZXh0cmFzIikpCisgICAgICAgIHNldHRpbmdzLT5zZXREZXZlbG9wZXJFeHRyYXNFbmFi bGVkKGdfdmFsdWVfZ2V0X2Jvb2xlYW4oJnZhbHVlKSk7CiAgICAgZWxzZSBpZiAoIWdfb2JqZWN0 X2NsYXNzX2ZpbmRfcHJvcGVydHkoR19PQkpFQ1RfR0VUX0NMQVNTKHdlYlNldHRpbmdzKSwgbmFt ZSkpCiAgICAgICAgIGdfd2FybmluZygiVW5leHBlY3RlZCBzZXR0aW5nICclcyciLCBuYW1lKTsK ICAgICBnX3ZhbHVlX3Vuc2V0KCZ2YWx1ZSk7Cg==