220159 2020-12-26 20:36:17 -0800 Fix incorrect return types of fallback color conversion functions 2020-12-27 10:39:15 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sam webkit-unassigned dino simon.fraser webkit-bug-importer oldest_to_newest 1716696 0 416797 sam 2020-12-26 04:37:54 -0800 Created attachment 416797 Patch 1716694 1 sam 2020-12-26 20:36:17 -0800 I accidentally left all the fallback color converter functions return SRGBA, which is not correct. They are not used yet, so this is not observable, but will be used soon so needs to be fixed. 1716733 2 ews-feeder 2020-12-27 10:38:16 -0800 Committed r271095: <https://trac.webkit.org/changeset/271095> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416797. 1716734 3 webkit-bug-importer 2020-12-27 10:39:15 -0800 <rdar://problem/72690877> 416797 2020-12-26 20:37:54 -0800 2020-12-27 10:38:17 -0800 Patch For2201.diff text/plain 1959 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3MTA5MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIwLTEyLTI2ICBTYW0gV2Vp bmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggaW5jb3JyZWN0IHJldHVybiB0 eXBlcyBvZiBmYWxsYmFjayBjb2xvciBjb252ZXJzaW9uIGZ1bmN0aW9ucworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIwMTU5CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9D b2xvckNvbnZlcnNpb24uaDoKKyAgICAgICAgRml4dXAgcmV0dXJuIHR5cGVzIG9mIGZhbGxiYWNr IGNvbnZlcnNpb24gZnVuY3Rpb25zIHRvIG1hdGNoIHNpZ25hdHVyZS4gCisKIDIwMjAtMTItMjYg IEFsZXhleSBTaHZheWthICA8c2h2YWlrYWxlc2hAZ21haWwuY29tPgogCiAgICAgICAgIFtXZWJJ RExdIFJlbW92ZSBbQ3VzdG9tVG9TdHJpbmdOYW1lXSBhbmQgTG9jYXRpb24tc3BlY2lmaWMgZXh0 ZW5kZWQgYXR0cmlidXRlcwoKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L0NvbG9yQ29udmVyc2lvbi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL0NvbG9yQ29udmVyc2lvbi5oCShyZXZpc2lvbiAyNzEwOTApCisrKyBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Db2xvckNvbnZlcnNpb24uaAkod29ya2luZyBjb3B5 KQpAQCAtMTA2LDI3ICsxMjIsMjcgQEAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gU1JHQkE8ZmxvYXQ+ IHRvU1JHQgogICAgIHJldHVybiB0b1NSR0JBKHRvWFlaQShjb2xvcikpOwogfQogCi10ZW1wbGF0 ZTx0eXBlbmFtZSBUPiBTUkdCQTxmbG9hdD4gdG9MaW5lYXJTUkdCQShjb25zdCBUJiBjb2xvcikK K3RlbXBsYXRlPHR5cGVuYW1lIFQ+IExpbmVhclNSR0JBPGZsb2F0PiB0b0xpbmVhclNSR0JBKGNv bnN0IFQmIGNvbG9yKQogewogICAgIHJldHVybiB0b0xpbmVhclNSR0JBKHRvWFlaQShjb2xvcikp OwogfQogCi10ZW1wbGF0ZTx0eXBlbmFtZSBUPiBTUkdCQTxmbG9hdD4gdG9EaXNwbGF5UDMoY29u c3QgVCYgY29sb3IpCit0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBEaXNwbGF5UDM8ZmxvYXQ+IHRvRGlz cGxheVAzKGNvbnN0IFQmIGNvbG9yKQogewogICAgIHJldHVybiB0b0Rpc3BsYXlQMyh0b1hZWkEo Y29sb3IpKTsKIH0KIAotdGVtcGxhdGU8dHlwZW5hbWUgVD4gU1JHQkE8ZmxvYXQ+IHRvTGluZWFy RGlzcGxheVAzKGNvbnN0IFQmIGNvbG9yKQordGVtcGxhdGU8dHlwZW5hbWUgVD4gTGluZWFyRGlz cGxheVAzPGZsb2F0PiB0b0xpbmVhckRpc3BsYXlQMyhjb25zdCBUJiBjb2xvcikKIHsKICAgICBy ZXR1cm4gdG9MaW5lYXJEaXNwbGF5UDModG9YWVpBKGNvbG9yKSk7CiB9CiAKLXRlbXBsYXRlPHR5 cGVuYW1lIFQ+IFNSR0JBPGZsb2F0PiB0b0hTTEEoY29uc3QgVCYgY29sb3IpCit0ZW1wbGF0ZTx0 eXBlbmFtZSBUPiBIU0xBPGZsb2F0PiB0b0hTTEEoY29uc3QgVCYgY29sb3IpCiB7CiAgICAgcmV0 dXJuIHRvSFNMQSh0b1hZWkEoY29sb3IpKTsKIH0KIAotdGVtcGxhdGU8dHlwZW5hbWUgVD4gU1JH QkE8ZmxvYXQ+IHRvQ01ZS0EoY29uc3QgVCYgY29sb3IpCit0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBD TVlLQTxmbG9hdD4gdG9DTVlLQShjb25zdCBUJiBjb2xvcikKIHsKICAgICByZXR1cm4gdG9DTVlL QSh0b1hZWkEoY29sb3IpKTsKIH0K