<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>220154</bug_id>
          
          <creation_ts>2020-12-26 10:34:49 -0800</creation_ts>
          <short_desc>[GTK][Stable] WebKitPluginProcess is built but not installed</short_desc>
          <delta_ts>2021-02-01 02:21:20 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alberto Garcia">berto</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>annulen</cc>
    
    <cc>aperez</cc>
    
    <cc>bugs-noreply</cc>
    
    <cc>cgarcia</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>fujii</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>jmason</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>ryuan.choi</cc>
    
    <cc>sergio</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1716666</commentid>
    <comment_count>0</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2020-12-26 10:34:49 -0800</bug_when>
    <thetext>This affects all releases since 2.29.1 up to (and including) 2.30.4.

The origin of the problem seems to be r259560, which was the fix for bug 210033

Jim Mason reported the problem in the comments of that bug, but it seems that no one noticed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1716670</commentid>
    <comment_count>1</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2020-12-26 11:33:10 -0800</bug_when>
    <thetext>The plan was to remove WebKitPluginProcess for 2.32. I guess we succeeded by accident....</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1716705</commentid>
    <comment_count>2</comment_count>
      <attachid>416802</attachid>
    <who name="Jim Mason">jmason</who>
    <bug_when>2020-12-27 03:51:49 -0800</bug_when>
    <thetext>Created attachment 416802
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1716706</commentid>
    <comment_count>3</comment_count>
    <who name="Jim Mason">jmason</who>
    <bug_when>2020-12-27 03:52:45 -0800</bug_when>
    <thetext>For reference, I have attached the patch I use to restore installation.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1716722</commentid>
    <comment_count>4</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2020-12-27 06:11:13 -0800</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #1)
&gt; The plan was to remove WebKitPluginProcess for 2.32. I guess we succeeded by
&gt; accident....

A Debian user wrote this:

&quot;I am sad to hear that the plugin support will be removed.

The plugin is our company&apos;s in house program to provide a way to 
communicate between C/C++ and JavaScript, makes it possible for the 
connected primitive hardware to play some roles in the evolving Internet 
world.

We don&apos;t use the full features of NPAPI, but just the calling/passing 
functions and information between the browser and the underneath lower 
level system/hardware resources.

If removing of the plugin is inevitable, we will need to find an 
alternative of WebKit to fulfill our goal.&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1716765</commentid>
    <comment_count>5</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2020-12-28 05:20:26 -0800</bug_when>
    <thetext>(In reply to Jim Mason from comment #3)
&gt; For reference, I have attached the patch I use to restore installation.

Thanks, I confirm that the patch works fine.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1718873</commentid>
    <comment_count>6</comment_count>
      <attachid>416802</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2021-01-11 17:12:15 -0800</bug_when>
    <thetext>Comment on attachment 416802
Patch

r265753 (Bug 215503) removed NPAPI plugin support for GTK and WPE ports.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1718956</commentid>
    <comment_count>7</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2021-01-12 04:27:42 -0800</bug_when>
    <thetext>(In reply to Fujii Hironori from comment #6)
&gt; Comment on attachment 416802 [details]
&gt; Patch
&gt; 
&gt; r265753 (Bug 215503) removed NPAPI plugin support for GTK and WPE ports.

This patch is for the 2.30 branch which should still support those plugins as far as I&apos;m aware.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1723129</commentid>
    <comment_count>8</comment_count>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2021-01-27 14:03:23 -0800</bug_when>
    <thetext>(In reply to Alberto Garcia from comment #7)
&gt; (In reply to Fujii Hironori from comment #6)
&gt; &gt; Comment on attachment 416802 [details]
&gt; &gt; Patch
&gt; &gt; 
&gt; &gt; r265753 (Bug 215503) removed NPAPI plugin support for GTK and WPE ports.
&gt; 
&gt; This patch is for the 2.30 branch which should still support those plugins
&gt; as far as I&apos;m aware.

Yes, the 2.30 branch still supports NPAPI plug-ins, I think we should
apply this fix in the branch (but of course not in ”trunk”). Carlos?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1723163</commentid>
    <comment_count>9</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-01-27 14:54:51 -0800</bug_when>
    <thetext>My $0.02: we are now four months into the six-month lifetime of 2.30. The plugin support is gone in 2.32 regardless. Reviving it for two more months after it&apos;s already been gone for four months -- albeit by accident - doesn&apos;t seem very useful.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1723172</commentid>
    <comment_count>10</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2021-01-27 15:15:04 -0800</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #9)
&gt; My $0.02: we are now four months into the six-month lifetime of 2.30. The
&gt; plugin support is gone in 2.32 regardless. Reviving it for two more months
&gt; after it&apos;s already been gone for four months -- albeit by accident - doesn&apos;t
&gt; seem very useful.

It seems that there are a few people who still use their own plugins, like the person that I quoted earlier in this thread.

Although those users will have to switch to a different solution at some point if they want to keep using a recent version of WebKit, it takes zero effort for us to fix this bug now and give them a few more months.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1724152</commentid>
    <comment_count>11</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2021-02-01 02:21:08 -0800</bug_when>
    <thetext>Committed r272131: &lt;https://trac.webkit.org/changeset/272131&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>416802</attachid>
            <date>2020-12-27 03:51:49 -0800</date>
            <delta_ts>2021-02-01 02:21:20 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-220154-20201227115147.patch</filename>
            <type>text/plain</type>
            <size>1067</size>
            <attacher name="Jim Mason">jmason</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL
aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNzEwOTIpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv
Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDIwLTEyLTI3ICBKaW0gTWFzb24g
IDxqbWFzb25AaWJpbnguY29tPgorCisgICAgICAgIFtHVEtdIFdlYktpdFBsdWdpblByb2Nlc3Mg
aXMgYnVpbHQgYnV0IG5vdCBpbnN0YWxsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTIyMDE1NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisKIDIwMjAtMTItMjMgIFNhaWQg
QWJvdS1IYWxsYXdhICA8c2FpZEBhcHBsZS5jb20+CiAKICAgICAgICAgW0dQVSBQcm9jZXNzXTog
RG9uJ3QgY2FsbCBmbHVzaERyYXdpbmdDb250ZXh0KCkgaW4gdGhlIG1pZGRsZSBvZiByZWNvcmRp
bmcgZHJhd2luZyBjb21tYW5kcwpJbmRleDogU291cmNlL1dlYktpdC9DTWFrZUxpc3RzLnR4dAo9
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L0NNYWtlTGlzdHMudHh0CShyZXZpc2lvbiAyNzEw
OTIpCisrKyBTb3VyY2UvV2ViS2l0L0NNYWtlTGlzdHMudHh0CSh3b3JraW5nIGNvcHkpCkBAIC01
OTUsNCArNTk1LDggQEAgZWxzZSAoKQogICAgICAgICBMSUJSQVJZIERFU1RJTkFUSU9OICIke0xJ
Ql9JTlNUQUxMX0RJUn0iCiAgICAgICAgIFJVTlRJTUUgREVTVElOQVRJT04gIiR7TElCRVhFQ19J
TlNUQUxMX0RJUn0iCiAgICAgKQorCisgICAgaWYgKEVOQUJMRV9QTFVHSU5fUFJPQ0VTUykKKyAg
ICAgICAgaW5zdGFsbChUQVJHRVRTIFBsdWdpblByb2Nlc3MgREVTVElOQVRJT04gIiR7TElCRVhF
Q19JTlNUQUxMX0RJUn0iKQorICAgIGVuZGlmICgpCiBlbmRpZiAoKQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>