220153 2020-12-26 09:55:24 -0800 [LFC] Rect::expandToContain should call LayoutRect::uniteEvenIfEmpty 2020-12-26 11:43:19 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1716662 0 zalan 2020-12-26 09:55:24 -0800 and not unite. This is useful when trying to expand a <span>'s rect when the <span> starts at the end of the line and is empty. 1716663 1 416785 zalan 2020-12-26 10:04:00 -0800 Created attachment 416785 Patch 1716671 2 ews-feeder 2020-12-26 11:42:53 -0800 Committed r271091: <https://trac.webkit.org/changeset/271091> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416785. 1716672 3 webkit-bug-importer 2020-12-26 11:43:19 -0800 <rdar://problem/72682902> 416785 2020-12-26 10:04:00 -0800 2020-12-26 11:42:53 -0800 Patch bug-220153-20201226100359.patch text/plain 4340 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxMDg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzMzNzM2MzI5N2Y4Yjcx NjUwZDU3NDgxZjExZDg3MDE2Mzg0ODM5NS4uYzM2ZTYyMzFhMGE5MDUwZjJhOTRkODJiY2M1ZmUy YTcwZDA5NDhjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIwLTEyLTI2ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ10gUmVjdDo6ZXhwYW5k VG9Db250YWluIHNob3VsZCBjYWxsIExheW91dFJlY3Q6OnVuaXRlRXZlbklmRW1wdHkKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMDE1MworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE11bHRpbGluZSBpbmxp bmUgYm94ZXMgc2hvdWxkIGV4cGFuZCBldmVuIHdoZW4gdGhleSBzdGFydCBhdCB0aGUgZW5kIG9m IHRoZSBsaW5lIGFuZCBhcmUgZW1wdHkuCisgICAgICAgIGUuZy4KKyAgICAgICAgICA8cHJlPnRo aXMgaXMgdGhlIGZpcnN0IGxpbmU8c3Bhbj4KKyAgICAgICAgICBhbmQgdGhpcyBpcyB0aGUgc2Vj b25kPC9zcGFuPjwvcHJlPgorICAgICAgICBUaGUgPHNwYW4+J3MgaGVpZ2h0ID0gZmlyc3QgbGlu ZSBoZWlnaHQgKGV2ZW4gdGhvdWdoIHRoZSA8c3Bhbj4gaXMgZW1wdHkgb24gdGhpcyBsaW5lKSAr IHNlY29uZCBsaW5lIGhlaWdodC4KKworICAgICAgICAqIGxheW91dC9sYXlvdXR0cmVlL0xheW91 dEdlb21ldHJ5UmVjdC5oOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpSZWN0OjpleHBhbmRU b0NvbnRhaW4pOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0xheW91dFJlY3QuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6TGF5b3V0UmVjdDo6dW5pdGUpOgorICAgICAgICAoV2ViQ29yZTo6 TGF5b3V0UmVjdDo6dW5pdGVFdmVuSWZFbXB0eSk6IGNvcHkgZnJvbSBGbG9hdFJlY3QuCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvTGF5b3V0UmVjdC5oOgorICAgICAgICAoV2ViQ29yZTo6 TGF5b3V0UmVjdDo6c2V0TG9jYXRpb25BbmRTaXplRnJvbUVkZ2VzKTogY29weSBmcm9tIEZsb2F0 UmVjdC4KKwogMjAyMC0xMi0yNiAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAg ICAgICAgIFtMRkNdW0ludGVncmF0aW9uXSBTZXQgcHJlLWNvbXB1dGVkIGlubGluZSBib3ggZ2Vv bWV0cmllcyAobWFyZ2luLCBib3JkZXIgYW5kIHBhZGRpbmcpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRHZW9tZXRyeVJlY3QuaCBiL1NvdXJjZS9X ZWJDb3JlL2xheW91dC9sYXlvdXR0cmVlL0xheW91dEdlb21ldHJ5UmVjdC5oCmluZGV4IGU1MTZl M2RkNDA1MzY3MWM5NmNlZWQ1ODBjMDAyMDFjNjhhNDQ3YTEuLjMyNTVkOTI0NWNlYjZjODc5NmM4 MGE4OWRhNjBhNGM3N2JjNzQwNDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9s YXlvdXR0cmVlL0xheW91dEdlb21ldHJ5UmVjdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91 dC9sYXlvdXR0cmVlL0xheW91dEdlb21ldHJ5UmVjdC5oCkBAIC0yOTcsNyArMjk3LDcgQEAgaW5s aW5lIHZvaWQgUmVjdDo6ZXhwYW5kVG9Db250YWluKGNvbnN0IFJlY3QmIHJlY3QpCiB7CiAgICAg QVNTRVJUKG1faGFzVmFsaWRXaWR0aCk7CiAgICAgQVNTRVJUKG1faGFzVmFsaWRIZWlnaHQpOwot ICAgIG1fcmVjdC51bml0ZShyZWN0KTsKKyAgICBtX3JlY3QudW5pdGVFdmVuSWZFbXB0eShyZWN0 KTsKIH0KIAogaW5saW5lIFJlY3QgUmVjdDo6Y2xvbmUoKSBjb25zdApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvTGF5b3V0UmVjdC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9MYXlvdXRSZWN0LmNwcAppbmRleCBhOTJjOTVhOTFhNGYx ZjJkMDllM2ZkZjM5YTJkYzc5N2IwNzkwYWQ1Li5jY2ZmZjhiZjA5MzdhMjc3Mzg0ODlhYzc0YjQ3 YmQ0MDRjMzVjNzRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9MYXlvdXRSZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9M YXlvdXRSZWN0LmNwcApAQCAtMTAwLDExICsxMDAsMTcgQEAgdm9pZCBMYXlvdXRSZWN0Ojp1bml0 ZShjb25zdCBMYXlvdXRSZWN0JiBvdGhlcikKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAg IExheW91dFBvaW50IG5ld0xvY2F0aW9uKHN0ZDo6bWluKHgoKSwgb3RoZXIueCgpKSwgc3RkOjpt aW4oeSgpLCBvdGhlci55KCkpKTsKLSAgICBMYXlvdXRQb2ludCBuZXdNYXhQb2ludChzdGQ6Om1h eChtYXhYKCksIG90aGVyLm1heFgoKSksIHN0ZDo6bWF4KG1heFkoKSwgb3RoZXIubWF4WSgpKSk7 CisgICAgdW5pdGVFdmVuSWZFbXB0eShvdGhlcik7Cit9CiAKLSAgICBtX2xvY2F0aW9uID0gbmV3 TG9jYXRpb247Ci0gICAgbV9zaXplID0gbmV3TWF4UG9pbnQgLSBuZXdMb2NhdGlvbjsKK3ZvaWQg TGF5b3V0UmVjdDo6dW5pdGVFdmVuSWZFbXB0eShjb25zdCBMYXlvdXRSZWN0JiBvdGhlcikKK3sK KyAgICBhdXRvIG1pblggPSBzdGQ6Om1pbih4KCksIG90aGVyLngoKSk7CisgICAgYXV0byBtaW5Z ID0gc3RkOjptaW4oeSgpLCBvdGhlci55KCkpOworICAgIGF1dG8gbWF4WCA9IHN0ZDo6bWF4KHRo aXMtPm1heFgoKSwgb3RoZXIubWF4WCgpKTsKKyAgICBhdXRvIG1heFkgPSBzdGQ6Om1heCh0aGlz LT5tYXhZKCksIG90aGVyLm1heFkoKSk7CisKKyAgICBzZXRMb2NhdGlvbkFuZFNpemVGcm9tRWRn ZXMobWluWCwgbWluWSwgbWF4WCwgbWF4WSk7CiB9CiAKIGJvb2wgTGF5b3V0UmVjdDo6Y2hlY2tl ZFVuaXRlKGNvbnN0IExheW91dFJlY3QmIG90aGVyKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvTGF5b3V0UmVjdC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvTGF5b3V0UmVjdC5oCmluZGV4IDFjYzIyNzQ1ZjM5NjEzZjgyMzRiMTkwNjM4 YTE3OTUwMDY2YzA4NjAuLjI0MmZmYTlkMjYxZjI5YzFmYzIyZWFhNDhlZmI5ZjQxMTA4Y2VkYzAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0xheW91dFJlY3Qu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9MYXlvdXRSZWN0LmgKQEAg LTE5MCw2ICsxOTAsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBpbnRlcnNlY3QoY29uc3QgTGF5b3V0 UmVjdCYpOwogICAgIGJvb2wgZWRnZUluY2x1c2l2ZUludGVyc2VjdChjb25zdCBMYXlvdXRSZWN0 Jik7CiAgICAgV0VCQ09SRV9FWFBPUlQgdm9pZCB1bml0ZShjb25zdCBMYXlvdXRSZWN0Jik7Cisg ICAgdm9pZCB1bml0ZUV2ZW5JZkVtcHR5KGNvbnN0IExheW91dFJlY3QmKTsKICAgICB2b2lkIHVu aXRlSWZOb25aZXJvKGNvbnN0IExheW91dFJlY3QmKTsKICAgICBib29sIGNoZWNrZWRVbml0ZShj b25zdCBMYXlvdXRSZWN0Jik7CiAKQEAgLTIyMyw2ICsyMjQsOCBAQCBwdWJsaWM6CiAgICAgb3Bl cmF0b3IgRmxvYXRSZWN0KCkgY29uc3QgeyByZXR1cm4gRmxvYXRSZWN0KG1fbG9jYXRpb24sIG1f c2l6ZSk7IH0KIAogcHJpdmF0ZToKKyAgICB2b2lkIHNldExvY2F0aW9uQW5kU2l6ZUZyb21FZGdl cyhMYXlvdXRVbml0IGxlZnQsIExheW91dFVuaXQgdG9wLCBMYXlvdXRVbml0IHJpZ2h0LCBMYXlv dXRVbml0IGJvdHRvbSk7CisKICAgICBMYXlvdXRQb2ludCBtX2xvY2F0aW9uOwogICAgIExheW91 dFNpemUgbV9zaXplOwogfTsKQEAgLTI1OCw2ICsyNjEsMTMgQEAgaW5saW5lIGJvb2wgTGF5b3V0 UmVjdDo6aXNJbmZpbml0ZSgpIGNvbnN0CiAgICAgcmV0dXJuICp0aGlzID09IExheW91dFJlY3Q6 OmluZmluaXRlUmVjdCgpOwogfQogCitpbmxpbmUgdm9pZCBMYXlvdXRSZWN0OjpzZXRMb2NhdGlv bkFuZFNpemVGcm9tRWRnZXMoTGF5b3V0VW5pdCBsZWZ0LCBMYXlvdXRVbml0IHRvcCwgTGF5b3V0 VW5pdCByaWdodCwgTGF5b3V0VW5pdCBib3R0b20pCit7CisgICAgbV9sb2NhdGlvbiA9IHsgbGVm dCwgdG9wIH07CisgICAgbV9zaXplLnNldFdpZHRoKHJpZ2h0IC0gbGVmdCk7CisgICAgbV9zaXpl LnNldEhlaWdodChib3R0b20gLSB0b3ApOworfQorCiAvLyBJbnRlZ3JhbCBzbmFwcGluZyBmdW5j dGlvbnMuCiBpbmxpbmUgSW50UmVjdCBzbmFwcGVkSW50UmVjdChjb25zdCBMYXlvdXRSZWN0JiBy ZWN0KQogewo=