<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>220130</bug_id>
          
          <creation_ts>2020-12-23 16:16:07 -0800</creation_ts>
          <short_desc>[YARR JIT] Crash on overflow when compiling /(a{1000000000}b{1000000000}|c{1000000000}|)d{1000000000}e{1000000000}/.test();</short_desc>
          <delta_ts>2021-02-23 21:00:38 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Mark Lam">mark.lam</reporter>
          <assigned_to name="Michael Saboff">msaboff</assigned_to>
          <cc>ews-watchlist</cc>
    
    <cc>keith_miller</cc>
    
    <cc>msaboff</cc>
    
    <cc>saam</cc>
    
    <cc>tzagallo</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1716523</commentid>
    <comment_count>0</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2020-12-23 16:16:07 -0800</bug_when>
    <thetext>rdar://69884758</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1716525</commentid>
    <comment_count>1</comment_count>
      <attachid>416731</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2020-12-23 16:30:28 -0800</bug_when>
    <thetext>Created attachment 416731
proposed patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1716828</commentid>
    <comment_count>2</comment_count>
      <attachid>416731</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2020-12-29 19:13:55 -0800</bug_when>
    <thetext>Comment on attachment 416731
proposed patch.

Seems sane.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1716829</commentid>
    <comment_count>3</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2020-12-29 19:24:49 -0800</bug_when>
    <thetext>Thanks.  I would still like Michael to take a look before I land, especially on whether I should be using a different error code.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1716871</commentid>
    <comment_count>4</comment_count>
      <attachid>416731</attachid>
    <who name="Michael Saboff">msaboff</who>
    <bug_when>2020-12-30 15:22:42 -0800</bug_when>
    <thetext>Comment on attachment 416731
proposed patch.

I spent some time trying the patch.  The test case should not cause an overflow.  The patch found a bug and through code inspection I found another related bug.  If you look at lines ~3107..3111, you&apos;ll notice that is &quot;if (!isBegin)&quot; is true, we add the offset from the prior op before subtracting the checked amount for the current op.  This is where we overflow with the test and this patch.  We should be subtracting the current checked amount before adding the prior.  When I made this fix, the offset never overflowed.  When I adjust the test to have combined sounds &gt;= 2^32, we overflow in the parser.

There is a similar &quot;add before subtract&quot; offset case in lines 2801..2805.

In a local build, I change both cases to have the subtract before the add and ran all JSC tests with no issues.

We can land this patch, but it is more of a canary for newly introduced bugs in YARR JIT code (after I land my changes).  If we do, we should restructure the code to assert no overflow.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1724940</commentid>
    <comment_count>5</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2021-02-02 15:45:34 -0800</bug_when>
    <thetext>Michael is going to implement the real fix.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1732757</commentid>
    <comment_count>6</comment_count>
    <who name="Michael Saboff">msaboff</who>
    <bug_when>2021-02-23 18:02:56 -0800</bug_when>
    <thetext>We do some checked math in the Yarr JIT compiler in the wrong order, addition before subtraction causing checked arithmetic overflows.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1732760</commentid>
    <comment_count>7</comment_count>
      <attachid>421381</attachid>
    <who name="Michael Saboff">msaboff</who>
    <bug_when>2021-02-23 18:17:53 -0800</bug_when>
    <thetext>Created attachment 421381
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1732762</commentid>
    <comment_count>8</comment_count>
      <attachid>421381</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2021-02-23 18:20:02 -0800</bug_when>
    <thetext>Comment on attachment 421381
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1732776</commentid>
    <comment_count>9</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-02-23 21:00:35 -0800</bug_when>
    <thetext>Committed r273371: &lt;https://commits.webkit.org/r273371&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421381.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>416731</attachid>
            <date>2020-12-23 16:30:28 -0800</date>
            <delta_ts>2021-02-23 18:17:53 -0800</delta_ts>
            <desc>proposed patch.</desc>
            <filename>bug-220130.patch</filename>
            <type>text/plain</type>
            <size>7028</size>
            <attacher name="Mark Lam">mark.lam</attacher>
            
              <data encoding="base64">SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n
CShyZXZpc2lvbiAyNzEwNzkpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA
QCAtMSwzICsxLDEzIEBACisyMDIwLTEyLTIzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv
bT4KKworICAgICAgICBBZGQgYWJpbGl0eSB0byBoYW5kbGUgY2hlY2tlZCBvZmZzZXQgb3ZlcmZs
b3cgd2hpbGUgY29tcGlsaW5nIGEgUmVnRXhwLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIwMTMwCisgICAgICAgIHJkYXI6Ly82OTg4NDc1OAorCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3RyZXNzL3Jl
Z2V4cC1iYWNrdHJhY2stb2Zmc2V0LW92ZXJmbG93LmpzOiBBZGRlZC4KKwogMjAyMC0xMi0yMSAg
WXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFtKU0NdIFVwZGF0
ZSBlbGVtLndhc3QuanMgdGVzdApJbmRleDogSlNUZXN0cy9zdHJlc3MvcmVnZXhwLWJhY2t0cmFj
ay1vZmZzZXQtb3ZlcmZsb3cuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSlNUZXN0cy9zdHJlc3MvcmVnZXhw
LWJhY2t0cmFjay1vZmZzZXQtb3ZlcmZsb3cuanMJKG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy9z
dHJlc3MvcmVnZXhwLWJhY2t0cmFjay1vZmZzZXQtb3ZlcmZsb3cuanMJKHdvcmtpbmcgY29weSkK
QEAgLTAsMCArMSwzIEBACisvL0AgcnVuRGVmYXVsdAorCisvKGF7MTAwMDAwMDAwMH1iezEwMDAw
MDAwMDB9fGN7MTAwMDAwMDAwMH18KWR7MTAwMDAwMDAwMH1lezEwMDAwMDAwMDB9Ly50ZXN0KCk7
CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv
dXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3MTA3NCkKKysrIFNvdXJj
ZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxOCBA
QAorMjAyMC0xMi0yMyAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CisKKyAgICAgICAg
QWRkIGFiaWxpdHkgdG8gaGFuZGxlIGNoZWNrZWQgb2Zmc2V0IG92ZXJmbG93IHdoaWxlIGNvbXBp
bGluZyBhIFJlZ0V4cC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTIyMDEzMAorICAgICAgICByZGFyOi8vNjk4ODQ3NTgKKworICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCb3RoIGdlbmVyYXRlKCkgYW5kIGJhY2t0
cmFjaygpIHdpbGwgbm93IGFsc28gY2hlY2sgaWYgbV9jaGVja2VkT2Zmc2V0IGhhcworICAgICAg
ICBvdmVyZmxvd2VkLiAgSWYgc28sIGZhaWwgb3V0IG9mIHRoZSBjb21waWxhdGlvbi4KKworICAg
ICAgICAqIHlhcnIvWWFyckpJVC5jcHA6CisgICAgICAgIChKU0M6OllhcnI6OmR1bXBDb21waWxl
RmFpbHVyZSk6CisgICAgICAgICogeWFyci9ZYXJySklULmg6CisKIDIwMjAtMTItMjEgIEplc3Np
Y2EgVGFsbG9uICA8anRhbGxvbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtKU0NdIEFkZCBtaW5p
bXVtIHBhcmFtZXRlciB0byB0aGUgV0FTTSBKUy1BUEkgZm9yIE1lbW9yeSAmIFRhYmxlLgpJbmRl
eDogU291cmNlL0phdmFTY3JpcHRDb3JlL3lhcnIvWWFyckpJVC5jcHAKPT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g
U291cmNlL0phdmFTY3JpcHRDb3JlL3lhcnIvWWFyckpJVC5jcHAJKHJldmlzaW9uIDI3MTA3NCkK
KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS95YXJyL1lhcnJKSVQuY3BwCSh3b3JraW5nIGNvcHkp
CkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAwOS0yMDE4IEFwcGxlIElu
Yy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAwOS0yMDIwIEFwcGxl
IEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNl
IGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNh
dGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9u
cwpAQCAtODUyLDcgKzg1Miw3IEBAIGNsYXNzIFlhcnJHZW5lcmF0b3IgZmluYWwgOiBwdWJsaWMg
WWFyckoKICAgICAgICAgLy8gQ3VycmVudGx5IHVzZWQgaW4gdGhlIGNhc2Ugb2Ygc29tZSBvZiB0
aGUgbW9yZSBjb21wbGV4IG1hbmFnZW1lbnQgb2YKICAgICAgICAgLy8gJ21fY2hlY2tlZE9mZnNl
dCcsIHRvIGNhY2hlIHRoZSBvZmZzZXQgdXNlZCBpbiB0aGlzIGFsdGVybmF0aXZlLCB0byBhdm9p
ZAogICAgICAgICAvLyByZWNhbGN1bGF0aW5nIGl0LgotICAgICAgICBDaGVja2VkPHVuc2lnbmVk
PiBtX2NoZWNrQWRqdXN0OworICAgICAgICBDaGVja2VkPHVuc2lnbmVkLCBSZWNvcmRPdmVyZmxv
dz4gbV9jaGVja0FkanVzdDsKIAogICAgICAgICAvLyBVc2VkIGJ5IE9wTmVzdGVkQWx0ZXJuYXRp
dmVOZXh0L0VuZCB0byBob2xkIHRoZSBwb2ludGVyIHRvIHRoZQogICAgICAgICAvLyB2YWx1ZSB0
aGF0IHdpbGwgYmUgcHVzaGVkIGludG8gdGhlIHBhdHRlcm4ncyBmcmFtZSB0byByZXR1cm4gdG8s
CkBAIC0xNTgxLDcgKzE1ODEsNyBAQCBjbGFzcyBZYXJyR2VuZXJhdG9yIGZpbmFsIDogcHVibGlj
IFlhcnJKCiAgICAgICAgICAgICBvcC5tX2p1bXBzLmFwcGVuZChqdW1wSWZOb0F2YWlsYWJsZUlu
cHV0KCkpOwogCiAgICAgICAgIG1vdmUoaW5kZXgsIGNvdW50UmVnaXN0ZXIpOwotICAgICAgICBD
aGVja2VkPHVuc2lnbmVkPiBzY2FsZWRNYXhDb3VudCA9IHRlcm0tPnF1YW50aXR5TWF4Q291bnQ7
CisgICAgICAgIENoZWNrZWQ8dW5zaWduZWQsIFJlY29yZE92ZXJmbG93PiBzY2FsZWRNYXhDb3Vu
dCA9IHRlcm0tPnF1YW50aXR5TWF4Q291bnQ7CiAgICAgICAgIHNjYWxlZE1heENvdW50ICo9IFVf
SVNfQk1QKGNoKSA/IDEgOiAyOwogICAgICAgICBzdWIzMihJbW0zMihzY2FsZWRNYXhDb3VudC51
bnNhZmVHZXQoKSksIGNvdW50UmVnaXN0ZXIpOwogCkBAIC0xNzg5LDcgKzE3ODksNyBAQCBjbGFz
cyBZYXJyR2VuZXJhdG9yIGZpbmFsIDogcHVibGljIFlhcnJKCiAKICAgICAgICAgbW92ZShpbmRl
eCwgY291bnRSZWdpc3Rlcik7CiAKLSAgICAgICAgQ2hlY2tlZDx1bnNpZ25lZD4gc2NhbGVkTWF4
Q291bnQgPSB0ZXJtLT5xdWFudGl0eU1heENvdW50OworICAgICAgICBDaGVja2VkPHVuc2lnbmVk
LCBSZWNvcmRPdmVyZmxvdz4gc2NhbGVkTWF4Q291bnQgPSB0ZXJtLT5xdWFudGl0eU1heENvdW50
OwogCiAjaWZkZWYgSklUX1VOSUNPREVfRVhQUkVTU0lPTlMKICAgICAgICAgaWYgKG1fZGVjb2Rl
U3Vycm9nYXRlUGFpcnMgJiYgdGVybS0+Y2hhcmFjdGVyQ2xhc3MtPmhhc09ubHlOb25CTVBDaGFy
YWN0ZXJzKCkgJiYgIXRlcm0tPmludmVydCgpKQpAQCAtMjM2OSw3ICsyMzY5LDcgQEAgY2xhc3Mg
WWFyckdlbmVyYXRvciBmaW5hbCA6IHB1YmxpYyBZYXJySgogICAgICAgICAgICAgICAgIFBhdHRl
cm5EaXNqdW5jdGlvbiogZGlzanVuY3Rpb24gPSB0ZXJtLT5wYXJlbnRoZXNlcy5kaXNqdW5jdGlv
bjsKIAogICAgICAgICAgICAgICAgIC8vIENhbGN1bGF0ZSBob3cgbXVjaCBpbnB1dCB3ZSBuZWVk
IHRvIGNoZWNrIGZvciwgYW5kIGlmIG5vbi16ZXJvIGNoZWNrLgotICAgICAgICAgICAgICAgIG9w
Lm1fY2hlY2tBZGp1c3QgPSBDaGVja2VkPHVuc2lnbmVkPihhbHRlcm5hdGl2ZS0+bV9taW5pbXVt
U2l6ZSk7CisgICAgICAgICAgICAgICAgb3AubV9jaGVja0FkanVzdCA9IENoZWNrZWQ8dW5zaWdu
ZWQsIFJlY29yZE92ZXJmbG93PihhbHRlcm5hdGl2ZS0+bV9taW5pbXVtU2l6ZSk7CiAgICAgICAg
ICAgICAgICAgaWYgKCh0ZXJtLT5xdWFudGl0eVR5cGUgPT0gUXVhbnRpZmllckZpeGVkQ291bnQp
ICYmICh0ZXJtLT50eXBlICE9IFBhdHRlcm5UZXJtOjpUeXBlUGFyZW50aGV0aWNhbEFzc2VydGlv
bikpCiAgICAgICAgICAgICAgICAgICAgIG9wLm1fY2hlY2tBZGp1c3QgLT0gZGlzanVuY3Rpb24t
Pm1fbWluaW11bVNpemU7CiAgICAgICAgICAgICAgICAgaWYgKG9wLm1fY2hlY2tBZGp1c3QpCkBA
IC0yNzQ3LDYgKzI3NDcsOSBAQCBjbGFzcyBZYXJyR2VuZXJhdG9yIGZpbmFsIDogcHVibGljIFlh
cnJKCiAKICAgICAgICAgICAgICsrb3BJbmRleDsKICAgICAgICAgfSB3aGlsZSAob3BJbmRleCA8
IG1fb3BzLnNpemUoKSk7CisKKyAgICAgICAgaWYgKFVOTElLRUxZKG1fY2hlY2tlZE9mZnNldC5o
YXNPdmVyZmxvd2VkKCkpKQorICAgICAgICAgICAgbV9mYWlsdXJlUmVhc29uID0gSklURmFpbHVy
ZVJlYXNvbjo6T2Zmc2V0T3ZlcmZsb3dlZDsKICAgICB9CiAKICAgICB2b2lkIGJhY2t0cmFjaygp
CkBAIC0zNDA0LDYgKzM0MDcsOSBAQCBjbGFzcyBZYXJyR2VuZXJhdG9yIGZpbmFsIDogcHVibGlj
IFlhcnJKCiAgICAgICAgICAgICB9CiAKICAgICAgICAgfSB3aGlsZSAob3BJbmRleCk7CisKKyAg
ICAgICAgaWYgKFVOTElLRUxZKG1fY2hlY2tlZE9mZnNldC5oYXNPdmVyZmxvd2VkKCkpKQorICAg
ICAgICAgICAgbV9mYWlsdXJlUmVhc29uID0gSklURmFpbHVyZVJlYXNvbjo6T2Zmc2V0T3ZlcmZs
b3dlZDsKICAgICB9CiAKICAgICAvLyBDb21waWxhdGlvbiBtZXRob2RzOgpAQCAtMzk1Miw5ICsz
OTU4LDE3IEBAIHB1YmxpYzoKICAgICAgICAgICAgIG1vdmUoaW5kZXgsIGluaXRpYWxTdGFydCk7
CiAKICAgICAgICAgZ2VuZXJhdGUoKTsKKyAgICAgICAgaWYgKFVOTElLRUxZKG1fZmFpbHVyZVJl
YXNvbikpIHsKKyAgICAgICAgICAgIGNvZGVCbG9jay5zZXRGYWxsQmFja1dpdGhGYWlsdXJlUmVh
c29uKCptX2ZhaWx1cmVSZWFzb24pOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CiAg
ICAgICAgIGlmIChtX2Rpc2Fzc2VtYmxlcikKICAgICAgICAgICAgIG1fZGlzYXNzZW1ibGVyLT5z
ZXRFbmRPZkdlbmVyYXRlKGxhYmVsKCkpOwogICAgICAgICBiYWNrdHJhY2soKTsKKyAgICAgICAg
aWYgKFVOTElLRUxZKG1fZmFpbHVyZVJlYXNvbikpIHsKKyAgICAgICAgICAgIGNvZGVCbG9jay5z
ZXRGYWxsQmFja1dpdGhGYWlsdXJlUmVhc29uKCptX2ZhaWx1cmVSZWFzb24pOworICAgICAgICAg
ICAgcmV0dXJuOworICAgICAgICB9CiAgICAgICAgIGlmIChtX2Rpc2Fzc2VtYmxlcikKICAgICAg
ICAgICAgIG1fZGlzYXNzZW1ibGVyLT5zZXRFbmRPZkJhY2t0cmFjayhsYWJlbCgpKTsKIApAQCAt
NDI0MSw3ICs0MjU1LDcgQEAgcHJpdmF0ZToKICAgICAvLyBGSVhNRTogVGhpcyBzaG91bGQgZ28g
YXdheS4gUmF0aGVyIHRoYW4gdHJhY2tpbmcgdGhpcyB2YWx1ZSB0aHJvdWdob3V0CiAgICAgLy8g
Y29kZSBnZW5lcmF0aW9uLCB3ZSBzaG91bGQgZ2F0aGVyIHRoaXMgaW5mb3JtYXRpb24gdXAgZnJv
bnQgJiBzdG9yZSBpdAogICAgIC8vIG9uIHRoZSBZYXJyT3Agc3RydWN0dXJlLgotICAgIENoZWNr
ZWQ8dW5zaWduZWQ+IG1fY2hlY2tlZE9mZnNldDsKKyAgICBDaGVja2VkPHVuc2lnbmVkLCBSZWNv
cmRPdmVyZmxvdz4gbV9jaGVja2VkT2Zmc2V0OwogCiAgICAgLy8gVGhpcyBjbGFzcyByZWNvcmRz
IHN0YXRlIHdoaWxzdCBnZW5lcmF0aW5nIHRoZSBiYWNrdHJhY2tpbmcgcGF0aCBvZiBjb2RlLgog
ICAgIEJhY2t0cmFja2luZ1N0YXRlIG1fYmFja3RyYWNraW5nU3RhdGU7CkBAIC00Mjc2LDYgKzQy
OTAsOSBAQCBzdGF0aWMgdm9pZCBkdW1wQ29tcGlsZUZhaWx1cmUoSklURmFpbHVyCiAgICAgY2Fz
ZSBKSVRGYWlsdXJlUmVhc29uOjpFeGVjdXRhYmxlTWVtb3J5QWxsb2NhdGlvbkZhaWx1cmU6CiAg
ICAgICAgIGRhdGFMb2coIkNhbid0IEpJVCBiZWNhdXNlIG9mIGZhaWx1cmUgb2YgYWxsb2NhdGlv
biBvZiBleGVjdXRhYmxlIG1lbW9yeVxuIik7CiAgICAgICAgIGJyZWFrOworICAgIGNhc2UgSklU
RmFpbHVyZVJlYXNvbjo6T2Zmc2V0T3ZlcmZsb3dlZDoKKyAgICAgICAgZGF0YUxvZygiQ2FuJ3Qg
SklUIGJlY2F1c2UgYSBjaGVja2VkIG9mZnNldCBvdmVyZmxvd2VkXG4iKTsKKyAgICAgICAgYnJl
YWs7CiAgICAgfQogfQogCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUveWFyci9ZYXJySklU
LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3lhcnIvWWFyckpJVC5oCShy
ZXZpc2lvbiAyNzEwNzQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUveWFyci9ZYXJySklULmgJ
KHdvcmtpbmcgY29weSkKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDA5
LTIwMTggQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAy
MDA5LTIwMjAgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJp
YnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91
dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxv
d2luZyBjb25kaXRpb25zCkBAIC01Myw2ICs1Myw3IEBAIGVudW0gY2xhc3MgSklURmFpbHVyZVJl
YXNvbiA6IHVpbnQ4X3QgewogICAgIEZpeGVkQ291bnRQYXJlbnRoZXNpemVkU3VicGF0dGVybiwK
ICAgICBQYXJlbnRoZXNpc05lc3RlZFRvb0RlZXAsCiAgICAgRXhlY3V0YWJsZU1lbW9yeUFsbG9j
YXRpb25GYWlsdXJlLAorICAgIE9mZnNldE92ZXJmbG93ZWQsCiB9OwogCiBjbGFzcyBNYXRjaGlu
Z0NvbnRleHRIb2xkZXIgewo=
</data>
<flag name="review"
          id="434333"
          type_id="1"
          status="-"
          setter="msaboff"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>421381</attachid>
            <date>2021-02-23 18:17:53 -0800</date>
            <delta_ts>2021-02-23 21:00:36 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>220130-2.patch</filename>
            <type>text/plain</type>
            <size>3453</size>
            <attacher name="Michael Saboff">msaboff</attacher>
            
              <data encoding="base64">SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n
CShyZXZpc2lvbiAyNzMzNjYpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA
QCAtMSwzICsxLDE0IEBACisyMDIxLTAyLTIzICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBw
bGUuY29tPgorCisgICAgICAgIFtZQVJSIEpJVF0gQ3Jhc2ggb24gb3ZlcmZsb3cgd2hlbiBjb21w
aWxpbmcgLyhhezEwMDAwMDAwMDB9YnsxMDAwMDAwMDAwfXxjezEwMDAwMDAwMDB9fClkezEwMDAw
MDAwMDB9ZXsxMDAwMDAwMDAwfS8udGVzdCgpOworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIwMTMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgTW9kaWZpZWQgdGhlIG9yaWdpbmFsIGZ1enplciB0ZXN0IHRv
IGdvIDJeMzItMS4KKworICAgICAgICAqIHN0cmVzcy9yZWdleHAtYmFja3RyYWNrLW9mZnNldC1v
dmVyZmxvdy5qczogQWRkZWQuCisKIDIwMjEtMDItMjEgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21p
bGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgSW1wbGVtZW50IHRoZSBUb3AtbGV2ZWwgYXdhaXQg
cHJvcG9zYWwKSW5kZXg6IEpTVGVzdHMvc3RyZXNzL3JlZ2V4cC1iYWNrdHJhY2stb2Zmc2V0LW92
ZXJmbG93LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL3JlZ2V4cC1iYWNrdHJhY2st
b2Zmc2V0LW92ZXJmbG93LmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMvc3RyZXNzL3JlZ2V4
cC1iYWNrdHJhY2stb2Zmc2V0LW92ZXJmbG93LmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEs
MyBAQAorLy9AIHJ1bkRlZmF1bHQKKworLyhhezEwMDAwMDAwMDB9YnsxMDAwMDAwMDAwfXxjezEw
MDAwMDAwMDB9fClkezEwOTQ5NjcyOTV9ZXsxMDAwMDAwMDAwfS8udGVzdCgiYWJjIik7CkluZGV4
OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K
YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3MzM2NikKKysrIFNvdXJjZS9KYXZh
U2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAy
MS0wMi0yMyAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KKworICAgICAgICBb
WUFSUiBKSVRdIENyYXNoIG9uIG92ZXJmbG93IHdoZW4gY29tcGlsaW5nIC8oYXsxMDAwMDAwMDAw
fWJ7MTAwMDAwMDAwMH18Y3sxMDAwMDAwMDAwfXwpZHsxMDAwMDAwMDAwfWV7MTAwMDAwMDAwMH0v
LnRlc3QoKTsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTIyMDEzMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IENoYW5nZWQgY29kZSB0byBzdWJ0cmFjdCBvdXQgdGhlIG9mZnNldCBvZiBhIGN1cnJlbnQgb3Ag
YmVmb3JlIGFkZGluZyB0aGUgb2Zmc2V0CisgICAgICAgIG9mIHRoZSBwcmlvciBvcCB3aGVuIGJh
Y2t0cmFja2luZyB0byBhdm9pZCBvdmVyZmxvd2luZyBjaGVja2VkIGFyaXRobWV0aWMuCisgICAg
ICAgIEl0IGxvb2tzIGxpa2UgdGhlIGNvZGUgaGFkIHRoaXMgd3JvbmcgZm9yIHNvbWUgdGltZS4K
KworICAgICAgICAqIHlhcnIvWWFyckpJVC5jcHA6CisKIDIwMjEtMDItMjIgIERvbiBPbG1zdGVh
ZCAgPGRvbi5vbG1zdGVhZEBzb255LmNvbT4KIAogICAgICAgICBOb24tdW5pZmllZCBidWlsZCBm
aXhlcyBsYXRlIEZlYnJ1YXJ5IDIwMjEgZWRpdGlvbgpJbmRleDogU291cmNlL0phdmFTY3JpcHRD
b3JlL3lhcnIvWWFyckpJVC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl
L3lhcnIvWWFyckpJVC5jcHAJKHJldmlzaW9uIDI3MzM2NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0
Q29yZS95YXJyL1lhcnJKSVQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNzk1LDExICsyNzk1LDEx
IEBAIGNsYXNzIFlhcnJHZW5lcmF0b3IgZmluYWwgOiBwdWJsaWMgWWFyckoKICAgICAgICAgICAg
IGNhc2UgT3BCb2R5QWx0ZXJuYXRpdmVOZXh0OiB7CiAgICAgICAgICAgICAgICAgUGF0dGVybkFs
dGVybmF0aXZlKiBhbHRlcm5hdGl2ZSA9IG9wLm1fYWx0ZXJuYXRpdmU7CiAKKyAgICAgICAgICAg
ICAgICBtX2NoZWNrZWRPZmZzZXQgLT0gYWx0ZXJuYXRpdmUtPm1fbWluaW11bVNpemU7CiAgICAg
ICAgICAgICAgICAgaWYgKG9wLm1fb3AgPT0gT3BCb2R5QWx0ZXJuYXRpdmVOZXh0KSB7CiAgICAg
ICAgICAgICAgICAgICAgIFBhdHRlcm5BbHRlcm5hdGl2ZSogcHJpb3JBbHRlcm5hdGl2ZSA9IG1f
b3BzW29wLm1fcHJldmlvdXNPcF0ubV9hbHRlcm5hdGl2ZTsKICAgICAgICAgICAgICAgICAgICAg
bV9jaGVja2VkT2Zmc2V0ICs9IHByaW9yQWx0ZXJuYXRpdmUtPm1fbWluaW11bVNpemU7CiAgICAg
ICAgICAgICAgICAgfQotICAgICAgICAgICAgICAgIG1fY2hlY2tlZE9mZnNldCAtPSBhbHRlcm5h
dGl2ZS0+bV9taW5pbXVtU2l6ZTsKIAogICAgICAgICAgICAgICAgIC8vIElzIHRoaXMgdGhlIGxh
c3QgYWx0ZXJuYXRpdmU/IElmIG5vdCwgdGhlbiBpZiB3ZSBiYWNrdHJhY2sgdG8gdGhpcyBwb2lu
dCB3ZSBqdXN0CiAgICAgICAgICAgICAgICAgLy8gbmVlZCB0byBqdW1wIHRvIHRyeSB0byBtYXRj
aCB0aGUgbmV4dCBhbHRlcm5hdGl2ZS4KQEAgLTMxMDEsMTEgKzMxMDEsMTEgQEAgY2xhc3MgWWFy
ckdlbmVyYXRvciBmaW5hbCA6IHB1YmxpYyBZYXJySgogICAgICAgICAgICAgICAgICAgICBtX2Jh
Y2t0cmFja2luZ1N0YXRlLmFwcGVuZChlbmRPcC0+bV9qdW1wcyk7CiAgICAgICAgICAgICAgICAg
fQogCisgICAgICAgICAgICAgICAgbV9jaGVja2VkT2Zmc2V0IC09IG9wLm1fY2hlY2tBZGp1c3Q7
CiAgICAgICAgICAgICAgICAgaWYgKCFpc0JlZ2luKSB7CiAgICAgICAgICAgICAgICAgICAgIFlh
cnJPcCYgbGFzdE9wID0gbV9vcHNbb3AubV9wcmV2aW91c09wXTsKICAgICAgICAgICAgICAgICAg
ICAgbV9jaGVja2VkT2Zmc2V0ICs9IGxhc3RPcC5tX2NoZWNrQWRqdXN0OwogICAgICAgICAgICAg
ICAgIH0KLSAgICAgICAgICAgICAgICBtX2NoZWNrZWRPZmZzZXQgLT0gb3AubV9jaGVja0FkanVz
dDsKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIGNh
c2UgT3BTaW1wbGVOZXN0ZWRBbHRlcm5hdGl2ZUVuZDoK
</data>

          </attachment>
      

    </bug>

</bugzilla>