220129 2020-12-23 15:23:18 -0800 [ANGLE] Metal backend renders tdl.js samples as red 2021-01-06 14:52:31 -0800 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 126404 219759 220076 1 kpiddington kpiddington dino ews-watchlist graouts jdarpinian kbr kkinnunen kondapallykalyan webkit-bug-importer oldest_to_newest 1716515 0 kpiddington 2020-12-23 15:23:18 -0800 As reported by Ken Russell, TDL samples render a red background. The root cause of this issue is an incorrect color mask for a texture blit. Instead of all channels being blitted, ANGLE tries to blit only the colors present specified by glColorMask Blitting shouldn't be affected by the color mask. 1716516 1 416727 kpiddington 2020-12-23 15:24:42 -0800 Created attachment 416727 Patch 1716517 2 ews-watchlist 2020-12-23 15:25:32 -0800 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1716521 3 416727 kbr 2020-12-23 15:51:46 -0800 Comment on attachment 416727 Patch Fantastic find and fix Kyle! Verified locally that this fixes the WebGL Aquarium with the Metal backend. r+ 1716532 4 416727 kbr 2020-12-23 16:46:14 -0800 Comment on attachment 416727 Patch Passed EWS; let me CQ this before the tree closure. 1716534 5 ews-feeder 2020-12-23 17:00:57 -0800 Committed r271080: <https://trac.webkit.org/changeset/271080> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416727. 1716536 6 webkit-bug-importer 2020-12-23 17:03:22 -0800 <rdar://problem/72638743> 416727 2020-12-23 15:24:42 -0800 2020-12-23 17:00:58 -0800 Patch bug-220129-20201223152442.patch text/plain 1760 kpiddington U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxMDc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggMDM2ZThkZDlhMGRjMjY0M2RmZjgwMDQ3MmFiYjlmODQzNGE3Mjc2YS4uNzI3YTY3OWJjNzBi ZDllODIzYTVmYWM4Njg1MmQyZmI0YWJjMjdkNCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDEzIEBACisyMDIwLTEyLTIzICBLeWxlIFBpZGRpbmd0b24gIDxrcGlkZGlu Z3RvbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0FOR0xFXSBNZXRhbCBiYWNrZW5kIHJlbmRlcnMg dGRsLmpzIHNhbXBsZXMgYXMgcmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMjAxMjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHNyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9GcmFtZUJ1ZmZlck10 bC5tbToKKyAgICAgICAgKHJ4OjpGcmFtZWJ1ZmZlck10bDo6YmxpdFdpdGhEcmF3KToKKwogMjAy MC0xMi0yMiAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGdub21lLm9yZz4KIAogICAg ICAgICB3YXJuaW5nOiBlbnVtZXJhdGVkIGFuZCBub24tZW51bWVyYXRlZCB0eXBlIGluIGNvbmRp dGlvbmFsIGV4cHJlc3Npb24gaW4gQ29tcGlsZXIuY3BwCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhp cmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvRnJhbWVCdWZmZXJNdGwu bW0gYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwv RnJhbWVCdWZmZXJNdGwubW0KaW5kZXggZDcxZGU3MmQyZGQyNTFiMjhiYTZjYzlmZmZjMTE1MzNj MDFkMDJlMS4uMDk1OTQ4Yjc0MDRlNDgzMDc2OWI1ZmQ2Zjk5MjVkYjIyODc3M2UyYSAxMDA2NDQK LS0tIGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3JlbmRlcmVyL21ldGFs L0ZyYW1lQnVmZmVyTXRsLm1tCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJB TkdMRS9yZW5kZXJlci9tZXRhbC9GcmFtZUJ1ZmZlck10bC5tbQpAQCAtNDY4LDcgKzQ2OCw3IEBA IGFuZ2xlOjpSZXN1bHQgRnJhbWVidWZmZXJNdGw6OmJsaXRXaXRoRHJhdyhjb25zdCBnbDo6Q29u dGV4dCAqY29udGV4dCwKICAgICAgICAgY29sb3JCbGl0UGFyYW1zLnNyY0xldmVsID0gc3JjQ29s b3JSdC0+Z2V0TGV2ZWxJbmRleCgpOwogICAgICAgICBjb2xvckJsaXRQYXJhbXMuc3JjTGF5ZXIg PSBzcmNDb2xvclJ0LT5nZXRMYXllckluZGV4KCk7CiAKLSAgICAgICAgY29sb3JCbGl0UGFyYW1z LmJsaXRDb2xvck1hc2sgID0gY29udGV4dE10bC0+Z2V0Q29sb3JNYXNrKCk7CisgICAgICAgIGNv bG9yQmxpdFBhcmFtcy5ibGl0Q29sb3JNYXNrICA9IE1UTENvbG9yV3JpdGVNYXNrQWxsOwogICAg ICAgICBjb2xvckJsaXRQYXJhbXMuZW5hYmxlZEJ1ZmZlcnMgPSBnZXRTdGF0ZSgpLmdldEVuYWJs ZWREcmF3QnVmZmVycygpOwogICAgICAgICBjb2xvckJsaXRQYXJhbXMuZmlsdGVyICAgICAgICAg PSBmaWx0ZXI7CiAgICAgICAgIGNvbG9yQmxpdFBhcmFtcy5kc3RMdW1pbmFuY2UgICA9IHNyY0Nv bG9yUnQtPmdldEZvcm1hdCgpLT5hY3R1YWxBbmdsZUZvcm1hdCgpLmlzTFVNQSgpOwo=