220092 2020-12-22 10:46:34 -0800 Remove non-inclusive language from imported tests 2023-05-13 00:57:32 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified NEW InRadar P2 Normal --- 256752 213092 1 bdakin webkit-unassigned achristensen bdakin cdumez ggaren gsnedders simon.fraser webkit-bug-importer youennf oldest_to_newest 1716265 0 bdakin 2020-12-22 10:46:34 -0800 Currently if you run report-non-inclusive language --verbose in LayoutTests/imported, there are 135 occurrences of non-inclusive language, full results below. I tried importing new versions on the tests in the two most offending directories (w3c/web-platform-tests/tools/third_party/ and w3c/web-platform-tests/html/webappapis/), but updating these tests at this time does not reduce the number of non-inclusive terms at all. At least some of the changes we could make are trivial, and should be done so upstream and imported. http://web-platform-tests.org/writing-tests/lint-tool.html also shows that we can move from lint.whitelist to lint.ignore. I don't know enough to know if that is a change that we can make without importing new tests or not. Please advise! Full results below: w3c/web-platform-tests/README.md: whitelist: 1 w3c/web-platform-tests/tools/manifest/tests/test_manifest.py: blacklist: 1 w3c/web-platform-tests/tools/third_party/py/CHANGELOG: slave: 1 w3c/web-platform-tests/tools/third_party/py/doc/announce/release-1.2.0.txt: slave: 1 w3c/web-platform-tests/tools/third_party/py/doc/announce/release-1.3.0.txt: slave: 1 w3c/web-platform-tests/tools/third_party/py/doc/announce/release-1.3.2.txt: slave: 1 w3c/web-platform-tests/tools/third_party/h2/tox.ini: whitelist: 1 w3c/web-platform-tests/tools/third_party/h2/examples/fragments/client_https_setup_fragment.py: blacklist: 1 w3c/web-platform-tests/tools/third_party/h2/examples/fragments/server_https_setup_fragment.py: blacklist: 1 w3c/web-platform-tests/tools/third_party/attrs/tests/test_filters.py: blacklist: 2 w3c/web-platform-tests/tools/third_party/attrs/tests/test_filters.py: whitelist: 2 w3c/web-platform-tests/tools/third_party/attrs/src/attr/filters.py: blacklist: 2 w3c/web-platform-tests/tools/third_party/attrs/src/attr/filters.py: whitelist: 2 w3c/web-platform-tests/tools/third_party/pytest/tox.ini: whitelist: 1 w3c/web-platform-tests/tools/third_party/pytest/CHANGELOG.rst: blacklist: 1 w3c/web-platform-tests/tools/third_party/pytest/CHANGELOG.rst: slave: 3 w3c/web-platform-tests/tools/third_party/pytest/testing/test_resultlog.py: slave: 2 w3c/web-platform-tests/tools/third_party/pytest/testing/test_junitxml.py: slave: 3 w3c/web-platform-tests/tools/third_party/pytest/doc/en/funcarg_compare.rst: slave: 1 w3c/web-platform-tests/tools/third_party/pytest/doc/en/announce/release-2.6.1.rst: slave: 1 w3c/web-platform-tests/tools/third_party/pytest/doc/en/announce/release-2.3.5.rst: slave: 1 w3c/web-platform-tests/tools/third_party/pytest/doc/en/test/plugin/cov.rst: slave: 7 w3c/web-platform-tests/tools/third_party/pytest/_pytest/resultlog.py: slave: 2 w3c/web-platform-tests/tools/third_party/pytest/_pytest/runner.py: slave: 5 w3c/web-platform-tests/tools/third_party/pytest/_pytest/pastebin.py: slave: 1 w3c/web-platform-tests/tools/third_party/pytest/_pytest/junitxml.py: slave: 6 w3c/web-platform-tests/tools/third_party/pytest/_pytest/cacheprovider.py: slave: 1 w3c/web-platform-tests/tools/third_party/pytest/src/_pytest/resultlog.py: slave: 2 w3c/web-platform-tests/tools/third_party/pytest/src/_pytest/runner.py: slave: 5 w3c/web-platform-tests/tools/third_party/pytest/src/_pytest/pastebin.py: slave: 1 w3c/web-platform-tests/tools/third_party/pytest/src/_pytest/junitxml.py: slave: 6 w3c/web-platform-tests/tools/third_party/pytest/src/_pytest/cacheprovider.py: slave: 2 w3c/web-platform-tests/tools/third_party/html5lib/CHANGES.rst: whitelist: 1 w3c/web-platform-tests/tools/third_party/html5lib/benchmarks/data/html.html: blacklist: 1 w3c/web-platform-tests/tools/third_party/html5lib/benchmarks/data/html.html: whitelist: 4 w3c/web-platform-tests/tools/third_party/pluggy/pluggy/__init__.py: blacklist: 1 w3c/web-platform-tests/referrer-policy/README.md: blacklist: 3 w3c/web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/protocol-expected.txt: blacklist: 25 w3c/web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/protocol-expected.txt: whitelist: 15 w3c/web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/content-expected.txt: blacklist: 4 w3c/web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/content-expected.txt: whitelist: 5 w3c/web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/content/006.xhtml: blacklist: 1 w3c/web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/content/006-expected.txt: blacklist: 1 w3c/web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/protocol/006.xhtml: whitelist: 1 w3c/web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/protocol/006-expected.txt: whitelist: 1 w3c/web-platform-tests/xhr/access-control-basic-cors-safelisted-response-headers.htm: whitelist: 1 w3c/web-platform-tests/content-security-policy/style-src/stylenonce-allowed.sub-expected.txt: whitelist: 1 w3c/web-platform-tests/common/security-features/README.md: blacklist: 2 Total: 135 (blacklist: 46, whitelist: 36, slave: 53) 1716813 1 webkit-bug-importer 2020-12-29 10:47:13 -0800 <rdar://problem/72726292> 1717375 2 gsnedders 2021-01-05 10:11:49 -0800 What's in w3c/web-platform-tests/tools/third_party/ is slightly complicated because WPT has generally avoided forking the libraries we vendor in, even though we're largely on outdated versions (due to the necessity to support Python 2 for WebKit). All the expectation files in html/webappapis/system-state-and-capabilities/the-navigator-object/ seem to be orphaned, with no test associated with them, so those should just be deletable? Guess our current import script doesn't manage to delete them? Most of the rest seem to have been fixed upstream, at least. As for your question about lint.ignore: we can probably just apply https://github.com/web-platform-tests/wpt/commit/622c9625dddfdef0c6dfafa8fa00d5119db50201 locally? 1720069 3 bdakin 2021-01-15 16:08:48 -0800 Thanks for your reply, Sam! Some comments inline. (In reply to Sam Sneddon [:gsnedders] from comment #2) > What's in w3c/web-platform-tests/tools/third_party/ is slightly complicated > because WPT has generally avoided forking the libraries we vendor in, even > though we're largely on outdated versions (due to the necessity to support > Python 2 for WebKit). > I don't totally understand what this means, but my question is below. > All the expectation files in > html/webappapis/system-state-and-capabilities/the-navigator-object/ seem to > be orphaned, with no test associated with them, so those should just be > deletable? Guess our current import script doesn't manage to delete them? > Perhaps I'll post a patch for this shortly, or anyone else can if they get to it first. > Most of the rest seem to have been fixed upstream, at least. > Are the tests in w3c/web-platform-tests/tools/third_party/ also fixed upstream? Does our dependency on Python 2 make it difficult to update our copy? For all tests or just for those in third_party? > As for your question about lint.ignore: we can probably just apply > https://github.com/web-platform-tests/wpt/commit/ > 622c9625dddfdef0c6dfafa8fa00d5119db50201 locally? Perhaps I'll post a patch for this shortly, or anyone else can if they get to it first. 1955210 4 annevk 2023-05-13 00:57:32 -0700 % report-non-inclusive-language --verbose tools/manifest/tests/test_manifest.py: blacklist: 1 tools/third_party/py/CHANGELOG.rst: slave: 1 tools/third_party/py/doc/announce/release-1.2.0.txt: slave: 1 tools/third_party/py/doc/announce/release-1.3.0.txt: slave: 1 tools/third_party/py/doc/announce/release-1.3.2.txt: slave: 1 tools/third_party/h2/tox.ini: whitelist: 2 tools/third_party/attrs/pyproject.toml: whitelist: 1 tools/third_party/pytest/tox.ini: whitelist: 1 tools/third_party/pytest/doc/en/changelog.rst: blacklist: 1 tools/third_party/pytest/doc/en/changelog.rst: slave: 1 tools/third_party/pytest/doc/en/reference/reference.rst: whitelist: 1 tools/third_party/html5lib/CHANGES.rst: whitelist: 1 tools/third_party/html5lib/benchmarks/data/html.html: blacklist: 1 tools/third_party/html5lib/benchmarks/data/html.html: whitelist: 4 tools/third_party/typing_extensions/src/typing_extensions.py: whitelist: 3 _venv3/lib/python3.10/site-packages/pip/_internal/operations/check.py: whitelist: 4 _venv3/lib/python3.10/site-packages/pip/_vendor/typing_extensions.py: whitelist: 2 _venv3/lib/python3.10/site-packages/pip/_vendor/urllib3/util/retry.py: blacklist: 5 _venv3/lib/python3.10/site-packages/pip/_vendor/urllib3/util/retry.py: whitelist: 23 _venv3/lib/python3.10/site-packages/yaml/constructor.py: blacklist: 8 _venv3/lib/python3.10/site-packages/setuptools/_vendor/typing_extensions.py: whitelist: 3 _venv3/lib/python3.10/site-packages/pkg_resources/_vendor/typing_extensions.py: whitelist: 2 Total: 68 (blacklist: 16, whitelist: 47, slave: 5) Is what I get upstream. I filed https://github.com/web-platform-tests/wpt/issues/39998. I filed bug 213092 on what we can address in WebKit directly and created a PR for that.