<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>220082</bug_id>
          
          <creation_ts>2020-12-22 02:17:27 -0800</creation_ts>
          <short_desc>[CMake] Fix seperated include dir of harfbuzz and harfbuzz-icu</short_desc>
          <delta_ts>2020-12-23 08:53:24 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CMake</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="monson">holymonson</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>achristensen</cc>
    
    <cc>annulen</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>fujii</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>ryuan.choi</cc>
    
    <cc>sergio</cc>
    
    <cc>smoley</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1716188</commentid>
    <comment_count>0</comment_count>
    <who name="monson">holymonson</who>
    <bug_when>2020-12-22 02:17:27 -0800</bug_when>
    <thetext>[CMake] Fix seperated include dir of harfbuzz and harfbuzz-icu</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1716191</commentid>
    <comment_count>1</comment_count>
      <attachid>416657</attachid>
    <who name="monson">holymonson</who>
    <bug_when>2020-12-22 02:28:08 -0800</bug_when>
    <thetext>Created attachment 416657
Patch

In some distros (NixOS) harfbuzz and harfbuzz-icu may have different include dir.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1716279</commentid>
    <comment_count>2</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-12-22 11:18:19 -0800</bug_when>
    <thetext>&lt;rdar://problem/72593922&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1716427</commentid>
    <comment_count>3</comment_count>
      <attachid>416657</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2020-12-22 19:53:48 -0800</bug_when>
    <thetext>Comment on attachment 416657
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416657&amp;action=review

LGTM.

&gt; ChangeLog:6
&gt; +        Reviewed by NOBODY (OOPS!).

Could you add your comment#2 in the ChangeLog?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1716445</commentid>
    <comment_count>4</comment_count>
      <attachid>416708</attachid>
    <who name="monson">holymonson</who>
    <bug_when>2020-12-23 04:12:39 -0800</bug_when>
    <thetext>Created attachment 416708
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1716456</commentid>
    <comment_count>5</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-12-23 08:53:22 -0800</bug_when>
    <thetext>Committed r271069: &lt;https://trac.webkit.org/changeset/271069&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416708.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>416657</attachid>
            <date>2020-12-22 02:28:08 -0800</date>
            <delta_ts>2020-12-23 04:12:27 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-220082-20201222182810.patch</filename>
            <type>text/plain</type>
            <size>2165</size>
            <attacher name="monson">holymonson</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxMDQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu
ZEhhcmZCdXp6LmNtYWtlIGIvU291cmNlL2NtYWtlL0ZpbmRIYXJmQnV6ei5jbWFrZQppbmRleCA0
NDlmOGMxNzBiMWZlMmQ0N2FhMzYwOGEyNmZiYjQzMWU4MWQzMDBmLi5hMDI5NmYzMjEyYjg2OTAy
MTlmOTRlMmQwZTYzODQyN2M1NzFhMDlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvRmluZEhh
cmZCdXp6LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kSGFyZkJ1enouY21ha2UKQEAgLTEw
Nyw2ICsxMDcsMTIgQEAgaWYgKCJJQ1UiIElOX0xJU1QgSGFyZkJ1enpfRklORF9DT01QT05FTlRT
KQogICAgIHBrZ19jaGVja19tb2R1bGVzKFBDX0hBUkZCVVpaX0lDVSBRVUlFVCBoYXJmYnV6ei1p
Y3UpCiAgICAgc2V0KEhhcmZCdXp6X0lDVV9DT01QSUxFX09QVElPTlMgJHtQQ19IQVJGQlVaWl9J
Q1VfQ0ZMQUdTX09USEVSfSkKIAorICAgIGZpbmRfcGF0aChIYXJmQnV6el9JQ1VfSU5DTFVERV9E
SVIKKyAgICAgICAgTkFNRVMgaGItaWN1LmgKKyAgICAgICAgSElOVFMgJHtQQ19IQVJGQlVaWl9J
Q1VfSU5DTFVERURJUn0gJHtQQ19IQVJGQlVaWl9JQ1VfSU5DTFVERV9ESVJTfQorICAgICAgICBQ
QVRIX1NVRkZJWEVTIGhhcmZidXp6CisgICAgKQorCiAgICAgZmluZF9saWJyYXJ5KEhhcmZCdXp6
X0lDVV9MSUJSQVJZCiAgICAgICAgIE5BTUVTICR7SGFyZkJ1enpfSUNVX05BTUVTfSBoYXJmYnV6
ei1pY3UKICAgICAgICAgSElOVFMgJHtQQ19IQVJGQlVaWl9JQ1VfTElCRElSfSAke1BDX0hBUkZC
VVpaX0lDVV9MSUJSQVJZX0RJUlN9CkBAIC0xNjQsMTcgKzE3MCwxOCBAQCBpZiAoSGFyZkJ1enpf
SUNVX0xJQlJBUlkgQU5EIE5PVCBUQVJHRVQgSGFyZkJ1eno6OklDVSkKICAgICBzZXRfdGFyZ2V0
X3Byb3BlcnRpZXMoSGFyZkJ1eno6OklDVSBQUk9QRVJUSUVTCiAgICAgICAgIElNUE9SVEVEX0xP
Q0FUSU9OICIke0hhcmZCdXp6X0lDVV9MSUJSQVJZfSIKICAgICAgICAgSU5URVJGQUNFX0NPTVBJ
TEVfT1BUSU9OUyAiJHtIYXJmQnV6el9JQ1VfQ09NUElMRV9PUFRJT05TfSIKLSAgICAgICAgSU5U
RVJGQUNFX0lOQ0xVREVfRElSRUNUT1JJRVMgIiR7SGFyZkJ1enpfSU5DTFVERV9ESVJ9IgorICAg
ICAgICBJTlRFUkZBQ0VfSU5DTFVERV9ESVJFQ1RPUklFUyAiJHtIYXJmQnV6el9JQ1VfSU5DTFVE
RV9ESVJ9IgogICAgICkKIGVuZGlmICgpCiAKIG1hcmtfYXNfYWR2YW5jZWQoCiAgICAgSGFyZkJ1
enpfSU5DTFVERV9ESVIKKyAgICBIYXJmQnV6el9JQ1VfSU5DTFVERV9ESVIKICAgICBIYXJmQnV6
el9MSUJSQVJZCiAgICAgSGFyZkJ1enpfSUNVX0xJQlJBUlkKICkKIAogaWYgKEhhcmZCdXp6X0ZP
VU5EKQogICAgc2V0KEhhcmZCdXp6X0xJQlJBUklFUyAke0hhcmZCdXp6X0xJQlJBUll9ICR7SGFy
ZkJ1enpfSUNVX0xJQlJBUll9KQotICAgc2V0KEhhcmZCdXp6X0lOQ0xVREVfRElSUyAke0hhcmZC
dXp6X0lOQ0xVREVfRElSfSkKKyAgIHNldChIYXJmQnV6el9JTkNMVURFX0RJUlMgJHtIYXJmQnV6
el9JTkNMVURFX0RJUn0gJHtIYXJmQnV6el9JQ1VfSU5DTFVERV9ESVJ9KQogZW5kaWYgKCkKZGlm
ZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAxMmYwNDgwZTQ4Y2U1OWY0NGY4
MTBkZmY0N2U4MjFjNjdhYzgxMWRiLi5iZmQ5YzQyMWQyNGEwNzVhNTE1YzhlYjRhNzZjMzUwNDc4
MjczNWQ0IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs
MTIgQEAKKzIwMjAtMTItMjIgIE1vbnNvbiBTaGFvICA8aG9seW1vbnNvbkBnbWFpbC5jb20+CisK
KyAgICAgICAgW0NNYWtlXSBGaXggc2VwZXJhdGVkIGluY2x1ZGUgZGlyIG9mIGhhcmZidXp6IGFu
ZCBoYXJmYnV6ei1pY3UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTIyMDA4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgICogU291cmNlL2NtYWtlL0ZpbmRIYXJmQnV6ei5jbWFrZToKKwogMjAyMC0xMi0yMSAg
UnlhbiBIb3N0ZXRsZXIgIDxyaG9zdEBhcHBsZS5jb20+CiAKICAgICAgICAgJChmaW5kc3RyaW5n
IGlwaG9uZSwkKFNES1JPT1QpKSBmYWlscyB3aGVuIFNES1JPT1QgaXMgbm90IGxvd2VyY2FzZQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>416708</attachid>
            <date>2020-12-23 04:12:39 -0800</date>
            <delta_ts>2020-12-23 08:53:23 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-220082-20201223201238.patch</filename>
            <type>text/plain</type>
            <size>2258</size>
            <attacher name="monson">holymonson</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxMDQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu
ZEhhcmZCdXp6LmNtYWtlIGIvU291cmNlL2NtYWtlL0ZpbmRIYXJmQnV6ei5jbWFrZQppbmRleCA0
NDlmOGMxNzBiMWZlMmQ0N2FhMzYwOGEyNmZiYjQzMWU4MWQzMDBmLi5hMDI5NmYzMjEyYjg2OTAy
MTlmOTRlMmQwZTYzODQyN2M1NzFhMDlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvRmluZEhh
cmZCdXp6LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kSGFyZkJ1enouY21ha2UKQEAgLTEw
Nyw2ICsxMDcsMTIgQEAgaWYgKCJJQ1UiIElOX0xJU1QgSGFyZkJ1enpfRklORF9DT01QT05FTlRT
KQogICAgIHBrZ19jaGVja19tb2R1bGVzKFBDX0hBUkZCVVpaX0lDVSBRVUlFVCBoYXJmYnV6ei1p
Y3UpCiAgICAgc2V0KEhhcmZCdXp6X0lDVV9DT01QSUxFX09QVElPTlMgJHtQQ19IQVJGQlVaWl9J
Q1VfQ0ZMQUdTX09USEVSfSkKIAorICAgIGZpbmRfcGF0aChIYXJmQnV6el9JQ1VfSU5DTFVERV9E
SVIKKyAgICAgICAgTkFNRVMgaGItaWN1LmgKKyAgICAgICAgSElOVFMgJHtQQ19IQVJGQlVaWl9J
Q1VfSU5DTFVERURJUn0gJHtQQ19IQVJGQlVaWl9JQ1VfSU5DTFVERV9ESVJTfQorICAgICAgICBQ
QVRIX1NVRkZJWEVTIGhhcmZidXp6CisgICAgKQorCiAgICAgZmluZF9saWJyYXJ5KEhhcmZCdXp6
X0lDVV9MSUJSQVJZCiAgICAgICAgIE5BTUVTICR7SGFyZkJ1enpfSUNVX05BTUVTfSBoYXJmYnV6
ei1pY3UKICAgICAgICAgSElOVFMgJHtQQ19IQVJGQlVaWl9JQ1VfTElCRElSfSAke1BDX0hBUkZC
VVpaX0lDVV9MSUJSQVJZX0RJUlN9CkBAIC0xNjQsMTcgKzE3MCwxOCBAQCBpZiAoSGFyZkJ1enpf
SUNVX0xJQlJBUlkgQU5EIE5PVCBUQVJHRVQgSGFyZkJ1eno6OklDVSkKICAgICBzZXRfdGFyZ2V0
X3Byb3BlcnRpZXMoSGFyZkJ1eno6OklDVSBQUk9QRVJUSUVTCiAgICAgICAgIElNUE9SVEVEX0xP
Q0FUSU9OICIke0hhcmZCdXp6X0lDVV9MSUJSQVJZfSIKICAgICAgICAgSU5URVJGQUNFX0NPTVBJ
TEVfT1BUSU9OUyAiJHtIYXJmQnV6el9JQ1VfQ09NUElMRV9PUFRJT05TfSIKLSAgICAgICAgSU5U
RVJGQUNFX0lOQ0xVREVfRElSRUNUT1JJRVMgIiR7SGFyZkJ1enpfSU5DTFVERV9ESVJ9IgorICAg
ICAgICBJTlRFUkZBQ0VfSU5DTFVERV9ESVJFQ1RPUklFUyAiJHtIYXJmQnV6el9JQ1VfSU5DTFVE
RV9ESVJ9IgogICAgICkKIGVuZGlmICgpCiAKIG1hcmtfYXNfYWR2YW5jZWQoCiAgICAgSGFyZkJ1
enpfSU5DTFVERV9ESVIKKyAgICBIYXJmQnV6el9JQ1VfSU5DTFVERV9ESVIKICAgICBIYXJmQnV6
el9MSUJSQVJZCiAgICAgSGFyZkJ1enpfSUNVX0xJQlJBUlkKICkKIAogaWYgKEhhcmZCdXp6X0ZP
VU5EKQogICAgc2V0KEhhcmZCdXp6X0xJQlJBUklFUyAke0hhcmZCdXp6X0xJQlJBUll9ICR7SGFy
ZkJ1enpfSUNVX0xJQlJBUll9KQotICAgc2V0KEhhcmZCdXp6X0lOQ0xVREVfRElSUyAke0hhcmZC
dXp6X0lOQ0xVREVfRElSfSkKKyAgIHNldChIYXJmQnV6el9JTkNMVURFX0RJUlMgJHtIYXJmQnV6
el9JTkNMVURFX0RJUn0gJHtIYXJmQnV6el9JQ1VfSU5DTFVERV9ESVJ9KQogZW5kaWYgKCkKZGlm
ZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAxMmYwNDgwZTQ4Y2U1OWY0NGY4
MTBkZmY0N2U4MjFjNjdhYzgxMWRiLi43ZDFiMjcxMGM1NTYzZTA1YTcyMmFiOGMwZmYzYTM5YTAx
N2EwMDE2IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs
MTQgQEAKKzIwMjAtMTItMjMgIE1vbnNvbiBTaGFvICA8aG9seW1vbnNvbkBnbWFpbC5jb20+CisK
KyAgICAgICAgW0NNYWtlXSBGaXggc2VwZXJhdGVkIGluY2x1ZGUgZGlyIG9mIGhhcmZidXp6IGFu
ZCBoYXJmYnV6ei1pY3UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTIyMDA4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgIEluIHNvbWUgZGlzdHJvcyAoTml4T1MpIGhhcmZidXp6IGFuZCBoYXJmYnV6ei1pY3Ug
bWF5IGhhdmUgZGlmZmVyZW50IGluY2x1ZGUgZGlyLgorCisgICAgICAgICogU291cmNlL2NtYWtl
L0ZpbmRIYXJmQnV6ei5jbWFrZToKKwogMjAyMC0xMi0yMSAgUnlhbiBIb3N0ZXRsZXIgIDxyaG9z
dEBhcHBsZS5jb20+CiAKICAgICAgICAgJChmaW5kc3RyaW5nIGlwaG9uZSwkKFNES1JPT1QpKSBm
YWlscyB3aGVuIFNES1JPT1QgaXMgbm90IGxvd2VyY2FzZQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>