220075 2020-12-21 15:42:07 -0800 Layout overflow is computed incorrectly inside flexbox (breaks sticky positioning) 2020-12-22 08:09:29 -0800 1 1 1 Unclassified WebKit Layout and Rendering Safari Technology Preview Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=116689 InRadar P2 Normal --- 1 simon.fraser simon.fraser bfulgham changseok clopez esprehn+autocc ews-watchlist glenn jfernandez kondapallykalyan pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1716118 0 416639 simon.fraser 2020-12-21 15:42:07 -0800 Created attachment 416639 Testcase In the attached testcase, the sticky element gets pushed out of view as you scroll down and should not. In RenderBoxModelObject::computeStickyPositionConstraints(), containingBlock->layoutOverflowRect() returns a rect that is too short, but only when inside flex layout. 1716119 1 simon.fraser 2020-12-21 15:43:00 -0800 <rdar://problem/70956639> 1716157 2 416648 simon.fraser 2020-12-21 19:58:36 -0800 Created attachment 416648 Patch 1716219 3 ews-feeder 2020-12-22 08:09:28 -0800 Committed r271053: <https://trac.webkit.org/changeset/271053> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416648. 416639 2020-12-21 15:42:07 -0800 2020-12-21 15:42:07 -0800 Testcase sticky-in-flex.html text/html 683 simon.fraser PCFET0NUWVBFIGh0bWw+CjxodG1sIGxhbmc9ImVuIiA+CjxoZWFkPgoJPG1ldGEgY2hhcnNldD0i VVRGLTgiPgoJPHRpdGxlPlN0aWNreSBUZXN0IENhc2U8L3RpdGxlPgo8c3R5bGU+Cmh0bWwgewoJ aGVpZ2h0OiAxMDAlOwp9Cgpib2R5IHsKCWRpc3BsYXk6IGZsZXg7CglmbGV4LWRpcmVjdGlvbjog Y29sdW1uOwoJaGVpZ2h0OiA4MCU7CgltYXJnaW46IDA7CglwYWRkaW5nOiAwOwp9CgouY29udGFp bmVyIHsKICAgIGJvcmRlcjogMXB4IHNvbGlkIGJsYWNrOwogICAgd2lkdGg6IDUwMHB4OwogICAg aGVpZ2h0OiA1MDBweDsKICAgIG1hcmdpbjogMjBweDsKCWZsZXg6IDEgMSAwOwoJb3ZlcmZsb3c6 IGF1dG87Cn0KCi5oZWFkZXIgewoJcG9zaXRpb246IHN0aWNreTsKCXRvcDogMDsKCWJhY2tncm91 bmQ6IGdvbGQ7Cn0KCi5jb250ZW50IHsKCWhlaWdodDogMjUwMHB4OwogICAgYmFja2dyb3VuZC1p bWFnZTogcmVwZWF0aW5nLWxpbmVhci1ncmFkaWVudCh3aGl0ZSwgc2lsdmVyIDMwMHB4KTsKfQo8 L3N0eWxlPgo8L2hlYWQ+Cjxib2R5PgoKPGRpdiBjbGFzcz0iY29udGFpbmVyIj4KCTxkaXYgY2xh c3M9ImhlYWRlciI+PGI+VEhJUyBFTEVNRU5UIFNIT1VMRCBSRU1BSU4gU1RJQ0tZPC9iPjwvZGl2 PgoJPGRpdiBjbGFzcz0iY29udGVudCI+Cgk8L2Rpdj4KPC9kaXY+CjwvYm9keT4KPC9odG1sPgo= 416648 2020-12-21 19:58:36 -0800 2020-12-22 08:09:29 -0800 Patch bug-220075-20201221195835.patch text/plain 4756 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxMDIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjJhODI5ZWZkYTY4ZTAx Y2I5YjE5NThlZDUzYzkwODQ5YmViODJkYy4uNDcyZDQzNzYwNjUwZmIwMmY4ZGNlNjVlMTQzNzhj ODNkOGJlMTM4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDIwLTEyLTIxICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIExheW91dCBvdmVy ZmxvdyBpcyBjb21wdXRlZCBpbmNvcnJlY3RseSBpbnNpZGUgZmxleGJveCAoYnJlYWtzIHN0aWNr eSBwb3NpdGlvbmluZykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIyMDA3NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzA5NTY2Mzk+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVuZGVyQmxvY2s6OmVu ZEFuZENvbW1pdFVwZGF0ZVNjcm9sbEluZm9BZnRlckxheW91dFRyYW5zYWN0aW9uKCksIHdoaWNo IGlzIG9ubHkgY2FsbGVkIGJ5IGdyaWQKKyAgICAgICAgYW5kIGZsZXhib3ggbGF5b3V0LCB3b3Vs ZCB1bmNvbmRpdGlvbmFsbHkgY2xlYXIgbGF5b3V0IG92ZXJmbG93IG9uIGJveGVzIHdpdGggb3Zl cmZsb3cgY2xpcHBpbmcsCisgICAgICAgIHdoaWNoIHJlc3VsdGVkIGluIGluY29ycmVjdCBzdGlj a3kgcG9zaXRpb25pbmcgYmVjYXVzZSBSZW5kZXJCb3hNb2RlbE9iamVjdDo6Y29tcHV0ZVN0aWNr eVBvc2l0aW9uQ29uc3RyYWludHMoKQorICAgICAgICBjb25zdWx0cyBsYXlvdXQgb3ZlcmZsb3cu CisKKyAgICAgICAgSXQgd2FzIG9ubHkgdGhyb3VnaCBoYXBwZW5zdGFuY2UgdGhhdCBvdmVyZmxv dzpzY3JvbGwgd29ya2VkIGNvcnJlY3RseSwgcmVseWluZyBvbiB0aGUgZmFjdAorICAgICAgICB0 aGF0IHVwZGF0ZVNjcm9sbEluZm9BZnRlckxheW91dCgpIHdvdWxkIHRyaWdnZXIgY2FjaGluZyBv ZiBzY3JvbGwgZGltZW5zaW9ucyBvbiBSZW5kZXJMYXllci4KKworICAgICAgICBUaGlzIGNsZWFy aW5nIHdhcyBhZGRlZCBpbiByMTUxMzYwIGJ1dCBzZWVtcyBpbmNvcnJlY3Q7IGxheW91dCBvdmVy ZmxvdyBzaG91bGQgYmUgcHJlc2VydmVkCisgICAgICAgIGFmdGVyIGxheW91dC4KKworICAgICAg ICBUZXN0OiBmYXN0L2ZsZXhib3gvcHJlc2VydmUtbGF5b3V0LW92ZXJmbG93Lmh0bWwKKworICAg ICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9jay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5k ZXJCbG9jazo6ZW5kQW5kQ29tbWl0VXBkYXRlU2Nyb2xsSW5mb0FmdGVyTGF5b3V0VHJhbnNhY3Rp b24pOgorCiAyMDIwLTEyLTIxICBBZGl0eWEgS2VlcnRoaSAgPGFrZWVydGhpQGFwcGxlLmNvbT4K IAogICAgICAgICBSRUdSRVNTSU9OIChyMjYyNzI5KTogUG9vciBjb250cmFzdCBmb3Igc3BlY2lm aWMgY29sb3IvYmFja2dyb3VuZCBjb21iaW5hdGlvbnMgb24gZGlzYWJsZWQgaW5wdXQgZmllbGRz CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAppbmRleCA4YTdmODk2NmI3 YzViNzU1YjJkNGE2ZDA3ZDQ0N2MyOTIyNjEzMTNkLi44Y2FiNzZhZmU1N2QwN2ZhN2Q2YmI2YTQx MzliM2U5NTNjYTFjZjM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyQmxvY2suY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5j cHAKQEAgLTU1NCw3ICs1NTQsNiBAQCB2b2lkIFJlbmRlckJsb2NrOjplbmRBbmRDb21taXRVcGRh dGVTY3JvbGxJbmZvQWZ0ZXJMYXlvdXRUcmFuc2FjdGlvbigpCiAgICAgZm9yIChhdXRvKiBibG9j ayA6IGJsb2Nrc1RvVXBkYXRlKSB7CiAgICAgICAgIEFTU0VSVChibG9jay0+aGFzT3ZlcmZsb3dD bGlwKCkpOwogICAgICAgICBibG9jay0+bGF5ZXIoKS0+dXBkYXRlU2Nyb2xsSW5mb0FmdGVyTGF5 b3V0KCk7Ci0gICAgICAgIGJsb2NrLT5jbGVhckxheW91dE92ZXJmbG93KCk7CiAgICAgfQogfQog CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKaW5kZXggYWQ1NzQ3M2M4NjI1MGFhN2UyNGQ4ODY5ZDJmMjgzY2IwZmZhYmYyYi4uNDE5NzBk ODI5YTU4M2JhNGYwYjBjYTQ2NGU2ODM5MGY1N2NkZGViMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBA CisyMDIwLTEyLTIxICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisg ICAgICAgIExheW91dCBvdmVyZmxvdyBpcyBjb21wdXRlZCBpbmNvcnJlY3RseSBpbnNpZGUgZmxl eGJveCAoYnJlYWtzIHN0aWNreSBwb3NpdGlvbmluZykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMDA3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9mbGV4Ym94L3ByZXNlcnZlLWxheW91dC1v dmVyZmxvdy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZmxleGJveC9wcmVz ZXJ2ZS1sYXlvdXQtb3ZlcmZsb3cuaHRtbDogQWRkZWQuCisKIDIwMjAtMTItMjEgIEFkaXR5YSBL ZWVydGhpICA8YWtlZXJ0aGlAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIyNjI3 MjkpOiBQb29yIGNvbnRyYXN0IGZvciBzcGVjaWZpYyBjb2xvci9iYWNrZ3JvdW5kIGNvbWJpbmF0 aW9ucyBvbiBkaXNhYmxlZCBpbnB1dCBmaWVsZHMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zh c3QvZmxleGJveC9wcmVzZXJ2ZS1sYXlvdXQtb3ZlcmZsb3ctZXhwZWN0ZWQudHh0IGIvTGF5b3V0 VGVzdHMvZmFzdC9mbGV4Ym94L3ByZXNlcnZlLWxheW91dC1vdmVyZmxvdy1leHBlY3RlZC50eHQK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uNjM3OTY4ZTI4YjA3OGNmMWIzZDA1YzhiN2U4OTMyMzdlZDBjNmNlOAotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZmxleGJveC9wcmVzZXJ2ZS1sYXlvdXQt b3ZlcmZsb3ctZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsOCBAQAorbGF5ZXIgYXQgKDAsMCkgc2l6 ZSA4MDB4NjAwCisgIFJlbmRlclZpZXcgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCitsYXllciBhdCAo MCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVyQmxvY2sge0hUTUx9IGF0ICgwLDApIHNpemUgODAw eDYwMAorICAgIFJlbmRlckZsZXhpYmxlQm94IHtCT0RZfSBhdCAoOCw4KSBzaXplIDYyMng1MjIg W2JvcmRlcjogKDFweCBzb2xpZCAjMDAwMDAwKV0KK2xheWVyIGF0ICgzOSwzOSkgc2l6ZSA0MDJ4 NDYwIGNsaXAgYXQgKDQwLDQwKSBzaXplIDM4NXg0NDMgc2Nyb2xsSGVpZ2h0IDI1MDAKKyAgUmVu ZGVyQmxvY2sge0RJVn0gYXQgKDMxLDMxKSBzaXplIDQwMng0NjAgW2JvcmRlcjogKDFweCBzb2xp ZCAjMDAwMDAwKV0gKGxheW91dCBvdmVyZmxvdyAxLDEgMzg1eDI1MDApCisgICAgUmVuZGVyQmxv Y2sge0RJVn0gYXQgKDEsMSkgc2l6ZSAzODV4MjUwMApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC9mbGV4Ym94L3ByZXNlcnZlLWxheW91dC1vdmVyZmxvdy5odG1sIGIvTGF5b3V0VGVzdHMv ZmFzdC9mbGV4Ym94L3ByZXNlcnZlLWxheW91dC1vdmVyZmxvdy5odG1sCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjhm ODViZWE2ZWM0M2Q2MThmZmU4OWExMjY0ZWQ2NTk5ZGIzMTEzZmUKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9mYXN0L2ZsZXhib3gvcHJlc2VydmUtbGF5b3V0LW92ZXJmbG93Lmh0bWwK QEAgLTAsMCArMSw0MSBAQAorPCFET0NUWVBFIGh0bWw+Cis8aGVhZD4KKzxzdHlsZT4KK2h0bWwg eworCWhlaWdodDogMTAwJTsKK30KKworYm9keSB7CisJZGlzcGxheTogZmxleDsKKwlmbGV4LWRp cmVjdGlvbjogY29sdW1uOworCXdpZHRoOiA2MDBweDsKKyAgICBoZWlnaHQ6IDUwMHB4OworICAg IHBhZGRpbmc6IDEwcHg7CisgICAgYm9yZGVyOiAxcHggc29saWQgYmxhY2s7Cit9CisKKy5jb250 YWluZXIgeworICAgIHdpZHRoOiA0MDBweDsKKyAgICBoZWlnaHQ6IDM0MHB4OworICAgIG1hcmdp bjogMjBweDsKKwlmbGV4OiAxIDEgMDsKKwlvdmVyZmxvdzogc2Nyb2xsOworICAgIGJvcmRlcjog MXB4IHNvbGlkIGJsYWNrOworfQorCisuY29udGVudCB7CisJaGVpZ2h0OiAyNTAwcHg7CisgICAg YmFja2dyb3VuZC1pbWFnZTogcmVwZWF0aW5nLWxpbmVhci1ncmFkaWVudCh3aGl0ZSwgc2lsdmVy IDMwMHB4KTsKK30KKzwvc3R5bGU+Cis8c2NyaXB0PgorICAgIGlmICh3aW5kb3cudGVzdFJ1bm5l cikKKyAgICAgICAgdGVzdFJ1bm5lci5zZXRSZW5kZXJUcmVlRHVtcE9wdGlvbnModGVzdFJ1bm5l ci5SRU5ERVJfVFJFRV9TSE9XX09WRVJGTE9XKTsKKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+ Cis8ZGl2IGNsYXNzPSJjb250YWluZXIiPgorCTxkaXYgY2xhc3M9ImNvbnRlbnQiPjwvZGl2Pgor PC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+Cg==