220062 2020-12-21 11:07:29 -0800 warning: enumerated and non-enumerated type in conditional expression in Compiler.cpp 2020-12-22 15:45:56 -0800 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro annulen dino ews-watchlist graouts gyuyoung.kim kondapallykalyan mcatanzaro ryuan.choi sergio smoley webkit-bug-importer oldest_to_newest 1716037 0 mcatanzaro 2020-12-21 11:07:29 -0800 [740/5326] Building CXX object Source/...src/compiler/translator/Compiler.cpp.o ../../Source/ThirdParty/ANGLE/src/compiler/translator/Compiler.cpp: In member function ‘bool sh::TCompiler::checkAndSimplifyAST(sh::TIntermBlock*, const sh::TParseContext&, ShCompileOptions)’: ../../Source/ThirdParty/ANGLE/src/compiler/translator/Compiler.cpp:726:43: warning: enumerated and non-enumerated type in conditional expression [-Wextra] 725 | unsigned int simplifyScalarized = (compileOptions & SH_SCALARIZE_VEC_AND_MAT_CONSTRUCTOR_ARGS) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 726 | ? IntermNodePatternMatcher::kScalarizedVecOrMatConstructor | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 727 | : 0; | ~~~ So we could fight warnings like this as they appear... but honestly, building ANGLE with -Wextra is too aggressive IMO. -Wextra is great for code that we control, where the burden of squashing warnings is relatively low. But with ANGLE, we have to either land fixes upstream, or carry them downstream forever. It doesn't make sense to bother with this for minor build warning fixes when upstream is clearly not using the same warning flags and/or same compiler that we do. So I suggest we simply disable -Wextra for all of ANGLE. 1716038 1 416611 mcatanzaro 2020-12-21 11:10:40 -0800 Created attachment 416611 Patch 1716039 2 ews-watchlist 2020-12-21 11:11:45 -0800 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1716040 3 416612 mcatanzaro 2020-12-21 11:14:24 -0800 Created attachment 416612 Patch 1716271 4 webkit-bug-importer 2020-12-22 10:59:01 -0800 <rdar://problem/72593062> 1716392 5 ews-feeder 2020-12-22 15:45:55 -0800 Committed r271066: <https://trac.webkit.org/changeset/271066> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416612. 416611 2020-12-21 11:10:40 -0800 2020-12-21 11:14:21 -0800 Patch bug-220062-20201221131104.patch text/plain 1893 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxMDI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggY2E2MzMwYjczZmY5NDcyM2JjYjczOWVjZTQyNzc4NDJlNjA5M2ZkMy4uZGU0NmUzZDNjNmRj Njk2MWMzNjk4MWZjZDIxNTUwOWVmNGRiNmI3NiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTEyLTIxICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRh bnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIHdhcm5pbmc6IGVudW1lcmF0ZWQgYW5kIG5vbi1l bnVtZXJhdGVkIHR5cGUgaW4gY29uZGl0aW9uYWwgZXhwcmVzc2lvbiBpbiBDb21waWxlci5jcHAK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMDA2Mgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1aWxkaW5n IEFOR0xFIHdpdGggLVdleHRyYSBpcyB0b28gYWdncmVzc2l2ZS4gLVdleHRyYSBpcyBncmVhdCBm b3IgY29kZSB0aGF0IHdlIGNvbnRyb2wsCisgICAgICAgIHdoZXJlIHRoZSBidXJkZW4gb2Ygc3F1 YXNoaW5nIHdhcm5pbmdzIGlzIHJlbGF0aXZlbHkgbG93LiBCdXQgd2l0aCBBTkdMRSwgd2UgaGF2 ZSB0byBlaXRoZXIKKyAgICAgICAgbGFuZCBmaXhlcyB1cHN0cmVhbSwgb3IgY2FycnkgdGhlbSBk b3duc3RyZWFtIGZvcmV2ZXIuIEl0IGRvZXNuJ3QgbWFrZSBzZW5zZSB0byBib3RoZXIgd2l0aAor ICAgICAgICB0aGlzIGZvciBtaW5vciBidWlsZCB3YXJuaW5nIGZpeGVzIHdoZW4gdXBzdHJlYW0g aXMgY2xlYXJseSBub3QgdXNpbmcgdGhlIHNhbWUgd2FybmluZyBmbGFncworICAgICAgICBhbmQv b3Igc2FtZSBjb21waWxlciB0aGF0IHdlIGRvLgorCisgICAgICAgIFNpbmNlIHdlIGFkZCAtV2V4 dHJhIGluIG91ciBnbG9iYWwgZmxhZ3MsIHdlIGhhdmUgdG8gbWFudWFsbHkgb3ZlcnJpZGUgaXQg aGVyZS4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OgorCiAyMDIwLTEyLTE2ICBGdWppaSBI aXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgogCiAgICAgICAgIFtXaW5DYWlyb10g RW5hYmxlIFVTRV9BTkdMRQpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvQ01h a2VMaXN0cy50eHQgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DTWFrZUxpc3RzLnR4dAppbmRl eCA2YThmYTJiMmFjMDBmNWJhYWNiMjFhNjBmODQ5OGQ5YTMxODRlNWUyLi5kZDgyZDZmNDA4NjVm YTRkMGVjY2VkNmE4OTBjMjBjMzRiYTllOTcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DTWFr ZUxpc3RzLnR4dApAQCAtMTk2LDYgKzE5Niw3IEBAIGVuZGlmICgpCiBpZiAoQ09NUElMRVJfSVNf R0NDX09SX0NMQU5HKQogICAgIFdFQktJVF9BRERfVEFSR0VUX0NYWF9GTEFHUyhBTkdMRSAtV25v LWNhc3QtYWxpZ24KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLVduby1k ZXByZWNhdGVkLWNvcHkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLVdu by1leHRyYQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtV25vLXN1Z2dl c3QtYXR0cmlidXRlPWZvcm1hdAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAtV25vLXR5cGUtbGltaXRzCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IC1Xbm8tdW5kZWYK 416612 2020-12-21 11:14:24 -0800 2020-12-22 15:45:55 -0800 Patch bug-220062-20201221131447.patch text/plain 2192 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxMDI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggY2E2MzMwYjczZmY5NDcyM2JjYjczOWVjZTQyNzc4NDJlNjA5M2ZkMy4uYzE3MTYyMGJjNzhi MDllNzlhYzIzM2I2MzU3NDc3MmE4YjIyOWM1OCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDI0IEBACisyMDIwLTEyLTIxICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRh bnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIHdhcm5pbmc6IGVudW1lcmF0ZWQgYW5kIG5vbi1l bnVtZXJhdGVkIHR5cGUgaW4gY29uZGl0aW9uYWwgZXhwcmVzc2lvbiBpbiBDb21waWxlci5jcHAK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMDA2Mgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1aWxkaW5n IEFOR0xFIHdpdGggLVdleHRyYSBpcyB0b28gYWdncmVzc2l2ZS4gLVdleHRyYSBpcyBncmVhdCBm b3IgY29kZSB0aGF0IHdlIGNvbnRyb2wsCisgICAgICAgIHdoZXJlIHRoZSBidXJkZW4gb2Ygc3F1 YXNoaW5nIHdhcm5pbmdzIGlzIHJlbGF0aXZlbHkgbG93LiBCdXQgd2l0aCBBTkdMRSwgd2UgaGF2 ZSB0byBlaXRoZXIKKyAgICAgICAgbGFuZCBmaXhlcyB1cHN0cmVhbSwgb3IgY2FycnkgdGhlbSBk b3duc3RyZWFtIGZvcmV2ZXIuIEl0IGRvZXNuJ3QgbWFrZSBzZW5zZSB0byBib3RoZXIgd2l0aAor ICAgICAgICB0aGlzIGZvciBtaW5vciBidWlsZCB3YXJuaW5nIGZpeGVzIHdoZW4gdXBzdHJlYW0g aXMgY2xlYXJseSBub3QgdXNpbmcgdGhlIHNhbWUgd2FybmluZyBmbGFncworICAgICAgICBhbmQv b3Igc2FtZSBjb21waWxlciB0aGF0IHdlIGRvLgorCisgICAgICAgIFNpbmNlIHdlIGFkZCAtV2V4 dHJhIGluIG91ciBnbG9iYWwgZmxhZ3MsIHdlIGhhdmUgdG8gbWFudWFsbHkgb3ZlcnJpZGUgaXQg aGVyZS4gV2UgY2FuIG5vdworICAgICAgICBhbHNvIHN0b3AgZXhwbGljaXRseSBkaXNhYmxpbmcg b3RoZXIgd2FybmluZ3MgdGhhdCBhcmUgaW1wbGllZCBieSAtV2V4dHJhLgorCisgICAgICAgIEZp bmFsbHksIG5vdGUgdGhhdCBjaGFuZ2VzLmRpZmYgaXMgbm90IG1vZGlmaWVkIGJlY2F1c2UgdGhp cyBpcywgY29uZnVzaW5nbHksIGEgZG93bnN0cmVhbQorICAgICAgICBXZWJLaXQgYnVpbGQgZmls ZS4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OgorCiAyMDIwLTEyLTE2ICBGdWppaSBIaXJv bm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgogCiAgICAgICAgIFtXaW5DYWlyb10gRW5h YmxlIFVTRV9BTkdMRQpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvQ01ha2VM aXN0cy50eHQgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DTWFrZUxpc3RzLnR4dAppbmRleCA2 YThmYTJiMmFjMDBmNWJhYWNiMjFhNjBmODQ5OGQ5YTMxODRlNWUyLi5iMmI0OGVhYmY0M2ZkMTdk NTdjYmIzMjI0YjQwMDU3N2Q4OWFhOThjIDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9B TkdMRS9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DTWFrZUxp c3RzLnR4dApAQCAtMTk1LDkgKzE5NSw4IEBAIGVuZGlmICgpCiAKIGlmIChDT01QSUxFUl9JU19H Q0NfT1JfQ0xBTkcpCiAgICAgV0VCS0lUX0FERF9UQVJHRVRfQ1hYX0ZMQUdTKEFOR0xFIC1Xbm8t Y2FzdC1hbGlnbgotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtV25vLWRl cHJlY2F0ZWQtY29weQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtV25v LWV4dHJhCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC1Xbm8tc3VnZ2Vz dC1hdHRyaWJ1dGU9Zm9ybWF0Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IC1Xbm8tdHlwZS1saW1pdHMKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg LVduby11bmRlZgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtV25vLXVu dXNlZC1wYXJhbWV0ZXIpCiBlbmRpZiAoKQo=