220007 2020-12-17 21:27:39 -0800 [WASM-References] Reuse instance initElementSegment to reduce duplication 2020-12-18 02:01:27 -0800 1 1 1 Unclassified WebKit WebAssembly WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dbezhetskov webkit-unassigned ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1715657 0 dbezhetskov 2020-12-17 21:27:39 -0800 [WASM-References] Reuse instance initElementSegment to reduce duplication 1715658 1 416498 dbezhetskov 2020-12-17 21:29:02 -0800 Created attachment 416498 Patch 1715676 2 416498 ysuzuki 2020-12-18 01:48:26 -0800 Comment on attachment 416498 Patch r=me 1715677 3 ews-feeder 2020-12-18 02:00:19 -0800 Committed r270965: <https://trac.webkit.org/changeset/270965> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416498. 1715678 4 webkit-bug-importer 2020-12-18 02:01:27 -0800 <rdar://problem/72460576> 416498 2020-12-17 21:29:02 -0800 2020-12-18 02:00:20 -0800 Patch bug-220007-20201218122901.patch text/plain 5002 dbezhetskov U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwOTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 MTFkODIxODU3MzVhNmI3NDA0MjU4NzljZDMwMjlmOTBlYjU4MzgyLi5hN2M0ODQ5NjRlOGYxMGVk YjNhMDNlMGE1NWNkNjZjOWE3YzJkYzY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMC0xMi0xNyAgRG1pdHJ5IEJlemhldHNrb3YgIDxkYmV6aGV0c2tvdkBp Z2FsaWEuY29tPgorCisgICAgICAgIFtXQVNNLVJlZmVyZW5jZXNdIFJldXNlIGluc3RhbmNlIGlu aXRFbGVtZW50U2VnbWVudCB0byByZWR1Y2UgZHVwbGljYXRpb24KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMDAwNworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbXBsZSByZWZhY3Ryb2luZy4gV2UgbmVl ZCBvbmx5IG9uZSBwbGFjZSB0byBpbml0aWFsaXplIGVsZW1lbnRzCisgICAgICAgIHNlZ21lbnRz LgorCisgICAgICAgICogd2FzbS9qcy9XZWJBc3NlbWJseU1vZHVsZVJlY29yZC5jcHA6CisgICAg ICAgIChKU0M6OldlYkFzc2VtYmx5TW9kdWxlUmVjb3JkOjpldmFsdWF0ZSk6CisKIDIwMjAtMTIt MTcgIERtaXRyeSBCZXpoZXRza292ICA8ZGJlemhldHNrb3ZAaWdhbGlhLmNvbT4KIAogICAgICAg ICBbV0FTTS1SZWZlcmVuY2VzXSBBZGQgc3VwcG9ydCBmb3IgbWVtb3J5LmNvcHksIG1lbW9yeS5p bml0IGFuZCBkYXRhLmRyb3AKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNt L2pzL1dlYkFzc2VtYmx5TW9kdWxlUmVjb3JkLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93 YXNtL2pzL1dlYkFzc2VtYmx5TW9kdWxlUmVjb3JkLmNwcAppbmRleCBiYmZlYTczMjVkNzE4MGE4 YzJjOGU4Njc5MzYxMmRiMTBjNDI1M2VkLi5lYTgyMTEzOWEyYzdiMTdlNThkNmQzZGY2ZjI4ZmUx Yjc4YTIyYzNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9qcy9XZWJB c3NlbWJseU1vZHVsZVJlY29yZC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20v anMvV2ViQXNzZW1ibHlNb2R1bGVSZWNvcmQuY3BwCkBAIC01MzcsNyArNTM3LDYgQEAgSlNWYWx1 ZSBXZWJBc3NlbWJseU1vZHVsZVJlY29yZDo6ZXZhbHVhdGUoSlNHbG9iYWxPYmplY3QqIGdsb2Jh bE9iamVjdCkKICAgICBhdXRvIHNjb3BlID0gREVDTEFSRV9USFJPV19TQ09QRSh2bSk7CiAKICAg ICBXYXNtOjpNb2R1bGUmIG1vZHVsZSA9IG1faW5zdGFuY2UtPmluc3RhbmNlKCkubW9kdWxlKCk7 Ci0gICAgV2FzbTo6Q29kZUJsb2NrKiBjb2RlQmxvY2sgPSBtX2luc3RhbmNlLT5pbnN0YW5jZSgp LmNvZGVCbG9jaygpOwogICAgIGNvbnN0IFdhc206Ok1vZHVsZUluZm9ybWF0aW9uJiBtb2R1bGVJ bmZvcm1hdGlvbiA9IG1vZHVsZS5tb2R1bGVJbmZvcm1hdGlvbigpOwogCiAgICAgY29uc3QgVmVj dG9yPFdhc206OlNlZ21lbnQ6OlB0cj4mIGRhdGEgPSBtb2R1bGVJbmZvcm1hdGlvbi5kYXRhOwpA QCAtNjA4LDQ4ICs2MDcsNyBAQCBKU1ZhbHVlIFdlYkFzc2VtYmx5TW9kdWxlUmVjb3JkOjpldmFs dWF0ZShKU0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0KQogICAgICAgICByZXR1cm4gZXhjZXB0 aW9uLnZhbHVlKCk7CiAKICAgICBmb3JFYWNoQWN0aXZlRWxlbWVudChbJl0gKGNvbnN0IFdhc206 OkVsZW1lbnQmIGVsZW1lbnQsIHVpbnQzMl90IHRhYmxlSW5kZXgsIHVpbnQzMl90IHN0YXJ0RWxl bWVudEluZGV4KSB7Ci0gICAgICAgIGZvciAodWludDMyX3QgaSA9IDA7IGkgPCBlbGVtZW50LmZ1 bmN0aW9uSW5kaWNlcy5zaXplKCk7ICsraSkgewotCi0gICAgICAgICAgICBjb25zdCB1aW50MzJf dCBlbGVtZW50SW5kZXggPSBzdGFydEVsZW1lbnRJbmRleCArIGk7Ci0gICAgICAgICAgICBjb25z dCB1aW50MzJfdCBmdW5jdGlvbkluZGV4ID0gZWxlbWVudC5mdW5jdGlvbkluZGljZXNbaV07Ci0g ICAgICAgICAgICBpZiAoV2FzbTo6RWxlbWVudDo6aXNOdWxsRnVuY0luZGV4KGZ1bmN0aW9uSW5k ZXgpKSB7Ci0gICAgICAgICAgICAgICAgbV9pbnN0YW5jZS0+dGFibGUodGFibGVJbmRleCktPmNs ZWFyKGVsZW1lbnRJbmRleCk7Ci0gICAgICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgICAg ICB9Ci0KLSAgICAgICAgICAgIC8vIEZJWE1FOiBUaGlzIGVzc2VudGlhbGx5IG1lYW5zIHdlJ3Jl IGV4cG9ydGluZyBhbiBpbXBvcnQuCi0gICAgICAgICAgICAvLyBXZSBuZWVkIGEgc3RvcnkgaGVy ZS4gV2UgbmVlZCB0byBjcmVhdGUgYSBXZWJBc3NlbWJseUZ1bmN0aW9uCi0gICAgICAgICAgICAv LyBmb3IgdGhlIGltcG9ydC4KLSAgICAgICAgICAgIC8vIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNjU1MTAKLSAgICAgICAgICAgIFdhc206OlNpZ25hdHVyZUluZGV4 IHNpZ25hdHVyZUluZGV4ID0gbW9kdWxlLnNpZ25hdHVyZUluZGV4RnJvbUZ1bmN0aW9uSW5kZXhT cGFjZShmdW5jdGlvbkluZGV4KTsKLSAgICAgICAgICAgIGlmIChmdW5jdGlvbkluZGV4IDwgY29k ZUJsb2NrLT5mdW5jdGlvbkltcG9ydENvdW50KCkpIHsKLSAgICAgICAgICAgICAgICBKU09iamVj dCogZnVuY3Rpb25JbXBvcnQgPSBtX2luc3RhbmNlLT5pbnN0YW5jZSgpLmltcG9ydEZ1bmN0aW9u PFdyaXRlQmFycmllcjxKU09iamVjdD4+KGZ1bmN0aW9uSW5kZXgpLT5nZXQoKTsKLSAgICAgICAg ICAgICAgICBpZiAoaXNXZWJBc3NlbWJseUhvc3RGdW5jdGlvbih2bSwgZnVuY3Rpb25JbXBvcnQp KSB7Ci0gICAgICAgICAgICAgICAgICAgIFdlYkFzc2VtYmx5RnVuY3Rpb24qIHdhc21GdW5jdGlv biA9IGpzRHluYW1pY0Nhc3Q8V2ViQXNzZW1ibHlGdW5jdGlvbio+KHZtLCBmdW5jdGlvbkltcG9y dCk7Ci0gICAgICAgICAgICAgICAgICAgIC8vIElmIHdlIGV2ZXIgaW1wb3J0IGEgV2ViQXNzZW1i bHlXcmFwcGVyRnVuY3Rpb24sIHdlIHNldCB0aGUgaW1wb3J0IGFzIHRoZSB1bndyYXBwZWQgdmFs dWUuCi0gICAgICAgICAgICAgICAgICAgIC8vIEJlY2F1c2UgYSBXZWJBc3NlbWJseVdyYXBwZXJG dW5jdGlvbiBjYW4gbmV2ZXIgd3JhcCBhbm90aGVyIFdlYkFzc2VtYmx5V3JhcHBlckZ1bmN0aW9u LAotICAgICAgICAgICAgICAgICAgICAvLyB0aGUgb25seSB0eXBlIHRoaXMgY291bGQgYmUgaXMg V2ViQXNzZW1ibHlGdW5jdGlvbi4KLSAgICAgICAgICAgICAgICAgICAgUkVMRUFTRV9BU1NFUlQo d2FzbUZ1bmN0aW9uKTsKLSAgICAgICAgICAgICAgICAgICAgbV9pbnN0YW5jZS0+dGFibGUodGFi bGVJbmRleCktPnNldChlbGVtZW50SW5kZXgsIHdhc21GdW5jdGlvbik7Ci0gICAgICAgICAgICAg ICAgICAgIGNvbnRpbnVlOwotICAgICAgICAgICAgICAgIH0KLQotICAgICAgICAgICAgICAgIG1f aW5zdGFuY2UtPnRhYmxlKHRhYmxlSW5kZXgpLT5zZXQoZWxlbWVudEluZGV4LAotICAgICAgICAg ICAgICAgICAgICBXZWJBc3NlbWJseVdyYXBwZXJGdW5jdGlvbjo6Y3JlYXRlKHZtLCBnbG9iYWxP YmplY3QsIGdsb2JhbE9iamVjdC0+d2ViQXNzZW1ibHlXcmFwcGVyRnVuY3Rpb25TdHJ1Y3R1cmUo KSwgZnVuY3Rpb25JbXBvcnQsIGZ1bmN0aW9uSW5kZXgsIG1faW5zdGFuY2UuZ2V0KCksIHNpZ25h dHVyZUluZGV4KSk7Ci0gICAgICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgICAgICB9Ci0K LSAgICAgICAgICAgIFdhc206OkNhbGxlZSYgZW1iZWRkZXJFbnRyeXBvaW50Q2FsbGVlID0gY29k ZUJsb2NrLT5lbWJlZGRlckVudHJ5cG9pbnRDYWxsZWVGcm9tRnVuY3Rpb25JbmRleFNwYWNlKGZ1 bmN0aW9uSW5kZXgpOwotICAgICAgICAgICAgV2FzbTo6V2FzbVRvV2FzbUltcG9ydGFibGVGdW5j dGlvbjo6TG9hZExvY2F0aW9uIGVudHJ5cG9pbnRMb2FkTG9jYXRpb24gPSBjb2RlQmxvY2stPmVu dHJ5cG9pbnRMb2FkTG9jYXRpb25Gcm9tRnVuY3Rpb25JbmRleFNwYWNlKGZ1bmN0aW9uSW5kZXgp OwotICAgICAgICAgICAgY29uc3QgV2FzbTo6U2lnbmF0dXJlJiBzaWduYXR1cmUgPSBXYXNtOjpT aWduYXR1cmVJbmZvcm1hdGlvbjo6Z2V0KHNpZ25hdHVyZUluZGV4KTsKLSAgICAgICAgICAgIC8v IEZJWE1FOiBTYXkgd2UgZXhwb3J0IGxvY2FsIGZ1bmN0aW9uICJmb28iIGF0IGZ1bmN0aW9uIGlu ZGV4IDAuCi0gICAgICAgICAgICAvLyBXaGF0IGlmIHdlIGFsc28gc2V0IGl0IHRvIHRoZSB0YWJs ZSBhbiBFbGVtZW50IHcvIGluZGV4IDAuCi0gICAgICAgICAgICAvLyBEb2VzIChuZXcgSW5zdGFu Y2UoLi4uKSkuZXhwb3J0cy5mb28gPT09IHRhYmxlLmdldCgwKT8KLSAgICAgICAgICAgIC8vIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjU4MjUKLSAgICAgICAgICAg IFdlYkFzc2VtYmx5RnVuY3Rpb24qIGZ1bmN0aW9uID0gV2ViQXNzZW1ibHlGdW5jdGlvbjo6Y3Jl YXRlKAotICAgICAgICAgICAgICAgIHZtLCBnbG9iYWxPYmplY3QsIGdsb2JhbE9iamVjdC0+d2Vi QXNzZW1ibHlGdW5jdGlvblN0cnVjdHVyZSgpLCBzaWduYXR1cmUuYXJndW1lbnRDb3VudCgpLCBT dHJpbmcoKSwgbV9pbnN0YW5jZS5nZXQoKSwgZW1iZWRkZXJFbnRyeXBvaW50Q2FsbGVlLCBlbnRy eXBvaW50TG9hZExvY2F0aW9uLCBzaWduYXR1cmVJbmRleCk7Ci0gICAgICAgICAgICBtX2luc3Rh bmNlLT50YWJsZSh0YWJsZUluZGV4KS0+c2V0KGVsZW1lbnRJbmRleCwgZnVuY3Rpb24pOwotICAg ICAgICB9CisgICAgICAgIG1faW5zdGFuY2UtPmluc3RhbmNlKCkuaW5pdEVsZW1lbnRTZWdtZW50 KHRhYmxlSW5kZXgsIGVsZW1lbnQsIHN0YXJ0RWxlbWVudEluZGV4LCAwVSwgZWxlbWVudC5sZW5n dGgoKSk7CiAgICAgfSk7CiAKICAgICBBU1NFUlQoIWV4Y2VwdGlvbik7Cg==