219994 2020-12-17 13:08:06 -0800 [run-webkit-tests] Replace FailureNotTested with FailureNoOutput 2020-12-17 15:18:04 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard dewei_zhu ews-watchlist ggaren glenn slewis webkit-bug-importer oldest_to_newest 1715514 0 jbedard 2020-12-17 13:08:06 -0800 The tests we mark as "not tested" more accurately have "no output". We should rename this failure type to reflect the actual behavior so that contributors are not confused. 1715538 1 webkit-bug-importer 2020-12-17 14:04:17 -0800 <rdar://problem/72440201> 1715551 2 416468 jbedard 2020-12-17 14:20:51 -0800 Created attachment 416468 Patch 1715556 3 jbedard 2020-12-17 14:23:58 -0800 This change is coming from some confusion Geoff voiced to me on Slack, seems like we should just rename the error class. 1715561 4 416468 ggaren 2020-12-17 14:26:50 -0800 Comment on attachment 416468 Patch r=me Thanks! 1715579 5 ews-feeder 2020-12-17 15:18:03 -0800 Committed r270953: <https://trac.webkit.org/changeset/270953> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416468. 416468 2020-12-17 14:20:51 -0800 2020-12-17 15:18:03 -0800 Patch bug-219994-20201217162050.patch text/plain 4172 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3MDk0NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIwIEBACisyMDIwLTEyLTE3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbcnVuLXdlYmtpdC10ZXN0c10gUmVwbGFjZSBGYWlsdXJlTm90VGVzdGVk IHdpdGggRmFpbHVyZU5vT3V0cHV0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMTk5OTQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzcyNDQwMjAxPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvc2luZ2xlX3Rlc3RfcnVubmVyLnB5 OgorICAgICAgICAoU2luZ2xlVGVzdFJ1bm5lci5fY29tcGFyZV90ZXh0KTogUmVwbGFjZSBGYWls dXJlTm90VGVzdCB3aXRoIEZhaWx1cmVOb091dHB1dC4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9mYWlsdXJlcy5weToKKyAgICAgICAgKGRldGVy bWluZV9yZXN1bHRfdHlwZSk6IFJlcGxhY2UgRmFpbHVyZU5vdFRlc3Qgd2l0aCBGYWlsdXJlTm9P dXRwdXQuCisgICAgICAgIChGYWlsdXJlTm9PdXRwdXQpOiBSZW5hbWVkIGZyb20gRmFpbHVyZU5v dFRlc3RlZC4KKyAgICAgICAgKEZhaWx1cmVOb3RUZXN0ZWQpOiBSZW5hbWVkIHRvIEZhaWx1cmVO b091dHB1dC4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMv dGVzdF9mYWlsdXJlc191bml0dGVzdC5weToKKyAgICAgICAgKFRlc3RGYWlsdXJlc1Rlc3QudGVz dF9hbGxfZmFpbHVyZV9jbGFzc2VzKTogUmVwbGFjZSBGYWlsdXJlTm90VGVzdCB3aXRoIEZhaWx1 cmVOb091dHB1dC4KKwogMjAyMC0xMi0xNyAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBs ZS5jb20+CiAKICAgICAgICAgW3dlYmtpdHNjbXB5XSBDYXB0dXJlIE1vY2sgcHJvY2VzcyBsb2dn aW5nIGR1cmluZyB0ZXN0cyAKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL2NvbnRyb2xsZXJzL3NpbmdsZV90ZXN0X3J1bm5lci5weQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9zaW5nbGVfdGVzdF9y dW5uZXIucHkJKHJldmlzaW9uIDI3MDk0MSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL3NpbmdsZV90ZXN0X3J1bm5lci5weQkod29ya2luZyBjb3B5 KQpAQCAtMjQzLDcgKzI0Myw3IEBAIGNsYXNzIFNpbmdsZVRlc3RSdW5uZXIob2JqZWN0KToKICAg ICAgICAgZWxpZiBhY3R1YWxfdGV4dCBhbmQgbm90IGV4cGVjdGVkX3RleHQ6CiAgICAgICAgICAg ICBmYWlsdXJlcy5hcHBlbmQodGVzdF9mYWlsdXJlcy5GYWlsdXJlTWlzc2luZ1Jlc3VsdCgpKQog ICAgICAgICBlbGlmIG5vdCBhY3R1YWxfdGV4dCBhbmQgZXhwZWN0ZWRfdGV4dDoKLSAgICAgICAg ICAgIGZhaWx1cmVzLmFwcGVuZCh0ZXN0X2ZhaWx1cmVzLkZhaWx1cmVOb3RUZXN0ZWQoKSkKKyAg ICAgICAgICAgIGZhaWx1cmVzLmFwcGVuZCh0ZXN0X2ZhaWx1cmVzLkZhaWx1cmVOb091dHB1dCgp KQogICAgICAgICByZXR1cm4gZmFpbHVyZXMKIAogICAgIGRlZiBfY29tcGFyZV9hdWRpbyhzZWxm LCBleHBlY3RlZF9hdWRpbywgYWN0dWFsX2F1ZGlvKToKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2ZhaWx1cmVzLnB5Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2ZhaWx1cmVz LnB5CShyZXZpc2lvbiAyNzA5NDEpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9tb2RlbHMvdGVzdF9mYWlsdXJlcy5weQkod29ya2luZyBjb3B5KQpAQCAtNzEsNyArNzEs NyBAQCBkZWYgZGV0ZXJtaW5lX3Jlc3VsdF90eXBlKGZhaWx1cmVfbGlzdCk6CiAgICAgICAgICAg RmFpbHVyZU1pc3NpbmdJbWFnZSBpbiBmYWlsdXJlX3R5cGVzIG9yCiAgICAgICAgICAgRmFpbHVy ZU1pc3NpbmdJbWFnZUhhc2ggaW4gZmFpbHVyZV90eXBlcyBvcgogICAgICAgICAgIEZhaWx1cmVN aXNzaW5nQXVkaW8gaW4gZmFpbHVyZV90eXBlcyBvcgotICAgICAgICAgIEZhaWx1cmVOb3RUZXN0 ZWQgaW4gZmFpbHVyZV90eXBlcyk6CisgICAgICAgICAgRmFpbHVyZU5vT3V0cHV0IGluIGZhaWx1 cmVfdHlwZXMpOgogICAgICAgICByZXR1cm4gdGVzdF9leHBlY3RhdGlvbnMuTUlTU0lORwogICAg IGVsc2U6CiAgICAgICAgIGlzX3RleHRfZmFpbHVyZSA9IEZhaWx1cmVUZXh0TWlzbWF0Y2ggaW4g ZmFpbHVyZV90eXBlcwpAQCAtMTkwLDkgKzE5MCw5IEBAIGNsYXNzIEZhaWx1cmVNaXNzaW5nUmVz dWx0KEZhaWx1cmVUZXh0KToKICAgICAgICAgcmV0dXJuICItZXhwZWN0ZWQudHh0IHdhcyBtaXNz aW5nIgogCiAKLWNsYXNzIEZhaWx1cmVOb3RUZXN0ZWQoRmFpbHVyZVRleHQpOgorY2xhc3MgRmFp bHVyZU5vT3V0cHV0KEZhaWx1cmVUZXh0KToKICAgICBkZWYgbWVzc2FnZShzZWxmKToKLSAgICAg ICAgcmV0dXJuICd0ZXN0IHdhcyBub3QgcnVuJworICAgICAgICByZXR1cm4gJ25vIG91dHB1dCBm cm9tIHRlc3QnCiAKIAogY2xhc3MgRmFpbHVyZVRleHRNaXNtYXRjaChGYWlsdXJlVGV4dCk6CkBA IC0yOTYsNyArMjk2LDcgQEAgY2xhc3MgRmFpbHVyZUVhcmx5RXhpdChUZXN0RmFpbHVyZSk6CiAK ICMgQ29udmVuaWVudCBjb2xsZWN0aW9uIG9mIGFsbCBmYWlsdXJlIGNsYXNzZXMgZm9yIGFueXRo aW5nIHRoYXQgbWlnaHQKICMgbmVlZCB0byBlbnVtZXJhdGUgb3ZlciB0aGVtIGFsbC4KLUFMTF9G QUlMVVJFX0NMQVNTRVMgPSAoRmFpbHVyZVRpbWVvdXQsIEZhaWx1cmVDcmFzaCwgRmFpbHVyZU1p c3NpbmdSZXN1bHQsIEZhaWx1cmVOb3RUZXN0ZWQsCitBTExfRkFJTFVSRV9DTEFTU0VTID0gKEZh aWx1cmVUaW1lb3V0LCBGYWlsdXJlQ3Jhc2gsIEZhaWx1cmVNaXNzaW5nUmVzdWx0LCBGYWlsdXJl Tm9PdXRwdXQsCiAgICAgICAgICAgICAgICAgICAgICAgIEZhaWx1cmVUZXh0TWlzbWF0Y2gsIEZh aWx1cmVNaXNzaW5nSW1hZ2VIYXNoLAogICAgICAgICAgICAgICAgICAgICAgICBGYWlsdXJlTWlz c2luZ0ltYWdlLCBGYWlsdXJlSW1hZ2VIYXNoTWlzbWF0Y2gsCiAgICAgICAgICAgICAgICAgICAg ICAgIEZhaWx1cmVJbWFnZUhhc2hJbmNvcnJlY3QsIEZhaWx1cmVSZWZ0ZXN0TWlzbWF0Y2gsCklu ZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9mYWls dXJlc191bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9tb2RlbHMvdGVzdF9mYWlsdXJlc191bml0dGVzdC5weQkocmV2aXNpb24gMjcw OTQxKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3Rf ZmFpbHVyZXNfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTY0LDcgKzY0LDcgQEAgY2xh c3MgVGVzdEZhaWx1cmVzVGVzdCh1bml0dGVzdC5UZXN0Q2FzZQogICAgICAgICAgICAgRmFpbHVy ZVRpbWVvdXQsCiAgICAgICAgICAgICBGYWlsdXJlQ3Jhc2gsCiAgICAgICAgICAgICBGYWlsdXJl TWlzc2luZ1Jlc3VsdCwKLSAgICAgICAgICAgIEZhaWx1cmVOb3RUZXN0ZWQsCisgICAgICAgICAg ICBGYWlsdXJlTm9PdXRwdXQsCiAgICAgICAgICAgICBGYWlsdXJlVGV4dE1pc21hdGNoLAogICAg ICAgICAgICAgRmFpbHVyZU1pc3NpbmdJbWFnZUhhc2gsCiAgICAgICAgICAgICBGYWlsdXJlTWlz c2luZ0ltYWdlLAo=