219988 2020-12-17 11:40:34 -0800 [webkitscmpy] Remove branches argument from mock Git 2020-12-17 12:31:16 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=219982 InRadar P2 Normal --- 1 jbedard jbedard dewei_zhu slewis webkit-bug-importer oldest_to_newest 1715469 0 jbedard 2020-12-17 11:40:34 -0800 The "branches" argument to the mock Git object is not very useful and makes the code more difficult to work with. We should just remove the option. 1715470 1 webkit-bug-importer 2020-12-17 11:41:00 -0800 <rdar://problem/72434657> 1715471 2 416445 jbedard 2020-12-17 11:43:20 -0800 Created attachment 416445 Patch 1715489 3 ews-feeder 2020-12-17 12:31:15 -0800 Committed r270941: <https://trac.webkit.org/changeset/270941> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416445. 416445 2020-12-17 11:43:20 -0800 2020-12-17 12:31:16 -0800 Patch bug-219988-20201217134319.patch text/plain 4168 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3MDkzOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDIwLTEyLTE3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0c2NtcHldIFJlbW92ZSBicmFuY2hlcyBhcmd1bWVudCBmcm9t IG1vY2sgR2l0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMTk5ODgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzcyNDM0NjU3PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9saWJyYXJpZXMv d2Via2l0c2NtcHkvd2Via2l0c2NtcHkvX19pbml0X18ucHk6IEJ1bXAgdmVyc2lvbi4KKyAgICAg ICAgKiBTY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS9tb2Nrcy9sb2Nh bC9naXQucHk6CisgICAgICAgIChHaXQuX19pbml0X18pOiBSZW1vdGUgYnJhbmNoZXMgYXJndW1l bnQuCisgICAgICAgICogU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkv dGVzdC9naXRfdW5pdHRlc3QucHk6CisgICAgICAgIChUZXN0R2l0LnRlc3RfYnJhbmNoZXMpOgor CiAyMDIwLTEyLTE3ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAg ICAgICBVbnJldmlld2VkLCByZW9yZGVyaW5nIGFzc29jaWF0ZWQgZW1haWwgYWRkcmVzc2VzIGlu CkluZGV4OiBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS9f X2luaXRfXy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRz Y21weS93ZWJraXRzY21weS9fX2luaXRfXy5weQkocmV2aXNpb24gMjcwOTM4KQorKysgVG9vbHMv U2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvX19pbml0X18ucHkJKHdv cmtpbmcgY29weSkKQEAgLTQ2LDcgKzQ2LDcgQEAgZXhjZXB0IEltcG9ydEVycm9yOgogICAgICAg ICAiUGxlYXNlIGluc3RhbGwgd2Via2l0Y29yZXB5IHdpdGggYHBpcCBpbnN0YWxsIHdlYmtpdGNv cmVweSAtLWV4dHJhLWluZGV4LXVybCA8cGFja2FnZSBpbmRleCBVUkw+YCIKICAgICApCiAKLXZl cnNpb24gPSBWZXJzaW9uKDAsIDYsIDEpCit2ZXJzaW9uID0gVmVyc2lvbigwLCA2LCAyKQogCiBB dXRvSW5zdGFsbC5yZWdpc3RlcihQYWNrYWdlKCdmYXN0ZW5lcnMnLCBWZXJzaW9uKDAsIDE1LCAw KSkpCiBBdXRvSW5zdGFsbC5yZWdpc3RlcihQYWNrYWdlKCdtb25vdG9uaWMnLCBWZXJzaW9uKDEs IDUpKSkKSW5kZXg6IFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNj bXB5L21vY2tzL2xvY2FsL2dpdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2xpYnJh cmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS9tb2Nrcy9sb2NhbC9naXQucHkJKHJldmlzaW9u IDI3MDkzOCkKKysrIFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNj bXB5L21vY2tzL2xvY2FsL2dpdC5weQkod29ya2luZyBjb3B5KQpAQCAtMzMsNyArMzMsNyBAQCBj bGFzcyBHaXQobW9ja3MuU3VicHJvY2Vzcyk6CiAKICAgICBkZWYgX19pbml0X18oCiAgICAgICAg IHNlbGYsIHBhdGg9Jy8uaW52YWxpZC1naXQnLCBkYXRhZmlsZT1Ob25lLAotICAgICAgICByZW1v dGU9Tm9uZSwgYnJhbmNoZXM9Tm9uZSwgdGFncz1Ob25lLAorICAgICAgICByZW1vdGU9Tm9uZSwg dGFncz1Ob25lLAogICAgICAgICBkZXRhY2hlZD1Ob25lLCBkZWZhdWx0X2JyYW5jaD0nbWFpbics CiAgICAgICAgIGdpdF9zdm49RmFsc2UsCiAgICAgKToKQEAgLTQyLDcgKzQyLDYgQEAgY2xhc3Mg R2l0KG1vY2tzLlN1YnByb2Nlc3MpOgogICAgICAgICBzZWxmLnJlbW90ZSA9IHJlbW90ZSBvciAn Z2l0QGV4YW1wbGUub3JnOi9tb2NrL3t9Jy5mb3JtYXQob3MucGF0aC5iYXNlbmFtZShwYXRoKSkK ICAgICAgICAgc2VsZi5kZXRhY2hlZCA9IGRldGFjaGVkIG9yIEZhbHNlCiAKLSAgICAgICAgc2Vs Zi5icmFuY2hlcyA9IGJyYW5jaGVzIG9yIFtdCiAgICAgICAgIHNlbGYudGFncyA9IHRhZ3Mgb3Ig e30KIAogICAgICAgICB0cnk6CkBAIC0xNTYsNyArMTU1LDcgQEAgbm90aGluZyB0byBjb21taXQs IHdvcmtpbmcgdHJlZSBjbGVhbgogICAgICAgICAgICAgICAgIGN3ZD1zZWxmLnBhdGgsCiAgICAg ICAgICAgICAgICAgZ2VuZXJhdG9yPWxhbWJkYSAqYXJncywgKiprd2FyZ3M6IG1vY2tzLlByb2Nl c3NDb21wbGV0aW9uKAogICAgICAgICAgICAgICAgICAgICByZXR1cm5jb2RlPTAsCi0gICAgICAg ICAgICAgICAgICAgIHN0ZG91dD0nXG4nLmpvaW4oc29ydGVkKFsnKiAnICsgc2VsZi5icmFuY2hd ICsgbGlzdCgoe2RlZmF1bHRfYnJhbmNofSB8IHNldChzZWxmLmNvbW1pdHMua2V5cygpKSB8IHNl dChzZWxmLmJyYW5jaGVzKSkgLSB7c2VsZi5icmFuY2h9KSkpICsKKyAgICAgICAgICAgICAgICAg ICAgc3Rkb3V0PSdcbicuam9pbihzb3J0ZWQoWycqICcgKyBzZWxmLmJyYW5jaF0gKyBsaXN0KCh7 ZGVmYXVsdF9icmFuY2h9IHwgc2V0KHNlbGYuY29tbWl0cy5rZXlzKCkpKSAtIHtzZWxmLmJyYW5j aH0pKSkgKwogICAgICAgICAgICAgICAgICAgICAgICAgICAgJ1xucmVtb3Rlcy9vcmlnaW4vSEVB RCAtPiBvcmlnaW4ve31cbicuZm9ybWF0KGRlZmF1bHRfYnJhbmNoKSwKICAgICAgICAgICAgICAg ICApLAogICAgICAgICAgICAgKSwgbW9ja3MuU3VicHJvY2Vzcy5Sb3V0ZSgKQEAgLTMxMiw1ICsz MTEsNSBAQCBub3RoaW5nIHRvIGNvbW1pdCwgd29ya2luZyB0cmVlIGNsZWFuCiAgICAgICAgIGNv bW1pdCA9IHNlbGYuZmluZChzb21ldGhpbmcpCiAgICAgICAgIGlmIGNvbW1pdDoKICAgICAgICAg ICAgIHNlbGYuaGVhZCA9IGNvbW1pdAotICAgICAgICAgICAgc2VsZi5kZXRhY2hlZCA9IHNvbWV0 aGluZyBub3QgaW4gc2VsZi5icmFuY2hlcworICAgICAgICAgICAgc2VsZi5kZXRhY2hlZCA9IHNv bWV0aGluZyBub3QgaW4gc2VsZi5jb21taXRzLmtleXMoKQogICAgICAgICByZXR1cm4gVHJ1ZSBp ZiBjb21taXQgZWxzZSBGYWxzZQpJbmRleDogVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0 c2NtcHkvd2Via2l0c2NtcHkvdGVzdC9naXRfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvdGVzdC9naXRfdW5p dHRlc3QucHkJKHJldmlzaW9uIDI3MDkzOCkKKysrIFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dl YmtpdHNjbXB5L3dlYmtpdHNjbXB5L3Rlc3QvZ2l0X3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkp CkBAIC01NiwxMCArNTYsMTAgQEAgY2xhc3MgVGVzdEdpdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAg ICAgICAgICAgICBzZWxmLmFzc2VydEVxdWFsKGxvY2FsLkdpdChzZWxmLnBhdGgpLnJlbW90ZSgp LCByZXBvLnJlbW90ZSkKIAogICAgIGRlZiB0ZXN0X2JyYW5jaGVzKHNlbGYpOgotICAgICAgICB3 aXRoIG1vY2tzLmxvY2FsLkdpdChzZWxmLnBhdGgsIGJyYW5jaGVzPSgncmVtb3Rlcy9vcmlnaW4v YnJhbmNoLTMnLCkpOgorICAgICAgICB3aXRoIG1vY2tzLmxvY2FsLkdpdChzZWxmLnBhdGgpOgog ICAgICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbCgKICAgICAgICAgICAgICAgICBsb2NhbC5HaXQo c2VsZi5wYXRoKS5icmFuY2hlcywKLSAgICAgICAgICAgICAgICBbJ2JyYW5jaC0zJywgJ2JyYW5j aC1hJywgJ2JyYW5jaC1iJywgJ21haW4nXSwKKyAgICAgICAgICAgICAgICBbJ2JyYW5jaC1hJywg J2JyYW5jaC1iJywgJ21haW4nXSwKICAgICAgICAgICAgICkKIAogICAgIGRlZiB0ZXN0X3RhZ3Mo c2VsZik6Cg==