<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>21997</bug_id>
          
          <creation_ts>2008-10-31 02:27:10 -0700</creation_ts>
          <short_desc>prepare-ChangeLog should filter out ChangeLog files</short_desc>
          <delta_ts>2008-10-31 11:08:13 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Minor</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alexey Proskuryakov">ap</reporter>
          <assigned_to name="David Kilzer (:ddkilzer)">ddkilzer</assigned_to>
          <cc>aroben</cc>
    
    <cc>ddkilzer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>97226</commentid>
    <comment_count>0</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2008-10-31 02:27:10 -0700</bug_when>
    <thetext>When someone runs prepare-ChangeLog for a second time, it lists ChangeLog files as changed ones. This is never useful IMO, but takes one&apos;s time to remove, or to point out in a review.

I think that prepare-ChangeLog should not list ChangeLog files as changed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>97241</commentid>
    <comment_count>1</comment_count>
      <attachid>24797</attachid>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2008-10-31 07:01:24 -0700</bug_when>
    <thetext>Created attachment 24797
Patch v1

Happy Halloween!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>97251</commentid>
    <comment_count>2</comment_count>
      <attachid>24797</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2008-10-31 09:55:30 -0700</bug_when>
    <thetext>Comment on attachment 24797
Patch v1

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>97263</commentid>
    <comment_count>3</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2008-10-31 11:08:13 -0700</bug_when>
    <thetext>$ git svn dcommit
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/prepare-ChangeLog
Committed r38038

</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>24797</attachid>
            <date>2008-10-31 07:01:24 -0700</date>
            <delta_ts>2008-10-31 09:55:30 -0700</delta_ts>
            <desc>Patch v1</desc>
            <filename>bug-21997-v1.diff</filename>
            <type>text/plain</type>
            <size>1457</size>
            <attacher name="David Kilzer (:ddkilzer)">ddkilzer</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv
ZwppbmRleCA3MjFiNzNiLi43NDg4ZTk3IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM
b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDgtMTAt
MzEgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBCdWcgMjE5
OTc6IHByZXBhcmUtQ2hhbmdlTG9nIHNob3VsZCBmaWx0ZXIgb3V0IENoYW5nZUxvZyBmaWxlcwor
CisgICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE5OTc+
CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3Jp
cHRzL3ByZXBhcmUtQ2hhbmdlTG9nOgorICAgICAgICAoZ2VuZXJhdGVGaWxlTGlzdCk6IERvbid0
IGFkZCBDaGFuZ2VMb2cgZmlsZXMgdG8gJXskZnVuY3Rpb25MaXN0c30uCisgICAgICAgIFRoaXMg
cHJldmVudHMgdGhlbSBmcm9tIHNob3dpbmcgdXAgaW4gdGhlIG5ldyBDaGFuZ2VMb2cgZW50cnku
ICBUaGV5CisgICAgICAgIHdlcmUgYWxyZWFkeSBleGNsdWRlZCBmcm9tIEB7JGNoYW5nZWRGaWxl
c30uCisKIDIwMDgtMTAtMzAgIFBpZXJyZS1PbGl2aWVyIExhdG91ciAgPHBvbEBhcHBsZS5jb20+
CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KZGlmZiAtLWdpdCBhL1dlYktp
dFRvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cgYi9XZWJLaXRUb29scy9TY3JpcHRzL3By
ZXBhcmUtQ2hhbmdlTG9nCmluZGV4IDE3OWU3NjYuLmZmNGNlODAgMTAwNzU1Ci0tLSBhL1dlYktp
dFRvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0
cy9wcmVwYXJlLUNoYW5nZUxvZwpAQCAtMTI1Miw4ICsxMjUyLDEwIEBAIHN1YiBnZW5lcmF0ZUZp
bGVMaXN0KFxAXEBcJSkKICAgICAgICAgfSBlbHNpZiAoaXNDb25mbGljdFN0YXR1cygkc3RhdHVz
KSkgewogICAgICAgICAgICAgcHVzaCBAeyRjb25mbGljdEZpbGVzfSwgJGZpbGU7CiAgICAgICAg
IH0KLSAgICAgICAgbXkgJGRlc2NyaXB0aW9uID0gc3RhdHVzRGVzY3JpcHRpb24oJHN0YXR1cywg
JG9yaWdpbmFsKTsKLSAgICAgICAgJGZ1bmN0aW9uTGlzdHMtPnskZmlsZX0gPSAkZGVzY3JpcHRp
b24gaWYgZGVmaW5lZCAkZGVzY3JpcHRpb247CisgICAgICAgIGlmIChiYXNlbmFtZSgkZmlsZSkg
bmUgIkNoYW5nZUxvZyIpIHsKKyAgICAgICAgICAgIG15ICRkZXNjcmlwdGlvbiA9IHN0YXR1c0Rl
c2NyaXB0aW9uKCRzdGF0dXMsICRvcmlnaW5hbCk7CisgICAgICAgICAgICAkZnVuY3Rpb25MaXN0
cy0+eyRmaWxlfSA9ICRkZXNjcmlwdGlvbiBpZiBkZWZpbmVkICRkZXNjcmlwdGlvbjsKKyAgICAg
ICAgfQogICAgIH0KICAgICBjbG9zZSBTVEFUOwogfQo=
</data>
<flag name="review"
          id="11350"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>