219960 2020-12-16 13:50:00 -0800 Scroll-chaining not triggering before complete end of overscroll 2022-02-08 21:32:23 -0800 1 1 1 Unclassified WebKit Scrolling Safari Technology Preview Mac (Intel) macOS 10.15 RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=219923 InRadar P2 Normal --- 1 augus.dupin simon.fraser augus.dupin cmarcelo ews-watchlist fred.wang jamesr luiz simon.fraser smoley thorton tonikitoo webkit-bug-importer oldest_to_newest 1715223 0 416361 augus.dupin 2020-12-16 13:50:00 -0800 Created attachment 416361 Test case Safari Technology Preview 117, on macOS 10.15.7 When scrolling inside a scroll container, after reaching the end, the scroll does not propagate to the parent scroll container (whether it is another element or the page) as long as the overscroll is ongoing. The current scroll has to be perfectly still for scroll-chaining to happen. See the attachment for a test case, also available here: https://output.jsbin.com/begomocugi Steps to reproduce: 1. scroll down to the end of the outer scroll (to reach the inner scroll) 2. scroll down inside the inner scroll, then up until reaching the top edge 3. scroll up again BEFORE the end of the overscroll Expected behaviour: the scroll should propagate to the outer scroll container as soon as a new "up" scroll happens, and the outer scroll container should scroll up as a consequence. Result: the inner scroll container get scrolled again, persisting in its overscroll. You have to wait for the overscroll to end completely to be able to scroll out of it. Scroll-chaining is thus made pretty unusable, as you have to wait for the overscroll to end in order to escape the current scroll context. This didn't happen in previous macOS Safari version (at least before STP 116, which I didn't test). To be noted: this problem has been present on iOS for a while. Not sure if I should create another bug for this? This bug might be related to this other one, on nested scrolling: https://bugs.webkit.org/show_bug.cgi?id=219923 Maybe it can even be considered as the same? As this bug (scroll-chaining) is present on iOS but not the other (nested scrolling) one I considered them to be different. As mentioned in the other bug, this might be a regression due to the recent changes on scrolling. 1715278 1 simon.fraser 2020-12-16 17:37:18 -0800 There's a 100ms timeout to clear latching which I think is a bit too long. 1716005 2 augus.dupin 2020-12-21 08:00:50 -0800 When is that timeout added exactly? It feels like there is a timeout preventing scroll chaining *after* the end of the overscroll. This doesn't seem useful, as it should be possible to scroll out of the inner scroll way before that, *during* the overscroll. If the user is overscrolling and scrolls again in the same direction, scroll chaining should take place right away. This is how it behaved before STP 117, and how it behaves in similar situations accross macOS and iOS native interfaces. Now maybe there can be a short timeout between the start of the overscroll and the possibility to trigger scroll chaining with a new scroll gesture, but I don't think this is when the timeout is used at the moment? 1716304 3 webkit-bug-importer 2020-12-22 12:01:42 -0800 <rdar://problem/72595521> 1718538 4 simon.fraser 2021-01-08 20:21:50 -0800 Part of this is about ScrollController's behavior of ignoring momentum scrolls (m_ignoreMomentumScrolls) when we're done rubberbanding, but we continue to claim to handle the wheel events, which postpones releasing the latch. 1721387 5 418095 simon.fraser 2021-01-21 16:02:19 -0800 Created attachment 418095 Patch 1721456 6 simon.fraser 2021-01-21 18:52:18 -0800 https://trac.webkit.org/changeset/271730/webkit 1839011 7 simon.fraser 2022-02-08 21:32:23 -0800 I filed bug 236348 to followup on https://twitter.com/mtomweb/status/1491162786369777665 416361 2020-12-16 13:50:00 -0800 2020-12-16 13:50:00 -0800 Test case scroll_chaining.html text/html 1192 augus.dupin PCFET0NUWVBFIGh0bWw+CjxodG1sIGxhbmc9ImVuIj4KPGhlYWQ+CiAgICA8bWV0YSBjaGFyc2V0 PSJVVEYtOCI+CiAgICA8bWV0YSBuYW1lPSJ2aWV3cG9ydCIgY29udGVudD0id2lkdGg9ZGV2aWNl LXdpZHRoLCBpbml0aWFsLXNjYWxlPTEuMCI+CiAgICA8dGl0bGU+U2Nyb2xsIGNoYWluaW5nPC90 aXRsZT4KICAgIDxzdHlsZT4KICAgICAgICAqIHsgYm94LXNpemluZzogYm9yZGVyLWJveDsgY29s b3I6IHdoaXRlIH0KICAgICAgICBib2R5IHsgbWFyZ2luOiAwIH0KCiAgICAgICAgLm91dGVyLXNj cm9sbCB7CiAgICAgICAgICAgIHdpZHRoOiAxMDB2dzsKICAgICAgICAgICAgaGVpZ2h0OiAxMDB2 aDsKICAgICAgICAgICAgb3ZlcmZsb3cteDogaGlkZGVuOwogICAgICAgICAgICBvdmVyZmxvdy15 OiBhdXRvOwogICAgICAgICAgICBib3JkZXI6IDJweCBzb2xpZCBvcmFuZ2U7CiAgICAgICAgfQoK ICAgICAgICAub3V0ZXItY29udGVudCB7CiAgICAgICAgICAgIHdpZHRoOiAxMDAlOwogICAgICAg ICAgICBoZWlnaHQ6IDIwMCU7CiAgICAgICAgICAgIGJhY2tncm91bmQ6IGxpbmVhci1ncmFkaWVu dCgjM2Y4N2E2LCAjZWJmOGUxKTsKICAgICAgICB9CgogICAgICAgIC5pbm5lci1zY3JvbGwgewog ICAgICAgICAgICB3aWR0aDogMTAwJTsKICAgICAgICAgICAgaGVpZ2h0OiA2MDBweDsKICAgICAg ICAgICAgb3ZlcmZsb3cteTogYXV0bzsKICAgICAgICAgICAgb3ZlcmZsb3cteDogaGlkZGVuOwog ICAgICAgICAgICBib3JkZXI6IDJweCBzb2xpZCBncmVlbjsKICAgICAgICB9CgogICAgICAgIC5p bm5lci1jb250ZW50IHsKICAgICAgICAgICAgd2lkdGg6IDEwMCU7CiAgICAgICAgICAgIGhlaWdo dDogMTAwMHB4OwogICAgICAgICAgICBiYWNrZ3JvdW5kOiBsaW5lYXItZ3JhZGllbnQoIzkxOThl NSwgI2U2NjQ2NSk7CiAgICAgICAgfQogICAgPC9zdHlsZT4KPC9oZWFkPgo8L2hlYWQ+Cjxib2R5 PgogICAgPGRpdiBjbGFzcz0ib3V0ZXItc2Nyb2xsIj4KICAgICAgICA8ZGl2IGNsYXNzPSJvdXRl ci1jb250ZW50Ij5vdXRlci1jb250ZW50PC9kaXY+CiAgICAgICAgPGRpdiBjbGFzcz0iaW5uZXIt c2Nyb2xsIj4KICAgICAgICAgICAgPGRpdiBjbGFzcz0iaW5uZXItY29udGVudCI+aW5uZXItY29u dGVudDwvZGl2PgogICAgICAgIDwvZGl2PgogICAgPC9kaXY+CjwvYm9keT4KPC9odG1sPg== 418095 2021-01-21 16:02:19 -0800 2021-01-21 17:35:36 -0800 Patch bug-219960-20210121160218.patch text/plain 4604 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWNkMzdkMWJhYzZkMDI3 NDBhNjIyM2EwMGJlOGNmYzRhNTg3NDQ1Yi4uMDUyMDM2NjllMDdmNmY4Zjk0ZTAwNTI0NTAwYWFh NzE3Nzc1MTk1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIxLTAxLTIxICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFNjcm9sbC1jaGFp bmluZyBub3QgdHJpZ2dlcmluZyBiZWZvcmUgY29tcGxldGUgZW5kIG9mIG92ZXJzY3JvbGwKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxOTk2MAorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vNzI1OTU1MjE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgU2Nyb2xsIGxhdGNoaW5nIGZvciBtb21lbnR1bSBzY3Jv bGxzIHdhcyB0b28gc3RpY2t5OyBpdCB3b3VsZCBrZWVwIGxhdGNoaW5nIHRvIHRoZSBzYW1lCisg ICAgICAgIHNjcm9sbGVyIHdpdGhpbiBhIDEwMG1zIG9mIHRoZSBsYXN0IGV2ZW50IHRoYXQgd2Fz IGhhbmRsZWQsIHdoaWNoIHdhcyBleGFjZXJiYXRlZCBieSB0aGUKKyAgICAgICAgZmFjdCB0aGF0 IFNjcm9sbENvbnRyb2xsZXIgY2FuIGdvIGludG8gImlnbm9yZU1vbWVudHVtU2Nyb2xscyIgbW9k ZSB3aGljaCByZXN1bHRzIGluCisgICAgICAgIG5vIHZpc2libGUgc2Nyb2xsaW5nIGJ1dCBjb250 aW51ZWQgY29uc3VtcHRpb24gb2YgbW9tZW50dW0gd2hlZWwgZXZlbnRzLgorCisgICAgICAgIEZp eCBieSByZWxlYXNpbmcgdGhlIGxhdGNoIGFzIHNvb24gYXMgd2Ugc2VlIHRoZSBlbmQgb2YgYSBt b21lbnR1bSBzY3JvbGwsCisgICAgICAgIHNvIHRoYXQgd2UgYWx3YXlzIHJlLWV2YWx1YXRlIGxh dGNoaW5nIGF0IHRoZSBzdGFydCBvZiB0aGUgbmV4dCBnZXN0dXJlLgorCisgICAgICAgIFRlc3Rl ZCBieSBmYXN0L3Njcm9sbGluZy9sYXRjaGluZy9uZXN0ZWQtY3Jvc3MtYXhpcy1sYXRjaC1leHBp cmF0aW9uLmh0bWwKKworICAgICAgICAqIHBhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1RyZWVMYXRj aGluZ0NvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsaW5nVHJlZUxhdGNo aW5nQ29udHJvbGxlcjo6bm9kZURpZEhhbmRsZUV2ZW50KToKKwogMjAyMS0wMS0yMSAgU2ltb24g RnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChB c3luYyBvdmVyZmxvdyk6IFNjcm9sbCBzdHV0dGVycy9ibG9ja2VkIHdpdGggbmVzdGVkIHNjcm9s bGluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5n VHJlZUxhdGNoaW5nQ29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGlu Zy9TY3JvbGxpbmdUcmVlTGF0Y2hpbmdDb250cm9sbGVyLmNwcAppbmRleCAyMzNlYzBjNjRkYWIy NjkxNmM4MGM1MWQyM2NjZDIyMTk4OTM0MDlmLi43OTQxMjIwNjk0M2VmOTZhOWMxMTNmZTFkMDU2 OGU3OTUwZWJiODI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9T Y3JvbGxpbmdUcmVlTGF0Y2hpbmdDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w YWdlL3Njcm9sbGluZy9TY3JvbGxpbmdUcmVlTGF0Y2hpbmdDb250cm9sbGVyLmNwcApAQCAtOTUs NyArOTUsMTAgQEAgdm9pZCBTY3JvbGxpbmdUcmVlTGF0Y2hpbmdDb250cm9sbGVyOjpub2RlRGlk SGFuZGxlRXZlbnQoU2Nyb2xsaW5nTm9kZUlEIHNjcm9sbGkKICAgICBMb2NrSG9sZGVyIGxvY2tl cihtX2xhdGNoZWROb2RlTXV0ZXgpOwogCiAgICAgaWYgKHdoZWVsRXZlbnQudXNlTGF0Y2hlZEV2 ZW50RWxlbWVudCgpICYmIG1fbGF0Y2hlZE5vZGVBbmRTdGVwcyAmJiBtX2xhdGNoZWROb2RlQW5k U3RlcHMtPnNjcm9sbGluZ05vZGVJRCA9PSBzY3JvbGxpbmdOb2RlSUQpIHsKLSAgICAgICAgbV9s YXN0TGF0Y2hlZE5vZGVJbnRlcmF0aW9uVGltZSA9IE1vbm90b25pY1RpbWU6Om5vdygpOworICAg ICAgICBpZiAod2hlZWxFdmVudC5pc0VuZE9mTW9tZW50dW1TY3JvbGwoKSkKKyAgICAgICAgICAg IG1fbGFzdExhdGNoZWROb2RlSW50ZXJhdGlvblRpbWUgPSB7IH07CisgICAgICAgIGVsc2UKKyAg ICAgICAgICAgIG1fbGFzdExhdGNoZWROb2RlSW50ZXJhdGlvblRpbWUgPSBNb25vdG9uaWNUaW1l Ojpub3coKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGM3YzQ0MDE2NDAwNzE0 MTQ4OGViMTQxMmE2NmVkMzRiNTA2ZDkxZTguLjY1YWVhOWQyZGQ2MTE0OWQxMzdjZTcyNGE4MWQ2 MTY3MGZiMzUxZWUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMS0wMS0yMSAgU2ltb24gRnJh c2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBTY3JvbGwtY2hhaW5pbmcg bm90IHRyaWdnZXJpbmcgYmVmb3JlIGNvbXBsZXRlIGVuZCBvZiBvdmVyc2Nyb2xsCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTk5NjAKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzcyNTk1NTIxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogZmFzdC9zY3JvbGxpbmcvbGF0Y2hpbmcvbmVzdGVkLWNyb3Nz LWF4aXMtbGF0Y2gtZXhwaXJhdGlvbi1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9zY3Jv bGxpbmcvbGF0Y2hpbmcvbmVzdGVkLWNyb3NzLWF4aXMtbGF0Y2gtZXhwaXJhdGlvbi5odG1sOgor CiAyMDIxLTAxLTIxICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAg ICAgICAgIFJFR1JFU1NJT04gKD8pOiBTY3JvbGwgc3R1dHRlcnMvYmxvY2tlZCB3aXRoIG5lc3Rl ZCBzY3JvbGxpbmcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qvc2Nyb2xsaW5nL2xhdGNo aW5nL25lc3RlZC1jcm9zcy1heGlzLWxhdGNoLWV4cGlyYXRpb24tZXhwZWN0ZWQudHh0IGIvTGF5 b3V0VGVzdHMvZmFzdC9zY3JvbGxpbmcvbGF0Y2hpbmcvbmVzdGVkLWNyb3NzLWF4aXMtbGF0Y2gt ZXhwaXJhdGlvbi1leHBlY3RlZC50eHQKaW5kZXggM2Q0MzFjMjI2M2Q4ZGExMDJhZWI1MWY2Y2Jk M2FhMWZlZGU2YzAxMS4uNjViMzJhYzlhNmM5OTk4OTY0OGRmZjZmM2RlNDY0NzY1OWVhZmIwYyAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9zY3JvbGxpbmcvbGF0Y2hpbmcvbmVzdGVkLWNy b3NzLWF4aXMtbGF0Y2gtZXhwaXJhdGlvbi1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMv ZmFzdC9zY3JvbGxpbmcvbGF0Y2hpbmcvbmVzdGVkLWNyb3NzLWF4aXMtbGF0Y2gtZXhwaXJhdGlv bi1leHBlY3RlZC50eHQKQEAgLTEsNSArMSw1IEBACiBQQVNTIGlubmVyT3ZlcmZsb3dTY3JvbGxF dmVudENvdW50ID4gMCBpcyB0cnVlCi1QQVNTIG91dGVyT3ZlcmZsb3dTY3JvbGxFdmVudENvdW50 IGlzIDAKK1BBU1Mgb3V0ZXJPdmVyZmxvd1Njcm9sbEV2ZW50Q291bnQgPiAwIGlzIHRydWUKIFBB U1Mgd2luZG93U2Nyb2xsRXZlbnRDb3VudCBpcyAwCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBp cyB0cnVlCiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qvc2Nyb2xsaW5nL2xhdGNoaW5n L25lc3RlZC1jcm9zcy1heGlzLWxhdGNoLWV4cGlyYXRpb24uaHRtbCBiL0xheW91dFRlc3RzL2Zh c3Qvc2Nyb2xsaW5nL2xhdGNoaW5nL25lc3RlZC1jcm9zcy1heGlzLWxhdGNoLWV4cGlyYXRpb24u aHRtbAppbmRleCBhNWM2YmM2MThjN2Q1ODliZTVkNGM4ZTE3MTQ1YTc3ZTU5MGZkYWYwLi41NmYz MTllOGY1Nzc3MTY0NzJjYjUzZWVhZmYzZTM5ZWZlZGNiMGE1IDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9mYXN0L3Njcm9sbGluZy9sYXRjaGluZy9uZXN0ZWQtY3Jvc3MtYXhpcy1sYXRjaC1leHBp cmF0aW9uLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9zY3JvbGxpbmcvbGF0Y2hpbmcvbmVz dGVkLWNyb3NzLWF4aXMtbGF0Y2gtZXhwaXJhdGlvbi5odG1sCkBAIC0xMDcsNyArMTA3LDcgQEAK ICAgICAgICAgZnVuY3Rpb24gY2hlY2tGb3JTY3JvbGwoKQogICAgICAgICB7CiAgICAgICAgICAg ICBzaG91bGRCZVRydWUoJ2lubmVyT3ZlcmZsb3dTY3JvbGxFdmVudENvdW50ID4gMCcpOwotICAg ICAgICAgICAgc2hvdWxkQmUoJ291dGVyT3ZlcmZsb3dTY3JvbGxFdmVudENvdW50JywgJzAnKTsK KyAgICAgICAgICAgIHNob3VsZEJlVHJ1ZSgnb3V0ZXJPdmVyZmxvd1Njcm9sbEV2ZW50Q291bnQg PiAwJyk7CiAgICAgICAgICAgICBzaG91bGRCZSgnd2luZG93U2Nyb2xsRXZlbnRDb3VudCcsICcw Jyk7CiAgICAgICAgICAgICBmaW5pc2hKU1Rlc3QoKTsKICAgICAgICAgfQo=