219953 2020-12-16 10:57:46 -0800 CachedRefPtr should adoptRef before calling ref to appease RefCounted's debug assertions 2020-12-18 15:15:20 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=219909 InRadar P2 Normal --- 1 ryanhaddad saam darin ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1715167 0 ryanhaddad 2020-12-16 10:57:46 -0800 616 tests are asserting on the debug JSC bot https://build.webkit.org/builders/Apple-Catalina-Debug-JSC-Tests/builds/2053/steps/jscore-test/logs/stdio ASSERTION FAILED: !m_adoptionIsRequired /Volumes/Data/slave/catalina-debug/build/WebKitBuild/Debug/usr/local/include/wtf/RefCounted.h(47) : void WTF::RefCountedBase::ref() const 1 0x10d832cc9 WTFCrash 2 0x10f00ef5b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x10f1dd28c WTF::RefCountedBase::ref() const 4 0x10e2fd391 WTF::DefaultRefDerefTraits<JSC::TDZEnvironmentLink>::refIfNotNull(JSC::TDZEnvironmentLink*) 5 0x10f0a4818 JSC::CachedRefPtr<JSC::CachedTDZEnvironmentLink, JSC::TDZEnvironmentLink, WTF::RawPtrTraits<JSC::TDZEnvironmentLink> >::decode(JSC::Decoder&) const 6 0x10f0a4775 JSC::CachedRefPtr<JSC::CachedTDZEnvironmentLink, JSC::TDZEnvironmentLink, WTF::RawPtrTraits<JSC::TDZEnvironmentLink> >::decode(JSC::Decoder&, WTF::RefPtr<JSC::TDZEnvironmentLink, WTF::RawPtrTraits<JSC::TDZEnvironmentLink>, WTF::DefaultRefDerefTraits<JSC::TDZEnvironmentLink> >&) const 7 0x10f0a45c1 JSC::CachedFunctionExecutableRareData::decode(JSC::Decoder&) const 8 0x10f0a435b JSC::UnlinkedFunctionExecutable::RareData* JSC::CachedPtr<JSC::CachedFunctionExecutableRareData, JSC::UnlinkedFunctionExecutable::RareData>::decode<>(JSC::Decoder&, bool&) const 9 0x10f0a4281 JSC::UnlinkedFunctionExecutable::RareData* JSC::CachedPtr<JSC::CachedFunctionExecutableRareData, JSC::UnlinkedFunctionExecutable::RareData>::decode<>(JSC::Decoder&) const 10 0x10f0a4016 JSC::CachedFunctionExecutable::rareData(JSC::Decoder&) const 11 0x10f0a3b0f JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable(JSC::Decoder&, JSC::CachedFunctionExecutable const&) 12 0x10f0a3555 JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable(JSC::Decoder&, JSC::CachedFunctionExecutable const&) 13 0x10f0a3417 JSC::CachedFunctionExecutable::decode(JSC::Decoder&) const 14 0x10f0a323b JSC::UnlinkedFunctionExecutable* JSC::CachedPtr<JSC::CachedFunctionExecutable, JSC::UnlinkedFunctionExecutable>::decode<>(JSC::Decoder&, bool&) const 15 0x10f0a3051 JSC::UnlinkedFunctionExecutable* JSC::CachedPtr<JSC::CachedFunctionExecutable, JSC::UnlinkedFunctionExecutable>::decode<>(JSC::Decoder&) const 16 0x10f0a2ff5 JSC::CachedWriteBarrier<JSC::CachedFunctionExecutable, JSC::UnlinkedFunctionExecutable>::decode(JSC::Decoder&, JSC::WriteBarrier<JSC::UnlinkedFunctionExecutable, WTF::RawPtrTraits<JSC::UnlinkedFunctionExecutable> >&, JSC::JSCell const*) const 17 0x10f0a2b50 std::__1::enable_if<!(std::is_same<JSC::CachedWriteBarrier<JSC::CachedFunctionExecutable, JSC::UnlinkedFunctionExecutable>, JSC::SourceTypeImpl<JSC::CachedWriteBarrier<JSC::CachedFunctionExecutable, JSC::UnlinkedFunctionExecutable>, void>::type>::value), void>::type JSC::decode<JSC::CachedWriteBarrier<JSC::CachedFunctionExecutable, JSC::UnlinkedFunctionExecutable>, JSC::UnlinkedCodeBlock*>(JSC::Decoder&, JSC::CachedWriteBarrier<JSC::CachedFunctionExecutable, JSC::UnlinkedFunctionExecutable> const&, JSC::SourceTypeImpl<JSC::CachedWriteBarrier<JSC::CachedFunctionExecutable, JSC::UnlinkedFunctionExecutable>, void>::type&, JSC::UnlinkedCodeBlock*) 18 0x10f09c3f3 void JSC::CachedVector<JSC::CachedWriteBarrier<JSC::CachedFunctionExecutable, JSC::UnlinkedFunctionExecutable>, 0ul, WTF::CrashOnOverflow, WTF::FastMalloc>::decode<JSC::UnlinkedCodeBlock*>(JSC::Decoder&, WTF::RefCountedArray<JSC::WriteBarrier<JSC::UnlinkedFunctionExecutable, WTF::RawPtrTraits<JSC::UnlinkedFunctionExecutable> >, WTF::RawPtrTraits<JSC::WriteBarrier<JSC::UnlinkedFunctionExecutable, WTF::RawPtrTraits<JSC::UnlinkedFunctionExecutable> > > >&, JSC::UnlinkedCodeBlock*) const 19 0x10f091c0d JSC::CachedCodeBlock<JSC::UnlinkedProgramCodeBlock>::decode(JSC::Decoder&, JSC::UnlinkedCodeBlock&) const 20 0x10f091913 JSC::CachedProgramCodeBlock::decode(JSC::Decoder&) const 21 0x10f0916fb JSC::UnlinkedProgramCodeBlock* JSC::CachedPtr<JSC::CachedProgramCodeBlock, JSC::UnlinkedProgramCodeBlock>::decode<>(JSC::Decoder&, bool&) const 22 0x10f08e2d1 JSC::UnlinkedProgramCodeBlock* JSC::CachedPtr<JSC::CachedProgramCodeBlock, JSC::UnlinkedProgramCodeBlock>::decode<>(JSC::Decoder&) const 23 0x10f060479 JSC::CacheEntry<JSC::UnlinkedProgramCodeBlock>::decode(JSC::Decoder&, std::__1::pair<JSC::SourceCodeKey, JSC::UnlinkedProgramCodeBlock*>&) const 24 0x10f06020e JSC::GenericCacheEntry::decode(JSC::Decoder&, std::__1::pair<JSC::SourceCodeKey, JSC::UnlinkedCodeBlock*>&) const 25 0x10f061023 JSC::decodeCodeBlockImpl(JSC::VM&, JSC::SourceCodeKey const&, WTF::Ref<JSC::CachedBytecode, WTF::RawPtrTraits<JSC::CachedBytecode> >) 26 0x10f0bc725 JSC::UnlinkedProgramCodeBlock* JSC::decodeCodeBlock<JSC::UnlinkedProgramCodeBlock>(JSC::VM&, JSC::SourceCodeKey const&, WTF::Ref<JSC::CachedBytecode, WTF::RawPtrTraits<JSC::CachedBytecode> >) 27 0x10f0bc5ab JSC::UnlinkedProgramCodeBlock* JSC::CodeCacheMap::fetchFromDiskImpl<JSC::UnlinkedProgramCodeBlock>(JSC::VM&, JSC::SourceCodeKey const&) 28 0x10f0bc1c5 std::__1::enable_if<(std::is_base_of<JSC::UnlinkedCodeBlock, JSC::UnlinkedProgramCodeBlock>::value) && (!(std::is_same<JSC::UnlinkedProgramCodeBlock, JSC::UnlinkedEvalCodeBlock>::value)), JSC::UnlinkedProgramCodeBlock*>::type JSC::CodeCacheMap::fetchFromDisk<JSC::UnlinkedProgramCodeBlock>(JSC::VM&, JSC::SourceCodeKey const&) 29 0x10f0bbcd8 JSC::UnlinkedProgramCodeBlock* JSC::CodeCacheMap::findCacheAndUpdateAge<JSC::UnlinkedProgramCodeBlock>(JSC::VM&, JSC::SourceCodeKey const&) 30 0x10f064353 JSC::UnlinkedProgramCodeBlock* JSC::CodeCache::getUnlinkedGlobalCodeBlock<JSC::UnlinkedProgramCodeBlock, JSC::ProgramExecutable>(JSC::VM&, JSC::ProgramExecutable*, JSC::SourceCode const&, JSC::JSParserStrictMode, JSC::JSParserScriptMode, WTF::OptionSet<JSC::CodeGenerationMode>, JSC::ParserError&, JSC::EvalContextType) 31 0x10f0641c9 JSC::CodeCache::getUnlinkedProgramCodeBlock(JSC::VM&, JSC::ProgramExecutable*, JSC::SourceCode const&, JSC::JSParserStrictMode, WTF::OptionSet<JSC::CodeGenerationMode>, JSC::ParserError&) 1715168 1 webkit-bug-importer 2020-12-16 10:58:00 -0800 <rdar://problem/72391255> 1715244 2 ryanhaddad 2020-12-16 15:27:28 -0800 Maybe https://trac.webkit.org/changeset/270870/webkit? 1715762 3 416531 saam 2020-12-18 11:12:57 -0800 Created attachment 416531 patch 1715778 4 416531 tzagallo 2020-12-18 11:48:57 -0800 Comment on attachment 416531 patch r=me 1715781 5 416531 darin 2020-12-18 12:00:25 -0800 Comment on attachment 416531 patch View in context: https://bugs.webkit.org/attachment.cgi?id=416531&action=review > Source/JavaScriptCore/runtime/CachedTypes.cpp:560 > + RefPtr<Source, PtrTraits> result = adoptRef(decodedPtr); Two related questions: 1) Is it OK that this calls adoptRef without template arguments rather than calling adoptRef<Source, PtrTraits>? 2) Would you consider using auto here instead of writing out the RefPtr type? 1715815 6 saam 2020-12-18 14:40:34 -0800 (In reply to Darin Adler from comment #5) > Comment on attachment 416531 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=416531&action=review > > > Source/JavaScriptCore/runtime/CachedTypes.cpp:560 > > + RefPtr<Source, PtrTraits> result = adoptRef(decodedPtr); > > Two related questions: > > 1) Is it OK that this calls adoptRef without template arguments rather than > calling adoptRef<Source, PtrTraits>? Probably not. Good call, I will fix. This is probably fine for the particular types we currently use it for, but it'd probably not work for future types that make use of non default PtrTraits. > 2) Would you consider using auto here instead of writing out the RefPtr type? Auto seems ok 1715817 7 416547 saam 2020-12-18 14:43:59 -0800 Created attachment 416547 patch for landing 1715823 8 ews-feeder 2020-12-18 15:15:19 -0800 Committed r270991: <https://trac.webkit.org/changeset/270991> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416547. 416531 2020-12-18 11:12:57 -0800 2020-12-18 14:43:59 -0800 patch c-backup.diff text/plain 1398 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjcwOTc4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDIwLTEyLTE4ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IENhY2hlZFJlZlB0ciBzaG91bGQgYWRvcHRSZWYgYmVmb3JlIGNhbGxpbmcgcmVmIHRvIGFwcGVh c2UgUmVmQ291bnRlZCdzIGRlYnVnIGFzc2VydGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxOTk1MworICAgICAgICA8cmRhcjovL3Byb2JsZW0v NzIzOTEyNTU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBydW50aW1lL0NhY2hlZFR5cGVzLmNwcDoKKyAgICAgICAgKEpTQzo6Q2FjaGVkUmVmUHRy OjpkZWNvZGUgY29uc3QpOgorCiAyMDIwLTEyLTE4ICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBh cHBsZS5jb20+CiAKICAgICAgICAgW0NTU0pJVF0gRG8gbm90IHVzZSB0cmFtcG9saW5lIGlmIEpJ VENhZ2UgaXMgZGlzYWJsZWQKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0Nh Y2hlZFR5cGVzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9DYWNoZWRUeXBlcy5jcHAJKHJldmlzaW9uIDI3MDk3NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0NhY2hlZFR5cGVzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTU3LDggKzU1 Nyw5IEBAIHB1YmxpYzoKICAgICAgICAgICAgICAgICBXVEY6OkRlZmF1bHRSZWZEZXJlZlRyYWl0 czxTb3VyY2U+OjpkZXJlZklmTm90TnVsbChkZWNvZGVkUHRyKTsKICAgICAgICAgICAgIH0pOwog ICAgICAgICB9Ci0gICAgICAgIFdURjo6RGVmYXVsdFJlZkRlcmVmVHJhaXRzPFNvdXJjZT46OnJl ZklmTm90TnVsbChkZWNvZGVkUHRyKTsKLSAgICAgICAgcmV0dXJuIGFkb3B0UmVmKGRlY29kZWRQ dHIpOworICAgICAgICBSZWZQdHI8U291cmNlLCBQdHJUcmFpdHM+IHJlc3VsdCA9IGFkb3B0UmVm KGRlY29kZWRQdHIpOworICAgICAgICByZXN1bHQtPnJlZigpOworICAgICAgICByZXR1cm4gcmVz dWx0OwogICAgIH0KIAogICAgIHZvaWQgZGVjb2RlKERlY29kZXImIGRlY29kZXIsIFJlZlB0cjxT b3VyY2UsIFB0clRyYWl0cz4mIHNyYykgY29uc3QK 416547 2020-12-18 14:43:59 -0800 2020-12-18 15:15:20 -0800 patch for landing c-backup.diff text/plain 1395 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjcwOTc4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDIwLTEyLTE4ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IENhY2hlZFJlZlB0ciBzaG91bGQgYWRvcHRSZWYgYmVmb3JlIGNhbGxpbmcgcmVmIHRvIGFwcGVh c2UgUmVmQ291bnRlZCdzIGRlYnVnIGFzc2VydGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxOTk1MworICAgICAgICA8cmRhcjovL3Byb2JsZW0v NzIzOTEyNTU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgVGFkZXUgWmFnYWxsby4KKworICAgICAg ICAqIHJ1bnRpbWUvQ2FjaGVkVHlwZXMuY3BwOgorICAgICAgICAoSlNDOjpDYWNoZWRSZWZQdHI6 OmRlY29kZSBjb25zdCk6CisKIDIwMjAtMTItMTggIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFw cGxlLmNvbT4KIAogICAgICAgICBbQ1NTSklUXSBEbyBub3QgdXNlIHRyYW1wb2xpbmUgaWYgSklU Q2FnZSBpcyBkaXNhYmxlZApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ2Fj aGVkVHlwZXMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0NhY2hlZFR5cGVzLmNwcAkocmV2aXNpb24gMjcwOTc2KQorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvQ2FjaGVkVHlwZXMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NTcsOCArNTU3 LDkgQEAgcHVibGljOgogICAgICAgICAgICAgICAgIFdURjo6RGVmYXVsdFJlZkRlcmVmVHJhaXRz PFNvdXJjZT46OmRlcmVmSWZOb3ROdWxsKGRlY29kZWRQdHIpOwogICAgICAgICAgICAgfSk7CiAg ICAgICAgIH0KLSAgICAgICAgV1RGOjpEZWZhdWx0UmVmRGVyZWZUcmFpdHM8U291cmNlPjo6cmVm SWZOb3ROdWxsKGRlY29kZWRQdHIpOwotICAgICAgICByZXR1cm4gYWRvcHRSZWYoZGVjb2RlZFB0 cik7CisgICAgICAgIGF1dG8gcmVzdWx0ID0gYWRvcHRSZWY8U291cmNlLCBQdHJUcmFpdHM+KGRl Y29kZWRQdHIpOworICAgICAgICByZXN1bHQtPnJlZigpOworICAgICAgICByZXR1cm4gcmVzdWx0 OwogICAgIH0KIAogICAgIHZvaWQgZGVjb2RlKERlY29kZXImIGRlY29kZXIsIFJlZlB0cjxTb3Vy Y2UsIFB0clRyYWl0cz4mIHNyYykgY29uc3QK