219934 2020-12-15 22:16:32 -0800 [Flatpak SDK] coredumpctl invocation when using a local SDK repo fallbacks to the remote repo 2021-01-06 05:46:21 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=219933 InRadar P2 Normal --- 1 lmoura lmoura bugs-noreply ews-watchlist glenn jbedard pnormand webkit-bug-importer oldest_to_newest 1715022 0 lmoura 2020-12-15 22:16:32 -0800 While investigating bug219933, building the updated SDK followed by running `update-webkit-flatpak`, running a test that crashes shows the following message: ``` Flatpak package org.webkit.Sdk.Debug/x86_64/0.3 not installed. Please update your SDK: Tools/Scripts/update-webkit-flatpak ``` Digging a bit deeper, indeed org.webkit.Sdk.Debug was not being shown in the output of `flatpak list` when generating the list of FlatpakPackages in flatpakutils.py, despite executing the same command in the shell[1] shows the Debug component (org.webkit.Sdk.Locale is present though). The issue is that linux_get_crash_log.py's _get_trace_from_flatpak invokes webkit-flatpak on the host without keeping the WEBKIT_FLATPAK_USER_DIR variable, making it fall back to the regular remote repo scheme. In my case, installing the remote packages. Due to the silent and lengthy process, after a ctrl+c this remote clone ended incomplete, thus the missing org.webkit.Sdk.Debug message. WIP patch already working. Will submit after cleanup. [1] `flatpak list --user --columns=application,arch,branch,origin -a` 1717305 1 417004 lmoura 2021-01-05 07:51:13 -0800 Created attachment 417004 Patch 1717315 2 417004 pnormand 2021-01-05 08:29:32 -0800 Comment on attachment 417004 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417004&action=review > Tools/Scripts/webkitpy/port/linux_get_crash_log.py:117 > + user_dir = os.environ.get('WEBKIT_FLATPAK_USER_DIR') > + if user_dir: > + cmd.append("--env=WEBKIT_FLATPAK_USER_DIR=%s" % user_dir) Might be simpler to pass-through the env to popen? 1717384 3 lmoura 2021-01-05 10:22:22 -0800 (In reply to Philippe Normand from comment #2) > Comment on attachment 417004 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=417004&action=review > > > Tools/Scripts/webkitpy/port/linux_get_crash_log.py:117 > > + user_dir = os.environ.get('WEBKIT_FLATPAK_USER_DIR') > > + if user_dir: > > + cmd.append("--env=WEBKIT_FLATPAK_USER_DIR=%s" % user_dir) > > Might be simpler to pass-through the env to popen? It's already passed through env as it's popen's default behavior to inherit the environment. The issue is that flatpak-spawn needs to be instructed which "non default" variables needs to be exported when creating the new shell for the new host command. 1717627 4 lmoura 2021-01-06 05:45:34 -0800 Committed r271199: <https://trac.webkit.org/changeset/271199> 1717628 5 webkit-bug-importer 2021-01-06 05:46:21 -0800 <rdar://problem/72849449> 417004 2021-01-05 07:51:13 -0800 2021-01-06 02:42:05 -0800 Patch bug-219934-20210105125112.patch text/plain 2560 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwNzk1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGIzMmU1YzU1ODQ3NGVlOTNmNTQ0YmVkYjhjMDQ3NWZh MzA4MDdmNS4uYTlkNmVjZjQxMThkNTdmY2JkYTY2YjJjYWVhNTgyZmYxZTM2MzA1MSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDIxLTAxLTA1ICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAg ICAgIFtGbGF0cGFrIFNES10gY29yZWR1bXBjdGwgaW52b2NhdGlvbiB3aGVuIHVzaW5nIGEgbG9j YWwgU0RLIHJlcG8gZmFsbGJhY2tzIHRvIHRoZSByZW1vdGUgcmVwbworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE5OTM0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU29tZSBjb21tYW5kcyBydW4gaW4gZmxh dHBhayBtYXkgZW5kIHVwIGNhbGxpbmcgb3RoZXIgY29tbWFuZHMgb24gdGhlCisgICAgICAgIGhv c3QgdGhyb3VnaCBmbGF0cGFrLXNwYXduIHRoYXQgd291bGQgZW50ZXIgdGhlIGZsYXRwYWsgZW52 aXJvbm1lbnQKKyAgICAgICAgYWdhaW4uIE9uZSBzdWNoIGNvbW1hbmQgaGFwcGVucyB3aGVuIGdl dHRpbmcgY3Jhc2ggbG9ncywgd2hpY2ggaW52b2tlcworICAgICAgICB3ZWJraXQtZmxhdHBhayB3 aXRoIC0tZ2RiLXN0YWNrLXRyYWNlLgorCisgICAgICAgIEJlZm9yZSB0aGlzIGNvbW1pdCwgdGhl IFdFQktJVF9GTEFUUEFLX1VTRVJfRElSIGlzIG5vdCBmb3J3YXJkZWQsCisgICAgICAgIG1ha2lu ZyBmbGF0cGFrdXRpbHMucHkgdG8gZG93bmxvYWQgdGhlIHJlZ3VsYXIgVXNlckZsYXRwYWsgU0RL IGluc3RlYWQKKyAgICAgICAgb2YgdXNpbmcgdGhlIG9uZSBpbiB0aGUgbWVudGlvbmVkIHZhcmlh YmxlLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L2xpbnV4X2dldF9jcmFzaF9s b2cucHk6CisgICAgICAgIChHREJDcmFzaExvZ0dlbmVyYXRvci5fZ2V0X3RyYWNlX2Zyb21fZmxh dHBhayk6CisKIDIwMjAtMTItMTQgIExhdXJvIE1vdXJhICA8bG1vdXJhQGlnYWxpYS5jb20+CiAK ICAgICAgICAgW0ZsYXBhayBTREtdIEFsbG93IHNldHRpbmcgY3VzdG9tIFNESyByZXBvc2l0b3J5 IGxvY2F0aW9ucyBhbmQgb3RoZXIgc21hbGwgZml4ZXMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvcG9ydC9saW51eF9nZXRfY3Jhc2hfbG9nLnB5IGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9wb3J0L2xpbnV4X2dldF9jcmFzaF9sb2cucHkKaW5kZXggMDM2NDhiMDczYmZlYjIz ZGI4YjExYzY0N2RkMzdjNWY0MTgyNTFlMi4uMDNkMTc0MDhhZTY1MGMyNWU4ODcwNjUxNzBlN2I4 NjdiZjJiNWJmYSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2xpbnV4 X2dldF9jcmFzaF9sb2cucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2xpbnV4 X2dldF9jcmFzaF9sb2cucHkKQEAgLTEwOCw4ICsxMDgsMTYgQEAgY2xhc3MgR0RCQ3Jhc2hMb2dH ZW5lcmF0b3Iob2JqZWN0KToKICAgICAgICAgZWxzZToKICAgICAgICAgICAgIGNvcmVkdW1wX3Np bmNlID0gIi0tZ2RiLXN0YWNrLXRyYWNlIgogICAgICAgICB3ZWJraXRfZmxhdHBha19wYXRoID0g c2VsZi5fd2Via2l0X2ZpbmRlci5wYXRoX3RvX3NjcmlwdCgnd2Via2l0LWZsYXRwYWsnKQotICAg ICAgICBjbWQgPSBbJ2ZsYXRwYWstc3Bhd24nLCAnLS1ob3N0Jywgd2Via2l0X2ZsYXRwYWtfcGF0 aCwgJy0tJXMnICUgc2VsZi5fcG9ydF9uYW1lLAotICAgICAgICAgICAgICAgIi0tJXMiICUgc2Vs Zi5fY29uZmlndXJhdGlvbi5sb3dlcigpLCBjb3JlZHVtcF9zaW5jZV0KKyAgICAgICAgY21kID0g WydmbGF0cGFrLXNwYXduJywgJy0taG9zdCddCisKKyAgICAgICAgIyBGb3J3YXJkIFdFQktJVF9G TEFUUEFLX1VTRVJfRElSIHNvIHdlYmtpdC1mbGF0cGFrIGNhbiB1c2UgdGhlIHNhbWUgZmxhdHBh aworICAgICAgICAjIGluc3RhbGwgYXMgdGhlIGN1cnJlbnQgb25lLgorICAgICAgICB1c2VyX2Rp ciA9IG9zLmVudmlyb24uZ2V0KCdXRUJLSVRfRkxBVFBBS19VU0VSX0RJUicpCisgICAgICAgIGlm IHVzZXJfZGlyOgorICAgICAgICAgICAgY21kLmFwcGVuZCgiLS1lbnY9V0VCS0lUX0ZMQVRQQUtf VVNFUl9ESVI9JXMiICUgdXNlcl9kaXIpCisKKyAgICAgICAgY21kLmV4dGVuZChbd2Via2l0X2Zs YXRwYWtfcGF0aCwgJy0tJXMnICUgc2VsZi5fcG9ydF9uYW1lLAorICAgICAgICAgICAgICAgICAg ICAiLS0lcyIgJSBzZWxmLl9jb25maWd1cmF0aW9uLmxvd2VyKCksICItLXZlcmJvc2UiLCBjb3Jl ZHVtcF9zaW5jZV0pCiAKICAgICAgICAgcHJvYyA9IHNlbGYuX2V4ZWN1dGl2ZS5wb3BlbihjbWQs IHN0ZGluPU5vbmUsIHN0ZG91dD1zdWJwcm9jZXNzLlBJUEUsIHN0ZGVycj1zdWJwcm9jZXNzLlBJ UEUpCiAgICAgICAgIGNyYXNoX2xvZywgc3RkZXJyID0gcHJvYy5jb21tdW5pY2F0ZSgpCg==