219932 2020-12-15 19:54:12 -0800 Calls to setFixedLayoutSize() should not be inside ENABLE(TEXT_AUTOSIZING) 2020-12-22 08:03:20 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1715010 0 simon.fraser 2020-12-15 19:54:12 -0800 Calls to setFixedLayoutSize() should be inside ENABLE(TEXT_AUTOSIZING) 1715011 1 416312 simon.fraser 2020-12-15 19:56:06 -0800 Created attachment 416312 Patch 1715013 2 simon.fraser 2020-12-15 20:00:00 -0800 Note to self: fix changelog title. 1716214 3 simon.fraser 2020-12-22 08:02:06 -0800 https://trac.webkit.org/changeset/270889/webkit 1716218 4 webkit-bug-importer 2020-12-22 08:03:20 -0800 <rdar://problem/72587885> 416312 2020-12-15 19:56:06 -0800 2020-12-15 19:57:20 -0800 Patch bug-219932-20201215195605.patch text/plain 3971 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwODUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU5ZDQyMzQ1OTExZWM2NjEy MWVkZDI3MzViYTZjN2RmYzcyYjAwOTkuLmRjNDAyMTI5ZTZkYmZhYTdkYTI5ZGY5MjY2YTZhNjI5 Yzk1MTU5YjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjAtMTItMTUgIFNpbW9uIEZy YXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgQ2FsbHMgdG8gc2V0Rml4 ZWRMYXlvdXRTaXplKCkgc2hvdWxkIGJlIGluc2lkZSBFTkFCTEUoVEVYVF9BVVRPU0laSU5HKQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE5OTMyCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgYWx3YXlz IHdhbnQgdG8gY2FsbCBzZXRGaXhlZExheW91dFNpemUoKSwgd2hldGhlciBvciBub3QgRU5BQkxF KFRFWFRfQVVUT1NJWklORykgaXMgZGVmaW5lZC4KKyAgICAgICAgCisgICAgICAgIEZvciBjb2Rl IHNpbXBsaWNpdHksIG1ha2UgcmVzZXRUZXh0QXV0b3NpemluZygpIGFuIGVtcHR5IGZ1bmN0aW9u IHdoZW4gRU5BQkxFKFRFWFRfQVVUT1NJWklORykKKyAgICAgICAgaXMgbm90IGRlZmluZWQuCisK KyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oOgorICAgICAgICAqIFdlYlBy b2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFn ZTo6ZHluYW1pY1ZpZXdwb3J0U2l6ZVVwZGF0ZSk6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6 OnJlc2V0VGV4dEF1dG9zaXppbmcpOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjp2aWV3cG9y dENvbmZpZ3VyYXRpb25DaGFuZ2VkKToKKwogMjAyMC0xMi0xNSAgU2ltb24gRnJhc2VyICA8c2lt b24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgYmF0Y2hpbmcgdG8gV2ViUHJlZmVy ZW5jZXMgdXBkYXRlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBh Z2UvV2ViUGFnZS5oIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5o CmluZGV4IDAzNWVjMmYwMWI0Mzg5NTIyMTIzZDllMTczMTA5YTIxNWYwOGJiMWEuLmU3YTJiNzli MzYxOTU2M2U4MDFlMjRlYjM3NWY3ZjhiYzliMzFmOGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmgKQEAgLTE0MzUsOSArMTQzNSw5IEBAIHByaXZhdGU6CiAK ICNpZiBFTkFCTEUoVEVYVF9BVVRPU0laSU5HKQogICAgIHZvaWQgdGV4dEF1dG9TaXppbmdBZGp1 c3RtZW50VGltZXJGaXJlZCgpOwotICAgIHZvaWQgcmVzZXRUZXh0QXV0b3NpemluZygpOwogICAg IHZvaWQgcmVzZXRJZGVtcG90ZW50VGV4dEF1dG9zaXppbmdJZk5lZWRlZChkb3VibGUgcHJldmlv dXNJbml0aWFsU2NhbGUpOwogI2VuZGlmCisgICAgdm9pZCByZXNldFRleHRBdXRvc2l6aW5nKCk7 CiAKICNpZiBFTkFCTEUoVklFV1BPUlRfUkVTSVpJTkcpCiAgICAgdm9pZCBzaHJpbmtUb0ZpdENv bnRlbnQoWm9vbVRvSW5pdGlhbFNjYWxlID0gWm9vbVRvSW5pdGlhbFNjYWxlOjpObyk7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5t bSBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCmlu ZGV4IDBlMjkzZmE0ZGYxOWNiZjhjZDY3OTMxNzZkNzg3ODkyYWQ4ZTEyODEuLjU3M2MzYjAxMjEw YzZiODQ2OGI2ZTJjM2I5NTU3YTRlYjQ1MjNhZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCkBAIC0zMzEzLDEwICszMzEzLDkg QEAgdm9pZCBXZWJQYWdlOjpkeW5hbWljVmlld3BvcnRTaXplVXBkYXRlKGNvbnN0IEZsb2F0U2l6 ZSYgdmlld0xheW91dFNpemUsIGNvbnN0IFcKIAogICAgIEludFNpemUgbmV3TGF5b3V0U2l6ZSA9 IG1fdmlld3BvcnRDb25maWd1cmF0aW9uLmxheW91dFNpemUoKTsKIAotI2lmIEVOQUJMRShURVhU X0FVVE9TSVpJTkcpCiAgICAgaWYgKHNldEZpeGVkTGF5b3V0U2l6ZShuZXdMYXlvdXRTaXplKSkK ICAgICAgICAgcmVzZXRUZXh0QXV0b3NpemluZygpOwotI2VuZGlmCisKICAgICBzZXRNYXhpbXVt VW5vYnNjdXJlZFNpemUobWF4aW11bVVub2JzY3VyZWRTaXplKTsKICAgICBtX3BhZ2UtPnNldFVu b2JzY3VyZWRTYWZlQXJlYUluc2V0cyh0YXJnZXRVbm9ic2N1cmVkU2FmZUFyZWFJbnNldHMpOwog CkBAIC0zNTE4LDE3ICszNTE3LDE5IEBAIHZvaWQgV2ViUGFnZTo6cmVzZXRJZGVtcG90ZW50VGV4 dEF1dG9zaXppbmdJZk5lZWRlZChkb3VibGUgcHJldmlvdXNJbml0aWFsU2NhbGUpCiAgICAgLy8g V2UgZG9uJ3QgbmVlZCB0byB1cGRhdGUgdGV4dCBzaXppbmcgZWFnZXJseS4gVGhlcmUgbWlnaHQg YmUgbXVsdGlwbGUgaW5jb21pbmcgZHluYW1pYyB2aWV3cG9ydCBjaGFuZ2VzLgogICAgIG1fdGV4 dEF1dG9TaXppbmdBZGp1c3RtZW50VGltZXIuc3RhcnRPbmVTaG90KHRleHRBdXRvU2l6aW5nRGVs YXkoKSk7CiB9CisjZW5kaWYgLy8gRU5BQkxFKFRFWFRfQVVUT1NJWklORykKIAogdm9pZCBXZWJQ YWdlOjpyZXNldFRleHRBdXRvc2l6aW5nKCkKIHsKKyNpZiBFTkFCTEUoVEVYVF9BVVRPU0laSU5H KQogICAgIGZvciAoRnJhbWUqIGZyYW1lID0gJm1fcGFnZS0+bWFpbkZyYW1lKCk7IGZyYW1lOyBm cmFtZSA9IGZyYW1lLT50cmVlKCkudHJhdmVyc2VOZXh0KCkpIHsKICAgICAgICAgRG9jdW1lbnQq IGRvY3VtZW50ID0gZnJhbWUtPmRvY3VtZW50KCk7CiAgICAgICAgIGlmICghZG9jdW1lbnQgfHwg IWRvY3VtZW50LT5yZW5kZXJWaWV3KCkpCiAgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAg ZG9jdW1lbnQtPnJlbmRlclZpZXcoKS0+cmVzZXRUZXh0QXV0b3NpemluZygpOwogICAgIH0KLX0K ICNlbmRpZgorfQogCiAjaWYgRU5BQkxFKFZJRVdQT1JUX1JFU0laSU5HKQogCkBAIC0zNjE5LDEw ICszNjIwLDEwIEBAIHZvaWQgV2ViUGFnZTo6dmlld3BvcnRDb25maWd1cmF0aW9uQ2hhbmdlZCha b29tVG9Jbml0aWFsU2NhbGUgem9vbVRvSW5pdGlhbFNjYWxlCiAgICAgZG91YmxlIHByZXZpb3Vz SW5pdGlhbFNjYWxlSWdub3JpbmdDb250ZW50U2l6ZSA9IG1fcGFnZS0+aW5pdGlhbFNjYWxlSWdu b3JpbmdDb250ZW50U2l6ZSgpOwogICAgIG1fcGFnZS0+c2V0SW5pdGlhbFNjYWxlSWdub3JpbmdD b250ZW50U2l6ZShpbml0aWFsU2NhbGVJZ25vcmluZ0NvbnRlbnRTaXplKTsKICAgICByZXNldElk ZW1wb3RlbnRUZXh0QXV0b3NpemluZ0lmTmVlZGVkKHByZXZpb3VzSW5pdGlhbFNjYWxlSWdub3Jp bmdDb250ZW50U2l6ZSk7Ci0KKyNlbmRpZgogICAgIGlmIChzZXRGaXhlZExheW91dFNpemUobV92 aWV3cG9ydENvbmZpZ3VyYXRpb24ubGF5b3V0U2l6ZSgpKSkKICAgICAgICAgcmVzZXRUZXh0QXV0 b3NpemluZygpOwotI2VuZGlmCisKICAgICBkb3VibGUgc2NhbGU7CiAgICAgaWYgKG1fdXNlckhh c0NoYW5nZWRQYWdlU2NhbGVGYWN0b3IgJiYgem9vbVRvSW5pdGlhbFNjYWxlID09IFpvb21Ub0lu aXRpYWxTY2FsZTo6Tm8pCiAgICAgICAgIHNjYWxlID0gc3RkOjptYXgoc3RkOjptaW4ocGFnZVNj YWxlRmFjdG9yKCksIG1fdmlld3BvcnRDb25maWd1cmF0aW9uLm1heGltdW1TY2FsZSgpKSwgbV92 aWV3cG9ydENvbmZpZ3VyYXRpb24ubWluaW11bVNjYWxlKCkpOwo=