219929 2020-12-15 16:50:09 -0800 destinationFor should check for FTLJIT, not DFGJIT twice 2020-12-15 18:33:17 -0800 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam ews-watchlist keith_miller mark.lam msaboff tzagallo webkit-bug-importer oldest_to_newest 1714971 0 saam 2020-12-15 16:50:09 -0800 ... 1714972 1 416303 saam 2020-12-15 16:53:26 -0800 Created attachment 416303 patch 1714980 2 416303 keith_miller 2020-12-15 17:35:23 -0800 Comment on attachment 416303 patch View in context: https://bugs.webkit.org/attachment.cgi?id=416303&action=review > Source/JavaScriptCore/bytecode/BytecodeOperandsForCheckpoint.h:103 > + if (type == JITType::DFGJIT || type == JITType::FTLJIT) Nah that seems legit :P 1714981 3 saam 2020-12-15 17:40:27 -0800 (In reply to Keith Miller from comment #2) > Comment on attachment 416303 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=416303&action=review > > > Source/JavaScriptCore/bytecode/BytecodeOperandsForCheckpoint.h:103 > > + if (type == JITType::DFGJIT || type == JITType::FTLJIT) > > Nah that seems legit :P :-) 1714997 4 ews-feeder 2020-12-15 18:32:48 -0800 Committed r270877: <https://trac.webkit.org/changeset/270877> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416303. 1714998 5 webkit-bug-importer 2020-12-15 18:33:17 -0800 <rdar://problem/72366903> 416303 2020-12-15 16:53:26 -0800 2020-12-15 18:32:48 -0800 patch c-backup.diff text/plain 1801 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjcwODc0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDIwLTEyLTE1ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IGRlc3RpbmF0aW9uRm9yIHNob3VsZCBjaGVjayBmb3IgRlRMSklULCBub3QgREZHSklUIHR3aWNl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTk5MjkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgY29k ZSB3YXMgY2hlY2tpbmcgZm9yIERGR0pJVCB0d2ljZSBpbnN0ZWFkIG9mIGNoZWNraW5nIGZvciBG VExKSVQuCisgICAgICAgIFRoaXMgZG9lc24ndCBmaXggYW55IGFjdHVhbCBidWdzLCBzaW5jZSBu b2JvZHkgcGFzc2VzIGluIEZUTEpJVCB0byB0aGlzCisgICAgICAgIGZ1bmN0aW9uLiBCdXQgaWYg d2UgZXZlciBkbyBpbiB0aGUgZnV0dXJlLCBpdCB3b3VsZCBoYXZlIHJldmVhbGVkIHRoaXMgYnVn LgorCisgICAgICAgICogYnl0ZWNvZGUvQnl0ZWNvZGVPcGVyYW5kc0ZvckNoZWNrcG9pbnQuaDoK KyAgICAgICAgKEpTQzo6ZGVzdGluYXRpb25Gb3IpOgorCiAyMDIwLTEyLTE1ICBBbGV4ZXkgU2h2 YXlrYSAgPHNodmFpa2FsZXNoQGdtYWlsLmNvbT4KIAogICAgICAgICBOb24tZW51bWVyYWJsZSBw cm9wZXJ0eSBmYWlscyB0byBzaGFkb3cgaW5oZXJpdGVkIGVudW1lcmFibGUgcHJvcGVydHkgZnJv bSBmb3ItaW4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9CeXRlY29kZU9w ZXJhbmRzRm9yQ2hlY2twb2ludC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ieXRlY29kZS9CeXRlY29kZU9wZXJhbmRzRm9yQ2hlY2twb2ludC5oCShyZXZpc2lvbiAyNzA4 NzMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQnl0ZWNvZGVPcGVyYW5kc0Zv ckNoZWNrcG9pbnQuaAkod29ya2luZyBjb3B5KQpAQCAtMTAwLDcgKzEwMCw3IEBAIE9wZXJhbmQg ZGVzdGluYXRpb25Gb3IoY29uc3QgQnl0ZWNvZGUmIGIKICAgICB9IGVsc2UgaWYgY29uc3RleHBy IChCeXRlY29kZTo6b3Bjb2RlSUQgPT0gb3BfaXRlcmF0b3JfbmV4dCkgewogICAgICAgICBzd2l0 Y2ggKGNoZWNrcG9pbnRJbmRleCkgewogICAgICAgICBjYXNlIE9wSXRlcmF0b3JOZXh0Ojpjb21w dXRlTmV4dDogewotICAgICAgICAgICAgaWYgKHR5cGUgPT0gSklUVHlwZTo6REZHSklUIHx8IHR5 cGUgPT0gSklUVHlwZTo6REZHSklUKQorICAgICAgICAgICAgaWYgKHR5cGUgPT0gSklUVHlwZTo6 REZHSklUIHx8IHR5cGUgPT0gSklUVHlwZTo6RlRMSklUKQogICAgICAgICAgICAgICAgIHJldHVy biBPcGVyYW5kOjp0bXAoT3BJdGVyYXRvck5leHQ6Om5leHRSZXN1bHQpOwogICAgICAgICAgICAg cmV0dXJuIGJ5dGVjb2RlLm1fdmFsdWU7IC8vIFdlIHJldXNlIHZhbHVlIGFzIGEgdGVtcCBiZWNh dXNlIGl0cyBlaXRoZXIgbm90IHVzZWQgaW4gc3Vic2VxdWVudCBieXRlY29kZXMgb3Igd3JpdHRl biBhcyB0aGUgdGVtcCBvYmplY3QgLgogICAgICAgICB9Cg==