219920 2020-12-15 13:47:26 -0800 [CMake][WPE] Add LibWPE before WPEBackend-FDO for qtwpe_INCLUDE_DIRECTORIES 2020-12-15 23:01:01 -0800 1 1 1 Unclassified WebKit CMake WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 psaavedra psaavedra annulen aperez calvaris don.olmstead ews-watchlist gyuyoung.kim mcatanzaro pnormand ryuan.choi sergio oldest_to_newest 1714916 0 psaavedra 2020-12-15 13:47:26 -0800 ... included as System libraries. In other case a build error like this can happen: #error "Only <wpe/fdo.h> can be included directly." ; because the wpe-1.0/wpe/wpe.h looks for the version.h header but it finds the wpe-fdo-1.0/wpe/version.h instead of from wpe-1.0 because the WPEBackend-FDO lib is defined as system lib and the libWPE library not. The way to avoid this it could ensuring the right order of the -isystem flags by appending before the LibWPE as a system lib: `list(APPEND WebCore_LIBRARIES ${WPE_INCLUDE_DIRS})` before adding the WPEbackend-fdo system libraries. Similar fix: https://bugs.webkit.org/show_bug.cgi?id=219835 1714917 1 416290 psaavedra 2020-12-15 13:49:01 -0800 Created attachment 416290 patch 1715028 2 ews-feeder 2020-12-15 23:00:59 -0800 Committed r270880: <https://trac.webkit.org/changeset/270880> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416290. 416290 2020-12-15 13:49:01 -0800 2020-12-15 23:01:00 -0800 patch bug-219920-20201215224900.patch text/plain 1140 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwODYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGRjNTJiZDYwZjZkYTkxZWYx NGY4OTI1OGY0NWQ5YjY5ZDliZGMxNjEuLjI1YWZkOTBiOThhNGYwMmVmMDJmZjA5NWYwODg4NTNj MTQ2NDgxYTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjAtMTItMTUgIFBhYmxvIFNh YXZlZHJhICA8cHNhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0NNYWtlXVtXUEVdIEFk ZCBMaWJXUEUgYmVmb3JlIFdQRUJhY2tlbmQtRkRPIGZvciBxdHdwZV9JTkNMVURFX0RJUkVDVE9S SUVTCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTk5 MjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFBs YXRmb3JtV1BFLmNtYWtlOgorCiAyMDIwLTEyLTE1ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNp ZWhAYXBwbGUuY29tPgogCiAgICAgICAgIEltYWdlIGV4dHJhY3Rpb24gaW50ZXJhY3Rpb24gc2hv dWxkIHJlbWFpbiBhY3RpdmUgd2hpbGUgc2Nyb2xsaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L1BsYXRmb3JtV1BFLmNtYWtlIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybVdQRS5jbWFrZQpp bmRleCBmZDRhNmUyZTRkN2UxNDc4MDE2MWVkNDhlMjM4ZmJjZjcxYzk2MjM4Li4wNDdjMzc1YTFi Yjc3NjA5OTEyYjEyM2U2NmU0ZTMzMGMzYjYwZWNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L1BsYXRmb3JtV1BFLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1XUEUuY21ha2UK QEAgLTQxMSw2ICs0MTEsNyBAQCBpZiAoRU5BQkxFX1dQRV9RVF9BUEkpCiAgICAgICAgICR7UXQ1 R3VpX1BSSVZBVEVfSU5DTFVERV9ESVJTfQogICAgICAgICAke0xJQkVQT1hZX0lOQ0xVREVfRElS U30KICAgICAgICAgJHtMSUJTT1VQX0lOQ0xVREVfRElSU30KKyAgICAgICAgJHtXUEVfSU5DTFVE RV9ESVJTfQogICAgICAgICAke1dQRUJBQ0tFTkRfRkRPX0lOQ0xVREVfRElSU30KICAgICApCiAK