219914 2020-12-15 12:37:37 -0800 Flaky crash under AudioBuffer::channelData() when running layout tests 2020-12-16 19:17:20 -0800 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez cdumez eric.carlson ews-watchlist ggaren glenn jer.noble peng.liu6 philipj sergio webkit-bug-importer oldest_to_newest 1714882 0 cdumez 2020-12-15 12:37:37 -0800 Flaky crash under AudioBuffer::channelData() when running layout tests: Thread 19 Crashed:: RemoteAudioDestinationProxy render thread 0 com.apple.JavaScriptCore 0x0000000777d4bb6e WTFCrash + 14 (Assertions.cpp:295) 1 com.apple.WebCore 0x0000000757797f61 WTF::RefCountedBase::applyRefDerefThreadingCheck() const + 177 (RefCounted.h:114) 2 com.apple.WebCore 0x00000007577ca85c WTF::RefCountedBase::ref() const + 28 (RefCounted.h:43) 3 com.apple.WebCore 0x0000000757d52637 WTF::DefaultRefDerefTraits<JSC::GenericTypedArrayView<JSC::Float32Adaptor> >::refIfNotNull(JSC::GenericTypedArrayView<JSC::Float32Adaptor>*) + 55 (RefPtr.h:36) 4 com.apple.WebCore 0x0000000757d525f4 WTF::RefPtr<JSC::GenericTypedArrayView<JSC::Float32Adaptor>, WTF::RawPtrTraits<JSC::GenericTypedArrayView<JSC::Float32Adaptor> >, WTF::DefaultRefDerefTraits<JSC::GenericTypedArrayView<JSC::Float32Adaptor> > >::RefPtr(JSC::GenericTypedArrayView<JSC::Float32Adaptor>*) + 36 (RefPtr.h:61) 5 com.apple.WebCore 0x0000000757d5162d WTF::RefPtr<JSC::GenericTypedArrayView<JSC::Float32Adaptor>, WTF::RawPtrTraits<JSC::GenericTypedArrayView<JSC::Float32Adaptor> >, WTF::DefaultRefDerefTraits<JSC::GenericTypedArrayView<JSC::Float32Adaptor> > >::RefPtr(JSC::GenericTypedArrayView<JSC::Float32Adaptor>*) + 29 (RefPtr.h:61) 6 com.apple.WebCore 0x0000000759a29a36 WTF::RefPtr<JSC::GenericTypedArrayView<JSC::Float32Adaptor>, WTF::RawPtrTraits<JSC::GenericTypedArrayView<JSC::Float32Adaptor> >, WTF::DefaultRefDerefTraits<JSC::GenericTypedArrayView<JSC::Float32Adaptor> > >::copyRef() const & + 38 (RefPtr.h:104) 7 com.apple.WebCore 0x0000000759a29872 WebCore::AudioBuffer::channelData(unsigned int) + 194 (AudioBuffer.cpp:169) 8 com.apple.WebCore 0x0000000759b02e81 WebCore::ScriptProcessorNode::process(unsigned long) + 1281 (ScriptProcessorNode.cpp:170) 9 com.apple.WebCore 0x0000000759a577ae WebCore::AudioNode::processIfNecessary(unsigned long) + 462 (AudioNode.cpp:474) 10 com.apple.WebCore 0x0000000759a5a127 WebCore::AudioNodeOutput::pull(WebCore::AudioBus*, unsigned long) + 407 (AudioNodeOutput.cpp:120) 11 com.apple.WebCore 0x0000000759a59ef6 WebCore::AudioNodeInput::sumAllConnections(WebCore::AudioBus*, unsigned long) + 566 (AudioNodeInput.cpp:193) 12 com.apple.WebCore 0x0000000759a51da7 WebCore::AudioNodeInput::pull(WebCore::AudioBus*, unsigned long) + 295 (AudioNodeInput.cpp:221) 13 com.apple.WebCore 0x0000000759a51949 WebCore::AudioDestinationNode::render(WebCore::AudioBus*, WebCore::AudioBus*, unsigned long, WebCore::AudioIOPosition const&) + 457 (AudioDestinationNode.cpp:91) 1714884 1 416281 cdumez 2020-12-15 12:48:43 -0800 Created attachment 416281 Patch 1715295 2 416281 ggaren 2020-12-16 18:53:00 -0800 Comment on attachment 416281 Patch R=me 1715298 3 ews-feeder 2020-12-16 19:16:48 -0800 Committed r270924: <https://trac.webkit.org/changeset/270924> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416281. 1715299 4 webkit-bug-importer 2020-12-16 19:17:20 -0800 <rdar://problem/72410113> 416281 2020-12-15 12:48:43 -0800 2020-12-16 19:16:49 -0800 Patch bug-219914-20201215124842.patch text/plain 4544 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwODQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzliOGExYmM0YTNjNzI1 NzRiOWU4NzIwMGIwN2M2Y2M1N2ZhMzc3MC4uNjZkYWMzYmQzOGZkNmFhNDkzZTljZDYyODBjMTdm MTExYTUzY2Q3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDIwLTEyLTE1ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRmxha3kgY3Jhc2ggdW5kZXIg QXVkaW9CdWZmZXI6OmNoYW5uZWxEYXRhKCkgd2hlbiBydW5uaW5nIGxheW91dCB0ZXN0cworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE5OTE0CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGlzc3VlIHdh cyB0aGF0IEF1ZGlvQnVmZmVyOjpjaGFubmVsRGF0YSgpIHJldHVybnMgYSBSZWZQdHI8RmxvYXQz MkFycmF5PiwKKyAgICAgICAgRmxvYXQzMkFycmF5IG5vdCBiZWluZyBUaHJlYWRTYWZlUmVmQ291 bnRlZC4gVGhlIEF1ZGlvQnVmZmVycyBpbiBTY3JpcHRQcm9jZXNzb3JOb2RlCisgICAgICAgIGFy ZSBjb25zdHJ1Y3RlZCBvbiB0aGUgbWFpbiB0aHJlYWQgYnV0IFNjcmlwdFByb2Nlc3Nvck5vZGU6 OnByb2Nlc3MoKSB3YXMgY2FsbGluZworICAgICAgICBBdWRpb0J1ZmZlcjo6Y2hhbm5lbERhdGEo KSBvbiB0aGUgYXVkaW8gcmVuZGVyaW5nIHRocmVhZC4gVGhpcyB3b3VsZCBkbyBzb21lCisgICAg ICAgIG5vbi10aHJlYWQtc2FmZSByZWZjb3VudGluZyBjaHVybiB3aGljaCB3b3VsZCBjYXVzZSB0 aGUgY3Jhc2hlcy4KKworICAgICAgICBUbyBhZGRyZXNzIHRoZSBpc3N1ZSwgSSBpbnRyb2R1Y2Vk IEF1ZGlvQnVmZmVyOjpyYXdDaGFubmVsRGF0YSgpIHdoaWNoIHJldHVybnMKKyAgICAgICAgdGhl IGRhdGEgYXMgYSBmbG9hdCosIHdpdGhvdXQgYW55IHJlZmNvdW50aW5nLiBJIHBvcnRlZCBTY3Jp cHRQcm9jZXNzb3JOb2RlOjpwcm9jZXNzKCkKKyAgICAgICAgdG8gdXNlIEF1ZGlvQnVmZmVyOjpy YXdDaGFubmVsRGF0YSgpIGluc3RlYWQgb2YgQXVkaW9CdWZmZXI6OmNoYW5uZWxEYXRhKCkuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzLCBjb3ZlcmVkIGJ5IGV4aXN0aW5nIGxheW91dCB0ZXN0cyB0 aGF0IGFyZSBmbGFraWx5IGNyYXNoaW5nLgorCisgICAgICAgICogTW9kdWxlcy93ZWJhdWRpby9B dWRpb0J1ZmZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBdWRpb0J1ZmZlcjo6cmF3Q2hhbm5l bERhdGEpOgorICAgICAgICAqIE1vZHVsZXMvd2ViYXVkaW8vQXVkaW9CdWZmZXIuaDoKKyAgICAg ICAgKiBNb2R1bGVzL3dlYmF1ZGlvL1NjcmlwdFByb2Nlc3Nvck5vZGUuY3BwOgorICAgICAgICAo V2ViQ29yZTo6U2NyaXB0UHJvY2Vzc29yTm9kZTo6cHJvY2Vzcyk6CisKIDIwMjAtMTItMTUgIENo cmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBbR1BVUHJvY2Vzc10gQXZv aWQgZG9pbmcgYW4gSVBDIHBlciByZW5kZXJpbmcgcXVhbnR1bSB3aGVuIHVzaW5nIFdlYkF1ZGlv CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvQnVmZmVy LmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9CdWZmZXIuY3BwCmlu ZGV4IGYzZGI2NDg5NThkY2E2M2MxY2E0M2Q3NTQzYTc5ZDE5YTAwZGViNDguLmM1OWJjOWM0NGE1 YmE2NWI0YjhkMGViYWE3NjA5YmM2NjI1MmUzMzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvd2ViYXVkaW8vQXVkaW9CdWZmZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvd2ViYXVkaW8vQXVkaW9CdWZmZXIuY3BwCkBAIC0xNjksNiArMTY5LDE1IEBAIFJlZlB0 cjxGbG9hdDMyQXJyYXk+IEF1ZGlvQnVmZmVyOjpjaGFubmVsRGF0YSh1bnNpZ25lZCBjaGFubmVs SW5kZXgpCiAgICAgcmV0dXJuIG1fY2hhbm5lbHNbY2hhbm5lbEluZGV4XS5jb3B5UmVmKCk7CiB9 CiAKK2Zsb2F0KiBBdWRpb0J1ZmZlcjo6cmF3Q2hhbm5lbERhdGEodW5zaWduZWQgY2hhbm5lbElu ZGV4KQoreworICAgIGlmIChjaGFubmVsSW5kZXggPj0gbV9jaGFubmVscy5zaXplKCkpCisgICAg ICAgIHJldHVybiBudWxscHRyOworICAgIGlmIChoYXNEZXRhY2hlZENoYW5uZWxCdWZmZXIoKSkK KyAgICAgICAgcmV0dXJuIG51bGxwdHI7CisgICAgcmV0dXJuIG1fY2hhbm5lbHNbY2hhbm5lbElu ZGV4XS0+ZGF0YSgpOworfQorCiBFeGNlcHRpb25Pcjx2b2lkPiBBdWRpb0J1ZmZlcjo6Y29weUZy b21DaGFubmVsKFJlZjxGbG9hdDMyQXJyYXk+JiYgZGVzdGluYXRpb24sIHVuc2lnbmVkIGNoYW5u ZWxOdW1iZXIsIHVuc2lnbmVkIGJ1ZmZlck9mZnNldCkKIHsKICAgICBpZiAoZGVzdGluYXRpb24t PmlzU2hhcmVkKCkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlv L0F1ZGlvQnVmZmVyLmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvQnVm ZmVyLmgKaW5kZXggNWRhNTMyNmRjOGRmOTcwMDg0MGMyOWRjZDU0YTNhZjYxZDg3OGVmNS4uZTkw OTMxZTc1NTI2MDk3MzAwYzU4MWNlN2VhNDNhNjUzNTNmM2M4NCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb0J1ZmZlci5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9CdWZmZXIuaApAQCAtNjUsNiArNjUsNyBAQCBwdWJs aWM6CiAKICAgICAvLyBOYXRpdmUgY2hhbm5lbCBkYXRhIGFjY2Vzcy4KICAgICBSZWZQdHI8Rmxv YXQzMkFycmF5PiBjaGFubmVsRGF0YSh1bnNpZ25lZCBjaGFubmVsSW5kZXgpOworICAgIGZsb2F0 KiByYXdDaGFubmVsRGF0YSh1bnNpZ25lZCBjaGFubmVsSW5kZXgpOwogICAgIHZvaWQgemVybygp OwogCiAgICAgLy8gQmVjYXVzZSBhbiBBdWRpb0J1ZmZlciBoYXMgYSBKYXZhU2NyaXB0IHdyYXBw ZXIsIHdoaWNoIHdpbGwgYmUgZ2FyYmFnZSBjb2xsZWN0ZWQsIGl0IG1heSB0YWtlIGEgd2hpbGUg Zm9yIHRoaXMgb2JqZWN0IHRvIGJlIGRlbGV0ZWQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL3dlYmF1ZGlvL1NjcmlwdFByb2Nlc3Nvck5vZGUuY3BwIGIvU291cmNlL1dlYkNv cmUvTW9kdWxlcy93ZWJhdWRpby9TY3JpcHRQcm9jZXNzb3JOb2RlLmNwcAppbmRleCAxNTlhNmFk MjViMDc2MWEyNjgxMDk1NGFhZjY5ZDUyYzM1OTMzNjE3Li5kOTg3MjE5OGYxZTk4OGY5MDAyYTBi ODYyY2JmNDM4YzhhYTFiZTNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dl YmF1ZGlvL1NjcmlwdFByb2Nlc3Nvck5vZGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvd2ViYXVkaW8vU2NyaXB0UHJvY2Vzc29yTm9kZS5jcHAKQEAgLTE2NywxNCArMTY3LDE0IEBA IHZvaWQgU2NyaXB0UHJvY2Vzc29yTm9kZTo6cHJvY2VzcyhzaXplX3QgZnJhbWVzVG9Qcm9jZXNz KQogICAgICAgICByZXR1cm47CiAKICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgbnVtYmVy T2ZJbnB1dENoYW5uZWxzOyBpKyspCi0gICAgICAgIG1faW50ZXJuYWxJbnB1dEJ1cy0+c2V0Q2hh bm5lbE1lbW9yeShpLCBpbnB1dEJ1ZmZlci0+Y2hhbm5lbERhdGEoaSktPmRhdGEoKSArIG1fYnVm ZmVyUmVhZFdyaXRlSW5kZXgsIGZyYW1lc1RvUHJvY2Vzcyk7CisgICAgICAgIG1faW50ZXJuYWxJ bnB1dEJ1cy0+c2V0Q2hhbm5lbE1lbW9yeShpLCBpbnB1dEJ1ZmZlci0+cmF3Q2hhbm5lbERhdGEo aSkgKyBtX2J1ZmZlclJlYWRXcml0ZUluZGV4LCBmcmFtZXNUb1Byb2Nlc3MpOwogCiAgICAgaWYg KG51bWJlck9mSW5wdXRDaGFubmVscykKICAgICAgICAgbV9pbnRlcm5hbElucHV0QnVzLT5jb3B5 RnJvbSgqaW5wdXRCdXMpOwogCiAgICAgLy8gQ29weSBmcm9tIHRoZSBvdXRwdXQgYnVmZmVyIHRv IHRoZSBvdXRwdXQuIAogICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBudW1iZXJPZk91dHB1 dENoYW5uZWxzOyArK2kpCi0gICAgICAgIG1lbWNweShvdXRwdXRCdXMtPmNoYW5uZWwoaSktPm11 dGFibGVEYXRhKCksIG91dHB1dEJ1ZmZlci0+Y2hhbm5lbERhdGEoaSktPmRhdGEoKSArIG1fYnVm ZmVyUmVhZFdyaXRlSW5kZXgsIHNpemVvZihmbG9hdCkgKiBmcmFtZXNUb1Byb2Nlc3MpOworICAg ICAgICBtZW1jcHkob3V0cHV0QnVzLT5jaGFubmVsKGkpLT5tdXRhYmxlRGF0YSgpLCBvdXRwdXRC dWZmZXItPnJhd0NoYW5uZWxEYXRhKGkpICsgbV9idWZmZXJSZWFkV3JpdGVJbmRleCwgc2l6ZW9m KGZsb2F0KSAqIGZyYW1lc1RvUHJvY2Vzcyk7CiAKICAgICAvLyBVcGRhdGUgdGhlIGJ1ZmZlcmlu ZyBpbmRleC4KICAgICBtX2J1ZmZlclJlYWRXcml0ZUluZGV4ID0gKG1fYnVmZmVyUmVhZFdyaXRl SW5kZXggKyBmcmFtZXNUb1Byb2Nlc3MpICUgYnVmZmVyU2l6ZSgpOwo=