219895 2020-12-15 09:27:28 -0800 Image extraction interaction should remain active while scrolling 2020-12-15 10:53:32 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin hi megan_gardner thorton webkit-bug-importer oldest_to_newest 1714775 0 wenson_hsieh 2020-12-15 09:27:28 -0800 <rdar://problem/72344814> 1714779 1 416256 wenson_hsieh 2020-12-15 09:34:52 -0800 Created attachment 416256 Patch 1714811 2 416256 hi 2020-12-15 10:37:46 -0800 Comment on attachment 416256 Patch r=me 1714817 3 416256 wenson_hsieh 2020-12-15 10:50:21 -0800 Comment on attachment 416256 Patch Thanks for the review! 1714819 4 ews-feeder 2020-12-15 10:53:31 -0800 Committed r270853: <https://trac.webkit.org/changeset/270853> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416256. 416256 2020-12-15 09:34:52 -0800 2020-12-15 10:53:31 -0800 Patch bug-219895-20201215093451.patch text/plain 6305 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwNzk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDIyYzhjZWRmMGUxY2IxNzFl NDUxMGRjZTM1ZmE4YmExNWIwYzkzNzAuLmY2OTAyYTdmNzM3OGY2NzRkMTIyN2JkZTdhZjZhNzcy MjI3MWE3OGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMjAtMTItMTUgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgSW1hZ2UgZXh0cmFjdGlv biBpbnRlcmFjdGlvbiBzaG91bGQgcmVtYWluIGFjdGl2ZSB3aGlsZSBzY3JvbGxpbmcKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxOTg5NQorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vNzIzNDQ4MTQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTWFrZSBvdXIgaW1hZ2UgZXh0cmFjdGlvbiBpbnRlcmFjdGlv biBiZWhhdmUgbW9yZSBsaWtlIHRoZSByZXN0IG9mIHRoZSBzeXN0ZW0gYnkgbWFraW5nIGl0IHBl cnNpc3QgdW50aWwKKyAgICAgICAgZXhwbGljaXRseSBkaXNtaXNzZWQgdmlhIHRhcCBnZXN0dXJl IChvciBhbnkgb3RoZXIgY29tcGV0aW5nIGludGVyYWN0aW9uLCBzdWNoIGFzIHRleHQgaW50ZXJh Y3Rpb25zLCBkcmFnCisgICAgICAgIGludGVyYWN0aW9ucyBhbmQgY29udGV4dCBtZW51IGludGVy YWN0aW9ucywgYXMgbG9uZyBhcyB0aGUgaW50ZXJhY3Rpb24gbG9jYXRpb24gaXMgb3V0c2lkZSBv ZiB0aGUgYWN0aXZlIGltYWdlCisgICAgICAgIGV4dHJhY3Rpb24gaW50ZXJhY3Rpb24pLgorCisg ICAgICAgIFdlIGN1cnJlbnRseSBqdXN0IGRpc21pc3MgYW55IGFjdGl2ZSBpbWFnZSBleHRyYWN0 aW9uIHVwb24gc3RhcnRpbmcgYSBuZXcgdG91Y2gsIHdoaWNoIHByZXZlbnRzIHNjcm9sbGluZyBm cm9tCisgICAgICAgIHdvcmtpbmcgYXMgZXhwZWN0ZWQgd2l0aCBpbWFnZSBleHRyYWN0aW9uLiBT ZWUgcmFkYXIgZm9yIG1vcmUgZGV0YWlscy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tD b250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IF93ZWJU b3VjaEV2ZW50c1JlY29nbml6ZWQ6XSk6CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgaGFzU2Vs ZWN0YWJsZVBvc2l0aW9uQXRQb2ludDpdKToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyB0ZXh0 SW50ZXJhY3Rpb25HZXN0dXJlOnNob3VsZEJlZ2luQXRQb2ludDpdKToKKyAgICAgICAgKC1bV0tD b250ZW50VmlldyBfc2luZ2xlVGFwSWRlbnRpZmllZDpdKToKKyAgICAgICAgKC1bV0tDb250ZW50 VmlldyBfZHJhZ0ludGVyYWN0aW9uOnByZXBhcmVGb3JTZXNzaW9uOmNvbXBsZXRpb246XSk6Cisg ICAgICAgICgtW1dLQ29udGVudFZpZXcgX2NvbnRleHRNZW51SW50ZXJhY3Rpb246Y29uZmlndXJh dGlvbkZvck1lbnVBdExvY2F0aW9uOmNvbXBsZXRpb246XSk6CisKIDIwMjAtMTItMTQgIFdlbnNv biBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgR1BVIHByb2Nlc3Mg c29tZXRpbWVzIGhhbmdzIGR1cmluZyBNb3Rpb25NYXJrIEZvY3VzIHdoZW4gZW5hYmxpbmcgR1BV IFByb2Nlc3MgZm9yIERPTQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9z L1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lv cy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KaW5kZXggOTc2NGIwOTg4N2U4NDU0MDdlYjU2 NWM0MmQ3ZTExNWU4YzA5NWY1MC4uYmZjZjA1MWYzYmUxNzBjNDNhNmE4ZWUxZjliNDVjM2VjZGJj MmE5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZp ZXdJbnRlcmFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250 ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC0xNTIxLDEwICsxNTIxLDYgQEAgLSAodm9pZClfd2Vi VG91Y2hFdmVudHNSZWNvZ25pemVkOihVSVdlYlRvdWNoRXZlbnRzR2VzdHVyZVJlY29nbml6ZXIg KilnZXN0dXJlUmUKICAgICAgICAgW3NlbGYgZG9BZnRlclBvc2l0aW9uSW5mb3JtYXRpb25VcGRh dGU6W2Fzc2lzdGFudCA9IFdlYWtPYmpDUHRyPFdLQWN0aW9uU2hlZXRBc3Npc3RhbnQ+KF9hY3Rp b25TaGVldEFzc2lzdGFudC5nZXQoKSldIChXZWJLaXQ6OkludGVyYWN0aW9uSW5mb3JtYXRpb25B dFBvc2l0aW9uIGluZm9ybWF0aW9uKSB7CiAgICAgICAgICAgICBbYXNzaXN0YW50IGludGVyYWN0 aW9uRGlkU3RhcnRXaXRoUG9zaXRpb25JbmZvcm1hdGlvbjppbmZvcm1hdGlvbl07CiAgICAgICAg IH0gZm9yUmVxdWVzdDpwb3NpdGlvbkluZm9ybWF0aW9uUmVxdWVzdF07Ci0KLSNpZiBFTkFCTEUo SU1BR0VfRVhUUkFDVElPTikKLSAgICAgICAgW3NlbGYgX2NhbmNlbEltYWdlRXh0cmFjdGlvbklm TmVlZGVkQWZ0ZXJUb3VjaEF0Ol9sYXN0SW50ZXJhY3Rpb25Mb2NhdGlvbl07Ci0jZW5kaWYKICAg ICB9CiAKICNpZiBFTkFCTEUoVE9VQ0hfRVZFTlRTKQpAQCAtMjU2OCw2ICsyNTY0LDggQEAgLSAo Qk9PTCloYXNTZWxlY3RhYmxlUG9zaXRpb25BdFBvaW50OihDR1BvaW50KXBvaW50CiAjaWYgRU5B QkxFKElNQUdFX0VYVFJBQ1RJT04pCiAgICAgaWYgKFtzZWxmIF9pbWFnZUV4dHJhY3Rpb25TaG91 bGRQcmV2ZW50VGV4dEludGVyYWN0aW9uQXRQb2ludDpwb2ludF0pCiAgICAgICAgIHJldHVybiBO TzsKKworICAgIFtzZWxmIF9jYW5jZWxJbWFnZUV4dHJhY3Rpb25dOwogI2VuZGlmCiAKICAgICBp ZiAoX2luc3BlY3Rvck5vZGVTZWFyY2hFbmFibGVkKQpAQCAtMjYxOCw2ICsyNjE2LDggQEAgLSAo Qk9PTCl0ZXh0SW50ZXJhY3Rpb25HZXN0dXJlOihVSVdLR2VzdHVyZVR5cGUpZ2VzdHVyZSBzaG91 bGRCZWdpbkF0UG9pbnQ6KENHUG8KICNpZiBFTkFCTEUoSU1BR0VfRVhUUkFDVElPTikKICAgICBp ZiAoW3NlbGYgX2ltYWdlRXh0cmFjdGlvblNob3VsZFByZXZlbnRUZXh0SW50ZXJhY3Rpb25BdFBv aW50OnBvaW50XSkKICAgICAgICAgcmV0dXJuIE5POworCisgICAgW3NlbGYgX2NhbmNlbEltYWdl RXh0cmFjdGlvbl07CiAjZW5kaWYKIAogICAgIGlmICghc2VsZi5pc0ZvY3VzaW5nRWxlbWVudCkg ewpAQCAtMjc4Nyw2ICsyNzg3LDEwIEBAIC0gKHZvaWQpX3NpbmdsZVRhcElkZW50aWZpZWQ6KFVJ VGFwR2VzdHVyZVJlY29nbml6ZXIgKilnZXN0dXJlUmVjb2duaXplcgogICAgIF9wb3RlbnRpYWxU YXBJblByb2dyZXNzID0gWUVTOwogICAgIF9pc1RhcEhpZ2hsaWdodElEVmFsaWQgPSBZRVM7CiAg ICAgX2lzRXhwZWN0aW5nRmFzdFNpbmdsZVRhcENvbW1pdCA9ICFfZG91YmxlVGFwR2VzdHVyZVJl Y29nbml6ZXIuZ2V0KCkuZW5hYmxlZDsKKworI2lmIEVOQUJMRShJTUFHRV9FWFRSQUNUSU9OKQor ICAgIFtzZWxmIF9jYW5jZWxJbWFnZUV4dHJhY3Rpb25JZk5lZWRlZEFmdGVyVG91Y2hBdDpnZXN0 dXJlUmVjb2duaXplci5sb2NhdGlvbl07CisjZW5kaWYKIH0KIAogc3RhdGljIHZvaWQgY2FuY2Vs UG90ZW50aWFsVGFwSWZOZWNlc3NhcnkoV0tDb250ZW50VmlldyogY29udGVudFZpZXcpCkBAIC04 MTcwLDcgKzgxNzQsOSBAQCAtICh2b2lkKV9kcmFnSW50ZXJhY3Rpb246KFVJRHJhZ0ludGVyYWN0 aW9uICopaW50ZXJhY3Rpb24gcHJlcGFyZUZvclNlc3Npb246KGlkCiAgICAgICAgIGlmICghc3Ry b25nU2VsZikKICAgICAgICAgICAgIHJldHVybjsKIAorICAgICAgICBhdXRvIGRyYWdPcmlnaW4g PSBbc2Vzc2lvbiBsb2NhdGlvbkluVmlldzpzdHJvbmdTZWxmLmdldCgpXTsKICNpZiBFTkFCTEUo SU1BR0VfRVhUUkFDVElPTikKKyAgICAgICAgW3N0cm9uZ1NlbGYgX2NhbmNlbEltYWdlRXh0cmFj dGlvbklmTmVlZGVkQWZ0ZXJUb3VjaEF0OmRyYWdPcmlnaW5dOwogICAgICAgICBpZiAoc3Ryb25n U2VsZi0+X2ltYWdlRXh0cmFjdGlvblN0YXRlID09IFdlYktpdDo6SW1hZ2VFeHRyYWN0aW9uU3Rh dGU6OkFjdGl2ZSkgewogICAgICAgICAgICAgUkVMRUFTRV9MT0coRHJhZ0FuZERyb3AsICJEcmFn IHNlc3Npb24gZmFpbGVkOiAlcCAoZGVmZXJyaW5nIHRvIGFjdGl2ZSBpbWFnZSBleHRyYWN0aW9u KSIsIHNlc3Npb24uZ2V0KCkpOwogICAgICAgICAgICAgY29tcGxldGlvbigpOwpAQCAtODE3OSwx MCArODE4NSw4IEBAIC0gKHZvaWQpX2RyYWdJbnRlcmFjdGlvbjooVUlEcmFnSW50ZXJhY3Rpb24g KilpbnRlcmFjdGlvbiBwcmVwYXJlRm9yU2Vzc2lvbjooaWQKICNlbmRpZgogCiAgICAgICAgIHN0 cm9uZ1NlbGYtPl9kcmFnRHJvcEludGVyYWN0aW9uU3RhdGUucHJlcGFyZUZvckRyYWdTZXNzaW9u KHNlc3Npb24uZ2V0KCksIGNvbXBsZXRpb24uZ2V0KCkpOwotCi0gICAgICAgIGF1dG8gZHJhZ09y aWdpbiA9IFdlYkNvcmU6OnJvdW5kZWRJbnRQb2ludChbc2Vzc2lvbiBsb2NhdGlvbkluVmlldzpz dHJvbmdTZWxmLmdldCgpXSk7Ci0gICAgICAgIHN0cm9uZ1NlbGYtPl9wYWdlLT5yZXF1ZXN0RHJh Z1N0YXJ0KGRyYWdPcmlnaW4sIFdlYkNvcmU6OnJvdW5kZWRJbnRQb2ludChbc3Ryb25nU2VsZiBj b252ZXJ0UG9pbnQ6ZHJhZ09yaWdpbiB0b1ZpZXc6W3N0cm9uZ1NlbGYgd2luZG93XV0pLCBbc3Ry b25nU2VsZiBfYWxsb3dlZERyYWdTb3VyY2VBY3Rpb25zXSk7Ci0gICAgICAgIFJFTEVBU0VfTE9H KERyYWdBbmREcm9wLCAiRHJhZyBzZXNzaW9uIHJlcXVlc3RlZDogJXAgYXQgb3JpZ2luOiB7JWQs ICVkfSIsIHNlc3Npb24uZ2V0KCksIGRyYWdPcmlnaW4ueCgpLCBkcmFnT3JpZ2luLnkoKSk7Cisg ICAgICAgIHN0cm9uZ1NlbGYtPl9wYWdlLT5yZXF1ZXN0RHJhZ1N0YXJ0KFdlYkNvcmU6OnJvdW5k ZWRJbnRQb2ludChkcmFnT3JpZ2luKSwgV2ViQ29yZTo6cm91bmRlZEludFBvaW50KFtzdHJvbmdT ZWxmIGNvbnZlcnRQb2ludDpkcmFnT3JpZ2luIHRvVmlldzpbc3Ryb25nU2VsZiB3aW5kb3ddXSks IFtzdHJvbmdTZWxmIF9hbGxvd2VkRHJhZ1NvdXJjZUFjdGlvbnNdKTsKKyAgICAgICAgUkVMRUFT RV9MT0coRHJhZ0FuZERyb3AsICJEcmFnIHNlc3Npb24gcmVxdWVzdGVkOiAlcCBhdCBvcmlnaW46 IHslLjBmLCAlLjBmfSIsIHNlc3Npb24uZ2V0KCksIGRyYWdPcmlnaW4ueCwgZHJhZ09yaWdpbi55 KTsKICAgICB9OwogCiAjaWYgRU5BQkxFKElNQUdFX0VYVFJBQ1RJT04pCkBAIC05NTQ0LDcgKzk1 NDgsOSBAQCAtICh2b2lkKV9jb250ZXh0TWVudUludGVyYWN0aW9uOihVSUNvbnRleHRNZW51SW50 ZXJhY3Rpb24gKilpbnRlcmFjdGlvbiBjb25maWd1cgogICAgICAgICBpZiAoIXN0cm9uZ1NlbGYp CiAgICAgICAgICAgICByZXR1cm47CiAKKyAgICAgICAgYXV0byBwb3NpdGlvbiA9IFtpbnRlcmFj dGlvbiBsb2NhdGlvbkluVmlldzpzdHJvbmdTZWxmLmdldCgpXTsKICNpZiBFTkFCTEUoSU1BR0Vf RVhUUkFDVElPTikKKyAgICAgICAgW3N0cm9uZ1NlbGYgX2NhbmNlbEltYWdlRXh0cmFjdGlvbklm TmVlZGVkQWZ0ZXJUb3VjaEF0OnBvc2l0aW9uXTsKICAgICAgICAgaWYgKHN0cm9uZ1NlbGYtPl9p bWFnZUV4dHJhY3Rpb25TdGF0ZSA9PSBXZWJLaXQ6OkltYWdlRXh0cmFjdGlvblN0YXRlOjpBY3Rp dmUpIHsKICAgICAgICAgICAgIGNvbXBsZXRpb24obmlsKTsKICAgICAgICAgICAgIHJldHVybjsK QEAgLTk1NTcsNyArOTU2Myw2IEBAIC0gKHZvaWQpX2NvbnRleHRNZW51SW50ZXJhY3Rpb246KFVJ Q29udGV4dE1lbnVJbnRlcmFjdGlvbiAqKWludGVyYWN0aW9uIGNvbmZpZ3VyCiAgICAgICAgIGlm IChOU051bWJlciAqdmFsdWUgPSBbW05TVXNlckRlZmF1bHRzIHN0YW5kYXJkVXNlckRlZmF1bHRz XSBvYmplY3RGb3JLZXk6d2Via2l0U2hvd0xpbmtQcmV2aWV3c1ByZWZlcmVuY2VLZXldKQogICAg ICAgICAgICAgc3Ryb25nU2VsZi0+X3Nob3dMaW5rUHJldmlld3MgPSB2YWx1ZS5ib29sVmFsdWU7 CiAKLSAgICAgICAgY29uc3QgYXV0byBwb3NpdGlvbiA9IFtpbnRlcmFjdGlvbiBsb2NhdGlvbklu VmlldzpzdHJvbmdTZWxmLmdldCgpXTsKICAgICAgICAgV2ViS2l0OjpJbnRlcmFjdGlvbkluZm9y bWF0aW9uUmVxdWVzdCByZXF1ZXN0IHsgV2ViQ29yZTo6cm91bmRlZEludFBvaW50KHBvc2l0aW9u KSB9OwogICAgICAgICByZXF1ZXN0LmluY2x1ZGVTbmFwc2hvdCA9IHRydWU7CiAgICAgICAgIHJl cXVlc3QuaW5jbHVkZUxpbmtJbmRpY2F0b3IgPSB0cnVlOwo=