219870 2020-12-14 12:47:28 -0800 "make clean" fails on EmptyDSTROOT target 2020-12-15 09:12:56 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rhost webkit-unassigned ap krollin oldest_to_newest 1714554 0 rhost 2020-12-14 12:47:28 -0800 rdar://72309233 After the fix for rdar://55716322 in https://trac.webkit.org/changeset/270536/webkit, issuing "make clean" from the command line fails when it hits the EmptyDSTROOT target that was added in that revision. Steps To Reproduce: 1. From the root of OpenSource, issue "make clean" in Terminal. Results: After cleaning a bunch of targets successfully, it fails when it hits the EmptyDSTROOT target with a "Build setting PRODUCT_NAME undefined" error. Output: === CLEAN AGGREGATE TARGET EmptyDSTROOT OF PROJECT WebKit WITH CONFIGURATION Debug === Check dependencies Build setting PRODUCT_NAME undefined ** CLEAN FAILED ** The following build commands failed: Check dependencies (1 failure) make[2]: *** [clean] Error 65 make[1]: *** [clean] Error 2 make: *** [clean] Error 2 1714559 1 416188 rhost 2020-12-14 12:57:02 -0800 Created attachment 416188 Patch 1714643 2 416188 ap 2020-12-14 17:11:54 -0800 Comment on attachment 416188 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416188&action=review > Source/WebKit/WebKit.xcodeproj/project.pbxproj:14427 > + PRODUCT_NAME = "$(TARGET_NAME)"; How do we decide when to put PRODUCT_NAME in xcconfig, and when do we put it in pbxproj? I see precedent for both. 1714657 3 rhost 2020-12-14 17:44:22 -0800 (In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 416188 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=416188&action=review > > > Source/WebKit/WebKit.xcodeproj/project.pbxproj:14427 > > + PRODUCT_NAME = "$(TARGET_NAME)"; > > How do we decide when to put PRODUCT_NAME in xcconfig, and when do we put it > in pbxproj? I see precedent for both. There are a few similar script-only aggregate targets in bmalloc, JavaScriptCore, libwebrtc, WTF that keep this setting in pbxproj. I opted for the pbxproj approach as to not introduce a new file for a target that is designed to work around a bug. 1714771 4 ews-feeder 2020-12-15 09:12:56 -0800 Committed r270843: <https://trac.webkit.org/changeset/270843> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416188. 416188 2020-12-14 12:57:02 -0800 2020-12-15 09:12:56 -0800 Patch bug-219870-20201214125701.patch text/plain 1566 rhost U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwNzk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ2NDcxMmU2MWU1MTMwZmVi YTQ4YzM1MjlkNGQ2YzI3OGZhYmU3NWMuLjk3Y2NmOGU5YzE2YWQ4MjQyYWFmMjkxYzgxNmE4ZTJj MDU4YmI5NmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMTItMTQgIFJ5YW4gSG9z dGV0bGVyICA8cmhvc3RAYXBwbGUuY29tPgorCisgICAgICAgICJtYWtlIGNsZWFuIiBmYWlscyBv biBFbXB0eURTVFJPT1QgdGFyZ2V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMTk4NzAKKyAgICAgICAgcmRhcjovLzcyMzA5MjMzCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbWFrZSBjbGVhbiBjYW4ndCBm aW5kIFBST0pFQ1RfTkFNRSBmb3IgRW1wdHlEU1RST09ULgorCisgICAgICAgICogV2ViS2l0Lnhj b2RlcHJvai9wcm9qZWN0LnBieHByb2o6CisKIDIwMjAtMTItMTQgIFRpbSBIb3J0b24gIDx0aW1v dGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRvcHQgc3ltYm9sIGltYWdlIEFQSSBp bnN0ZWFkIG9mIFNQSSBpbiBXS1BERkhVRFZpZXcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv V2ViS2l0Lnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2ogYi9Tb3VyY2UvV2ViS2l0L1dlYktpdC54 Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCmluZGV4IDdlZWQ2M2E1MTYzYWJkOGY4N2QyZDA2YTZh MjhmY2JlMzZjMjgxMWYuLjdmYTlmMWJiMDU4YTY2YzVhZTA3M2FjNmFkMzcxNWI4MzdkNDI1Yjkg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViS2l0Lnhjb2RlcHJvai9wcm9qZWN0LnBieHBy b2oKKysrIGIvU291cmNlL1dlYktpdC9XZWJLaXQueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagpA QCAtMTQ0MjQsMTggKzE0NDI0LDIxIEBACiAJCTk0MkRCMjMzMjU3RUU2RDQwMDlCRDgwQSAvKiBE ZWJ1ZyAqLyA9IHsKIAkJCWlzYSA9IFhDQnVpbGRDb25maWd1cmF0aW9uOwogCQkJYnVpbGRTZXR0 aW5ncyA9IHsKKwkJCQlQUk9EVUNUX05BTUUgPSAiJChUQVJHRVRfTkFNRSkiOwogCQkJfTsKIAkJ CW5hbWUgPSBEZWJ1ZzsKIAkJfTsKIAkJOTQyREIyMzQyNTdFRTZENDAwOUJEODBBIC8qIFJlbGVh c2UgKi8gPSB7CiAJCQlpc2EgPSBYQ0J1aWxkQ29uZmlndXJhdGlvbjsKIAkJCWJ1aWxkU2V0dGlu Z3MgPSB7CisJCQkJUFJPRFVDVF9OQU1FID0gIiQoVEFSR0VUX05BTUUpIjsKIAkJCX07CiAJCQlu YW1lID0gUmVsZWFzZTsKIAkJfTsKIAkJOTQyREIyMzUyNTdFRTZENDAwOUJEODBBIC8qIFByb2R1 Y3Rpb24gKi8gPSB7CiAJCQlpc2EgPSBYQ0J1aWxkQ29uZmlndXJhdGlvbjsKIAkJCWJ1aWxkU2V0 dGluZ3MgPSB7CisJCQkJUFJPRFVDVF9OQU1FID0gIiQoVEFSR0VUX05BTUUpIjsKIAkJCX07CiAJ CQluYW1lID0gUHJvZHVjdGlvbjsKIAkJfTsK