21987 2008-10-30 14:51:09 -0700 CTI::putDoubleResultToJSNumberCellOrJSImmediate() hardcodes result register 2008-10-30 15:17:02 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 zwarich zwarich oldest_to_newest 97177 0 zwarich 2008-10-30 14:51:09 -0700 CTI::putDoubleResultToJSNumberCellOrJSImmediate() hardcodes its result register as ecx, but it should clearly be tempReg1, which is currently ecx in all of its callsites. 97179 1 24783 zwarich 2008-10-30 15:00:05 -0700 Created attachment 24783 Proposed patch 97184 2 zwarich 2008-10-30 15:17:02 -0700 Landed in r38012. 24783 2008-10-30 15:00:05 -0700 2008-10-30 15:08:27 -0700 Proposed patch ecx.diff text/plain 1206 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM4MDEx KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMTAt MzAgIENhbWVyb24gWndhcmljaCAgPHp3YXJpY2hAYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAyMTk4NzogQ1RJOjpwdXREb3Vi bGVSZXN1bHRUb0pTTnVtYmVyQ2VsbE9ySlNJbW1lZGlhdGUoKSBoYXJkY29kZXMgcmVzdWx0IHJl Z2lzdGVyCisgICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjE5ODc+CisKKyAgICAgICAgKiBWTS9DVEkuY3BwOgorICAgICAgICAoSlNDOjpDVEk6OnB1dERv dWJsZVJlc3VsdFRvSlNOdW1iZXJDZWxsT3JKU0ltbWVkaWF0ZSk6CisKIDIwMDgtMTAtMzAgIENh bWVyb24gWndhcmljaCAgPHp3YXJpY2hAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IFNhbSBXZWluaWcuCkluZGV4OiBWTS9DVEkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFZNL0NUSS5jcHAJ KHJldmlzaW9uIDM4MDExKQorKysgVk0vQ1RJLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzk1LDcg Kzc5NSw3IEBAIHZvaWQgQ1RJOjpwdXREb3VibGVSZXN1bHRUb0pTTnVtYmVyQ2VsbE8KICAgICBt X2ppdC5saW5rKG1faml0LmVtaXRVbmxpbmtlZEplKCksIHJlc3VsdExvb2tlZExpa2VJbW1CdXRB Y3R1YWxseUlzbnQpOyAvLyBBY3R1YWxseSB3YXMgLTAKICAgICAvLyBZZXMgaXQgcmVhbGx5IHJl YWxseSByZWFsbHkgaXMgcmVwcmVzZW50YWJsZSBhcyBhIEpTSW1tZWRpYXRlLgogICAgIGVtaXRG YXN0QXJpdGhJbnRUb0ltbU5vQ2hlY2sodGVtcFJlZzEpOwotICAgIGVtaXRQdXRSZXN1bHQoZHN0 LCBYODY6OmVjeCk7CisgICAgZW1pdFB1dFJlc3VsdChkc3QsIHRlbXBSZWcxKTsKIH0KIAogdm9p ZCBDVEk6OmNvbXBpbGVCaW5hcnlBcml0aE9wKE9wY29kZUlEIG9wY29kZUlELCB1bnNpZ25lZCBk c3QsIHVuc2lnbmVkIHNyYzEsIHVuc2lnbmVkIHNyYzIsIE9wZXJhbmRUeXBlcyB0eXBlcywgdW5z aWduZWQgaSkK