219865 2020-12-14 11:29:11 -0800 [GLIB] Missing header for std::once_flag in WebKitInitialize.cpp 2020-12-14 12:18:40 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Other Linux RESOLVED FIXED P2 Normal --- 1 psaavedra psaavedra achristensen berto bugs-noreply cgarcia ews-watchlist gustavo oldest_to_newest 1714513 0 psaavedra 2020-12-14 11:29:11 -0800 Error: ../../Source/WebKit/UIProcess/API/glib/WebKitInitialize.cpp: In function �~@~Xvoid WebKit::webkitInitialize()�~@~Y: ../../Source/WebKit/UIProcess/API/glib/WebKitInitialize.cpp:61:17: error: �~@~Xonce_flag�~@~Y in namespace �~@~Xstd�~@~Y does not name a type 61 | static std::once_flag onceFlag; | ^~~~~~~~~ ../../Source/WebKit/UIProcess/API/glib/WebKitInitialize.cpp:32:1: note: �~@~Xstd::once_flag�~@~Y is defined in header �~@~X<mutex>�~@~Y; did you forget to �~@~X#include <mutex>�~@~Y? 31 | #include <wtf/glib/GUniquePtr.h> +++ |+#include <mutex> 32 | 1714514 1 416178 psaavedra 2020-12-14 11:31:50 -0800 Created attachment 416178 patch 1714515 2 ews-watchlist 2020-12-14 11:32:57 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1714541 3 ews-feeder 2020-12-14 12:18:38 -0800 Committed r270797: <https://trac.webkit.org/changeset/270797> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416178. 416178 2020-12-14 11:31:50 -0800 2020-12-14 12:18:39 -0800 patch bug-219865-20201214203148.patch text/plain 1186 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwNzg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDVlMGI5MWMyOTZjZDQ1NGY5 ZTA4MTQ2ODNjMzNlYjNiZjA2YjY4MDguLmY3OWQ5NWQ5YmY2Y2VlMDAxNGE5YjgwYjcwNjc5MTA0 NmUzOGUzOWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjAtMTItMTQgIFBhYmxvIFNh YXZlZHJhICA8cHNhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dMSUJdIE1pc3Npbmcg aGVhZGVyIGZvciBzdGQ6Om9uY2VfZmxhZyBpbiBXZWJLaXRJbml0aWFsaXplLmNwcAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE5ODY1CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L2dsaWIvV2ViS2l0SW5pdGlhbGl6ZS5jcHA6CisKIDIwMjAtMTItMTQgIEFuZHkgRXN0ZXMgIDxh ZXN0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFtNYWNdIEVuYWJsZSBgd2VibV9mb3JtYXRfcmVh ZGVyYCBmZWF0dXJlIGZsYWcgYnkgZGVmYXVsdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0SW5pdGlhbGl6ZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRJbml0aWFsaXplLmNwcAppbmRleCBlNzJkNWRiZDdhN2Fi Yzk2ZWNhMDJjZjMzMjhhZmIzNWIzMjYyMmQ2Li44OGY3ZTg3YTQ2OTkwNzAzOWE0MjMxMDliMjc0 NzE1NTgyOWEwZjVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xp Yi9XZWJLaXRJbml0aWFsaXplLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkv Z2xpYi9XZWJLaXRJbml0aWFsaXplLmNwcApAQCAtMjgsNiArMjgsNyBAQAogCiAjaW5jbHVkZSA8 SmF2YVNjcmlwdENvcmUvUmVtb3RlSW5zcGVjdG9yU2VydmVyLmg+CiAjaW5jbHVkZSA8V2ViS2l0 L1NoYXJlZC9XZWJLaXQySW5pdGlhbGl6ZS5oPgorI2luY2x1ZGUgPG11dGV4PgogI2luY2x1ZGUg PHd0Zi9nbGliL0dVbmlxdWVQdHIuaD4KIAogbmFtZXNwYWNlIFdlYktpdCB7Cg==