219859 2020-12-14 09:56:20 -0800 Drop duplicate call to makeUniqueRef() in RemoteAudioSourceProviderProxy::createRingBuffer() 2020-12-15 10:02:03 -0800 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=219867 InRadar P2 Normal --- 1 cdumez cdumez cdumez darin eric.carlson ews-watchlist ggaren glenn jer.noble peng.liu6 philipj sergio webkit-bug-importer youennf oldest_to_newest 1714470 0 cdumez 2020-12-14 09:56:20 -0800 Drop duplicate call to makeUniqueRef() in RemoteAudioSourceProviderProxy::createRingBuffer(). 1714471 1 416168 cdumez 2020-12-14 09:58:09 -0800 Created attachment 416168 Patch 1714519 2 ews-feeder 2020-12-14 11:37:22 -0800 Committed r270792: <https://trac.webkit.org/changeset/270792> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416168. 1714520 3 webkit-bug-importer 2020-12-14 11:38:22 -0800 <rdar://problem/72306990> 1714794 4 darin 2020-12-15 10:02:03 -0800 Why did this compile? Can we change something so that next time a mistake like this won’t compile? 416168 2020-12-14 09:58:09 -0800 2020-12-14 11:37:23 -0800 Patch bug-219859-20201214095808.patch text/plain 1652 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwNzY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDUwZWJlZThmMTUxMThlN2Jl NTBkYzFlYzE5YzUyZDFhOGQzODNhZWIuLmI1OTY2NGFjNTdiZTY4YThlNWNlZGZmOGExNmYxZTg2 ZDQ4ZjZlYWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjAtMTItMTQgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBEcm9wIGR1cGxpY2F0ZSBjYWxsIHRv IG1ha2VVbmlxdWVSZWYoKSBpbiBSZW1vdGVBdWRpb1NvdXJjZVByb3ZpZGVyUHJveHk6OmNyZWF0 ZVJpbmdCdWZmZXIoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjE5ODU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBHUFVQcm9jZXNzL21lZGlhL1JlbW90ZUF1ZGlvU291cmNlUHJvdmlkZXJQcm94eS5j cHA6CisgICAgICAgIChXZWJLaXQ6OlJlbW90ZUF1ZGlvU291cmNlUHJvdmlkZXJQcm94eTo6Y3Jl YXRlUmluZ0J1ZmZlcik6CisKIDIwMjAtMTItMTQgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxl LmNvbT4KIAogICAgICAgICBbR1BVUHJvY2Vzc10gQ3Jhc2ggdW5kZXIgQXVkaW9EZXN0aW5hdGlv bkNvY29hOjpzZXRJc1BsYXlpbmcoYm9vbCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvR1BV UHJvY2Vzcy9tZWRpYS9SZW1vdGVBdWRpb1NvdXJjZVByb3ZpZGVyUHJveHkuY3BwIGIvU291cmNl L1dlYktpdC9HUFVQcm9jZXNzL21lZGlhL1JlbW90ZUF1ZGlvU291cmNlUHJvdmlkZXJQcm94eS5j cHAKaW5kZXggNWZjZDQwYTE2OWU0M2FiYWJjMjc1NjA1ZDBhNjgxY2QyZGU0MDMxZi4uYmIzOTdm N2UwMTA0ODNlMzMyNTE1ZGQ3YjA0NDFhMGU3ODk5YmQxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9HUFVQcm9jZXNzL21lZGlhL1JlbW90ZUF1ZGlvU291cmNlUHJvdmlkZXJQcm94eS5jcHAK KysrIGIvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL21lZGlhL1JlbW90ZUF1ZGlvU291cmNlUHJv dmlkZXJQcm94eS5jcHAKQEAgLTU5LDcgKzU5LDcgQEAgVW5pcXVlUmVmPENBUmluZ0J1ZmZlcj4g UmVtb3RlQXVkaW9Tb3VyY2VQcm92aWRlclByb3h5OjpjcmVhdGVSaW5nQnVmZmVyKGNvbnN0IEMK IHsKICAgICBtX3JpbmdCdWZmZXJEZXNjcmlwdGlvbiA9IGRlc2NyaXB0aW9uOwogICAgIG1fcmlu Z0J1ZmZlckNhcGFjaXR5ID0gY2FwYWNpdHk7Ci0gICAgYXV0byByaW5nQnVmZmVyID0gbWFrZVVu aXF1ZVJlZjxDQVJpbmdCdWZmZXI+KG1ha2VVbmlxdWVSZWY8U2hhcmVkUmluZ0J1ZmZlclN0b3Jh Z2U+KG1ha2VVbmlxdWVSZWY8U2hhcmVkUmluZ0J1ZmZlclN0b3JhZ2U+KHRoaXMpKSk7CisgICAg YXV0byByaW5nQnVmZmVyID0gbWFrZVVuaXF1ZVJlZjxDQVJpbmdCdWZmZXI+KG1ha2VVbmlxdWVS ZWY8U2hhcmVkUmluZ0J1ZmZlclN0b3JhZ2U+KHRoaXMpKTsKICAgICByaW5nQnVmZmVyLT5hbGxv Y2F0ZShkZXNjcmlwdGlvbiwgY2FwYWNpdHkpOwogICAgIHJldHVybiByaW5nQnVmZmVyOwogfQo=