219850 2020-12-14 05:42:38 -0800 [SOUP] WebSockets: wrong data sent in some cases with libsoup < 2.68 2020-12-15 01:15:44 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned berto bugs-noreply csaavedra mcatanzaro oldest_to_newest 1714426 0 cgarcia 2020-12-14 05:42:38 -0800 We are using soup_websocket_connection_send_text() when libsoup < 2.68, which expects a null terminated string, but we are receiving a IPC::DataReference that needs to be converted to a null terminated string by taking into account its size. 1714427 1 416151 cgarcia 2020-12-14 05:44:27 -0800 Created attachment 416151 Patch 1714477 2 berto 2020-12-14 10:15:20 -0800 This bug can be reproduced in https://www.websocket.org/echo.html using older versions of libsoup. I confirm that the patch fixes the problem. 1714693 3 ews-feeder 2020-12-15 01:15:43 -0800 Committed r270825: <https://trac.webkit.org/changeset/270825> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416151. 416151 2020-12-14 05:44:27 -0800 2020-12-15 01:15:44 -0800 Patch wk2-ws-send.diff text/plain 1772 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYzgzZjU2NThhNmZiLi43YzJkYzkwNjRhNzkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTcgQEAKKzIwMjAtMTItMTQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtTT1VQXSBXZWJTb2NrZXRzOiB3cm9uZyBkYXRhIHNlbnQgaW4g c29tZSBjYXNlcyB3aXRoIGxpYnNvdXAgPCAyLjY4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTk4NTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXZSBhcmUgdXNpbmcgc291cF93ZWJzb2NrZXRfY29ubmVj dGlvbl9zZW5kX3RleHQoKSB3aGVuIGxpYnNvdXAgPCAyLjY4LCB3aGljaCBleHBlY3RzIGEgbnVs bCB0ZXJtaW5hdGVkIHN0cmluZywKKyAgICAgICAgYnV0IHdlIGFyZSByZWNlaXZpbmcgYSBJUEM6 OkRhdGFSZWZlcmVuY2UgdGhhdCBuZWVkcyB0byBiZSBjb252ZXJ0ZWQgdG8gYSBudWxsIHRlcm1p bmF0ZWQgc3RyaW5nIGJ5IHRha2luZyBpbnRvCisgICAgICAgIGFjY291bnQgaXRzIHNpemUuCisK KyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9zb3VwL1dlYlNvY2tldFRhc2tTb3VwLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6V2ViU29ja2V0VGFzazo6c2VuZFN0cmluZyk6CisKIDIwMjAtMTItMTQg IENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtX UEVdW0dUS10gU2hvdWxkIGVuYWJsZSBXZWJQcm9jZXNzQ2FjaGUKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mvc291cC9XZWJTb2NrZXRUYXNrU291cC5jcHAgYi9Tb3Vy Y2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL3NvdXAvV2ViU29ja2V0VGFza1NvdXAuY3BwCmluZGV4 IGEzZTcwMTRiNWQ4ZS4uMzFiZmI5NGZhMDFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05l dHdvcmtQcm9jZXNzL3NvdXAvV2ViU29ja2V0VGFza1NvdXAuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvTmV0d29ya1Byb2Nlc3Mvc291cC9XZWJTb2NrZXRUYXNrU291cC5jcHAKQEAgLTIxMCw3ICsy MTAsNyBAQCB2b2lkIFdlYlNvY2tldFRhc2s6OnNlbmRTdHJpbmcoY29uc3QgSVBDOjpEYXRhUmVm ZXJlbmNlJiB1dGY4LCBDb21wbGV0aW9uSGFuZGxlcgogICAgICAgICBHUmVmUHRyPEdCeXRlcz4g Ynl0ZXMgPSBhZG9wdEdSZWYoZ19ieXRlc19uZXdfc3RhdGljKHV0ZjguZGF0YSgpLCB1dGY4LnNp emUoKSkpOwogICAgICAgICBzb3VwX3dlYnNvY2tldF9jb25uZWN0aW9uX3NlbmRfbWVzc2FnZSht X2Nvbm5lY3Rpb24uZ2V0KCksIFNPVVBfV0VCU09DS0VUX0RBVEFfVEVYVCwgYnl0ZXMuZ2V0KCkp OwogI2Vsc2UKLSAgICAgICAgc291cF93ZWJzb2NrZXRfY29ubmVjdGlvbl9zZW5kX3RleHQobV9j b25uZWN0aW9uLmdldCgpLCByZWludGVycHJldF9jYXN0PGNvbnN0IGNoYXIqPih1dGY4LmRhdGEo KSkpOworICAgICAgICBzb3VwX3dlYnNvY2tldF9jb25uZWN0aW9uX3NlbmRfdGV4dChtX2Nvbm5l Y3Rpb24uZ2V0KCksIENTdHJpbmcocmVpbnRlcnByZXRfY2FzdDxjb25zdCBjaGFyKj4odXRmOC5k YXRhKCkpLCB1dGY4LnNpemUoKSkuZGF0YSgpKTsKICNlbmRpZgogICAgIH0KICAgICBjYWxsYmFj aygpOwo=