21984 2008-10-30 13:13:10 -0700 Slow cases of opcodes should use the same machine registers for their final result as fast cases 2008-11-19 13:07:41 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 zwarich zwarich zwarich oldest_to_newest 97155 0 zwarich 2008-10-30 13:13:10 -0700 In order to properly resolve bug 21943, the slow cases of opcodes should use the same machine registers for their final destination as the fast cases. As far as I can tell, only op_get_by_id and op_get_by_val violate this rule, although some other opcodes without slow cases unnecessarily avoid using eax. 97186 1 zwarich 2008-10-30 15:51:29 -0700 I am trying to fix the op_get_by_id case first, but changing the write to ecx there to use eax makes everything explode, even though it shouldn't matter. I will investigate and then attempt to fix this. 98222 2 25031 zwarich 2008-11-10 15:39:30 -0800 Created attachment 25031 Proposed patch Here is a patch for changing the last two cases that I know about. I will probably wait to land it with the speedup. 99370 3 zwarich 2008-11-19 13:07:41 -0800 This is now fixed, due to a number of changes. 25031 2008-11-10 15:39:30 -0800 2008-11-10 15:39:30 -0800 Proposed patch moves.diff text/plain 1401 zwarich SW5kZXg6IFZNL0NUSS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVk0vQ1RJLmNwcAkocmV2aXNpb24gMzgy NjYpCisrKyBWTS9DVEkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMzY4LDggKzIzNjgsOSBAQCB2 b2lkIENUSTo6cHJpdmF0ZUNvbXBpbGVTbG93Q2FzZXMoKQogICAgICAgICAgICAgLy8gQ2hlY2sg d2hldGhlciB0aGUgdmFsdWUgbG9hZGVkIGlzIHplcm87IGlmIHNvIHdlIG5lZWQgdG8gcmV0dXJu IHVuZGVmaW5lZC4KICAgICAgICAgICAgIG1faml0LnRlc3RsX3JyKFg4Njo6ZWN4LCBYODY6OmVj eCk7CiAgICAgICAgICAgICBtX2ppdC5saW5rKG1faml0LmVtaXRVbmxpbmtlZEplKCksIGJlZ2lu R2V0QnlWYWxTbG93KTsKLSAgICAgICAgICAgIGVtaXRQdXRSZXN1bHQoaW5zdHJ1Y3Rpb25baSAr IDFdLnUub3BlcmFuZCwgWDg2OjplY3gpOwotICAgICAgICAgICAgCisgICAgICAgICAgICBtX2pp dC5tb3ZsX3JyKFg4Njo6ZWN4LCBYODY6OmVheCk7CisgICAgICAgICAgICBlbWl0UHV0UmVzdWx0 KGluc3RydWN0aW9uW2kgKyAxXS51Lm9wZXJhbmQsIFg4Njo6ZWF4KTsKKwogICAgICAgICAgICAg aSArPSA0OwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KQEAgLTI0NzEsNyArMjQ3Miw4 IEBAIHZvaWQgQ1RJOjpwcml2YXRlQ29tcGlsZVNsb3dDYXNlcygpCiAgICAgICAgICAgICBlbWl0 UHV0QXJnQ29uc3RhbnQocmVpbnRlcnByZXRfY2FzdDx1bnNpZ25lZD4oaWRlbnQpLCA0KTsKICAg ICAgICAgICAgIFg4NkFzc2VtYmxlcjo6Sm1wU3JjIGNhbGwgPSBlbWl0Q1RJQ2FsbChpbnN0cnVj dGlvbiArIGksIGksIE1hY2hpbmU6OmN0aV9vcF9nZXRfYnlfaWQpOwogICAgICAgICAgICAgQVNT RVJUKFg4NkFzc2VtYmxlcjo6Z2V0RGlmZmVyZW5jZUJldHdlZW5MYWJlbHMoY29sZFBhdGhCZWdp biwgY2FsbCkgPT0gcmVwYXRjaE9mZnNldEdldEJ5SWRTbG93Q2FzZUNhbGwpOwotICAgICAgICAg ICAgZW1pdFB1dFJlc3VsdChpbnN0cnVjdGlvbltpICsgMV0udS5vcGVyYW5kKTsKKyAgICAgICAg ICAgIG1faml0Lm1vdmxfcnIoWDg2OjplYXgsIFg4Njo6ZWN4KTsKKyAgICAgICAgICAgIGVtaXRQ dXRSZXN1bHQoaW5zdHJ1Y3Rpb25baSArIDFdLnUub3BlcmFuZCwgWDg2OjplY3gpOwogCiAgICAg ICAgICAgICAvLyBUcmFjayB0aGUgbG9jYXRpb24gb2YgdGhlIGNhbGw7IHRoaXMgd2lsbCBiZSB1 c2VkIHRvIHJlY292ZXIgcmVwYXRjaCBpbmZvcm1hdGlvbi4KICAgICAgICAgICAgIEFTU0VSVCht X2NvZGVCbG9jay0+cHJvcGVydHlBY2Nlc3NJbnN0cnVjdGlvbnNbcHJvcGVydHlBY2Nlc3NJbnN0 cnVjdGlvbkluZGV4XS5vcGNvZGVJbmRleCA9PSBpKTsK