219797 2020-12-11 11:58:06 -0800 [GPUProcess] WebAudio rendering quantum is 15 instead of 128 when the GPU Process is enabled 2020-12-11 13:05:19 -0800 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez cdumez eric.carlson ews-watchlist ggaren glenn jer.noble peng.liu6 philipj sergio webkit-bug-importer oldest_to_newest 1714014 0 cdumez 2020-12-11 11:58:06 -0800 WebAudio rendering quantum is 15 instead of 128 when the GPU Process is enabled. This generates a lot more IPC unnecessarily, not to mention how WebAudio code expects a rendering quantum of 128 and could potentially do bad things with a lower value. 1714017 1 416025 cdumez 2020-12-11 12:00:36 -0800 Created attachment 416025 Patch 1714031 2 416025 peng.liu6 2020-12-11 12:13:15 -0800 Comment on attachment 416025 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416025&action=review > Source/WebKit/GPUProcess/media/RemoteAudioSessionProxyManager.cpp:108 > + if (otherProxy.preferredBufferSize() && otherProxy.preferredBufferSize() < preferredBufferSize) Do we need to consider the case that "otherProxy.preferredBufferSize()" returns a different value such as -1 if not set? I mean potentially. 1714033 3 cdumez 2020-12-11 12:14:32 -0800 (In reply to Peng Liu from comment #2) > Comment on attachment 416025 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=416025&action=review > > > Source/WebKit/GPUProcess/media/RemoteAudioSessionProxyManager.cpp:108 > > + if (otherProxy.preferredBufferSize() && otherProxy.preferredBufferSize() < preferredBufferSize) > > Do we need to consider the case that "otherProxy.preferredBufferSize()" > returns a different value such as -1 if not set? I mean potentially. size_t m_preferredBufferSize { 0 }; It is initialized to 0 by default. Also, it is unsigned. 1714034 4 416025 peng.liu6 2020-12-11 12:17:14 -0800 Comment on attachment 416025 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416025&action=review >>> Source/WebKit/GPUProcess/media/RemoteAudioSessionProxyManager.cpp:108 >>> + if (otherProxy.preferredBufferSize() && otherProxy.preferredBufferSize() < preferredBufferSize) >> >> Do we need to consider the case that "otherProxy.preferredBufferSize()" returns a different value such as -1 if not set? I mean potentially. > > size_t m_preferredBufferSize { 0 }; > > It is initialized to 0 by default. Also, it is unsigned. Oh that's right! I looked AudioSession::preferredBufferSize() by mistake. :-) 1714060 5 ews-feeder 2020-12-11 13:04:48 -0800 Committed r270705: <https://trac.webkit.org/changeset/270705> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416025. 1714061 6 webkit-bug-importer 2020-12-11 13:05:19 -0800 <rdar://problem/72235555> 416025 2020-12-11 12:00:36 -0800 2020-12-11 13:04:49 -0800 Patch bug-219797-20201211120036.patch text/plain 2415 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwNjg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY4YjAxZDRkMWE0ZjcyYjZk YjIwNWMxNTdmM2M5NTIwZjk0YmZiZmQuLjE5NWYwZDNmMmRmM2IxOWNmMTBiYTVhYzdjMWFlZGMw ZWZmNzA3YmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjAtMTItMTEgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBbR1BVUHJvY2Vzc10gV2ViQXVkaW8g cmVuZGVyaW5nIHF1YW50dW0gaXMgMTUgaW5zdGVhZCBvZiAxMjggd2hlbiB0aGUgR1BVIFByb2Nl c3MgaXMgZW5hYmxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjE5Nzk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgV2ViQXVkaW8gcmVuZGVyaW5nIHF1YW50dW0gaXMgMTUgaW5zdGVhZCBvZiAxMjggd2hl biB0aGUgR1BVIFByb2Nlc3MgaXMgZW5hYmxlZC4gVGhpcyBnZW5lcmF0ZXMgYSBsb3QgbW9yZQor ICAgICAgICBJUEMgdW5uZWNlc3NhcmlseSwgbm90IHRvIG1lbnRpb24gaG93IFdlYkF1ZGlvIGNv ZGUgZXhwZWN0cyBhIHJlbmRlcmluZyBxdWFudHVtIG9mIDEyOCBhbmQgY291bGQgcG90ZW50aWFs bHkKKyAgICAgICAgZG8gYmFkIHRoaW5ncyB3aXRoIGEgbG93ZXIgdmFsdWUuCisKKyAgICAgICAg VGhlIGlzc3VlIHdhcyB0aGF0IFJlbW90ZUF1ZGlvU2Vzc2lvblByb3h5TWFuYWdlcjo6c2V0UHJl ZmVycmVkQnVmZmVyU2l6ZUZvclByb2Nlc3MoKSB3YXMgaXRlcmF0aW5nIG92ZXIKKyAgICAgICAg YWxsIFJlbW90ZUF1ZGlvU2Vzc2lvblByb3h5IG9iamVjdHMgdG8gZmluZCBvdXQgdGhlIGxvd2Vz dCByZW5kZXJpbmcgcXVhbnR1bS4gSWYgdGhlcmUgaXMgYSBwcm94eSB3aXRoCisgICAgICAgIGEg cHJlZmVycmVkIGJ1ZmZlciBzaXplIHRoYXQgaXMgbm90IHNldCwgdGhlIHZhbHVlIGVuZHMgdXAg YmVpbmcgMC4gV2hlbiB0aGVuIGFzayBjb3JlIGF1ZGlvIGZvciBhIHJlbmRlcmluZworICAgICAg ICBxdWFudHVtIG9mIDAsIGFuZCB0aGV5IGVuZCB1cCB1c2luZyAxNSAobGlrZWx5IHRoZSBtaW5p bXVtKS4KKworICAgICAgICAqIEdQVVByb2Nlc3MvbWVkaWEvUmVtb3RlQXVkaW9TZXNzaW9uUHJv eHlNYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UmVtb3RlQXVkaW9TZXNzaW9uUHJveHlN YW5hZ2VyOjpzZXRQcmVmZXJyZWRCdWZmZXJTaXplRm9yUHJvY2Vzcyk6CisKIDIwMjAtMTItMTEg IENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFBy b3RlY3QgdGhlIFdlYlByb2Nlc3NQb29sIGVhcmxpZXIgaW4gV2ViUHJvY2Vzc0NhY2hlOjphZGRQ cm9jZXNzSWZQb3NzaWJsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL21l ZGlhL1JlbW90ZUF1ZGlvU2Vzc2lvblByb3h5TWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L0dQ VVByb2Nlc3MvbWVkaWEvUmVtb3RlQXVkaW9TZXNzaW9uUHJveHlNYW5hZ2VyLmNwcAppbmRleCBm ZjM2NDQwY2Y2ODdkYThiNWI5YzA0MmE5ZTMzZTdjYjY4YmFhOWY3Li4zNGZiMzE0MGMyNTFjM2Fk NWJkZGJmM2ZlYWM1MDRjZjM2N2FlOWMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0dQVVBy b2Nlc3MvbWVkaWEvUmVtb3RlQXVkaW9TZXNzaW9uUHJveHlNYW5hZ2VyLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L0dQVVByb2Nlc3MvbWVkaWEvUmVtb3RlQXVkaW9TZXNzaW9uUHJveHlNYW5hZ2Vy LmNwcApAQCAtMTA1LDcgKzEwNSw3IEBAIHZvaWQgUmVtb3RlQXVkaW9TZXNzaW9uUHJveHlNYW5h Z2VyOjpzZXRDYXRlZ29yeUZvclByb2Nlc3MoUmVtb3RlQXVkaW9TZXNzaW9uUHJvCiB2b2lkIFJl bW90ZUF1ZGlvU2Vzc2lvblByb3h5TWFuYWdlcjo6c2V0UHJlZmVycmVkQnVmZmVyU2l6ZUZvclBy b2Nlc3MoUmVtb3RlQXVkaW9TZXNzaW9uUHJveHkmIHByb3h5LCBzaXplX3QgcHJlZmVycmVkQnVm ZmVyU2l6ZSkKIHsKICAgICBmb3IgKGF1dG8mIG90aGVyUHJveHkgOiBtX3Byb3hpZXMpIHsKLSAg ICAgICAgaWYgKG90aGVyUHJveHkucHJlZmVycmVkQnVmZmVyU2l6ZSgpIDwgcHJlZmVycmVkQnVm ZmVyU2l6ZSkKKyAgICAgICAgaWYgKG90aGVyUHJveHkucHJlZmVycmVkQnVmZmVyU2l6ZSgpICYm IG90aGVyUHJveHkucHJlZmVycmVkQnVmZmVyU2l6ZSgpIDwgcHJlZmVycmVkQnVmZmVyU2l6ZSkK ICAgICAgICAgICAgIHByZWZlcnJlZEJ1ZmZlclNpemUgPSBvdGhlclByb3h5LnByZWZlcnJlZEJ1 ZmZlclNpemUoKTsKICAgICB9CiAK