219758 2020-12-10 14:53:16 -0800 [macOS] Only extend access to the RootDomainUserClient IOKit class if the GPU Process is not used 2020-12-11 09:33:22 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham pvollan webkit-bug-importer oldest_to_newest 1713731 0 bfulgham 2020-12-10 14:53:16 -0800 This IOKit class appears to only be used by media, and only on Apple Silicon. Dynamically extend access to this class for Apple Silicon builds if the GPU process is not being used. This patch includes additional telemetry to confirm that it is not needed on Intel, and not for any other purposes. 1713732 1 bfulgham 2020-12-10 14:53:28 -0800 <rdar://problem/70464431> 1713733 2 webkit-bug-importer 2020-12-10 14:53:47 -0800 <rdar://problem/72198404> 1713735 3 415935 bfulgham 2020-12-10 14:57:04 -0800 Created attachment 415935 Patch 1713842 4 415935 pvollan 2020-12-11 00:41:21 -0800 Comment on attachment 415935 Patch R=me. 1713927 5 ews-feeder 2020-12-11 09:33:21 -0800 Committed r270682: <https://trac.webkit.org/changeset/270682> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415935. 415935 2020-12-10 14:57:04 -0800 2020-12-11 09:33:21 -0800 Patch bug-219758-20201210145704.patch text/plain 3085 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwNjU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGNiOGE1YjkwZTBjZWI4N2Ni MjEwMGQwOTJlZTNkYjMwMGUyZDMwOTguLmU3Njc2NmIyMjlmYTExYzg1ZTYwZWMzNzM3MTczZTk2 ZTY1MDkzZjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjAtMTItMTAgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW21hY09TXSBPbmx5IGV4dGVu ZCBhY2Nlc3MgdG8gdGhlIFJvb3REb21haW5Vc2VyQ2xpZW50IElPS2l0IGNsYXNzIGlmIHRoZSBH UFUgUHJvY2VzcyBpcyBub3QgdXNlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjE5NzU4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83MDQ2NDQzMT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgUm9v dERvbWFpblVzZXJDbGllbnQgSU9LaXQgY2xhc3MgYXBwZWFycyB0byBvbmx5IGJlIHVzZWQgYnkg bWVkaWEgb24gQXBwbGUgU2lsaWNvbi4gRHluYW1pY2FsbHkgZXh0ZW5kIGFjY2VzcyB0byB0aGlz CisgICAgICAgIGNsYXNzIGZvciBBcHBsZSBTaWxpY29uIGJ1aWxkcyBpZiB0aGUgR1BVIHByb2Nl c3MgaXMgbm90IGJlaW5nIHVzZWQuCisKKyAgICAgICAgVGhpcyBwYXRjaCBhbHNvIGluY2x1ZGVz IHRlbGVtZXRyeSB0byBjb25maXJtIHRoYXQgaXQgaXMgbm90IG5lZWRlZCBvbiBJbnRlbCwgb3Ig Zm9yIGFueSBvdGhlciBwdXJwb3Nlcy4gSXQgZG9lcyBub3QKKyAgICAgICAgYmxvY2sgYWNjZXNz IHRvIHRoZSBJT0tpdCBjbGFzcyB5ZXQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVBy b3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6bWVkaWFSZWxhdGVkSU9LaXRDbGFzc2VzKToKKyAg ICAgICAgKiBXZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluOgorCiAyMDIwLTEy LTEwICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbbWFj T1NdIENyZWF0ZSBzYW5kYm94IGV4dGVuc2lvbiBmb3IgQXBwbGVBVkRVc2VyQ2xpZW50IHdoZW4g TWVkaWEgaW4gR1BVIHByb2Nlc3MgaXMgbm90IGVuYWJsZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9XZWJQYWdlUHJveHkuY3BwCmluZGV4IDliYTE3NmFlZDM5NDNkMjFkZGM1YzZmZDcxYzY0Njdk MjBlZmZjMDUuLjljODMxNjAyY2RkMDllZjFlYzE2Mzc3OTVkNzlmNjNhNTM3NGRiZDUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKKysrIGIvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcApAQCAtNzgyNiw2ICs3ODI2LDcg QEAgc3RhdGljIGNvbnN0IFZlY3RvcjxBU0NJSUxpdGVyYWw+JiBtZWRpYVJlbGF0ZWRJT0tpdENs YXNzZXMoKQogICAgIHN0YXRpYyBjb25zdCBhdXRvIHNlcnZpY2VzID0gbWFrZU5ldmVyRGVzdHJv eWVkKFZlY3RvcjxBU0NJSUxpdGVyYWw+IHsKICNpZiAoUExBVEZPUk0oTUFDKSB8fCBQTEFURk9S TShNQUNDQVRBTFlTVCkpICYmIENQVShBUk02NCkKICAgICAgICAgIkFwcGxlQVZEVXNlckNsaWVu dCJfcywKKyAgICAgICAgIlJvb3REb21haW5Vc2VyQ2xpZW50Il9zLAogI2VuZGlmCiAgICAgfSk7 CiAgICAgcmV0dXJuIHNlcnZpY2VzOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNz L2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluCmluZGV4IGFlNGJkYzYzZTllMGI4ZWYwY2Y5MTVk MzM5NDUyZjYzZTI4NmFiMWMuLmQ3MDVjZTMwN2U1ODIxMTAyMmY3NjE3NjI1MDhjYjNlZWI2NjYw NDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJv Y2Vzcy5zYi5pbgorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFwcGxlLldlYlBy b2Nlc3Muc2IuaW4KQEAgLTg2Myw3ICs4NjMsMTAgQEAKICkKIAogKGFsbG93IGlva2l0LW9wZW4K LSAgICAoaW9raXQtdXNlci1jbGllbnQtY2xhc3MgIlJvb3REb21haW5Vc2VyQ2xpZW50IikgOzsg TmVlZGVkIGJ5IFdlYkNvcmU6OlBlcmZvcm1hbmNlTW9uaXRvcgorICAgIChyZXF1aXJlLWFsbAor ICAgICAgICAoZXh0ZW5zaW9uICJjb20uYXBwbGUud2Via2l0LmV4dGVuc2lvbi5pb2tpdCIpCisg ICAgICAgIChpb2tpdC11c2VyLWNsaWVudC1jbGFzcyAiUm9vdERvbWFpblVzZXJDbGllbnQiKSA7 OyBOZWVkZWQgYnkgTWVkaWEgcGxheWJhY2sKKyAgICApCiAjaWYgSEFWRShTQU5EQk9YX01FU1NB R0VfRklMVEVSSU5HKQogICAgICh3aXRoIHRlbGVtZXRyeS1iYWNrdHJhY2UpCiAgICAgKGFwcGx5 LW1lc3NhZ2UtZmlsdGVyCkBAIC0xNjU0LDYgKzE2NTcsMTcgQEAKICAgICApCiApCiAKKzs7IEZJ WE1FOiBEYXRhIGluZGljYXRlcyB0aGlzIGlzIG9ubHkgbmVlZGVkIG9uIEFSTTY0LiBUaGlzIGxv Z2dpbmcgd2lsbCBjb25maXJtLgorOzsgUmVtb3ZlIHdoZW4gdGhlIEdQVSBwcm9jZXNzIGlzIGVu YWJsZWQgYnkgZGVmYXVsdAorKGFsbG93IGlva2l0LW9wZW4gKHdpdGggcmVwb3J0KSAod2l0aCB0 ZWxlbWV0cnktYmFja3RyYWNlKQorICAgIChyZXF1aXJlLWFsbAorICAgICAgICAocmVxdWlyZS1u b3QgKGV4dGVuc2lvbiAiY29tLmFwcGxlLndlYmtpdC5leHRlbnNpb24uaW9raXQiKSkKKyAgICAg ICAgKGlva2l0LXVzZXItY2xpZW50LWNsYXNzCisgICAgICAgICAgICAiUm9vdERvbWFpblVzZXJD bGllbnQiCisgICAgICAgICkKKyAgICApCispCisKICNlbmRpZiAvLyBIQVZFKFNBTkRCT1hfTUVT U0FHRV9GSUxURVJJTkcpCiAKICNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID4g MTEwMDAwCg==