219730 2020-12-09 23:36:46 -0800 [macOS] The development WebContent XPC service is missing a required entitlement 2020-12-11 10:59:23 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified REOPENED InRadar P2 Normal --- 219793 1 pvollan pvollan bfulgham commit-queue webkit-bug-importer oldest_to_newest 1713445 0 pvollan 2020-12-09 23:36:46 -0800 The message filtering entitlement is missing in com.apple.WebKit.WebContent.Development.xpc on macOS. 1713446 1 pvollan 2020-12-09 23:45:27 -0800 <rdar://problem/72145560> 1713447 2 415840 pvollan 2020-12-09 23:47:59 -0800 Created attachment 415840 Patch 1713617 3 415840 bfulgham 2020-12-10 11:02:43 -0800 Comment on attachment 415840 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415840&action=review r=me > Source/WebKit/Scripts/process-entitlements.sh:28 > plistbuddy Add :com.apple.pac.shared_region_id string WebContent It seems like we should enable this for Dev builds, too. 1713707 4 bfulgham 2020-12-10 13:59:04 -0800 (In reply to Brent Fulgham from comment #3) > Comment on attachment 415840 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=415840&action=review > > r=me > > > Source/WebKit/Scripts/process-entitlements.sh:28 > > plistbuddy Add :com.apple.pac.shared_region_id string WebContent > > It seems like we should enable this for Dev builds, too. But lets do that as a separate bug after confirming with JSC/Security teams. I don't want to introduce a regression by enabling it without confirming. 1713711 5 ews-feeder 2020-12-10 14:02:19 -0800 Committed r270654: <https://trac.webkit.org/changeset/270654> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415840. 1713840 6 pvollan 2020-12-11 00:28:25 -0800 (In reply to Brent Fulgham from comment #4) > (In reply to Brent Fulgham from comment #3) > > Comment on attachment 415840 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=415840&action=review > > > > r=me > > > > > Source/WebKit/Scripts/process-entitlements.sh:28 > > > plistbuddy Add :com.apple.pac.shared_region_id string WebContent > > > > It seems like we should enable this for Dev builds, too. > > But lets do that as a separate bug after confirming with JSC/Security teams. > I don't want to introduce a regression by enabling it without confirming. Sounds good, thanks for reviewing! 1713972 7 commit-queue 2020-12-11 10:59:23 -0800 Re-opened since this is blocked by bug 219793 415840 2020-12-09 23:47:59 -0800 2020-12-10 14:02:20 -0800 Patch bug-219730-20201210084758.patch text/plain 1892 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNzA2MTQpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDIwLTEyLTA5ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbbWFjT1NdIFRoZSBkZXZlbG9w bWVudCBXZWJDb250ZW50IFhQQyBzZXJ2aWNlIGlzIG1pc3NpbmcgYSByZXF1aXJlZCBlbnRpdGxl bWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE5 NzMwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83MjE0NTU2MD4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgbWVzc2FnZSBmaWx0ZXJpbmcgZW50 aXRsZW1lbnQgaXMgbWlzc2luZyBpbiBjb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuRGV2ZWxv cG1lbnQueHBjIG9uIG1hY09TLgorCisgICAgICAgICogU2NyaXB0cy9wcm9jZXNzLWVudGl0bGVt ZW50cy5zaDoKKwogMjAyMC0xMi0wOSAgUGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5j b20+CiAKICAgICAgICAgW21hY09TXSBSZW1vdmUgY29tLmFwcGxlLlBvd2VyTWFuYWdlbWVudC5j b250cm9sIGZyb20gV2ViQ29udGVudCBzYW5kYm94CkluZGV4OiBTb3VyY2UvV2ViS2l0L1Njcmlw dHMvcHJvY2Vzcy1lbnRpdGxlbWVudHMuc2gKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9T Y3JpcHRzL3Byb2Nlc3MtZW50aXRsZW1lbnRzLnNoCShyZXZpc2lvbiAyNzA1ODkpCisrKyBTb3Vy Y2UvV2ViS2l0L1NjcmlwdHMvcHJvY2Vzcy1lbnRpdGxlbWVudHMuc2gJKHdvcmtpbmcgY29weSkK QEAgLTEyLDYgKzEyLDEwIEBAIGZ1bmN0aW9uIHBsaXN0YnVkZHkoKQogZnVuY3Rpb24gbWFjX3By b2Nlc3Nfd2ViY29udGVudF9lbnRpdGxlbWVudHMoKQogewogICAgIHBsaXN0YnVkZHkgQWRkIDpj b20uYXBwbGUuc2VjdXJpdHkuY3MuYWxsb3ctaml0IGJvb2wgWUVTCisgICAgaWYgKCggIiR7VEFS R0VUX01BQ19PU19YX1ZFUlNJT05fTUFKT1J9IiA+PSAxMTAwMDAgKSkKKyAgICB0aGVuCisgICAg ICAgIHBsaXN0YnVkZHkgQWRkIDpjb20uYXBwbGUucHJpdmF0ZS5zZWN1cml0eS5tZXNzYWdlLWZp bHRlciBib29sIFlFUworICAgIGZpCiAKICAgICBpZiBbWyAiJHtXS19VU0VfUkVTVFJJQ1RFRF9F TlRJVExFTUVOVFN9IiA9PSBZRVMgXV0KICAgICB0aGVuCkBAIC0yMyw3ICsyNyw2IEBAIGZ1bmN0 aW9uIG1hY19wcm9jZXNzX3dlYmNvbnRlbnRfZW50aXRsZW0KICAgICAgICAgICAgIHBsaXN0YnVk ZHkgQWRkIDpjb20uYXBwbGUuZGV2ZWxvcGVyLnZpZGVvdG9vbGJveC5jbGllbnQtc2FuZGJveGVk LWRlY29kZXIgYm9vbCBZRVMKICAgICAgICAgICAgIHBsaXN0YnVkZHkgQWRkIDpjb20uYXBwbGUu cGFjLnNoYXJlZF9yZWdpb25faWQgc3RyaW5nIFdlYkNvbnRlbnQKICAgICAgICAgICAgIHBsaXN0 YnVkZHkgQWRkIDpjb20uYXBwbGUucHJpdmF0ZS5wYWMuZXhjZXB0aW9uIGJvb2wgWUVTCi0gICAg ICAgICAgICBwbGlzdGJ1ZGR5IEFkZCA6Y29tLmFwcGxlLnByaXZhdGUuc2VjdXJpdHkubWVzc2Fn ZS1maWx0ZXIgYm9vbCBZRVMKICAgICAgICAgICAgIHBsaXN0YnVkZHkgQWRkIDpjb20uYXBwbGUu YXZmb3VuZGF0aW9uLmFsbG93LXN5c3RlbS13aWRlLWNvbnRleHQgYm9vbCBZRVMKICAgICAgICAg ZmkKICAgICBmaQo=