21973 2008-10-30 10:02:59 -0700 gcc warnings in ASCIICType.h and Font.h 2008-10-30 22:36:44 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Trivial --- 0 bks24 webkit-unassigned oldest_to_newest 97129 0 bks24 2008-10-30 10:02:59 -0700 gcc 4.3.3 generates "suggest parentheses around && within ||" warnings when compiling JavaScriptCore/wtf/ASCIICType.h and WebCore/platform/graphics/Font.h The code looks to be correct, just easy enough to mentally mis-parse that gcc warns about it with "build-webkit --qt"'s default compiler flags. 97130 1 24773 bks24 2008-10-30 10:08:03 -0700 Created attachment 24773 patch: add parentheses to disambiguate things 97132 2 bks24 2008-10-30 10:09:34 -0700 Here's a patch to add disambiguating parentheses and quiet the warnings. It's my first patch to WebKit, so let me know what else I need to do. 97139 3 24773 mitz 2008-10-30 11:07:11 -0700 Comment on attachment 24773 patch: add parentheses to disambiguate things r=me for these changes. I am not sure that as a rule this should be done everywhere where some compiler might suggest it. 97154 4 bks24 2008-10-30 13:11:06 -0700 Agreed, there may be places where just adding parentheses is not a great idea -- but getting a page of warnings from every file that includes ASCIICType.h isn't great either. Will you be landing the patch, then? 97218 5 timothy 2008-10-30 22:36:44 -0700 Landed in r38024. 24773 2008-10-30 10:08:03 -0700 2008-10-30 11:07:11 -0700 patch: add parentheses to disambiguate things webkit-warnings-fix.patch text/plain 5253 bks24 SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM4MDAxKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDgtMTAtMzAgIEJlbmphbWlu IEsuIFN0dWhsICA8YmtzMjRAY29ybmVsbC5lZHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIxOTczCisgICAgICAgIEFkZCBwYXJlbnRoZXNlcyB0byBjbGVhbiB1cCBzb21lIGdj YyB3YXJuaW5ncworCisgICAgICAgIGdjYyA0LjMuMy9saW51eC14ODYgZ2VuZXJhdGVzICJzdWdn ZXN0IHBhcmVudGhlc2VzIGFyb3VuZCAmJiB3aXRoaW4gfHwiIAorICAgICAgICB3YXJuaW5nczsg YWRkIHNvbWUgcGFyZW50aGVzZXMgdG8gZGlzYW1iaWd1YXRlIHRoaW5ncy4gTm8gZnVuY3Rpb25h bAorICAgICAgICBjaGFuZ2VzLCBzbyBubyB0ZXN0cy4KKworICAgICAgICAqIHd0Zi9BU0NJSUNU eXBlLmg6CisgICAgICAgIChXVEY6OmlzQVNDSUlBbHBoYW51bWVyaWMpOgorICAgICAgICAoV1RG Ojppc0FTQ0lJSGV4RGlnaXQpOgorCiAyMDA4LTEwLTMwICBBbHAgVG9rZXIgIDxhbHBAbnVhbnRp LmNvbT4KIAogICAgICAgICBCdWlsZCBmaXggYXR0ZW1wdCBmb3Igb2xkZXIgZ2NjIG9uIHRoZSB0 cnVuay1tYWMtaW50ZWwgYnVpbGQgYm90CkluZGV4OiBKYXZhU2NyaXB0Q29yZS93dGYvQVNDSUlD VHlwZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3d0Zi9BU0NJSUNUeXBlLmgJKHJl dmlzaW9uIDM4MDAxKQorKysgSmF2YVNjcmlwdENvcmUvd3RmL0FTQ0lJQ1R5cGUuaAkod29ya2lu ZyBjb3B5KQpAQCAtNTEsMTIgKzUxLDEyIEBAIG5hbWVzcGFjZSBXVEYgewogI2VuZGlmCiAgICAg aW5saW5lIGJvb2wgaXNBU0NJSUFscGhhKGludCBjKSB7IHJldHVybiAoYyB8IDB4MjApID49ICdh JyAmJiAoYyB8IDB4MjApIDw9ICd6JzsgfQogCi0gICAgaW5saW5lIGJvb2wgaXNBU0NJSUFscGhh bnVtZXJpYyhjaGFyIGMpIHsgcmV0dXJuIGMgPj0gJzAnICYmIGMgPD0gJzknIHx8IChjIHwgMHgy MCkgPj0gJ2EnICYmIChjIHwgMHgyMCkgPD0gJ3onOyB9Ci0gICAgaW5saW5lIGJvb2wgaXNBU0NJ SUFscGhhbnVtZXJpYyh1bnNpZ25lZCBzaG9ydCBjKSB7IHJldHVybiBjID49ICcwJyAmJiBjIDw9 ICc5JyB8fCAoYyB8IDB4MjApID49ICdhJyAmJiAoYyB8IDB4MjApIDw9ICd6JzsgfQorICAgIGlu bGluZSBib29sIGlzQVNDSUlBbHBoYW51bWVyaWMoY2hhciBjKSB7IHJldHVybiAoYyA+PSAnMCcg JiYgYyA8PSAnOScpIHx8ICgoYyB8IDB4MjApID49ICdhJyAmJiAoYyB8IDB4MjApIDw9ICd6Jyk7 IH0KKyAgICBpbmxpbmUgYm9vbCBpc0FTQ0lJQWxwaGFudW1lcmljKHVuc2lnbmVkIHNob3J0IGMp IHsgcmV0dXJuIChjID49ICcwJyAmJiBjIDw9ICc5JykgfHwgKChjIHwgMHgyMCkgPj0gJ2EnICYm IChjIHwgMHgyMCkgPD0gJ3onKTsgfQogI2lmICFDT01QSUxFUihNU1ZDKSB8fCBkZWZpbmVkKF9O QVRJVkVfV0NIQVJfVF9ERUZJTkVEKQotICAgIGlubGluZSBib29sIGlzQVNDSUlBbHBoYW51bWVy aWMod2NoYXJfdCBjKSB7IHJldHVybiBjID49ICcwJyAmJiBjIDw9ICc5JyB8fCAoYyB8IDB4MjAp ID49ICdhJyAmJiAoYyB8IDB4MjApIDw9ICd6JzsgfQorICAgIGlubGluZSBib29sIGlzQVNDSUlB bHBoYW51bWVyaWMod2NoYXJfdCBjKSB7IHJldHVybiAoYyA+PSAnMCcgJiYgYyA8PSAnOScpIHx8 ICgoYyB8IDB4MjApID49ICdhJyAmJiAoYyB8IDB4MjApIDw9ICd6Jyk7IH0KICNlbmRpZgotICAg IGlubGluZSBib29sIGlzQVNDSUlBbHBoYW51bWVyaWMoaW50IGMpIHsgcmV0dXJuIGMgPj0gJzAn ICYmIGMgPD0gJzknIHx8IChjIHwgMHgyMCkgPj0gJ2EnICYmIChjIHwgMHgyMCkgPD0gJ3onOyB9 CisgICAgaW5saW5lIGJvb2wgaXNBU0NJSUFscGhhbnVtZXJpYyhpbnQgYykgeyByZXR1cm4gKGMg Pj0gJzAnICYmIGMgPD0gJzknKSB8fCAoKGMgfCAweDIwKSA+PSAnYScgJiYgKGMgfCAweDIwKSA8 PSAneicpOyB9CiAKICAgICBpbmxpbmUgYm9vbCBpc0FTQ0lJRGlnaXQoY2hhciBjKSB7IHJldHVy biAoYyA+PSAnMCcpICYgKGMgPD0gJzknKTsgfQogICAgIGlubGluZSBib29sIGlzQVNDSUlEaWdp dCh1bnNpZ25lZCBzaG9ydCBjKSB7IHJldHVybiAoYyA+PSAnMCcpICYgKGMgPD0gJzknKTsgfQpA QCAtNjUsMTIgKzY1LDEyIEBAIG5hbWVzcGFjZSBXVEYgewogI2VuZGlmCiAgICAgaW5saW5lIGJv b2wgaXNBU0NJSURpZ2l0KGludCBjKSB7IHJldHVybiAoYyA+PSAnMCcpICYgKGMgPD0gJzknKTsg fQogCi0gICAgaW5saW5lIGJvb2wgaXNBU0NJSUhleERpZ2l0KGNoYXIgYykgeyByZXR1cm4gYyA+ PSAnMCcgJiYgYyA8PSAnOScgfHwgKGMgfCAweDIwKSA+PSAnYScgJiYgKGMgfCAweDIwKSA8PSAn Zic7IH0KLSAgICBpbmxpbmUgYm9vbCBpc0FTQ0lJSGV4RGlnaXQodW5zaWduZWQgc2hvcnQgYykg eyByZXR1cm4gYyA+PSAnMCcgJiYgYyA8PSAnOScgfHwgKGMgfCAweDIwKSA+PSAnYScgJiYgKGMg fCAweDIwKSA8PSAnZic7IH0KKyAgICBpbmxpbmUgYm9vbCBpc0FTQ0lJSGV4RGlnaXQoY2hhciBj KSB7IHJldHVybiAoYyA+PSAnMCcgJiYgYyA8PSAnOScpIHx8ICgoYyB8IDB4MjApID49ICdhJyAm JiAoYyB8IDB4MjApIDw9ICdmJyk7IH0KKyAgICBpbmxpbmUgYm9vbCBpc0FTQ0lJSGV4RGlnaXQo dW5zaWduZWQgc2hvcnQgYykgeyByZXR1cm4gKGMgPj0gJzAnICYmIGMgPD0gJzknKSB8fCAoKGMg fCAweDIwKSA+PSAnYScgJiYgKGMgfCAweDIwKSA8PSAnZicpOyB9CiAjaWYgIUNPTVBJTEVSKE1T VkMpIHx8IGRlZmluZWQoX05BVElWRV9XQ0hBUl9UX0RFRklORUQpCi0gICAgaW5saW5lIGJvb2wg aXNBU0NJSUhleERpZ2l0KHdjaGFyX3QgYykgeyByZXR1cm4gYyA+PSAnMCcgJiYgYyA8PSAnOScg fHwgKGMgfCAweDIwKSA+PSAnYScgJiYgKGMgfCAweDIwKSA8PSAnZic7IH0KKyAgICBpbmxpbmUg Ym9vbCBpc0FTQ0lJSGV4RGlnaXQod2NoYXJfdCBjKSB7IHJldHVybiAoYyA+PSAnMCcgJiYgYyA8 PSAnOScpIHx8ICgoYyB8IDB4MjApID49ICdhJyAmJiAoYyB8IDB4MjApIDw9ICdmJyk7IH0KICNl bmRpZgotICAgIGlubGluZSBib29sIGlzQVNDSUlIZXhEaWdpdChpbnQgYykgeyByZXR1cm4gYyA+ PSAnMCcgJiYgYyA8PSAnOScgfHwgKGMgfCAweDIwKSA+PSAnYScgJiYgKGMgfCAweDIwKSA8PSAn Zic7IH0KKyAgICBpbmxpbmUgYm9vbCBpc0FTQ0lJSGV4RGlnaXQoaW50IGMpIHsgcmV0dXJuIChj ID49ICcwJyAmJiBjIDw9ICc5JykgfHwgKChjIHwgMHgyMCkgPj0gJ2EnICYmIChjIHwgMHgyMCkg PD0gJ2YnKTsgfQogCiAgICAgaW5saW5lIGJvb2wgaXNBU0NJSU9jdGFsRGlnaXQoY2hhciBjKSB7 IHJldHVybiAoYyA+PSAnMCcpICYgKGMgPD0gJzcnKTsgfQogICAgIGlubGluZSBib29sIGlzQVND SUlPY3RhbERpZ2l0KHVuc2lnbmVkIHNob3J0IGMpIHsgcmV0dXJuIChjID49ICcwJykgJiAoYyA8 PSAnNycpOyB9CkluZGV4OiBXZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L0NoYW5nZUxvZwkocmV2aXNpb24gMzgwMDEpCisrKyBXZWJDb3JlL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDA4LTEwLTMwICBCZW5qYW1pbiBLLiBTdHVobCAg PGJrczI0QGNvcm5lbGwuZWR1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTk3 MworICAgICAgICBBZGQgcGFyZW50aGVzZXMgdG8gY2xlYW4gdXAgc29tZSBnY2Mgd2FybmluZ3MK KworICAgICAgICBnY2MgNC4zLjMvbGludXgteDg2IGdlbmVyYXRlcyAic3VnZ2VzdCBwYXJlbnRo ZXNlcyBhcm91bmQgJiYgd2l0aGluIHx8IiAKKyAgICAgICAgd2FybmluZ3M7IGFkZCBzb21lIHBh cmVudGhlc2VzIHRvIGRpc2FtYmlndWF0ZSB0aGluZ3MuIE5vIGZ1bmN0aW9uYWwKKyAgICAgICAg Y2hhbmdlcywgc28gbm8gdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9Gb250 Lmg6CisgICAgICAgIChXZWJDb3JlOjpGb250Ojp0cmVhdEFzWmVyb1dpZHRoU3BhY2UpOgorCiAy MDA4LTEwLTMwICBEaXJrIFNjaHVsemUgIDx2YnM4NUBnbXguZGU+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgQWxwIFRva2VyLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250LmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250LmgJKHJldmlzaW9u IDM4MDAxKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250LmgJKHdvcmtpbmcgY29w eSkKQEAgLTE3OSw3ICsxNzksNyBAQCBwdWJsaWM6CiAgICAgRm9udFNlbGVjdG9yKiBmb250U2Vs ZWN0b3IoKSBjb25zdDsKICNlbmRpZgogICAgIHN0YXRpYyBib29sIHRyZWF0QXNTcGFjZShVQ2hh ciBjKSB7IHJldHVybiBjID09ICcgJyB8fCBjID09ICdcdCcgfHwgYyA9PSAnXG4nIHx8IGMgPT0g MHgwMEEwOyB9Ci0gICAgc3RhdGljIGJvb2wgdHJlYXRBc1plcm9XaWR0aFNwYWNlKFVDaGFyIGMp IHsgcmV0dXJuIGMgPCAweDIwIHx8IChjID49IDB4N0YgJiYgYyA8IDB4QTApIHx8IGMgPT0gMHgy MDBlIHx8IGMgPT0gMHgyMDBmIHx8IGMgPj0gMHgyMDJhICYmIGMgPD0gMHgyMDJlIHx8IGMgPT0g MHhGRkZDOyB9CisgICAgc3RhdGljIGJvb2wgdHJlYXRBc1plcm9XaWR0aFNwYWNlKFVDaGFyIGMp IHsgcmV0dXJuIGMgPCAweDIwIHx8IChjID49IDB4N0YgJiYgYyA8IDB4QTApIHx8IGMgPT0gMHgy MDBlIHx8IGMgPT0gMHgyMDBmIHx8IChjID49IDB4MjAyYSAmJiBjIDw9IDB4MjAyZSkgfHwgYyA9 PSAweEZGRkM7IH0KIAogI2lmIEVOQUJMRShTVkdfRk9OVFMpCiAgICAgYm9vbCBpc1NWR0ZvbnQo KSBjb25zdDsK