219689 2020-12-09 08:34:27 -0800 [WPE][GTK] Should enable WebProcessCache 2020-12-14 04:28:25 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro webkit-unassigned aperez berto bugs-noreply cdumez cgarcia ews-watchlist gustavo mcatanzaro oldest_to_newest 1713162 0 mcatanzaro 2020-12-09 08:34:27 -0800 It looks like WPE and GTK do not enable the WebProcessCache feature added in r241556: """ Introduce a WebContent Process cache to reduce the number of process launches when process swap on navigation is enabled, and to reduce the power cost of the feature. If a WebProcess loaded pages from a single registrable domain then it is eligible for the cache. When process-swapping on navigation to a new registrable domain, we now attempt to retrieve a process from the cache for the domain in question instead of always launching a new one. The WebProcess cache currently has the following attributes: It may contains 4 processes per GB of RAM the machine has, up to 30 processes. WebProcesses automatically get evicted from the cache after 30 minutes. If the application is no longer the active app, then the cache will get cleared after 5 minutes. WebProcesses that are in the cache are reported as "(Cached)" in Activity Monitor. The WebProcess cache is currently disabled by default and can by enabled by the client via SPI. """ We probably want to have that enabled, or at least make it possible to enable it? 1713164 1 cdumez 2020-12-09 08:36:16 -0800 If you have Process-Swap-On-Navigation (PSON) enabled, then I think you'd definitely want the process cache too. Note that Apple only enables the process-cache on desktop (not mobile) due to memory constraints. 1713168 2 mcatanzaro 2020-12-09 08:39:03 -0800 Yeah of course we have PSON. That has been enabled for ages now. I think nobody realized that the process cache had to be enabled separately. 1713170 3 mcatanzaro 2020-12-09 08:42:22 -0800 (In reply to Chris Dumez from comment #1) > If you have Process-Swap-On-Navigation (PSON) enabled, then I think you'd > definitely want the process cache too. Note that Apple only enables the > process-cache on desktop (not mobile) due to memory constraints. Currently we have a chassis type check that could be used for this, but it doesn't work reliably due to bug #218122, and is currently only used to set a mobile user agent header. It would probably make more sense to enable or disable the cache based on total available RAM, rather than checking form factor, since there's not really any difference between a mobile phone with 3 GB RAM (Librem 5) and a desktop with 3 GB RAM. The performance hit if you run out of RAM is going to be bad either way. 1713171 4 cdumez 2020-12-09 08:44:34 -0800 (In reply to Michael Catanzaro from comment #3) > (In reply to Chris Dumez from comment #1) > > If you have Process-Swap-On-Navigation (PSON) enabled, then I think you'd > > definitely want the process cache too. Note that Apple only enables the > > process-cache on desktop (not mobile) due to memory constraints. > > Currently we have a chassis type check that could be used for this, but it > doesn't work reliably due to bug #218122, and is currently only used to set > a mobile user agent header. > > It would probably make more sense to enable or disable the cache based on > total available RAM, rather than checking form factor, since there's not > really any difference between a mobile phone with 3 GB RAM (Librem 5) and a > desktop with 3 GB RAM. The performance hit if you run out of RAM is going to > be bad either way. Yes, Apple port listen to memory pressure warnings and kill those cached processes as necessary. 1713500 5 cgarcia 2020-12-10 05:22:33 -0800 I thought it was enabled. I'll submit a patch. 1713501 6 415860 cgarcia 2020-12-10 05:23:25 -0800 Created attachment 415860 Patch 1713502 7 ews-watchlist 2020-12-10 05:24:15 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1713524 8 415860 aperez 2020-12-10 06:28:46 -0800 Comment on attachment 415860 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415860&action=review > Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:394 > + configuration.setUsesWebProcessCache(true); I think it's fine to land this as-is, but depending on things go we might need to either add some smarts to choose a sensible default for this and/or add API to WebKitWebContext to toggle it. 1713530 9 mcatanzaro 2020-12-10 06:56:39 -0800 The GTK API EWS is red. Score +1 for whoever set up that EWS bot. That is nice to have.... 1714412 10 416146 cgarcia 2020-12-14 03:01:00 -0800 Created attachment 416146 Patch for landing 1714421 11 cgarcia 2020-12-14 04:28:25 -0800 Committed r270767: <https://trac.webkit.org/changeset/270767> 415860 2020-12-10 05:23:25 -0800 2020-12-14 03:01:00 -0800 Patch wk2-process-cache.diff text/plain 1278 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNmJjZDQ5YjhkMDI3Li5jOWE1N2QxODZlZDAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTMgQEAKKzIwMjAtMTItMTAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtXUEVdW0dUS10gU2hvdWxkIGVuYWJsZSBXZWJQcm9jZXNzQ2Fj aGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxOTY4 OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQ cm9jZXNzL0FQSS9nbGliL1dlYktpdFdlYkNvbnRleHQuY3BwOgorICAgICAgICAod2Via2l0V2Vi Q29udGV4dENvbnN0cnVjdGVkKToKKwogMjAyMC0xMi0xMCAgSmlld2VuIFRhbiAgPGppZXdlbl90 YW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtXZWJBdXRobl0gQWRvcHQgbmV3IFVJIGZvciB0aGUg U2VjdXJpdHkgS2V5IG1ha2VDcmVkZW50aWFsIGZsb3cKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFdlYkNvbnRleHQuY3BwIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2ViQ29udGV4dC5jcHAKaW5kZXggZjdmYWE1ODgw YmYwLi5hY2Y5Y2NkYjZkMTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQ SS9nbGliL1dlYktpdFdlYkNvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0FQSS9nbGliL1dlYktpdFdlYkNvbnRleHQuY3BwCkBAIC0zOTEsNiArMzkxLDcgQEAgc3RhdGlj IHZvaWQgd2Via2l0V2ViQ29udGV4dENvbnN0cnVjdGVkKEdPYmplY3QqIG9iamVjdCkKIAogICAg IEFQSTo6UHJvY2Vzc1Bvb2xDb25maWd1cmF0aW9uIGNvbmZpZ3VyYXRpb247CiAgICAgY29uZmln dXJhdGlvbi5zZXRJbmplY3RlZEJ1bmRsZVBhdGgoRmlsZVN5c3RlbTo6c3RyaW5nRnJvbUZpbGVT eXN0ZW1SZXByZXNlbnRhdGlvbihidW5kbGVGaWxlbmFtZS5nZXQoKSkpOworICAgIGNvbmZpZ3Vy YXRpb24uc2V0VXNlc1dlYlByb2Nlc3NDYWNoZSh0cnVlKTsKICNpZiBQTEFURk9STShHVEspCiAg ICAgY29uZmlndXJhdGlvbi5zZXRQcm9jZXNzU3dhcHNPbk5hdmlnYXRpb24ocHJpdi0+cHNvbkVu YWJsZWQpOwogI2lmICFVU0UoR1RLNCkK 416146 2020-12-14 03:01:00 -0800 2020-12-14 03:01:00 -0800 Patch for landing wk-process-cache.diff text/plain 1295 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggMzAzMjhjZjZlODQ1Li5jODNmNTY1OGE2ZmIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTMgQEAKKzIwMjAtMTItMTQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtXUEVdW0dUS10gU2hvdWxkIGVuYWJsZSBXZWJQcm9jZXNzQ2Fj aGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxOTY4 OQorCisgICAgICAgIFJldmlld2VkIGJ5IEFkcmlhbiBQZXJleiBkZSBDYXN0cm8uCisKKyAgICAg ICAgKiBVSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2ViQ29udGV4dC5jcHA6CisgICAgICAgICh3 ZWJraXRXZWJDb250ZXh0Q29uc3RydWN0ZWQpOgorCiAyMDIwLTEyLTEzICBZdXN1a2UgU3V6dWtp ICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10gSW50cm9kdWNlIHZtRW50cnlD dXN0b21BY2Nlc3NvciBhbmQgdm1FbnRyeUhvc3RGdW5jdGlvbiBmb3IgSklUQ2FnZQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2ViQ29udGV4dC5j cHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRXZWJDb250ZXh0LmNw cAppbmRleCBmN2ZhYTU4ODBiZjAuLmFjZjljY2RiNmQxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2ViQ29udGV4dC5jcHAKKysrIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2ViQ29udGV4dC5jcHAKQEAgLTM5MSw2 ICszOTEsNyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRXZWJDb250ZXh0Q29uc3RydWN0ZWQoR09iamVj dCogb2JqZWN0KQogCiAgICAgQVBJOjpQcm9jZXNzUG9vbENvbmZpZ3VyYXRpb24gY29uZmlndXJh dGlvbjsKICAgICBjb25maWd1cmF0aW9uLnNldEluamVjdGVkQnVuZGxlUGF0aChGaWxlU3lzdGVt OjpzdHJpbmdGcm9tRmlsZVN5c3RlbVJlcHJlc2VudGF0aW9uKGJ1bmRsZUZpbGVuYW1lLmdldCgp KSk7CisgICAgY29uZmlndXJhdGlvbi5zZXRVc2VzV2ViUHJvY2Vzc0NhY2hlKHRydWUpOwogI2lm IFBMQVRGT1JNKEdUSykKICAgICBjb25maWd1cmF0aW9uLnNldFByb2Nlc3NTd2Fwc09uTmF2aWdh dGlvbihwcml2LT5wc29uRW5hYmxlZCk7CiAjaWYgIVVTRShHVEs0KQo=