219676 2020-12-09 03:45:03 -0800 Build error after r270457 2020-12-09 09:55:39 -0800 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 psaavedra psaavedra aperez cdumez darin eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1713092 0 psaavedra 2020-12-09 03:45:03 -0800 Related with https://bugs.webkit.org/show_bug.cgi?id=219546 Error: ../../Source/WebCore/platform/audio/SincResampler.cpp: In member function �~@~Xfloat WebCore::SincResampler::convolve(const float*, const float*, const float*, float)�~@~Y: ../../Source/WebCore/platform/audio/SincResampler.cpp:339:35: error: �~@~XkKernelSize�~@~Y was not declared in this scope; did you mean �~@~XkernelSize�~@~Y? 339 | const float* upper = inputP + kKernelSize; | ^~~~~~~~~~~ | kernelSize It seems kKernelSize defined for Source/WebCore/platform/audio/SincResampler.h|cpp ... but it is defined in Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/sinc_resampler.h class SincResampler { public: // The kernel size can be adjusted for quality (higher is better) at the // expense of performance. Must be a multiple of 32. // TODO(dalecurtis): Test performance to see if we can jack this up to 64+. static const size_t kKernelSize = 32; 1713095 1 415737 psaavedra 2020-12-09 03:51:01 -0800 Created attachment 415737 patch 1713152 2 415737 cdumez 2020-12-09 08:24:36 -0800 Comment on attachment 415737 patch View in context: https://bugs.webkit.org/attachment.cgi?id=415737&action=review > Source/WebCore/platform/audio/SincResampler.h:51 > + static const size_t kKernelSize = 32; See in SincResampler.cpp: constexpr unsigned kernelSize { 32 }; We should be using kernelSize, not kKernelSize. 1713158 3 cdumez 2020-12-09 08:31:16 -0800 Committed r270581: <https://trac.webkit.org/changeset/270581> 1713159 4 webkit-bug-importer 2020-12-09 08:32:19 -0800 <rdar://problem/72137809> 1713207 5 psaavedra 2020-12-09 09:55:39 -0800 (In reply to Chris Dumez from comment #3) > Committed r270581: <https://trac.webkit.org/changeset/270581> OK. Thanks. 415737 2020-12-09 03:51:01 -0800 2020-12-09 08:24:36 -0800 patch bug-219676-20201209125059.patch text/plain 1331 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwNTc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGZhMjQ2Yzc4MjMxZjZl YTJlOTM4ZmZjZjYwMGI4YjU0ZDdhMzU0MC4uMmI5MTgyOTI0NGI1MzQ1ZmViZmZmODM4OWFlYTlh NTlmMWZhNDZkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIwLTEyLTA5ICBQYWJs byBTYWF2ZWRyYSAgPHBzYWF2ZWRyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIEJ1aWxkIGVycm9y IGFmdGVyIHIyNzA0NTcuIE1pc3NpbmcgZGVmaW5pdGlvbiBmb3Iga0tlcm5lbFNpemUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxOTY3NgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vYXVk aW8vU2luY1Jlc2FtcGxlci5oOgorCiAyMDIwLTEyLTA5ICBTaWh1aSBMaXUgIDxzaWh1aV9saXVA YXBwbGUuY29tPgogCiAgICAgICAgIEltcGxlbWVudCBhdWRpbyBjYXB0dXJlIGZvciBTcGVlY2hS ZWNvZ25pdGlvbiBvbiBpT1MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1 ZGlvL1NpbmNSZXNhbXBsZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL1NpbmNS ZXNhbXBsZXIuaAppbmRleCA1ZTZkYWMyNGNhMWFlZGE1Y2Q2NWUwZDNmZTg3ZTBmN2JkNGRhMWZm Li5mMTJlMjhmYzA0ODlmMGIwMjY0ZjU5NWIyMzgxYWRkOWJlYzE3MzE0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9TaW5jUmVzYW1wbGVyLmgKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vU2luY1Jlc2FtcGxlci5oCkBAIC00OCw2ICs0OCw4IEBA IHB1YmxpYzoKICAgICAKICAgICBzaXplX3QgY2h1bmtTaXplKCkgY29uc3QgeyByZXR1cm4gbV9j aHVua1NpemU7IH0KIAorICAgIHN0YXRpYyBjb25zdCBzaXplX3Qga0tlcm5lbFNpemUgPSAzMjsK KwogICAgIC8vIFByb2Nlc3NlcyBudW1iZXJPZlNvdXJjZUZyYW1lcyBmcm9tIHNvdXJjZSB0byBw cm9kdWNlIG51bWJlck9mU291cmNlRnJhbWVzIC8gc2NhbGVGYWN0b3IgZnJhbWVzIGluIGRlc3Rp bmF0aW9uLgogICAgIHN0YXRpYyB2b2lkIHByb2Nlc3NCdWZmZXIoY29uc3QgZmxvYXQqIHNvdXJj ZSwgZmxvYXQqIGRlc3RpbmF0aW9uLCB1bnNpZ25lZCBudW1iZXJPZlNvdXJjZUZyYW1lcywgZG91 YmxlIHNjYWxlRmFjdG9yKTsKIAo=