219665 2020-12-08 20:18:54 -0800 Fix clicking on links in PDFs on Big Sur after r266654 2020-12-09 11:58:55 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen thorton webkit-bug-importer oldest_to_newest 1713006 0 achristensen 2020-12-08 20:18:54 -0800 Fix clicking on links in PDFs on Big Sur after r266654 1713008 1 415704 achristensen 2020-12-08 20:23:02 -0800 Created attachment 415704 Patch 1713009 2 achristensen 2020-12-08 20:23:04 -0800 <rdar://problem/72080683> 1713064 3 415704 thorton 2020-12-09 00:54:53 -0800 Comment on attachment 415704 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415704&action=review > Source/WebKit/UIProcess/PDF/WKPDFHUDView.mm:170 > + if (_page) > + return fromWebPageProxy(*_page); > + > + ASSERT_NOT_REACHED(); > + return self; I think you want to just return nil 1713065 4 thorton 2020-12-09 00:55:57 -0800 ALSO, don't you need to get mouse events when you're inside the HUD? It looks like WKPDFHudView implements mouseDown. 1713066 5 thorton 2020-12-09 00:57:00 -0800 So probably what you really want is to return nil UNLESS the point is inside _layer, in which case you return self. 1713067 6 thorton 2020-12-09 00:57:19 -0800 (In reply to Tim Horton from comment #5) > So probably what you really want is to return nil UNLESS the point is inside > _layer, in which case you return self. (And also only if the layer is not hidden, but I think it always will be unhidden if the mouse is over it??) 1713198 7 achristensen 2020-12-09 09:25:33 -0800 WebViewImpl::mouseDown and friends give all HUDs the needed mouse events, not just this one, which is better than what you suggested because there may be two partially overlapping HUDs. 1713228 8 thorton 2020-12-09 10:59:05 -0800 Oh! So it’s called by WebKit code, not appkit? Very confusing! 1713253 9 ews-feeder 2020-12-09 11:58:54 -0800 Committed r270593: <https://trac.webkit.org/changeset/270593> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415704. 415704 2020-12-08 20:23:02 -0800 2020-12-09 11:58:55 -0800 Patch bug-219665-20201208202301.patch text/plain 2105 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwNDIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFkMjYwZThlYWM5NmVjMDUy MzQ5N2QyZTQ0ODFhZDJlOGMxZDUzNDIuLmQxM2U0Y2UzOTdiNTk3OTRlZTRmNmE2YzdkYTg0OTM4 NGJmZTQzOGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjAtMTItMDggIEFsZXggQ2hy aXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBGaXggY2xpY2tp bmcgb24gbGlua3MgaW4gUERGcyBvbiBCaWcgU3VyIGFmdGVyIHIyNjY2NTQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxOTY2NQorICAgICAgICA8cmRh cjovL3Byb2JsZW0vNzIwODA2ODM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgbW91c2VVcDogd2FzIGJlaW5nIGNhbGxlZCBieSBBcHBLaXQgb24gdGhl IFdLUERGSFVEVmlldyBpbnN0ZWFkIG9mIHRoZSBXS1dlYlZpZXcsIGNhdXNpbmcgdGhlIGV2ZW50 IHRvIG5vdCBtYWtlIGl0IHRvIHRoZSBQREZQbHVnaW4sCisgICAgICAgIHdoaWNoIG1lYW50IFBE RktpdCB3YXNuJ3QgYmVpbmcgdG9sZCBpdCB3YXMgY2xpY2tlZCBvbiwgd2hpY2ggbWVhbnMgaXQg d2Fzbid0IHRlbGxpbmcgV2ViS2l0IHRvIGNoYW5nZSB0aGUgZnJhbWUncyBsb2NhdGlvbi4KKyAg ICAgICAgT3ZlcnJpZGluZyBoaXRUZXN0IHRvIGZvcndhcmQgYWxsIG1vdXNlIGV2ZW50cyB0byB0 aGUgV0tXZWJWaWV3IHNvbHZlcyB0aGlzIHByb2JsZW0uCisKKyAgICAgICAgQ292ZXJlZCBieSB0 aGUgV2ViS2l0LlBERkxpbmtSZWZlcnJlciBBUEkgdGVzdCwgd2hpY2ggd2FzIGZhaWxpbmcgb24g QmlnIFN1ciwgd2hlcmUgRU5BQkxFKFVJX1BST0NFU1NfUERGX0hVRCkgaXMgdHJ1ZS4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9QREYvV0tQREZIVURWaWV3Lm1tOgorICAgICAgICAoLVtXS1BERkhV RFZpZXcgaGl0VGVzdDpdKToKKwogMjAyMC0xMi0wMyAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBs ZS5jb20+CiAKICAgICAgICAgQWRvcHQgRkFMTEJBQ0tfUExBVEZPUk0KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL1BERi9XS1BERkhVRFZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9QREYvV0tQREZIVURWaWV3Lm1tCmluZGV4IGNlNjYwYzgzMjIxOTZlMGI1NDhl MDU0NDhkYzE1MGNhMmE1ODg0NGMuLjZmNjc3ZTE1YWFkMjJlOWFmNGEzYTI4ZGU0YjFjYjljZjQ3 YjJkOTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1BERi9XS1BERkhVRFZp ZXcubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvUERGL1dLUERGSFVEVmlldy5tbQpA QCAtMjgsNiArMjgsNyBAQAogCiAjaWYgRU5BQkxFKFVJX1BST0NFU1NfUERGX0hVRCkKIAorI2lt cG9ydCAiV0tXZWJWaWV3SW50ZXJuYWwuaCIKICNpbXBvcnQgIldlYlBhZ2VQcm94eS5oIgogI2lt cG9ydCA8UXVhcnR6Q29yZS9DQVRyYW5zYWN0aW9uLmg+CiAjaW1wb3J0IDxwYWwvc3BpL2NvY29h L1F1YXJ0ekNvcmVTUEkuaD4KQEAgLTE2MCw2ICsxNjEsMTUgQEAgc3RhdGljIE5TQXJyYXk8TlNT dHJpbmcgKj4gKmNvbnRyb2xBcnJheSgpCiAgICAgW0NBVHJhbnNhY3Rpb24gY29tbWl0XTsKIH0K IAorLSAoTlNWaWV3ICopaGl0VGVzdDooTlNQb2ludClwb2ludAoreworICAgIGlmIChfcGFnZSkK KyAgICAgICAgcmV0dXJuIGZyb21XZWJQYWdlUHJveHkoKl9wYWdlKTsKKworICAgIEFTU0VSVF9O T1RfUkVBQ0hFRCgpOworICAgIHJldHVybiBzZWxmOworfQorCiAtICh2b2lkKW1vdXNlTW92ZWQ6 KE5TRXZlbnQgKilldmVudAogewogICAgIGlmIChDR1JlY3RDb250YWluc1BvaW50KFtzZWxmIGNv bnZlcnRSZWN0OkNHUmVjdEluc2V0KFtfbGF5ZXIgZnJhbWVdLCAtMTYuMCwgLTE2LjApIHRvVmll dzpuaWxdLCBOU1BvaW50VG9DR1BvaW50KGV2ZW50LmxvY2F0aW9uSW5XaW5kb3cpKSkgewo=