219660 2020-12-08 15:45:52 -0800 [GPUProcess] Video does not resume if the GPU Process crashes while in fullscreen 2020-12-09 10:23:17 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez darin eric.carlson ews-watchlist glenn jer.noble peng.liu6 philipj sergio webkit-bug-importer oldest_to_newest 1712956 0 cdumez 2020-12-08 15:45:52 -0800 Video does not resume if the GPU Process crashes while in fullscreen. 1712957 1 415685 cdumez 2020-12-08 15:51:25 -0800 Created attachment 415685 Patch 1712961 2 415685 peng.liu6 2020-12-08 15:59:31 -0800 Comment on attachment 415685 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415685&action=review > Source/WebCore/ChangeLog:11 > + again. However, the full screen logic lives in the UIProcess and I could no figure out how to s/no/not/ > Source/WebCore/ChangeLog:13 > + I have verified that the video renders properly if the user re-enter full screen after a crash. Nice! I assume this patch works for the picture-in-picture case as well, right? Did you see any issue in the animation (exit fullscreen)? 1712962 3 cdumez 2020-12-08 16:03:06 -0800 (In reply to Peng Liu from comment #2) > Comment on attachment 415685 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=415685&action=review > > > Source/WebCore/ChangeLog:11 > > + again. However, the full screen logic lives in the UIProcess and I could no figure out how to > > s/no/not/ > > > Source/WebCore/ChangeLog:13 > > + I have verified that the video renders properly if the user re-enter full screen after a crash. > > Nice! I assume this patch works for the picture-in-picture case as well, > right? Did you see any issue in the animation (exit fullscreen)? I see no reason why it would no work in PIP but I have not tested. I personally don't see an animation when full screen exits due to a crash. I am not sure why since we are not calling the exitFullScreenWithoutAnination. That said, it does not look bad, especially considering something crashed. 1712965 4 415687 cdumez 2020-12-08 16:04:29 -0800 Created attachment 415687 Patch 1712976 5 415687 darin 2020-12-08 17:07:35 -0800 Comment on attachment 415687 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415687&action=review > Source/WebCore/platform/graphics/MediaPlayer.cpp:535 > + if (client().mediaPlayerFullscreenMode() != MediaPlayer::VideoFullscreenModeNone) > + client().mediaPlayerExitFullscreen(); Not sure it’s self explanatory that "we would play in full screen if we could, but we can’t make that work, so exit full screen to work around that" is the intention here. Maybe add a brief comment? 1712977 6 415687 darin 2020-12-08 17:08:25 -0800 Comment on attachment 415687 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415687&action=review >> Source/WebCore/platform/graphics/MediaPlayer.cpp:535 >> + client().mediaPlayerExitFullscreen(); > > Not sure it’s self explanatory that "we would play in full screen if we could, but we can’t make that work, so exit full screen to work around that" is the intention here. Maybe add a brief comment? Maybe something like: "It would be even better if we could resume in full screen mode, but, for now, exiting full screen makes the video rendering work." 1713213 7 cdumez 2020-12-09 10:22:53 -0800 Committed r270586: <https://trac.webkit.org/changeset/270586> 1713214 8 webkit-bug-importer 2020-12-09 10:23:17 -0800 <rdar://problem/72141981> 415685 2020-12-08 15:51:25 -0800 2020-12-08 16:04:27 -0800 Patch bug-219660-20201208155124.patch text/plain 2105 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwNTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGQxODJjZmM1Mzc1MTVm MzcyNTdlYzc5ZjU0ZmUwZWRjZjdjNWU4ZS4uOTBkYzYwYmNhZTQ4MjA1N2RlN2FmYzVlZTAwMGRl Y2IxYWI0NmU5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTEyLTA4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW0dQVVByb2Nlc3NdIFZpZGVv IGRvZXMgbm90IHJlc3VtZSBpZiB0aGUgR1BVIFByb2Nlc3MgY3Jhc2hlcyB3aGlsZSBpbiBmdWxs c2NyZWVuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MTk2NjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBX aGVuIHRoZSBHUFUgcHJvY2VzcyB3YXMgY3Jhc2hpbmcgd2hpbGUgYSB2aWRlbyB3YXMgcGxheWlu ZyBpbiBmdWxsIHNjcmVlbiAodmVyeSBjb21tb24gb24gaU9TKSwKKyAgICAgICAgd2Ugd291bGQg YXR0ZW1wdCB0byByZXN1bWUgcGxheWJhY2sgYnV0IHZpZGVvIHJlbmRlcmluZyB3YXMgYnJva2Vu LiBJdCBsb29rcyBsaWtlIHRoaXMgc2hvdWxkCisgICAgICAgIGJlIHJlY292ZXJhYmxlIGluIHNv bWUgd2F5IHNpbmNlIGNoYW5naW5nIHRoZSBvcmllbnRhdGlvbiBvZiB0aGUgZGV2aWNlIG1ha2Vz IHRoZSB2aWRlbyByZW5kZXIKKyAgICAgICAgYWdhaW4uIEhvd2V2ZXIsIHRoZSBmdWxsIHNjcmVl biBsb2dpYyBsaXZlcyBpbiB0aGUgVUlQcm9jZXNzIGFuZCBJIGNvdWxkIG5vIGZpZ3VyZSBvdXQg aG93IHRvCisgICAgICAgIHJlY292ZXIgbmljZWx5LiBBcyBhIHJlc3VsdCwgdGhpcyBwYXRjaCBz aW1wbHkgZXhpdHMgZnVsbHNjcmVlbiB3aGVuIHRoZSBHUFUgcHJvY2VzcyBjcmFzaGVzLgorICAg ICAgICBJIGhhdmUgdmVyaWZpZWQgdGhhdCB0aGUgdmlkZW8gcmVuZGVycyBwcm9wZXJseSBpZiB0 aGUgdXNlciByZS1lbnRlciBmdWxsIHNjcmVlbiBhZnRlciBhIGNyYXNoLgorCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVk aWFQbGF5ZXI6OnJlbG9hZEFuZFJlc3VtZVBsYXliYWNrSWZOZWVkZWQpOgorCiAyMDIwLTEyLTA3 ICBBbmRyZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQg Y2hlY2sgdG8gZW5zdXJlIHRoYXQgdGhlIHNpemUgb2YgdGhlIHJlc3VsdCBvZiBBWFRleHRNYXJr ZXJHZXRCeXRlUHRyIGlzIGVxdWFsIHRvIHRoZSBzaXplIG9mIFRleHRNYXJrZXJEYXRhLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuY3BwCmluZGV4 IGUyNmFlNTkzNDkwNWU2NzM0NjhlNzY1YWZmYzdmYTM5ZmQ0ODQxNTAuLmE3ZThmODAyNTY3YmQz ODhkNmI1NDAwZmNiZjEzNDJhYzc0MjkyYzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5jcHAKQEAgLTUzMSw2ICs1MzEsOSBAQCB2b2lkIE1l ZGlhUGxheWVyOjpyZWxvYWRBbmRSZXN1bWVQbGF5YmFja0lmTmVlZGVkKCkKICAgICBhdXRvIHBy ZXZpb3VzTWVkaWFUaW1lID0gY3VycmVudFRpbWUoKTsKICAgICBib29sIHdhc1BhdXNlZCA9IHBh dXNlZCgpOwogCisgICAgaWYgKGNsaWVudCgpLm1lZGlhUGxheWVyRnVsbHNjcmVlbk1vZGUoKSAh PSBNZWRpYVBsYXllcjo6VmlkZW9GdWxsc2NyZWVuTW9kZU5vbmUpCisgICAgICAgIGNsaWVudCgp Lm1lZGlhUGxheWVyRXhpdEZ1bGxzY3JlZW4oKTsKKwogICAgIG1fY3VycmVudE1lZGlhRW5naW5l ID0gbnVsbHB0cjsKICAgICBsb2FkV2l0aE5leHRNZWRpYUVuZ2luZShudWxscHRyKTsKIAo= 415687 2020-12-08 16:04:29 -0800 2020-12-08 18:29:06 -0800 Patch bug-219660-20201208160428.patch text/plain 2098 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjcwNTYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjVkZmQ0YjE5Y2ZkMGQ5 NWNlYWRkOTA4NmQ4NmNlYTllNTU2YzlhYS4uMThiZjhmNzExZmYyOWQ3ODc2ZDc1NWQ2YzE3Y2Uw MDJkYmQwYzE5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTEyLTA4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW0dQVVByb2Nlc3NdIFZpZGVv IGRvZXMgbm90IHJlc3VtZSBpZiB0aGUgR1BVIFByb2Nlc3MgY3Jhc2hlcyB3aGlsZSBpbiBmdWxs c2NyZWVuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MTk2NjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBX aGVuIHRoZSBHUFUgcHJvY2VzcyB3YXMgY3Jhc2hpbmcgd2hpbGUgYSB2aWRlbyB3YXMgcGxheWlu ZyBpbiBmdWxsIHNjcmVlbiAodmVyeSBjb21tb24gb24gaU9TKSwKKyAgICAgICAgd2Ugd291bGQg YXR0ZW1wdCB0byByZXN1bWUgcGxheWJhY2sgYnV0IHZpZGVvIHJlbmRlcmluZyB3YXMgYnJva2Vu LiBJdCBsb29rcyBsaWtlIHRoaXMgc2hvdWxkCisgICAgICAgIGJlIHJlY292ZXJhYmxlIGluIHNv bWUgd2F5IHNpbmNlIGNoYW5naW5nIHRoZSBvcmllbnRhdGlvbiBvZiB0aGUgZGV2aWNlIG1ha2Vz IHRoZSB2aWRlbyByZW5kZXIKKyAgICAgICAgYWdhaW4uIEhvd2V2ZXIsIHRoZSBmdWxsIHNjcmVl biBsb2dpYyBsaXZlcyBpbiB0aGUgVUlQcm9jZXNzIGFuZCBJIGNvdWxkIG5vdCBmaWd1cmUgb3V0 IGhvdyB0bworICAgICAgICByZWNvdmVyIG5pY2VseS4gQXMgYSByZXN1bHQsIHRoaXMgcGF0Y2gg c2ltcGx5IGV4aXRzIGZ1bGxzY3JlZW4gd2hlbiB0aGUgR1BVIHByb2Nlc3MgY3Jhc2hlcy4KKyAg ICAgICAgSSBoYXZlIHZlcmlmaWVkIHRoYXQgdGhlIHZpZGVvIHJlbmRlcnMgcHJvcGVybHkgaWYg dGhlIHVzZXIgcmUtZW50ZXIgZnVsbCBzY3JlZW4gYWZ0ZXIgYSBjcmFzaC4KKworICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1l ZGlhUGxheWVyOjpyZWxvYWRBbmRSZXN1bWVQbGF5YmFja0lmTmVlZGVkKToKKwogMjAyMC0xMi0w OCAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFRleHRNYW5p cHVsYXRpb25Db250cm9sbGVyIHNvbWV0aW1lcyBmYWlscyB0byBub3RpZnkgaXRzIGRlbGVnYXRl IG9mIG5ldyB0ZXh0IChpZiBhbiBlbGVtZW50IGhhcyBiZWVuIHJlbW92ZWQpCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5jcHAKaW5kZXggZTI2YWU1 OTM0OTA1ZTY3MzQ2OGU3NjVhZmZjN2ZhMzlmZDQ4NDE1MC4uYTdlOGY4MDI1NjdiZDM4OGQ2YjU0 MDBmY2JmMTM0MmFjNzQyOTJjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvTWVkaWFQbGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL01lZGlhUGxheWVyLmNwcApAQCAtNTMxLDYgKzUzMSw5IEBAIHZvaWQgTWVkaWFQbGF5 ZXI6OnJlbG9hZEFuZFJlc3VtZVBsYXliYWNrSWZOZWVkZWQoKQogICAgIGF1dG8gcHJldmlvdXNN ZWRpYVRpbWUgPSBjdXJyZW50VGltZSgpOwogICAgIGJvb2wgd2FzUGF1c2VkID0gcGF1c2VkKCk7 CiAKKyAgICBpZiAoY2xpZW50KCkubWVkaWFQbGF5ZXJGdWxsc2NyZWVuTW9kZSgpICE9IE1lZGlh UGxheWVyOjpWaWRlb0Z1bGxzY3JlZW5Nb2RlTm9uZSkKKyAgICAgICAgY2xpZW50KCkubWVkaWFQ bGF5ZXJFeGl0RnVsbHNjcmVlbigpOworCiAgICAgbV9jdXJyZW50TWVkaWFFbmdpbmUgPSBudWxs cHRyOwogICAgIGxvYWRXaXRoTmV4dE1lZGlhRW5naW5lKG51bGxwdHIpOwogCg==