219644 2020-12-08 08:00:17 -0800 [webkitcorepy] Fix case where cached=True with other arguments 2020-12-08 09:14:16 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard dewei_zhu slewis webkit-bug-importer oldest_to_newest 1712794 0 jbedard 2020-12-08 08:00:17 -0800 Memoized was referencing the cache by args instead of keyargs in a subset of cases. 1712796 1 webkit-bug-importer 2020-12-08 08:01:24 -0800 <rdar://problem/72092851> 1712799 2 415645 jbedard 2020-12-08 08:03:55 -0800 Created attachment 415645 Patch 1712811 3 ews-feeder 2020-12-08 09:14:16 -0800 Committed r270540: <https://trac.webkit.org/changeset/270540> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415645. 415645 2020-12-08 08:03:55 -0800 2020-12-08 09:14:16 -0800 Patch bug-219644-20201208100354.patch text/plain 3686 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3MDUzOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDIwLTEyLTA4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0Y29yZXB5XSBGaXggY2FzZSB3aGVyZSBjYWNoZWQ9VHJ1ZSB3 aXRoIG90aGVyIGFyZ3VtZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjE5NjQ0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83MjA5Mjg1MT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMv bGlicmFyaWVzL3dlYmtpdGNvcmVweS93ZWJraXRjb3JlcHkvX19pbml0X18ucHk6IEJ1bXAgdmVy c2lvbi4KKyAgICAgICAgKiBTY3JpcHRzL2xpYnJhcmllcy93ZWJraXRjb3JlcHkvd2Via2l0Y29y ZXB5L2RlY29yYXRvcnMucHk6CisgICAgICAgIChNZW1vaXplLl9fY2FsbF9fLmRlY29yYXRvcik6 IFVzZSBrZXlhcmdzIGluc3RlYWQgb2YgYXJncy4KKyAgICAgICAgKiBTY3JpcHRzL2xpYnJhcmll cy93ZWJraXRjb3JlcHkvd2Via2l0Y29yZXB5L3Rlc3RzL2RlY29yYXRvcnNfdW5pdHRlc3QucHk6 CisgICAgICAgIChUZXN0TWVtb2l6ZSk6CisgICAgICAgIChUZXN0TWVtb2l6ZS5pbmNyZW1lbnRf d2l0aF9hcmcpOiBBZGRlZC4KKyAgICAgICAgKFRlc3RNZW1vaXplLnRlc3Rfb3ZlcnJpZGUpOgor CiAyMDIwLTEyLTA4ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KIAogICAg ICAgICBbZXdzXSBjb21taXQtcXVldWUgc2hvdWxkIHVzZSBvbmx5IHRoZSBmaXJzdCBlbWFpbCBm cm9tIGNvbnRyaWJ1dG9ycy5qc29uIHRvIHZhbGlkYXRlIGNvbW1pdHRlcnMgYW5kIHJldmlld2Vy cwpJbmRleDogVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0Y29yZXB5L3dlYmtpdGNvcmVw eS9fX2luaXRfXy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJr aXRjb3JlcHkvd2Via2l0Y29yZXB5L19faW5pdF9fLnB5CShyZXZpc2lvbiAyNzA1MzgpCisrKyBU b29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRjb3JlcHkvd2Via2l0Y29yZXB5L19faW5pdF9f LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zNSw3ICszNSw3IEBAIGZyb20gd2Via2l0Y29yZXB5LnRp bWVvdXQgaW1wb3J0IFRpbWVvdXQKIGZyb20gd2Via2l0Y29yZXB5LnN1YnByb2Nlc3NfdXRpbHMg aW1wb3J0IFRpbWVvdXRFeHBpcmVkLCBDb21wbGV0ZWRQcm9jZXNzLCBydW4KIGZyb20gd2Via2l0 Y29yZXB5Lm91dHB1dF9jYXB0dXJlIGltcG9ydCBMb2dnZXJDYXB0dXJlLCBPdXRwdXRDYXB0dXJl LCBPdXRwdXREdXBsaWNhdGUKIAotdmVyc2lvbiA9IFZlcnNpb24oMCwgNCwgMjIpCit2ZXJzaW9u ID0gVmVyc2lvbigwLCA0LCAyMykKIAogZnJvbSB3ZWJraXRjb3JlcHkuYXV0b2luc3RhbGwgaW1w b3J0IFBhY2thZ2UsIEF1dG9JbnN0YWxsCiBpZiBzeXMudmVyc2lvbl9pbmZvID4gKDMsIDApOgpJ bmRleDogVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0Y29yZXB5L3dlYmtpdGNvcmVweS9k ZWNvcmF0b3JzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtp dGNvcmVweS93ZWJraXRjb3JlcHkvZGVjb3JhdG9ycy5weQkocmV2aXNpb24gMjcwNTM4KQorKysg VG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0Y29yZXB5L3dlYmtpdGNvcmVweS9kZWNvcmF0 b3JzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC01MCw3ICs1MCw3IEBAIGNsYXNzIE1lbW9pemUob2Jq ZWN0KToKICAgICAgICAgICAgIGlmIHRpbWVvdXQgYW5kIHRpbWVvdXQgPCB0aW1lLnRpbWUoKSAt IGxhc3RfY2FsbGVkOgogICAgICAgICAgICAgICAgIGlzX2NhY2hlZCA9IEZhbHNlCiAgICAgICAg ICAgICBpZiBpc19jYWNoZWQ6Ci0gICAgICAgICAgICAgICAgcmV0dXJuIHNlbGYuX2NhY2hlW2Z1 bmN0aW9uXS5nZXQoYXJncywgTm9uZSkKKyAgICAgICAgICAgICAgICByZXR1cm4gc2VsZi5fY2Fj aGVbZnVuY3Rpb25dLmdldChrZXlhcmdzLCBOb25lKQogCiAgICAgICAgICAgICB2YWx1ZSA9IGZ1 bmN0aW9uKCphcmdzLCAqKmt3YXJncykKICAgICAgICAgICAgIHNlbGYuX2xhc3RfY2FsbGVkW2Z1 bmN0aW9uXVtrZXlhcmdzXSA9IHRpbWUudGltZSgpCkluZGV4OiBUb29scy9TY3JpcHRzL2xpYnJh cmllcy93ZWJraXRjb3JlcHkvd2Via2l0Y29yZXB5L3Rlc3RzL2RlY29yYXRvcnNfdW5pdHRlc3Qu cHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0Y29yZXB5L3dl YmtpdGNvcmVweS90ZXN0cy9kZWNvcmF0b3JzX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAyNzA1Mzgp CisrKyBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRjb3JlcHkvd2Via2l0Y29yZXB5L3Rl c3RzL2RlY29yYXRvcnNfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTU4LDYgKzU4LDEy IEBAIGNsYXNzIFRlc3RNZW1vaXplKHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICBkZWYgaW5jcmVt ZW50X3dpdGhfYXJncyh0aW1lb3V0PU5vbmUsIGNhY2hlZD1Ob25lKToKICAgICAgICAgcmV0dXJu IHRpbWVvdXQsIGNhY2hlZAogCisgICAgQHN0YXRpY21ldGhvZAorICAgIEBkZWNvcmF0b3JzLk1l bW9pemUoY2FjaGVkPUZhbHNlKQorICAgIGRlZiBpbmNyZW1lbnRfd2l0aF9hcmcoYXJnPU5vbmUp OgorICAgICAgICBUZXN0TWVtb2l6ZS5jb3VudCArPSAxCisgICAgICAgIHJldHVybiBUZXN0TWVt b2l6ZS5jb3VudAorCiAgICAgZGVmIHRlc3RfY2FjaGVkKHNlbGYpOgogICAgICAgICB3aXRoIG1v Y2tzLlRpbWU6CiAgICAgICAgICAgICBUZXN0TWVtb2l6ZS5jb3VudCA9IDAKQEAgLTEwNywzICsx MTMsMTAgQEAgY2xhc3MgVGVzdE1lbW9pemUodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICAg ICAgdGltZW91dD0ndGltZW91dC1uZXcnLAogICAgICAgICAgICAgY2FjaGVkPSdjYWNoZWQtbmV3 JywKICAgICAgICAgKSwgKCd0aW1lb3V0LW5ldycsICdjYWNoZWQtbmV3JykpCisKKyAgICBkZWYg dGVzdF9vdmVycmlkZShzZWxmKToKKyAgICAgICAgVGVzdE1lbW9pemUuY291bnQgPSAwCisgICAg ICAgIFRlc3RNZW1vaXplLmluY3JlbWVudF93aXRoX2FyZy5jbGVhcigpCisgICAgICAgIHNlbGYu YXNzZXJ0RXF1YWwoVGVzdE1lbW9pemUuaW5jcmVtZW50X3dpdGhfYXJnKGFyZz0neCcpLCAxKQor ICAgICAgICBzZWxmLmFzc2VydEVxdWFsKFRlc3RNZW1vaXplLmluY3JlbWVudF93aXRoX2FyZyhh cmc9J3gnKSwgMikKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChUZXN0TWVtb2l6ZS5pbmNyZW1l bnRfd2l0aF9hcmcoYXJnPSd4JywgY2FjaGVkPVRydWUpLCAyKQo=